codeless_code 0.1.7 → 0.1.8

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: ead759abc57cf4ba37d82e2837ebedb3b8375859b4146513e7cc2e53dbe24868
-  data.tar.gz: 1c528ddfca911727e94e8786c69f16f296dce0dc6ec1972772a41b4f195fc22f
+  metadata.gz: 5154091052ec2023109ecdc022ec10fdfa3762dcec89f1dd2f6203acac57018d
+  data.tar.gz: f9eb3c12e08dd25885faf6d758d67e1020d324a8ce53ab7c77b486b001eeceb1
 SHA512:
-  metadata.gz: c0136a3d0368a69d20fe44d0541ddfe42d54315985dc978ad175314f3f51854635999ae8bdbc11ce7f2cbdd9992eefc4458d9359175e508bfd399512147f68d3
-  data.tar.gz: 66c643b815b4a49626eaa57c01682af7f8ed0f8d9a746084691fed9acfda0203a24e4b8191ca0d8ec683403b9834483c96487728ef1a8ac2a8a9ea6cb751643b
+  metadata.gz: bba85e6463c19551a62b0064af87905f0bc1781bcaf198591c2513b4157ae514cc0fd17e31da864683be25c599c7d4170250ecfee8a098c45df9caab6d40600d
+  data.tar.gz: 4d8b4f45d6511bac204a88bb5b936a5303da0d5bbed221bdfa0531e03ee45193bcce7ae3f959c5d3c1b41f8ea75359598a5d010a09e98393dfa57dfd9a1de525

data/.gitmodules

@@ -1,3 +1,3 @@
 [submodule "data/the-codeless-code"]
 	path = data/the-codeless-code
-	url = git@github.com:sangster/the-codeless-code.git
+	url = https://github.com/sangster/the-codeless-code.git

data/.reek.yml

@@ -0,0 +1,14 @@
+---
+exclude_paths:
+  - test
+detectors:
+  DuplicateMethodCall:
+    enabled: false
+  NilCheck:
+    enabled: false
+  LongParameterList:
+    max_params: 4
+  UtilityFunction:
+    exclude:
+      - CodelessCode::Filters::Headers::Base
+      - CodelessCode::Filters::Date

data/.rubocop.yml

@@ -0,0 +1,18 @@
+AllCops:
+  Exclude:
+    - codeless_code.gemspec
+    - vendor/**/*
+
+Metrics/BlockLength:
+  Exclude:
+    - lib/codeless_code.rb
+
+Metrics/ModuleLength:
+  Exclude:
+    - lib/codeless_code.rb
+
+Style/DoubleNegation:
+  Enabled: false
+
+Style/FormatStringToken:
+  Enabled: false

data/.ruby-version

@@ -0,0 +1 @@
+2.5.1

data/{test/test_codeless_code.rb → .travis.yml}

@@ -1,3 +1,4 @@
+---
 # codeless_code filters and prints fables from http://thecodelesscode.com
 # Copyright (C) 2018  Jon Sangster
 #
@@ -13,14 +14,15 @@
 #
 # You should have received a copy of the GNU General Public License along with
 # this program. If not, see <https://www.gnu.org/licenses/>.
-require 'helper'
-
-class TestCodelessCode < UnitTest
-  def test_data_dir
-    assert_kind_of Pathname, CodelessCode::DEFAULT_DATA
-    assert_predicate CodelessCode::DEFAULT_DATA, :frozen?
-
-    assert_predicate CodelessCode::DEFAULT_DATA.glob('*'), :any?
-  end
-end
+language: ruby
 
+before_script:
+    - curl -L https://codeclimate.com/downloads/test-reporter/test-reporter-latest-linux-amd64 > ./cc-test-reporter
+    - chmod +x ./cc-test-reporter
+    - ./cc-test-reporter before-build
+env:
+    - COVERAGE=1
+script:
+    - bundle exec rake
+after_script:
+    - ./cc-test-reporter after-build -t simplecov --exit-code $TRAVIS_TEST_RESULT

data/Gemfile

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 # codeless_code filters and prints fables from http://thecodelesscode.com
 # Copyright (C) 2018  Jon Sangster
 #
@@ -24,6 +26,8 @@ group :development do
   gem 'bundler', '~> 1.17'
   gem 'guard', '~> 2.14'
   gem 'guard-minitest', '~> 2.4'
+  gem 'guard-reek', '~> 1.2'
+  gem 'guard-rubocop', '~> 1.3'
   gem 'jeweler', '~> 2.0'
   gem 'minitest', '~> 5.11'
   gem 'minitest-reporters', '~> 1.3'
@@ -31,6 +35,7 @@ group :development do
   gem 'rake', '~> 12.3'
   gem 'rdoc', '~> 6.0'
   gem 'reek', '~> 5.2'
+  gem 'rubocop', '~> 0.60'
   gem 'simplecov', '~> 0.16', require: false
   gem 'yard', '~> 0.9'
 end

data/Gemfile.lock

@@ -45,9 +45,16 @@ GEM
     guard-minitest (2.4.6)
       guard-compat (~> 1.2)
       minitest (>= 3.0)
+    guard-reek (1.2.0)
+      guard-compat (~> 1.1)
+      reek
+    guard-rubocop (1.3.0)
+      guard (~> 2.0)
+      rubocop (~> 0.20)
     hashie (3.6.0)
     highline (2.0.0)
     ice_nine (0.11.2)
+    jaro_winkler (1.5.1)
     jeweler (2.3.9)
       builder
       bundler
@@ -92,8 +99,10 @@ GEM
       multi_json (~> 1.3)
       multi_xml (~> 0.5)
       rack (>= 1.2, < 3)
+    parallel (1.12.1)
     parser (2.5.3.0)
       ast (~> 2.4.0)
+    powerpack (0.1.2)
     pry (0.11.3)
       coderay (~> 1.1.0)
       method_source (~> 0.9.0)
@@ -113,6 +122,14 @@ GEM
       kwalify (~> 0.7.0)
       parser (>= 2.5.0.0, < 2.6, != 2.5.1.1)
       rainbow (>= 2.0, < 4.0)
+    rubocop (0.60.0)
+      jaro_winkler (~> 1.5.1)
+      parallel (~> 1.10)
+      parser (>= 2.5, != 2.5.1.1)
+      powerpack (~> 0.1)
+      rainbow (>= 2.2.2, < 4.0)
+      ruby-progressbar (~> 1.7)
+      unicode-display_width (~> 1.4.0)
     ruby-progressbar (1.10.0)
     ruby_dep (1.5.0)
     semver2 (3.4.2)
@@ -125,6 +142,7 @@ GEM
     slop (4.6.2)
     thor (0.20.0)
     thread_safe (0.3.6)
+    unicode-display_width (1.4.0)
     virtus (1.0.5)
       axiom-types (~> 0.1)
       coercible (~> 1.0)
@@ -140,6 +158,8 @@ DEPENDENCIES
   colorize (~> 0.8)
   guard (~> 2.14)
   guard-minitest (~> 2.4)
+  guard-reek (~> 1.2)
+  guard-rubocop (~> 1.3)
   jeweler (~> 2.0)
   mediacloth (~> 0.6)
   minitest (~> 5.11)
@@ -149,6 +169,7 @@ DEPENDENCIES
   rake (~> 12.3)
   rdoc (~> 6.0)
   reek (~> 5.2)
+  rubocop (~> 0.60)
   simplecov (~> 0.16)
   slop (~> 4.6)
   yard (~> 0.9)

data/Guardfile

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 # vim:ft=ruby:
 # codeless_code filters and prints fables from http://thecodelesscode.com
 # Copyright (C) 2018  Jon Sangster
@@ -14,8 +16,18 @@
 #
 # You should have received a copy of the GNU General Public License along with
 # this program. If not, see <https://www.gnu.org/licenses/>.
-guard :minitest do
+guard :minitest, all_after_pass: true do
   watch(%r{^test/(.*)\/?test_(.*)\.rb$})
   watch(%r{^lib/(.*/)?([^/]+)\.rb$})     { |m| "test/#{m[1]}test_#{m[2]}.rb" }
   watch(%r{^test/helper\.rb$})           { 'test' }
 end
+
+guard :reek do
+  watch(%r{^lib/.+\.rb$})
+  watch('.reek.yml')
+end
+
+guard :rubocop do
+  watch(/.+\.rb$/)
+  watch(%r{(?:.+/)?\.rubocop(?:_todo)?\.yml$}) { |m| File.dirname(m[0]) }
+end

data/README.md

@@ -1,5 +1,11 @@
 # codeless_code
 
+[![Gem Version](https://badge.fury.io/rb/codeless_code.svg)](https://badge.fury.io/rb/codeless_code)
+[![Build Status](https://travis-ci.org/sangster/codeless_code.svg?branch=master)](https://travis-ci.org/sangster/codeless_code)
+[![Maintainability](https://api.codeclimate.com/v1/badges/0b67f813b9c48e639888/maintainability)](https://codeclimate.com/github/sangster/codeless_code/maintainability)
+<a href="https://codeclimate.com/github/sangster/codeless_code/test_coverage"><img src="https://api.codeclimate.com/v1/badges/0b67f813b9c48e639888/test_coverage" /></a>
+[![GitHub license](https://img.shields.io/github/license/sangster/codeless_code.svg)](https://github.com/sangster/codeless_code/blob/master/LICENSE)
+
 Search and print [The Codeless Code](http://thecodelesscode.com/contents)
 fables.
 

data/Rakefile

@@ -1,4 +1,5 @@
-# encoding: utf-8
+# frozen_string_literal: true
+
 # codeless_code filters and prints fables from http://thecodelesscode.com
 # Copyright (C) 2018  Jon Sangster
 #
@@ -21,8 +22,8 @@ require 'bundler'
 begin
   Bundler.setup(:default, :development)
 rescue Bundler::BundlerError => e
-  $stderr.puts e.message
-  $stderr.puts "Run `bundle install` to install missing gems"
+  warn e.message
+  warn 'Run `bundle install` to install missing gems'
   exit e.status_code
 end
 
@@ -37,9 +38,9 @@ require 'yard'
 require 'codeless_code'
 
 Jeweler::Tasks.new do |gem|
-  gem.name = "codeless_code"
-  gem.homepage = "https://github.com/sangster/codeless_code"
-  gem.license = "GPL-3.0"
+  gem.name = 'codeless_code'
+  gem.homepage = 'https://github.com/sangster/codeless_code'
+  gem.license = 'GPL-3.0'
   gem.summary = 'Search and print The Codeless Code fables'
   gem.description = <<-DESC.gsub(/\s+/m, ' ').strip
     http://thecodelesscode.com contains many humorous and interesting fables
@@ -48,8 +49,8 @@ Jeweler::Tasks.new do |gem|
 
     This tool provides a CLI to filter through these fables and view them.
   DESC
-  gem.email = "jon@ertt.ca"
-  gem.authors = ["Jon Sangster"]
+  gem.email = 'jon@ertt.ca'
+  gem.authors = ['Jon Sangster']
   gem.files.include('data/**/*.txt')
   # dependencies defined in Gemfile
 end
@@ -62,9 +63,9 @@ Rake::TestTask.new(:test) do |test|
 end
 Rake::Task[:build].prerequisites << :test
 
-desc "Code coverage detail"
+desc 'Code coverage detail'
 task :simplecov do
-  ENV['COVERAGE'] = "true"
+  ENV['COVERAGE'] = 'true'
   Rake::Task['test'].execute
 end
 
@@ -96,4 +97,18 @@ namespace :readme do
   end
 end
 
-task default: :test
+namespace :lint do
+  require 'reek/rake/task'
+  require 'rubocop/rake_task'
+
+  Reek::Rake::Task.new do |t|
+    t.fail_on_error = false
+  end
+
+  RuboCop::RakeTask.new
+end
+
+desc 'Run all linters'
+task lint: ['lint:rubocop', 'lint:reek']
+
+task default: %i[test lint]

data/VERSION

@@ -1 +1 @@
-0.1.7
+0.1.8

data/bin/codeless_code

@@ -1,4 +1,6 @@
 #!/usr/bin/env ruby
+# frozen_string_literal: true
+
 # vim: ft=ruby:
 
 require 'pathname'
@@ -7,4 +9,4 @@ require 'pry-byebug' if ENV.key?('DEBUG')
 $LOAD_PATH << Pathname.new(__dir__).join('..', 'lib')
 require 'codeless_code'
 
-CodelessCode::Cli.new(File.basename($0), ARGV).call
+CodelessCode::Cli.new(File.basename($PROGRAM_NAME), ARGV).call

data/codeless_code.gemspec

@@ -2,16 +2,16 @@
 # DO NOT EDIT THIS FILE DIRECTLY
 # Instead, edit Jeweler::Tasks in Rakefile, and run 'rake gemspec'
 # -*- encoding: utf-8 -*-
-# stub: codeless_code 0.1.7 ruby lib
+# stub: codeless_code 0.1.8 ruby lib
 
 Gem::Specification.new do |s|
   s.name = "codeless_code".freeze
-  s.version = "0.1.7"
+  s.version = "0.1.8"
 
   s.required_rubygems_version = Gem::Requirement.new(">= 0".freeze) if s.respond_to? :required_rubygems_version=
   s.require_paths = ["lib".freeze]
   s.authors = ["Jon Sangster".freeze]
-  s.date = "2018-11-05"
+  s.date = "2018-11-09"
   s.description = "http://thecodelesscode.com contains many humorous and interesting fables and koans. The authors have open-sourced these fables, and many tanslations, available at https://github.com/aldesantis/the-codeless-code. This tool provides a CLI to filter through these fables and view them.".freeze
   s.email = "jon@ertt.ca".freeze
   s.executables = ["codeless_code".freeze]
@@ -20,8 +20,11 @@ Gem::Specification.new do |s|
     "README.md"
   ]
   s.files = [
-    ".document",
     ".gitmodules",
+    ".reek.yml",
+    ".rubocop.yml",
+    ".ruby-version",
+    ".travis.yml",
     "Gemfile",
     "Gemfile.lock",
     "Guardfile",
@@ -31,7 +34,6 @@ Gem::Specification.new do |s|
     "VERSION",
     "bin/codeless_code",
     "codeless_code.gemspec",
-    "data/README.md",
     "data/the-codeless-code/cs-hanzik/case-1.txt",
     "data/the-codeless-code/cs-hanzik/case-10.txt",
     "data/the-codeless-code/cs-hanzik/case-11.txt",
@@ -1487,30 +1489,40 @@ Gem::Specification.new do |s|
     "lib/codeless_code/filters/composite.rb",
     "lib/codeless_code/filters/date.rb",
     "lib/codeless_code/filters/from_options.rb",
-    "lib/codeless_code/filters/header_integer.rb",
-    "lib/codeless_code/filters/header_string.rb",
+    "lib/codeless_code/filters/headers/base.rb",
+    "lib/codeless_code/filters/headers/integer.rb",
+    "lib/codeless_code/filters/headers/string.rb",
     "lib/codeless_code/filters/lang.rb",
     "lib/codeless_code/filters/translator.rb",
     "lib/codeless_code/formats/base.rb",
+    "lib/codeless_code/formats/parsers/base.rb",
+    "lib/codeless_code/formats/parsers/plain.rb",
+    "lib/codeless_code/formats/parsers/term.rb",
     "lib/codeless_code/formats/plain.rb",
-    "lib/codeless_code/formats/plain_generator.rb",
     "lib/codeless_code/formats/raw.rb",
     "lib/codeless_code/formats/term.rb",
-    "lib/codeless_code/formats/term_generator.rb",
     "lib/codeless_code/language_set.rb",
     "lib/codeless_code/options.rb",
     "lib/codeless_code/renderers/fable.rb",
     "lib/codeless_code/renderers/term_page.rb",
+    "test/codeless_code/commands/test_filter_fables.rb",
+    "test/codeless_code/filters/headers/test_integer.rb",
+    "test/codeless_code/filters/headers/test_string.rb",
     "test/codeless_code/filters/test_builders.rb",
-    "test/codeless_code/filters/test_header_integer.rb",
-    "test/codeless_code/filters/test_header_string.rb",
+    "test/codeless_code/filters/test_composite.rb",
+    "test/codeless_code/filters/test_date.rb",
+    "test/codeless_code/filters/test_langs.rb",
+    "test/codeless_code/filters/test_translator.rb",
+    "test/codeless_code/renderers/test_fable.rb",
+    "test/codeless_code/renderers/test_term_page.rb",
     "test/codeless_code/test_catalog.rb",
+    "test/codeless_code/test_cli.rb",
     "test/codeless_code/test_fable.rb",
     "test/codeless_code/test_fable_set.rb",
     "test/codeless_code/test_language_set.rb",
     "test/codeless_code/test_options.rb",
     "test/helper.rb",
-    "test/test_codeless_code.rb"
+    "test/support/fs.rb"
   ]
   s.homepage = "https://github.com/sangster/codeless_code".freeze
   s.licenses = ["GPL-3.0".freeze]
@@ -1528,6 +1540,8 @@ Gem::Specification.new do |s|
       s.add_development_dependency(%q<bundler>.freeze, ["~> 1.17"])
       s.add_development_dependency(%q<guard>.freeze, ["~> 2.14"])
       s.add_development_dependency(%q<guard-minitest>.freeze, ["~> 2.4"])
+      s.add_development_dependency(%q<guard-reek>.freeze, ["~> 1.2"])
+      s.add_development_dependency(%q<guard-rubocop>.freeze, ["~> 1.3"])
       s.add_development_dependency(%q<jeweler>.freeze, ["~> 2.0"])
       s.add_development_dependency(%q<minitest>.freeze, ["~> 5.11"])
       s.add_development_dependency(%q<minitest-reporters>.freeze, ["~> 1.3"])
@@ -1535,6 +1549,7 @@ Gem::Specification.new do |s|
       s.add_development_dependency(%q<rake>.freeze, ["~> 12.3"])
       s.add_development_dependency(%q<rdoc>.freeze, ["~> 6.0"])
       s.add_development_dependency(%q<reek>.freeze, ["~> 5.2"])
+      s.add_development_dependency(%q<rubocop>.freeze, ["~> 0.60"])
       s.add_development_dependency(%q<simplecov>.freeze, ["~> 0.16"])
       s.add_development_dependency(%q<yard>.freeze, ["~> 0.9"])
     else
@@ -1545,6 +1560,8 @@ Gem::Specification.new do |s|
       s.add_dependency(%q<bundler>.freeze, ["~> 1.17"])
       s.add_dependency(%q<guard>.freeze, ["~> 2.14"])
       s.add_dependency(%q<guard-minitest>.freeze, ["~> 2.4"])
+      s.add_dependency(%q<guard-reek>.freeze, ["~> 1.2"])
+      s.add_dependency(%q<guard-rubocop>.freeze, ["~> 1.3"])
       s.add_dependency(%q<jeweler>.freeze, ["~> 2.0"])
       s.add_dependency(%q<minitest>.freeze, ["~> 5.11"])
       s.add_dependency(%q<minitest-reporters>.freeze, ["~> 1.3"])
@@ -1552,6 +1569,7 @@ Gem::Specification.new do |s|
       s.add_dependency(%q<rake>.freeze, ["~> 12.3"])
       s.add_dependency(%q<rdoc>.freeze, ["~> 6.0"])
       s.add_dependency(%q<reek>.freeze, ["~> 5.2"])
+      s.add_dependency(%q<rubocop>.freeze, ["~> 0.60"])
       s.add_dependency(%q<simplecov>.freeze, ["~> 0.16"])
       s.add_dependency(%q<yard>.freeze, ["~> 0.9"])
     end
@@ -1563,6 +1581,8 @@ Gem::Specification.new do |s|
     s.add_dependency(%q<bundler>.freeze, ["~> 1.17"])
     s.add_dependency(%q<guard>.freeze, ["~> 2.14"])
     s.add_dependency(%q<guard-minitest>.freeze, ["~> 2.4"])
+    s.add_dependency(%q<guard-reek>.freeze, ["~> 1.2"])
+    s.add_dependency(%q<guard-rubocop>.freeze, ["~> 1.3"])
     s.add_dependency(%q<jeweler>.freeze, ["~> 2.0"])
     s.add_dependency(%q<minitest>.freeze, ["~> 5.11"])
     s.add_dependency(%q<minitest-reporters>.freeze, ["~> 1.3"])
@@ -1570,6 +1590,7 @@ Gem::Specification.new do |s|
     s.add_dependency(%q<rake>.freeze, ["~> 12.3"])
     s.add_dependency(%q<rdoc>.freeze, ["~> 6.0"])
     s.add_dependency(%q<reek>.freeze, ["~> 5.2"])
+    s.add_dependency(%q<rubocop>.freeze, ["~> 0.60"])
     s.add_dependency(%q<simplecov>.freeze, ["~> 0.16"])
     s.add_dependency(%q<yard>.freeze, ["~> 0.9"])
   end

data/lib/codeless_code/catalog.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 # codeless_code filters and prints fables from http://thecodelesscode.com
 # Copyright (C) 2018  Jon Sangster
 #
@@ -41,7 +43,7 @@ module CodelessCode
         LanguageSet.new(lang, root_dir: @root_dir)
       else
         raise LanguageSet::NotFoundError,
-              format("No fables for language %p", lang)
+              format('No fables for language %p', lang)
       end
     end
 

data/lib/codeless_code/cli.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 # codeless_code filters and prints fables from http://thecodelesscode.com
 # Copyright (C) 2018  Jon Sangster
 #
@@ -17,63 +19,77 @@ require 'date'
 require 'slop'
 
 module CodelessCode
+  # Parse command-line parameters and dispatch them to the user's chosen
+  # "command."
   class Cli
-    def initialize(command_name = $0, args = ARGV)
+    def initialize(command_name = $PROGRAM_NAME, args = ARGV)
       @command_name = command_name
       @args = args
     end
 
     def call
       user_io = io_open
+      call_io(user_io)
+    rescue Slop::Error => err
+      warn format("%s\n\n%s", err, options.help)
+      exit 1
+    ensure
+      user_io&.close
+    end
+
+    private
 
+    def call_io(user_io)
       if options.key?(:help)
-        (user_io || $stdout).puts options.help
+        io_puts(user_io, options.help)
       elsif options.key?(:version)
-        (user_io || $stdout).puts version_str
+        io_puts(user_io, version_str)
       elsif options.key?(:list_translations)
-        Commands::ListTranslations.new(catalog, io: user_io).call
+        list_translations(user_io)
       else
-        Commands::FilterFables.new(catalog, options, io: user_io)
-                              .call(&method(:select))
+        filter_fables(user_io)
       end
-
-    rescue Slop::Error => e
-      warn format("%s\n\n%s", e, options.help)
-      exit 1
-    ensure
-      user_io&.close
     end
 
-    private
+    # :reek:ControlParameter
+    # :reek:UtilityFunction
+    def io_puts(io, *args)
+      (io || $stdout).puts(*args)
+    end
 
     def options
       @options ||= Options.new(@command_name, @args)
     end
 
+    def list_translations(user_io)
+      Commands::ListTranslations.new(catalog, io: user_io).call
+    end
+
+    def filter_fables(user_io)
+      Commands::FilterFables.new(catalog, options, io: user_io)
+                            .call(&method(:select_rand))
+    end
+
     def catalog
       @catalog ||= Catalog.new(options.data_dir)
     end
 
     # @return [IO,nil] the user's chosen output stream. +nil+ if unspecified
+    # :reek:FeatureEnvy
     def io_open
-      if (path = options[:output])
-        path == '-' ? $stdout.dup : File.open(path, 'w')
-      end
-    end
+      path = options[:output]
+      return if path.nil?
 
-    def select(fables)
-      select_rand(fables)
+      path == '-' ? $stdout.dup : File.open(path, 'w')
     end
 
     # @return [Enumerable<Fable>] a random subset of the given collection, as
     #   specified by {#options}
     def select_rand(fables)
       if options[:daily]
-        fables.sample(1, random: Random.new(Date.today.strftime('%Y%m%d').to_i))
+        fables.sample(1, random: date_random_generator)
       elsif (count = options[:random_set])
-        if count&.to_i&.to_s != count
-          raise ArgumentError, format('not a number %p', count)
-        end
+        assert_num!(count)
         fables.sample(count&.to_i)
       elsif options[:random]
         fables.sample(1)
@@ -82,6 +98,22 @@ module CodelessCode
       end
     end
 
+    # :reek:UtilityFunction
+    def date_random_generator
+      Random.new(::Date.today.strftime('%Y%m%d').to_i)
+    end
+
+    def assert_num!(num)
+      return unless assert_num(num)
+
+      raise ArgumentError, format('not a number %p', num)
+    end
+
+    # :reek:UtilityFunction
+    def assert_num(num)
+      num&.to_i&.to_s != num
+    end
+
     def version_str
       format(['%s %s', '%s', 'See <%s>'].join("\n\n"), @command_name, VERSION,
              copyright_summary, 'https://github.com/sangster/codeless_code')
@@ -92,7 +124,7 @@ module CodelessCode
         'Copyright (C) %<date>d  Jon Sangster',
         'License GPL-3.0: GNU General Public License v3.0 <%<url>s>',
         'This is free software: you are free to change and redistribute it.',
-        'There is NO WARRANTY, to the extent permitted by law.',
+        'There is NO WARRANTY, to the extent permitted by law.'
       ].join("\n")
 
       format(template, date: ::Date.today.year,

data/lib/codeless_code/commands/filter_fables.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 # codeless_code filters and prints fables from http://thecodelesscode.com
 # Copyright (C) 2018  Jon Sangster
 #
@@ -29,11 +31,8 @@ module CodelessCode
         @io = io
       end
 
-      def call
-        filter = Filters::FromOptions.new(options)
-        fables = @catalog.select(filter)
-        fables = yield fables if block_given?
-        fables = sort(fables)
+      def call(&blk)
+        fables = filters_from_options(&blk)
 
         case fables.size
         when 0
@@ -47,9 +46,16 @@ module CodelessCode
 
       private
 
+      def filters_from_options
+        filter = Filters::FromOptions.new(options)
+        fables = @catalog.select(filter)
+        fables = yield fables if block_given?
+        sort(fables)
+      end
+
       def sort(fables)
         if options.key?(:sort)
-          fables = fables.sort_by { |f| f[options[:sort]] || "\uffff" }
+          fables = fables.sort_by { |fable| fable[options[:sort]] || "\uffff" }
         end
         fables = fables.reverse if options[:reverse]
         fables
@@ -64,9 +70,7 @@ module CodelessCode
       end
 
       def pager(cmd, fable)
-        io = open format('|%s', cmd), 'w'
-        pid = io.pid
-
+        io = IO.popen(cmd, 'w')
         io.puts for_pager(fable)
       ensure
         io&.close
@@ -98,12 +102,13 @@ module CodelessCode
 
       def title_width(fables)
         if options[:columns]
-          -fables.map { |f| render(f).best_title.size }.compact.max
+          -fables.map { |fable| render(fable).best_title.size }.compact.max
         else
           ''
         end
       end
 
+      # :reek:UtilityFunction
       def render(fable)
         Renderers::Fable.new(fable)
       end

data/lib/codeless_code/commands/list_translations.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 # codeless_code filters and prints fables from http://thecodelesscode.com
 # Copyright (C) 2018  Jon Sangster
 #
@@ -15,6 +17,7 @@
 # this program. If not, see <https://www.gnu.org/licenses/>.
 module CodelessCode
   module Commands
+    # List all the translations available in the given {Catalog}.
     class ListTranslations
       # @param io [IO] if given, the output will be written to this stream,
       #   otherwise STDOUT will be used