codefumes 0.2.2 → 0.3.0

data/features/deleting_a_project.feature

@@ -7,21 +7,21 @@ Feature: Deleting a project
   Scenario: The specified project does not exist on CodeFumes.com
     When I run "#{@bin_path}/fumes delete -p bad-public-key"
     Then the output should contain "Not Found"
-    And the exit status should be 0
+    And the exit status should be "SUCCESS"
 
   Scenario: Attempting to delete a project without having an API key entry in the CodeFumes config file
     Given I have cloned and synchronized 1 project
     And I have claimed the project
     When I delete the project
     Then the output should contain 1 successful delete messages
-    And the exit status should be 0
+    And the exit status should be "SUCCESS"
 
   Scenario: Deleting one of multiple projects in your CodeFumes config file
     Given I have cloned and synchronized 2 projects
     And I have claimed the 1st project
     When I delete the 1st project
     Then the output should contain 1 successful delete messages
-    And the exit status should be 0
+    And the exit status should be "SUCCESS"
 
   Scenario: Releasing all projects in your CodeFumes config file
     Given valid user credentials have been stored in the CodeFumes config file
@@ -29,4 +29,4 @@ Feature: Deleting a project
     And I run "#{@bin_path}/fumes claim -a"
     When I run "#{@bin_path}/fumes delete -a"
     Then the output should contain 2 successful delete messages
-    And the exit status should be 0
+    And the exit status should be "SUCCESS"

data/features/managing_project_build_status.feature

@@ -0,0 +1,63 @@
+Feature: Managing a project's build status
+  Tracking the build status of a project is one of, if not
+  THE primary purpose of CodeFumes.com. As the owner of a project
+  I want to be able to easily manage and the state of an read
+  the state of various builds for a project.
+
+  Scenario: Starting a build for a project
+    Given I have cloned and synchronized 1 project
+    And I cd to "project_1/"
+    When I run "#{@bin_path}/fumes build --start ie7"
+    Then the output should contain "Setting 'ie7' build status to 'started'"
+    And the output should contain "'ie7' build successfully marked as 'started'"
+    And the exit status should be "SUCCESS"
+
+  Scenario: Setting a project build status to 'failure'
+    Given I have cloned and synchronized 1 project
+    And I cd to "project_1/"
+    And I run "#{@bin_path}/fumes build --start ie7"
+    When I run "#{@bin_path}/fumes build --finished=failed ie7"
+    Then the output should contain "Setting 'ie7' build status to 'failed'"
+    And the output should contain "'ie7' build successfully marked as 'failed'"
+    And the exit status should be "SUCCESS"
+
+  Scenario: Setting a project build status to an invalid state
+    Given I have cloned and synchronized 1 project
+    And I cd to "project_1/"
+    And I run "#{@bin_path}/fumes build --start ie7"
+    When I run "#{@bin_path}/fumes build --finished=badstate ie7"
+    Then the output should contain "Invalid build state"
+    And the exit status should be "INVALID_BUILD_STATE"
+
+  Scenario: Attempting to set multiple build states in same command
+    Given I have cloned and synchronized 1 project
+    And I cd to "project_1/"
+    And I run "#{@bin_path}/fumes build --start ie7"
+    When I run "#{@bin_path}/fumes build --finished=failed --start ie7"
+    Then the output should contain "multiple states"
+    And the exit status should be "INVALID_COMMAND_SYNTAX"
+
+  Scenario: Retrieving the current build state of a specific build
+    Given I have cloned and synchronized 1 project
+    And I cd to "project_1/"
+    And I run "#{@bin_path}/fumes build --start ie7"
+    When I run "#{@bin_path}/fumes build --status ie7"
+    Then the output should contain "running"
+    And the exit status should be "SUCCESS"
+
+  Scenario: Retrieving the current build state of a all builds of the latest commit
+    Given I have cloned and synchronized 1 project
+    And I cd to "project_1/"
+    And I run "#{@bin_path}/fumes build --start ie7"
+    And I run "#{@bin_path}/fumes build --start specs"
+    When I run "#{@bin_path}/fumes build --status --all"
+    Then the output should contain 2 running build status messages
+    And the exit status should be "SUCCESS"
+
+  Scenario: Running the build command without any arguments
+    Given I have cloned and synchronized 1 project
+    And I cd to "project_1/"
+    When I run "#{@bin_path}/fumes build"
+    Then the output should contain "build [options]"
+    Then the output should contain "Options:"
+    And the exit status should be "SUCCESS"

data/features/releasing_a_project.feature

@@ -7,14 +7,14 @@ Feature: Claiming a project
     Given valid user credentials have been stored in the CodeFumes config file
     When I run "#{@bin_path}/fumes release -p bad-public-key"
     Then the output should contain "Not Found"
-    And the exit status should be 0
+    And the exit status should be "SUCCESS"
 
   Scenario: Attempting to claim a project without having an API key entry in the CodeFumes config file
     And I have cloned and synchronized 1 project
     And I have claimed the project
     When I release the project
     Then the output should contain instructions about storing your API key
-    And the exit status should be 3
+    And the exit status should be "NO_USER_CREDENTIALS"
 
   Scenario: Attempting to release a project with an invalid API key entry in the user's CodeFumes config file
     Given invalid user credentials have been stored in the CodeFumes config file
@@ -23,7 +23,7 @@ Feature: Claiming a project
     And invalid user credentials have been stored in the CodeFumes config file
     When I release the project
     Then the output should contain "Denied"
-    And the exit status should be 0
+    And the exit status should be "SUCCESS"
 
   Scenario: Releasing a project using the key stored in a CodeFumes project directory
     Given valid user credentials have been stored in the CodeFumes config file
@@ -31,7 +31,7 @@ Feature: Claiming a project
     And I have claimed the project
     When I release the project
     Then the output should contain "Success"
-    And the exit status should be 0
+    And the exit status should be "SUCCESS"
 
   Scenario: Releasing one of multiple projects in your CodeFumes config file
     Given valid user credentials have been stored in the CodeFumes config file
@@ -39,7 +39,7 @@ Feature: Claiming a project
     And I have claimed the 1st project
     When I release the 1st project
     Then the output should contain 1 successful release message
-    And the exit status should be 0
+    And the exit status should be "SUCCESS"
 
   Scenario: Releasing all projects in your CodeFumes config file
     Given valid user credentials have been stored in the CodeFumes config file
@@ -47,4 +47,4 @@ Feature: Claiming a project
     And I run "#{@bin_path}/fumes claim -a"
     When I run "#{@bin_path}/fumes release -a"
     Then the output should contain 2 successful release messages
-    And the exit status should be 0
+    And the exit status should be "SUCCESS"

data/features/step_definitions/cli_steps.rb

@@ -1,8 +1,8 @@
 # still a super-hack...but at least it's not duplicated, right?
 # ...
 # ...right?
-def output_message_qty(action)
-  combined_output.scan(/#{action}\.\.\.'.*': Success/).count
+def output_message_qty(action, result = "Success")
+  combined_output.scan(/#{action}\.\.\.'.*': #{result}/).count
 end
 
 def clone_fixture_repo_into(dir_name)
@@ -24,6 +24,12 @@ Then /^the output should contain (\d+) successful delete message[s]?$/ do |count
   output_message_qty("Deleting").should == count.to_i
 end
 
+# TODO: Get a better way of testing this...output is horrible
+Then /^the output should contain (\d+) running build status message[s]?$/ do |count|
+  running_status_count = combined_output.scan(/'.*' build: running/).count
+  running_status_count.should == count.to_i
+end
+
 Then /^the output should contain instructions about storing your API key$/ do
     Then "the output should contain \"fumes setup\""
 end
@@ -96,3 +102,7 @@ Then /^the API key in the config file should be ("[^"]*"|cleared)$/ do |api_key_
   expected_value = api_key_value == 'cleared' ? nil : api_key_value.gsub(/"/,'')
   ConfigFile.api_key.should == expected_value
 end
+
+Then /^the exit status should be "([^"]*)"$/ do |exit_code_name|
+  Then "the exit status should be #{instance_eval("CodeFumes::ExitCodes::#{exit_code_name}")}"
+end

data/features/storing_user_api_key.feature

@@ -10,7 +10,7 @@ Feature: Storing a User's API key
       """
       No API key specified
       """
-    And the exit status should be 5
+    And the exit status should be "NO_API_KEY_SPECIFIED"
 
   Scenario: Issuing 'api-key' with an argument
     When I run "#{@bin_path}/fumes api-key userkey"
@@ -19,7 +19,7 @@ Feature: Storing a User's API key
       Your API key has been saved to your CodeFumes config file
       """
     And the API key in the config file should be "userkey"
-    And the exit status should be 0
+    And the exit status should be "SUCCESS"
 
   Scenario: Issuing 'api-key' with the --clear flag
     When I run "#{@bin_path}/fumes api-key --clear"
@@ -28,7 +28,7 @@ Feature: Storing a User's API key
       Your API key has been removed from your CodeFumes config file
       """
     And the API key in the config file should be cleared
-    And the exit status should be 0
+    And the exit status should be "SUCCESS"
 
   Scenario: Issuing 'api-key' with the --clear flag and an argument
     When I run "#{@bin_path}/fumes api-key userkey1"
@@ -38,4 +38,4 @@ Feature: Storing a User's API key
       Your API key has been removed from your CodeFumes config file
       """
     And the API key in the config file should be cleared
-    And the exit status should be 0
+    And the exit status should be "SUCCESS"

data/features/synchronizing_repository_with_project.feature

@@ -10,12 +10,12 @@ Feature: Synchronizing a repository with CodeFumes
       """
       Unsupported
       """
-    And the exit status should be 1
+    And the exit status should be "UNSUPPORTED_SCM"
 
   Scenario: Successful synchronization
     Given I have cloned 1 project
     When I synchronize the project
-    Then the exit status should be 0
+    Then the exit status should be "SUCCESS"
     And the output should contain "Successfully saved"
     And the output should contain "Visit http://"
 
@@ -24,10 +24,10 @@ Feature: Synchronizing a repository with CodeFumes
     When I synchronize the project
     Then the output should contain "non-production"
     And the output should contain "test.codefumes.com"
-    And the exit status should be 0
+    And the exit status should be "SUCCESS"
 
   Scenario: Specifying a custom, but non-existant public/private key combination
     Given I have cloned 1 project
     And I cd to "project_1/"
     When I run "#{@bin_path}/fumes sync -p non-existant-pubkey -a non-existant-privkey"
-    And the exit status should be 2
+    And the exit status should be "PROJECT_NOT_FOUND"

data/lib/codefumes.rb

@@ -12,5 +12,5 @@ require 'codefumes/source_control.rb'
 include CodeFumes::API
 
 module CodeFumes
-  VERSION = '0.2.2' unless defined?(CodeFumes::VERSION)
+  VERSION = '0.3.0' unless defined?(CodeFumes::VERSION)
 end

data/lib/codefumes/api/build.rb

@@ -6,6 +6,7 @@ module CodeFumes
     # the current status (running, failed, success) and the
     # start & end times of the Build process.
     class Build
+      VALID_BUILD_RESULT_STATES = [:running,:failed,:successful]
       attr_reader   :created_at, :api_uri, :identifier, :commit, :project
       attr_accessor :started_at, :ended_at, :state, :name
 
@@ -25,6 +26,7 @@ module CodeFumes
         @state      = state.to_s
         @started_at = options[:started_at] || options['started_at'] || Time.now
         @ended_at   = options[:ended_at]   || options['ended_at']
+        validate_build_state
       end
 
       # Overrides existing attributes with those supplied in +options+. This
@@ -59,6 +61,7 @@ module CodeFumes
       # ---
       # TODO: Make this consistent w/ other class' create/update handling
       def save
+        validate_build_state
         response = exists? ? update : create
 
         case response.code
@@ -134,6 +137,11 @@ module CodeFumes
         def standard_content_hash
           {:name => name,:started_at => started_at, :ended_at => ended_at, :state => state}
         end
+
+        def validate_build_state
+          raise(Errors::InvalidBuildState) if state.nil? || state.empty?
+          raise(Errors::InvalidBuildState) unless VALID_BUILD_RESULT_STATES.include?(state.to_sym)
+        end
     end
   end
 end

data/lib/codefumes/api/commit.rb

@@ -139,12 +139,34 @@ module CodeFumes
         latest_commit.nil? ? nil : latest_commit.identifier
       end
 
+      # Returns the all associated builds
+      def builds
+        response = API.get("/projects/#{project.public_key}/commits/#{identifier}/builds")
+
+        case response.code
+          when 200
+            builds_returned(response).map do |build_data|
+              build_name = build_data.delete("name")
+              build_state = build_data.delete("state")
+              Build.new(self, build_name, build_state, build_data)
+            end
+          else
+            nil
+        end
+      end
+
       private
         def convert_custom_attributes_keys_to_symbols
           @custom_attributes = @custom_attributes.inject({}) do |results, key_and_value|
             results.merge! key_and_value.first.to_sym => key_and_value.last
           end
         end
+
+        def builds_returned(response)
+          return [] if response["builds"].nil? || response["builds"].empty?
+          return [] if response["builds"]["build"].nil? || response["builds"]["build"].empty?
+          [response["builds"]["build"]].flatten
+        end
     end
   end
 end

data/lib/codefumes/cli_helpers.rb

@@ -10,6 +10,10 @@ module CodeFumes
       puts "NOTE: Sending all requests & data to non-production server! (#{API.base_uri})"
     end
 
+    def issuing_build_command?(command)
+      command && command.name.to_sym == :build
+    end
+
     def issue_project_commands(message, public_keys, &block)
       public_keys.each do |public_key|
         print "#{message}...'#{public_key}': "
@@ -50,5 +54,9 @@ module CodeFumes
     def open_in_browser(url, &block)
       has_launchy? {Launchy::Browser.new.visit url}
     end
+
+    def multiple_build_states?(options)
+      options[:start] && options[:finished]
+    end
   end
 end

data/lib/codefumes/errors.rb

@@ -9,12 +9,18 @@ module CodeFumes
     class UnknownProjectError < StandardError #:nodoc:
     end
 
+    class InvalidCommandSyntax < StandardError #:nodoc:
+    end
+
     class NoUserApiKeyError < ArgumentError #:nodoc:
     end
 
     class NoApiKeySpecified < ArgumentError #:nodoc:
     end
 
+    class InvalidBuildState < ArgumentError #:nodoc:
+    end
+
     class MissingLaunchyGem < Gem::LoadError #:nodoc:
     end
   end

data/lib/codefumes/exit_codes.rb

@@ -1,10 +1,14 @@
-module ExitCodes
-  SUCCESS                    = 0
-  UNSUPPORTED_SCM            = 1
-  PROJECT_NOT_FOUND          = 2
-  NO_USER_CREDENTIALS        = 3
-  INCORRECT_USER_CREDENTIALS = 4
-  NO_API_KEY_SPECIFIED       = 5
-  MISSING_DEPENDENCY         = 6
-  UNKNOWN                    = 100
+module CodeFumes
+  module ExitCodes
+    SUCCESS                    = 0
+    UNSUPPORTED_SCM            = 1
+    PROJECT_NOT_FOUND          = 2
+    NO_USER_CREDENTIALS        = 3
+    INCORRECT_USER_CREDENTIALS = 4
+    NO_API_KEY_SPECIFIED       = 5
+    MISSING_DEPENDENCY         = 6
+    INVALID_BUILD_STATE        = 7
+    INVALID_COMMAND_SYNTAX     = 8
+    UNKNOWN                    = 100
+  end
 end

data/spec/codefumes/api/build_spec.rb

@@ -14,7 +14,7 @@ describe "API::Build" do
     @build = Build.new(@commit, @build_name, @state, {:started_at => @started_at})
   end
 
-  describe "save" do
+  describe "#save" do
     it "sets basic auth with the public and private key" do
       @build.stub!(:exists?).and_return(false)
       register_create_uri(["401", "Unauthorized"], "")
@@ -26,6 +26,22 @@ describe "API::Build" do
       @build.save
     end
 
+    it "raises an exception when an invalid state is specified" do
+      lambda {
+        setup_fixture_base
+        @build.state = 'invalid_state'
+        @build.save
+      }.should raise_error(Errors::InvalidBuildState)
+    end
+
+    it "does not raise an InvalidBuildState exception when a valid state is specified" do
+      lambda {
+        setup_fixture_base
+        @build.state = Build::VALID_BUILD_RESULT_STATES.first
+        @build.save
+      }.should_not raise_error(Errors::InvalidBuildState)
+    end
+
     context "when it's a new build for the specified commit" do
       before(:each) do
         @build.stub!(:exists?).and_return(false)
@@ -70,7 +86,7 @@ describe "API::Build" do
     end
   end
 
-  describe "find" do
+  describe "#find" do
     before(:each) do
       setup_fixture_base
       setup_build_fixtures
@@ -89,7 +105,7 @@ describe "API::Build" do
     end
   end
 
-  describe "destroy" do
+  describe "#destroy" do
     before(:each) do
       setup_fixture_base
       setup_build_fixtures
@@ -106,4 +122,20 @@ describe "API::Build" do
       @build.destroy.should be_false
     end
   end
+
+  describe "#new" do
+    it "raises an exception when an invalid state is specified" do
+      lambda {
+        setup_fixture_base
+        Build.new(@commit, @build_name, 'invalid_state')
+      }.should raise_error(Errors::InvalidBuildState)
+    end
+
+    it "does not raise an InvalidBuildState exception when a valid state is specified" do
+      lambda {
+        setup_fixture_base
+        Build.new(@commit, @build_name, Build::VALID_BUILD_RESULT_STATES.first)
+      }.should_not raise_error(Errors::InvalidBuildState)
+    end
+  end
 end