codefumes 0.1.10 → 0.2.0

data/spec/codefumes/config_file_spec.rb

@@ -14,7 +14,7 @@ end
 
 describe "ConfigFile" do
   before(:each) do
-    @project = Project.new(:public_key => 'public_key_value', :private_key => 'private_key_value')
+    @project = Project.new('public_key_value', :private_key => 'private_key_value')
   end
 
   after(:all) do
@@ -53,7 +53,7 @@ describe "ConfigFile" do
     context "when passed an existing project" do
       before(:each) do
         ConfigFile.save_project(@project)
-        @updated_project = Project.new(:public_key => @project.public_key, :private_key => "updated_private_key")
+        @updated_project = Project.new(@project.public_key, :private_key => "updated_private_key")
       end
 
       it "does not create a duplicate entry in the list of projects" do
@@ -67,9 +67,9 @@ describe "ConfigFile" do
 
     context "when several projects exist" do
       before(:each) do
-        @project1 = Project.new(:public_key => :p1_pub_value, :private_key => "p1_private_key")
-        @project2 = Project.new(:public_key => :p2_pub_value, :private_key => "p2_private_key")
-        @project3 = Project.new(:public_key => :p3_pub_value, :private_key => "p3_private_key")
+        @project1 = Project.new(:p1_pub_value, :private_key => "p1_private_key")
+        @project2 = Project.new(:p2_pub_value, :private_key => "p2_private_key")
+        @project3 = Project.new(:p3_pub_value, :private_key => "p3_private_key")
         ConfigFile.save_project(@project1)
         ConfigFile.save_project(@project2)
         ConfigFile.save_project(@project3)
@@ -86,9 +86,9 @@ describe "ConfigFile" do
   describe "calling 'delete_project'" do
     context "when the project entry exists in the file" do
       before(:each) do
-        @project1 = Project.new(:public_key => "p1_pub_value", :private_key => "p1_private_key")
-        @project2 = Project.new(:public_key => "p2_pub_value", :private_key => "p2_private_key")
-        @project3 = Project.new(:public_key => "p3_pub_value", :private_key => "p3_private_key")
+        @project1 = Project.new("p1_pub_value", :private_key => "p1_private_key")
+        @project2 = Project.new("p2_pub_value", :private_key => "p2_private_key")
+        @project3 = Project.new("p3_pub_value", :private_key => "p3_private_key")
         ConfigFile.save_project(@project1)
         ConfigFile.save_project(@project2)
         ConfigFile.save_project(@project3)
@@ -107,7 +107,7 @@ describe "ConfigFile" do
 
     context "when the project entry does not exist in the file" do
       before(:each) do
-        @project = Project.new(:public_key => "p1_pub_nonexist_value", :private_key => "p1_private_key")
+        @project = Project.new("p1_pub_nonexist_value", :private_key => "p1_private_key")
       end
 
       it "does not raise an error" do
@@ -144,7 +144,7 @@ describe "ConfigFile" do
       end
     end
   end
-  
+
   describe "calling 'save_credentials'" do
     before(:each) do
       @api_key  = "API_KEY"
@@ -182,7 +182,7 @@ describe "ConfigFile" do
 
     it "does not affect existing project content" do
       public_key = "pub_value"
-      project = Project.new(:public_key => public_key, :private_key => "private_key")
+      project = Project.new(public_key, :private_key => "private_key")
       ConfigFile.save_project(project)
       ConfigFile.save_credentials(@api_key)
       ConfigFile.serialized[:projects][public_key.to_sym].should_not be_nil
@@ -215,7 +215,7 @@ describe "ConfigFile" do
 
     context "when projects exist in the file" do
       before(:each) do
-        create_uniq_project = lambda {|index| Project.new(:public_key => "pub_key_#{index}", :private_key => 'pk')}
+        create_uniq_project = lambda {|index| Project.new("pub_key_#{index}", :private_key => 'pk')}
         @projects = 5.times.map {|i| create_uniq_project.call(i)}
         @projects.each {|project| ConfigFile.save_project(project)}
       end
@@ -237,9 +237,65 @@ describe "ConfigFile" do
     end
 
     context "when no credentials exist in the file" do
-      it "returns an empty Hash" do
+      it "returns nil" do
         ConfigFile.api_key.should == nil
       end
     end
   end
+
+  describe "#options_for_project" do
+    let(:private_key) {'private_key'}
+    let(:public_key) {'public_key'}
+    let(:project_instance) {Project.new(public_key, private_key)}
+
+    context "when passing in an Project instance" do
+      let(:param) {project_instance}
+
+      context "and no projects have been saved before" do
+        it "returns an empty Hash" do
+          delete_config_file
+          ConfigFile.options_for_project(param).should == {}
+        end
+      end
+
+      context "and the specified project has not been saved before" do
+        it "returns an empty Hash" do
+          ConfigFile.save_project(Project.new('public_key1'))
+          ConfigFile.options_for_project(param).should == {}
+        end
+      end
+
+      context "and the specified project has been saved before" do
+        it "returns a Hash of the project information" do
+          ConfigFile.save_project(project_instance)
+          ConfigFile.options_for_project(param).should include(:private_key => private_key)
+        end
+      end
+    end
+
+    context "when passing in the public key" do
+      let(:param) {public_key}
+
+      context "and no projects have been saved before" do
+        it "returns an empty Hash" do
+          delete_config_file
+          ConfigFile.options_for_project(param).should == {}
+        end
+      end
+
+      context "and the specified project has not been saved before" do
+        it "returns an empty Hash" do
+          ConfigFile.save_project(Project.new('public_key1'))
+          ConfigFile.options_for_project(param).should == {}
+        end
+      end
+
+      context "and the specified project has been saved before" do
+        it "returns a Hash of the project information" do
+          ConfigFile.save_project(project_instance)
+          ConfigFile.options_for_project(param).should include(:private_key => private_key)
+        end
+      end
+    end
+  end
 end

data/spec/codefumes/harvester_spec.rb

@@ -0,0 +1,118 @@
+require File.expand_path(File.dirname(__FILE__) + '/../spec_helper')
+
+#TODO: clean this up
+include CodeFumesServiceHelpers::Shared
+include CodeFumesServiceHelpers::ProjectHelpers
+
+def raise_if_users_config_file
+  if ConfigFile.path == File.expand_path('~/.codefumes_config')
+    raise "Set a custom config file path"
+  end
+end
+
+def delete_config_file
+  unless ConfigFile.path == File.expand_path('~/.codefumes_config')
+    File.delete(ConfigFile.path) if File.exist?(ConfigFile.path)
+  end
+end
+
+describe Harvester do
+  after(:all) do
+    delete_config_file
+    FakeWeb.allow_net_connect = false
+    FakeWeb.clean_registry
+  end
+
+
+  let(:no_scm_path) {"#{File.dirname(__FILE__)}/../fixtures/sample_project_dirs/no_scm"}
+  let(:git_scm_path) {"#{File.dirname(__FILE__)}/../fixtures/sample_project_dirs/git_repository"}
+
+
+  before(:each) do
+    raise_if_users_config_file
+    setup_fixture_base
+    register_create_uri #For project creation
+    @repository = Grit::Repo.new(git_scm_path)
+  end
+
+  describe "#new" do
+    context "with a path to a directory that is using git" do
+      before(:each) do
+        Grit::Repo.stub!(:new).with(File.expand_path(git_scm_path)).and_return(@repository)
+      end
+
+      it "initializes a new Grit::Repo instance with the specified directory path" do
+        Grit::Repo.should_receive(:new).with(File.expand_path(git_scm_path)).and_return(@repository)
+        Harvester.new(:path => git_scm_path)
+      end
+    end
+
+    context "with a path to a directory that is not using a supported SCM" do
+      it "raises an UnsupportedScmToolError" do
+        lambda {
+          Harvester.new(:path => no_scm_path)
+        }.should raise_error(Errors::UnsupportedScmToolError)
+      end
+    end
+
+    context "when specifying the public/private keys" do
+      let(:public_key) {@pub_key}
+      let(:private_key) {@priv_key}
+
+      it "ignores the configuration saved in the underlying repository" do
+        register_show_uri
+        @repository.should_not_receive(:public_key)
+        @repository.should_not_receive(:private__key)
+        lambda {Harvester.new(:public_key => public_key, :private_key => private_key)}
+      end
+
+      context "if the specified project is not found on the server" do
+        before(:each) {register_show_uri(["404", "Not found"])}
+
+        it "raises an UnknownProjectError" do
+          lambda {
+            Harvester.new(:public_key => public_key, :private_key => private_key)
+          }.should raise_error(Errors::UnknownProjectError)
+        end
+
+        it "does not attempt to create a new project on the CodeFumes site" do
+          Project.should_not_receive(:create)
+          lambda {Harvester.new(:public_key => public_key, :private_key => private_key)}
+        end
+      end
+    end
+  end
+
+  describe "#path" do
+    it "returns the full path to a project" do
+      harvester = Harvester.new(:path => git_scm_path)
+      harvester.path.should == File.expand_path(git_scm_path)
+    end
+  end
+
+  describe "#publish_data!" do
+    include CodeFumesServiceHelpers::CommitHelpers
+    include CodeFumesServiceHelpers::ProjectHelpers
+
+    before(:each) do
+      delete_config_file
+      register_latest_uri
+      register_update_uri
+      @harvester = Harvester.new(:path => git_scm_path)
+      @payload = mock("Payload instance", :save => true)
+      Payload.stub!(:new).and_return(@payload)
+    end
+
+    it "saves the Payload to the website" do
+      pending "Need to figure out a better way to test this..."
+      @payload.should_receive(:save).and_return(true)
+      @harvester.publish_data!
+    end
+
+    it "updates the config file's project information" do
+      pending "Need to figure out a better way to test this..."
+      ConfigFile.should_receive(:save_project)
+      @harvester.publish_data!
+    end
+  end
+end

data/spec/codefumes/source_control_spec.rb

@@ -0,0 +1,199 @@
+require File.expand_path(File.dirname(__FILE__) + '/../spec_helper')
+
+describe SourceControl do
+  after(:each) do
+    SourceControl.new(GIT_FIXTURE_REPO_PATH).unlink_from_codefumes!
+    unless ConfigFile.path == File.expand_path('~/.codefumes_config')
+      File.delete(ConfigFile.path) if File.exists?(ConfigFile.path)
+    end
+  end
+
+  describe "creation" do
+    context "with a path to a directory that is not a git repository" do
+      it "raises an error" do
+        invalid_path = File.dirname(__FILE__)
+        lambda {SourceControl.new(invalid_path)}.should raise_error(Errors::UnsupportedScmToolError)
+      end
+    end
+  end
+
+  describe "#supported_systems" do
+    it "includes :git" do
+      SourceControl.supported_systems.should include(:git)
+    end
+  end
+
+  describe "#supported_system?" do
+    SourceControl.supported_systems.each do |scm_tool|
+      it "returns true for the string '#{scm_tool.to_s}'" do
+        SourceControl.supported_system?(scm_tool.to_s)
+      end
+
+      it "returns true for the symbol ':#{scm_tool.to_s}'" do
+        SourceControl.supported_system?(scm_tool.to_sym)
+      end
+    end
+  end
+
+  describe "#initial_commit_identifier" do
+    before(:each) do
+      git_repo_path = File.expand_path(File.dirname(__FILE__) + '/../fixtures/sample_project_dirs/git_repository')
+      @repository = SourceControl.new(git_repo_path)
+    end
+
+    it "returns the identifer (sha/commit #) of the first commit" do
+      @repository.initial_commit_identifier.should == "a8b3e73fc5e4bc46bbdf5c1cab38cb2ce47ba2d0"
+    end
+  end
+
+  describe "#payload_between" do
+    before(:each) do
+      git_repo_path = File.expand_path(File.dirname(__FILE__) + '/../fixtures/sample_project_dirs/git_repository')
+      @repository = SourceControl.new(git_repo_path)
+    end
+
+    it "returns a Hash containing the key ':commits'" do
+      @repository.payload_between.keys.should include(:commits)
+    end
+
+    it "is aliased to 'payload'" do
+      @repository.payload_between.keys.should == @repository.payload.keys
+      # FIXME: Improve this...not a complete test. Object ids getting in the way
+      @repository.payload_between[:commits].each_with_index do |commit, index|
+        commit[:identifier].should == @repository.payload[:commits][index][:identifier]
+      end
+    end
+
+    it "returns the commits in the same order a standard 'log view' of the repository would" do
+      first_commit = @repository.payload_between[:commits].last
+      first_commit[:identifier].should == "a8b3e73fc5e4bc46bbdf5c1cab38cb2ce47ba2d0"
+    end
+
+    context "the ':commits' key returned" do
+      context "contains a list of data for each commit" do
+        before(:each) do
+          @first_commit = @repository.payload_between[:commits].last
+        end
+
+        it "contains 'id', which is the 'sha' of the commit" do
+          @first_commit[:identifier].should == "a8b3e73fc5e4bc46bbdf5c1cab38cb2ce47ba2d0"
+        end
+
+        it "contains 'author', which points to the 'email' & the 'name' of the commit (in a Hash)" do
+          @first_commit[:author_email].should == "tkersten@obtiva.com"
+          @first_commit[:author_name].should == "Tom Kersten"
+        end
+
+        it "contains 'committer', which points to the 'email' & the 'name' of the commit (in a Hash)" do
+          @first_commit[:committer_email].should == "tkersten@obtiva.com"
+          @first_commit[:committer_name].should == "Tom Kersten"
+        end
+
+        it "contains 'message', which holds the full message of the commit" do
+          @first_commit[:message].should == "Initial commit with description of directory"
+        end
+
+        it "contains 'short_message', which holds the first line of the message of the commit" do
+          @first_commit[:short_message].should == "Initial commit with description of directory"
+        end
+
+        it "contains 'committed_date' of the commit" do
+          @first_commit[:committed_at].should == Chronic.parse("Sat May 09 08:52:14 -0500 2009")
+        end
+
+        it "contains 'authored_date' of the commit" do
+          @first_commit[:authored_at].should == Chronic.parse("Sat May 09 08:52:14 -0500 2009")
+        end
+
+        it "contains 'parent_commits' of the commit" do
+          @first_commit[:parent_identifiers].should_not be_nil
+        end
+
+        it "contains a 'line_additions' key" do
+          @first_commit[:line_additions].should_not be_nil
+        end
+
+        it "contains an 'line_deletions' key" do
+          @first_commit[:line_deletions].should_not be_nil
+        end
+
+        it "contains an 'line_total' key" do
+          @first_commit[:line_total].should_not be_nil
+        end
+
+        it "contains a 'affected_file_count' key" do
+          @first_commit[:affected_file_count].should_not be_nil
+        end
+      end
+    end
+
+    context "when 'from' is specified but the value is nil" do
+      it "defaults to the initial commit identifier of the repository" do
+        @repository.should_receive(:commits_between).with("a8b3e73fc5e4bc46bbdf5c1cab38cb2ce47ba2d0", anything()).and_return([])
+        @repository.payload_between(nil, "something")
+      end
+    end
+
+    context "when 'to' is specified but the value is nil" do
+      it "defaults to the 'HEAD' commit identifier of the repository" do
+        @repository.should_receive(:commits_between).with(anything(), "HEAD").and_return([])
+        @repository.payload_between("something", nil)
+      end
+    end
+
+    context "when there is no new information to send up" do
+      it "returns an empty object" do
+        @repository.payload_between("HEAD", "HEAD").should be_empty
+      end
+    end
+  end
+
+  describe "#public_key=" do
+    before(:each) do
+      git_repo_path = File.expand_path(File.dirname(__FILE__) + '/../fixtures/sample_project_dirs/git_repository')
+      @public_key = "public_key_specified"
+      @repository = SourceControl.new(git_repo_path)
+      @project = Project.new(:public_key => @public_key)
+    end
+
+    it "stores the supplied public key in the SCM tool's repository-specific configuration" do
+      @repository.store_public_key(@public_key)
+      @repository.public_key.should == @public_key
+    end
+  end
+
+  describe "#public_key" do
+    before(:each) do
+      @public_key = "original_value"
+      git_repo_path = File.expand_path(File.dirname(__FILE__) + '/../fixtures/sample_project_dirs/git_repository')
+      @repository = SourceControl.new(git_repo_path)
+      @repository.store_public_key(@public_key)
+    end
+
+    it "returns the current value of 'codometer.public_key' from the repository-specific configuration" do
+      @repository.public_key.should == @public_key
+    end
+  end
+
+  describe "#local_commit_identifier" do
+    before(:each) do
+      git_repo_path = File.expand_path(File.dirname(__FILE__) + '/../fixtures/sample_project_dirs/git_repository')
+      @repository = SourceControl.new(git_repo_path)
+    end
+
+    it "returns the current commit identifier for the local repository" do
+      @repository.local_commit_identifier.should == "7dc0e73fea4625204b7c1e6a48e9a57025be4d7e"
+    end
+  end
+
+  describe "#path" do
+    before(:each) do
+      @git_repo_path = File.expand_path(File.dirname(__FILE__) + '/../fixtures/sample_project_dirs/git_repository')
+      @repository = SourceControl.new(@git_repo_path)
+    end
+
+    it "returns the full path to the .git directory of the repository" do
+      @repository.path.should == @git_repo_path + '/.git'
+    end
+  end
+end