codeclimate 0.85.28 → 0.87.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 8ca0c15dd4895e2c738f0e08b7ae17c06ef8abeb0640761ab8ed9b35f3cd5bb2
-  data.tar.gz: 620605f5ffe39ed8b45edab7b38ed161888c25ed1a0875ce70e3e0fdcdbe6143
+  metadata.gz: 39b2a1bf8027ab5894a37493d345667a11c3a8c759d8c2612f9dfaa244654c9d
+  data.tar.gz: 61e7efec4f68964c400b5b2cb9f88f23116e54d533ebf754d2cfc833fc83638e
 SHA512:
-  metadata.gz: d5420f8af6589b01028db9c28edab19582d76866777e3087a99bc7d998212a81fd38f8d718d534123454c981636b3a86b8d54dbd7b2b186ac7677fa714363a11
-  data.tar.gz: 1b0925cf9eaa9484c0b64e260b6f03e169124832318cee43afa89ccc89a9ba6d0b8a5e70f1a73599eb9e999afe4b294ea6cbef42833dc39c51170d5ffd0e284c
+  metadata.gz: eeb564e3981ed3709b9972cc3b05b053582b6264c69f1a3c0cdd7d5cea1ae1bab6e822b70713d1287517760889f1f0ad7222ad172d9d15f1c34149f8ef2686b2
+  data.tar.gz: 9fd9e173468007706a41f5dbb4af4003ffad314047077cb33cce63dcb478842aff93ab61f7ab4324bde8837993609be1c460779b8b4ba9e95b0159106c5d3533

data/config/engines.yml

@@ -256,6 +256,8 @@ rubocop:
     rubocop-1-22-2: codeclimate/codeclimate-rubocop:rubocop-1-22-2
     rubocop-1-22-3: codeclimate/codeclimate-rubocop:rubocop-1-22-3
     rubocop-1-23-0: codeclimate/codeclimate-rubocop:rubocop-1-23-0
+    rubocop-1-30-0: codeclimate/codeclimate-rubocop:rubocop-1-30-0
+    rubocop-1-31-0: codeclimate/codeclimate-rubocop:rubocop-1-31-0
   description: A Ruby static code analyzer, based on the community Ruby style guide.
 rubymotion:
   channels:
@@ -286,7 +288,7 @@ shellcheck:
 sonar-java:
   channels:
     stable: codeclimate/codeclimate-sonar-java
-    beta: codeclimate/codeclimate-sonar-java:sonar-java-5-14
+    beta: codeclimate/codeclimate-sonar-java:beta
     sonar-java-5-14: codeclimate/codeclimate-sonar-java:sonar-java-5-14
   description: Over 400 checks for bugs, vulnerabilities, and code smells in Java code.
   minimum_memory_limit: 2_048_000_000

data/lib/cc/analyzer/container.rb

@@ -1,5 +1,5 @@
-require "posix/spawn"
 require "cc/analyzer/container/result"
+require "open3"
 
 module CC
   module Analyzer
@@ -52,19 +52,14 @@ module CC
 
         command = docker_run_command(options)
         Analyzer.logger.debug("docker run: #{command.inspect}")
-        pid, _, out, err = POSIX::Spawn.popen4(*command)
+        _, out, err, @t_wait = Open3.popen3(*command)
 
         @t_out = read_stdout(out)
         @t_err = read_stderr(err)
         t_timeout = timeout_thread
 
-        # blocks until the engine stops. this is put in a thread so that we can
-        # explicitly abort it as part of #stop. otherwise a run-away container
-        # could still block here forever if the docker-kill/wait is not
-        # successful. there may still be stdout in flight if it was being
-        # produced more quickly than consumed.
-        @t_wait = Thread.new { _, @status = Process.waitpid2(pid) }
-        @t_wait.join
+        # Calling @t_wait.value waits the termination of the process / engine
+        @status = @t_wait.value
 
         # blocks until all readers are done. they're still governed by the
         # timeout thread at this point. if we hit the timeout while processing
@@ -97,6 +92,9 @@ module CC
       def stop(message = nil)
         reap_running_container(message)
         kill_reader_threads
+        # Manually killing the process otherwise a run-away container
+        # could still block here forever if the docker-kill/wait is not
+        # successful
         kill_wait_thread
       end
 
@@ -178,9 +176,11 @@ module CC
 
       def reap_running_container(message)
         Analyzer.logger.warn("killing container name=#{@name} message=#{message.inspect}")
-        POSIX::Spawn::Child.new("docker", "kill", @name, timeout: 2.minutes)
-        POSIX::Spawn::Child.new("docker", "wait", @name, timeout: 2.minutes)
-      rescue POSIX::Spawn::TimeoutExceeded
+        Timeout.timeout(2.minutes.to_i) do
+          Kernel.system("docker", "kill", @name, [:out, :err] => File::NULL)
+          Kernel.system("docker", "wait", @name, [:out, :err] => File::NULL)
+        end
+      rescue Timeout::Error
         Analyzer.logger.error("unable to kill container name=#{@name} message=#{message.inspect}")
         Analyzer.statsd.increment("container.zombie")
         Analyzer.statsd.increment("container.zombie.#{metric_name}") if metric_name

data/lib/cc/cli/file_store.rb

@@ -31,7 +31,7 @@ module CC
         @data =
           if File.exist? self.class::FILE_NAME
             File.open(self.class::FILE_NAME, "r:bom|utf-8") do |f|
-              YAML.safe_load(f, [Time], [], false, self.class::FILE_NAME) || {}
+              YAML.safe_load(f, permitted_classes: [Time], permitted_symbols: [], aliases: false, filename: self.class::FILE_NAME)  || {}
             end
           else
             {}

data/lib/cc/cli/prepare.rb

@@ -26,6 +26,7 @@ module CC
         IPAddr.new("fd00::/8"),
         IPAddr.new("127.0.0.1"),
         IPAddr.new("0:0:0:0:0:0:0:1"),
+        IPAddr.new("169.254.0.0/16"),
       ].freeze
 
       def run

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: codeclimate
 version: !ruby/object:Gem::Version
-  version: 0.85.28
+  version: 0.87.0
 platform: ruby
 authors:
 - Code Climate
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2022-06-07 00:00:00.000000000 Z
+date: 2022-08-15 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: activesupport
@@ -44,40 +44,14 @@ dependencies:
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '1.7'
-    - - ">="
-      - !ruby/object:Gem::Version
-        version: 1.7.2
+        version: 2.0.3
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '1.7'
-    - - ">="
-      - !ruby/object:Gem::Version
-        version: 1.7.2
-- !ruby/object:Gem::Dependency
-  name: posix-spawn
-  requirement: !ruby/object:Gem::Requirement
-    requirements:
-    - - "~>"
-      - !ruby/object:Gem::Version
-        version: '0.3'
-    - - ">="
-      - !ruby/object:Gem::Version
-        version: 0.3.11
-  type: :runtime
-  prerelease: false
-  version_requirements: !ruby/object:Gem::Requirement
-    requirements:
-    - - "~>"
-      - !ruby/object:Gem::Version
-        version: '0.3'
-    - - ">="
-      - !ruby/object:Gem::Version
-        version: 0.3.11
+        version: 2.0.3
 - !ruby/object:Gem::Dependency
   name: pry
   requirement: !ruby/object:Gem::Requirement
@@ -256,9 +230,12 @@ require_paths:
 - lib
 required_ruby_version: !ruby/object:Gem::Requirement
   requirements:
-  - - "~>"
+  - - ">="
     - !ruby/object:Gem::Version
       version: '2.6'
+  - - "<="
+    - !ruby/object:Gem::Version
+      version: 3.1.2
 required_rubygems_version: !ruby/object:Gem::Requirement
   requirements:
   - - ">="