codeclimate 0.84.0 → 0.85.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
-SHA1:
-  metadata.gz: 9428ec03c8cdcf8f38760bea6e34742333d83b6a
-  data.tar.gz: 6d1dda9a4acd07555797876d2d9424076309d8ff
+SHA256:
+  metadata.gz: 658c734cd7d6152721a5001d2ddbfd53bac5bd4c5f9f93300c735034ddeda8f9
+  data.tar.gz: 26b5b168326a37015822429db4e70516ec767f2ef231baa209b97f398feb6a36
 SHA512:
-  metadata.gz: 511c8b79b673c5bf371c8a0c77d6286b42bfd6cb2f900acbfe0facb1053acc58eee82366141e9f56cf37672026111ebeb6f55b9cc967bf38d1acf39f764bdeb5
-  data.tar.gz: 9a993d6b07f537cde95db02e5e4b0f24a82d620f511e09650b14c3adfae603a6c48a3cc32744c0cc07d5230c599df3f4ee69b517daaf82ef395fb673b48e9700
+  metadata.gz: 66eaf0d359da6aee9db3c52c26138231244c08a2aca31df5c21a7ce02a1388809ff3e54d2644b43f34ddf7cc9c82090842a49ae093ea3c592d658315e44d12c0
+  data.tar.gz: 7c3ca247d9c538b1327e7e8ac166dda9a335697fa31930c980aec2fd8999e084ba027c007f47725de1d9f6ab745a24850a4b7d8313298960d41ebdeec7195b83

data/lib/cc/analyzer/container.rb

@@ -84,7 +84,7 @@ module CC
         Result.new(
           container_name: @name,
           duration: duration,
-          exit_status: @status && @status.exitstatus,
+          exit_status: @status&.exitstatus,
           maximum_output_exceeded: @maximum_output_exceeded,
           output_byte_count: output_byte_count,
           stderr: @stderr_io.string,
@@ -93,7 +93,7 @@ module CC
         )
       ensure
         kill_reader_threads
-        t_timeout.kill if t_timeout
+        t_timeout&.kill
       end
 
       def stop(message = nil)
@@ -118,31 +118,27 @@ module CC
 
       def read_stdout(out)
         Thread.new do
-          begin
-            out.each_line(@output_delimeter) do |chunk|
-              output = chunk.chomp(@output_delimeter)
-
-              Analyzer.logger.debug("engine stdout: #{output}")
-              @on_output.call(output)
-              check_output_bytes(output.bytesize)
-            end
-          ensure
-            out.close
+          out.each_line(@output_delimeter) do |chunk|
+            output = chunk.chomp(@output_delimeter)
+
+            Analyzer.logger.debug("engine stdout: #{output}")
+            @on_output.call(output)
+            check_output_bytes(output.bytesize)
           end
+        ensure
+          out.close
         end
       end
 
       def read_stderr(err)
         Thread.new do
-          begin
-            err.each_line do |line|
-              Analyzer.logger.debug("engine stderr: #{line.chomp}")
-              @stderr_io.write(line)
-              check_output_bytes(line.bytesize)
-            end
-          ensure
-            err.close
+          err.each_line do |line|
+            Analyzer.logger.debug("engine stderr: #{line.chomp}")
+            @stderr_io.write(line)
+            check_output_bytes(line.bytesize)
           end
+        ensure
+          err.close
         end
       end
 
@@ -174,12 +170,12 @@ module CC
       end
 
       def kill_reader_threads
-        @t_out.kill if @t_out
-        @t_err.kill if @t_err
+        @t_out&.kill
+        @t_err&.kill
       end
 
       def kill_wait_thread
-        @t_wait.kill if @t_wait
+        @t_wait&.kill
       end
 
       def reap_running_container(message)

data/lib/cc/analyzer/formatters/plain_text_formatter.rb

@@ -30,7 +30,7 @@ module CC
           end
 
           print(colorize("Analysis complete! Found #{pluralize(issues.size, "issue")}", :green))
-          if warnings.size > 0
+          unless warnings.empty?
             print(colorize(" and #{pluralize(warnings.size, "warning")}", :green))
           end
           puts(colorize(".", :green))

data/lib/cc/analyzer/issue_validations/type_validation.rb

@@ -3,7 +3,7 @@ module CC
     module IssueValidations
       class TypeValidation < Validation
         def valid?
-          type && type.casecmp("issue").zero?
+          type&.casecmp("issue")&.zero?
         end
 
         def message

data/lib/cc/analyzer/measurement_validations/name_validation.rb

@@ -5,7 +5,7 @@ module CC
         REGEX = /^[A-Za-z0-9_\.\-]+$/
 
         def valid?
-          name && name.is_a?(String) && REGEX.match?(name)
+          name&.is_a?(String) && REGEX.match?(name)
         end
 
         def message

data/lib/cc/analyzer/measurement_validations/type_validation.rb

@@ -3,7 +3,7 @@ module CC
     module MeasurementValidations
       class TypeValidation < Validation
         def valid?
-          type && type.casecmp("measurement").zero?
+          type&.casecmp("measurement")&.zero?
         end
 
         def message

data/lib/cc/analyzer/measurement_validations/value_validation.rb

@@ -3,7 +3,7 @@ module CC
     module MeasurementValidations
       class ValueValidation < Validation
         def valid?
-          value && value.is_a?(Numeric)
+          value&.is_a?(Numeric)
         end
 
         def message

data/lib/cc/config/validation/engine_validator.rb

@@ -86,9 +86,6 @@ module CC
 
         def validate_exclude_fingerprints
           validate_key_type("exclude_fingerprints", Array)
-          if data.key?("exclude_fingerprints")
-            warnings << "'exclude_fingerprints' is deprecated, and support may be removed in the future"
-          end
         end
       end
     end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: codeclimate
 version: !ruby/object:Gem::Version
-  version: 0.84.0
+  version: 0.85.0
 platform: ruby
 authors:
 - Code Climate
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2019-03-26 00:00:00.000000000 Z
+date: 2019-03-28 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: activesupport
@@ -102,22 +102,22 @@ dependencies:
   name: rainbow
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - "~>"
-      - !ruby/object:Gem::Version
-        version: '2.0'
     - - ">="
       - !ruby/object:Gem::Version
         version: 2.0.0
+    - - "~>"
+      - !ruby/object:Gem::Version
+        version: '2.0'
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - "~>"
-      - !ruby/object:Gem::Version
-        version: '2.0'
     - - ">="
       - !ruby/object:Gem::Version
         version: 2.0.0
+    - - "~>"
+      - !ruby/object:Gem::Version
+        version: '2.0'
 - !ruby/object:Gem::Dependency
   name: redcarpet
   requirement: !ruby/object:Gem::Requirement
@@ -261,17 +261,16 @@ require_paths:
 - lib
 required_ruby_version: !ruby/object:Gem::Requirement
   requirements:
-  - - ">="
+  - - "~>"
     - !ruby/object:Gem::Version
-      version: '0'
+      version: '2.5'
 required_rubygems_version: !ruby/object:Gem::Requirement
   requirements:
   - - ">="
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
-rubyforge_project: 
-rubygems_version: 2.5.1
+rubygems_version: 3.0.3
 signing_key: 
 specification_version: 4
 summary: Code Climate CLI