codeclimate 0.25.1 → 0.26.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 6a339ef7445d413401803539cfb5bb54f2edf475
-  data.tar.gz: ff0640ca34caa4b97680bfa2d9a39efd4a3361dd
+  metadata.gz: 9d43c699da6eae6069acb8272502c1f14f21314b
+  data.tar.gz: 831177029f49803b8196bc87ae215825856833af
 SHA512:
-  metadata.gz: c4115c859c3123d70c07b9ab358ba7c5d701ac18da018bef98af170cd79cdcf57aa74f13d60f5d2ef35975b8eee8d6dcead8e317db572bd538e27363825f404c
-  data.tar.gz: 2a893fbbcfea71a99504281f02dce3a8cef50bf11a0c72e3c4eaa46e020084c0d4b6bc102d6ac456d591b375790f3d4095db759db7a75db09f4d3ed6faa6361f
+  metadata.gz: 011ea2bf09e8c6f49439546fe49cf18b55473163ba2b9b62b676b3054411db336870d9ccafa5387cb7cf25820de4a770f80ab722c2f7c6148effbb6e296fe7ed
+  data.tar.gz: 37f30fe06ba2ac1c65874837fef499effe1f9eab80a7522f65061e0294428afce0b9101125afaa7d97172184544e8571e29a23c6b8f8d461e95b0ed54b45ebf3

data/lib/cc/analyzer.rb

@@ -18,6 +18,8 @@ module CC
     autoload :IssueCategoryValidation, "cc/analyzer/issue_category_validation"
     autoload :IssueCheckNamePresenceValidation, "cc/analyzer/issue_check_name_presence_validation"
     autoload :IssueDescriptionPresenceValidation, "cc/analyzer/issue_description_presence_validation"
+    autoload :IssueLocationFormatValidation, "cc/analyzer/issue_location_format_validation"
+    autoload :IssueOtherLocationsFormatValidation, "cc/analyzer/issue_other_locations_format_validation"
     autoload :IssuePathExistenceValidation, "cc/analyzer/issue_path_existence_validation"
     autoload :IssuePathPresenceValidation, "cc/analyzer/issue_path_presence_validation"
     autoload :IssueRelativePathValidation, "cc/analyzer/issue_relative_path_validation"

data/lib/cc/analyzer/issue_location_format_validation.rb

@@ -0,0 +1,43 @@
+module CC
+  module Analyzer
+    class IssueLocationFormatValidation < Validation
+      def valid?
+        if location["lines"]
+          valid_lines?(location["lines"])
+        elsif location["positions"]
+          valid_positions?(location["positions"])
+        else
+          false
+        end
+      end
+
+      def message
+        "Location is not formatted correctly"
+      end
+
+      private
+
+      def location
+        @location ||= object.fetch("location", {})
+      end
+
+      def valid_positions?(positions)
+        positions.is_a?(Hash) &&
+          valid_position?(positions["begin"]) &&
+          valid_position?(positions["end"])
+      end
+
+      def valid_position?(position)
+        position &&
+          (
+            (position["line"] && position["column"]) ||
+            position["offset"]
+          )
+      end
+
+      def valid_lines?(lines)
+        lines.is_a?(Hash) && lines.key?("begin") && lines.key?("end")
+      end
+    end
+  end
+end

data/lib/cc/analyzer/issue_other_locations_format_validation.rb

@@ -0,0 +1,33 @@
+module CC
+  module Analyzer
+    class IssueOtherLocationsFormatValidation < Validation
+      CHECKS = [
+        IssueLocationFormatValidation,
+        IssuePathExistenceValidation,
+        IssuePathPresenceValidation,
+        IssueRelativePathValidation,
+      ].freeze
+
+      def valid?
+        if object["other_locations"]
+          object["other_locations"].is_a?(Array) &&
+            object["other_locations"].all?(&method(:other_location_valid?))
+        else
+          true
+        end
+      end
+
+      def message
+        "Other locations are not formatted correctly"
+      end
+
+      private
+
+      def other_location_valid?(location)
+        CHECKS.all? do |klass|
+          klass.new("location" => location).valid?
+        end
+      end
+    end
+  end
+end

data/lib/cc/analyzer/issue_validator.rb

@@ -5,6 +5,8 @@ module CC
         IssueCategoryValidation,
         IssueCheckNamePresenceValidation,
         IssueDescriptionPresenceValidation,
+        IssueLocationFormatValidation,
+        IssueOtherLocationsFormatValidation,
         IssuePathExistenceValidation,
         IssuePathPresenceValidation,
         IssueRelativePathValidation,

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: codeclimate
 version: !ruby/object:Gem::Version
-  version: 0.25.1
+  version: 0.26.0
 platform: ruby
 authors:
 - Code Climate
@@ -171,6 +171,8 @@ files:
 - lib/cc/analyzer/issue_category_validation.rb
 - lib/cc/analyzer/issue_check_name_presence_validation.rb
 - lib/cc/analyzer/issue_description_presence_validation.rb
+- lib/cc/analyzer/issue_location_format_validation.rb
+- lib/cc/analyzer/issue_other_locations_format_validation.rb
 - lib/cc/analyzer/issue_path_existence_validation.rb
 - lib/cc/analyzer/issue_path_presence_validation.rb
 - lib/cc/analyzer/issue_relative_path_validation.rb