codeclimate 0.1.2 → 0.1.3

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 44be0fcd7a63732cee0dcaffeb53073518b2224b
-  data.tar.gz: 7ba8ce2698db154603ceeec311d5683e2bac97df
+  metadata.gz: eade4e029db8e5fbeb3074af03ba35a571fa8b89
+  data.tar.gz: 9b10d656951c5f7411fe10fbf4e504d629810363
 SHA512:
-  metadata.gz: eb5dc4a21dae91099c9895be07463d74156a43640aa451c3d886f1f43fb05fe4d7bad97fc0f7ce23cdad039ea10ee067c30350500ae47392a1129fd509dd1a3e
-  data.tar.gz: e3cb97dce3b7fc85eda2afa2cb7462dc2785dbc5747dd155156c71e03b09af7da338960d07d405ccbeef5e5b7289004d334889dcc3848a3128f20e23cf6b4e9c
+  metadata.gz: 66b2b0e15c242af37fb41cd88c62db72bbb6f60b32d16edd061bae32ffe051a624395c94a098ce0a466e4a8596c7bd5414b1b723b0cd95a418cb061fd739895b
+  data.tar.gz: 02d48721c2276f455e3480c5cabf7736cd65d8132f5f35ac2ad876d50efd3208f3b4e8137af585435dd5c3e6a78a07d06774a55404abba7fd9de9b49ee6b7746

data/lib/cc/analyzer.rb

@@ -4,6 +4,7 @@ module CC
     autoload :Config,             "cc/analyzer/config"
     autoload :Engine,             "cc/analyzer/engine"
     autoload :EngineClient,       "cc/analyzer/engine_client"
+    autoload :EngineOutputFilter, "cc/analyzer/engine_output_filter"
     autoload :EngineProcess,      "cc/analyzer/engine_process"
     autoload :EngineRegistry,     "cc/analyzer/engine_registry"
     autoload :Filesystem,         "cc/analyzer/filesystem"

data/lib/cc/analyzer/engine.rb

@@ -23,7 +23,11 @@ module CC
 
         t_out = Thread.new do
           out.each_line("\0") do |chunk|
-            stdout_io.write(chunk.chomp("\0"))
+            output = chunk.chomp("\0")
+
+            unless output_filter.filter?(output)
+              stdout_io.write(output)
+            end
           end
         end
 
@@ -110,6 +114,16 @@ module CC
         end
       end
 
+      def output_filter
+        @output_filter ||= EngineOutputFilter.new(config)
+      end
+
+      def config
+        # N.B. there is no expected scenario where this would fail so a
+        # parser-error rescue has been omitted intentionally
+        JSON.parse(@config_json)
+      end
+
       CommandFailure = Class.new(StandardError)
       EngineFailure = Class.new(StandardError)
       EngineTimeout = Class.new(StandardError)

data/lib/cc/analyzer/engine_output_filter.rb

@@ -0,0 +1,40 @@
+module CC
+  module Analyzer
+    class EngineOutputFilter
+      ISSUE_TYPE = "issue".freeze
+
+      def initialize(config = {})
+        @config = config
+      end
+
+      def filter?(output)
+        if (json = parse_as_json(output))
+          issue?(json) && ignore_issue?(json)
+        else
+          false
+        end
+      end
+
+      private
+
+      def parse_as_json(output)
+        JSON.parse(output)
+      rescue JSON::ParserError
+        nil
+      end
+
+      def issue?(json)
+        json["type"] == ISSUE_TYPE
+      end
+
+      def ignore_issue?(json)
+        !check_config(json["check"]).fetch("enabled", true)
+      end
+
+      def check_config(check_name)
+        @checks ||= @config.fetch("checks", {})
+        @checks.fetch(check_name, {})
+      end
+    end
+  end
+end

data/lib/cc/analyzer/formatters/formatter.rb

@@ -13,7 +13,10 @@ module CC
         end
 
         def engine_running(engine)
+          @current_engine = engine
           yield
+        ensure
+          @current_engine = nil
         end
 
         def finished
@@ -23,6 +26,10 @@ module CC
         end
 
         InvalidFormatterError = Class.new(StandardError)
+
+        private
+
+        attr_reader :current_engine
       end
     end
   end

data/lib/cc/analyzer/formatters/json_formatter.rb

@@ -7,25 +7,19 @@ module CC
           @has_begun = false
         end
 
-        def engine_running(engine)
-          @active_engine = engine
-          yield
-          @active_engine = nil
-        end
-
         def started
-          print "[ "
+          print "["
         end
 
         def finished
-          print " ]\n"
+          print "]\n"
         end
 
         def write(data)
           return unless data.present?
 
           document = JSON.parse(data)
-          document["engine_name"] = @active_engine.name
+          document["engine_name"] = current_engine.name
 
           if @has_begun
             print ",\n"

data/lib/cc/analyzer/formatters/plain_text_formatter.rb

@@ -14,9 +14,7 @@ module CC
         def write(data)
           if data.present?
             json = JSON.parse(data)
-            if @active_engine
-              json["engine_name"] = @active_engine.name
-            end
+            json["engine_name"] = current_engine.name
 
             case json["type"].downcase
             when "issue"
@@ -54,12 +52,10 @@ module CC
           puts(colorize(".", :green))
         end
 
-        def engine_running(engine)
-          @active_engine = engine
-          with_spinner("Running #{engine.name}: ") do
-            yield
+        def engine_running(engine, &block)
+          super(engine) do
+            with_spinner("Running #{current_engine.name}: ", &block)
           end
-          @active_engine = nil
         end
 
         def failed(output)

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: codeclimate
 version: !ruby/object:Gem::Version
-  version: 0.1.2
+  version: 0.1.3
 platform: ruby
 authors:
 - Code Climate
@@ -198,6 +198,7 @@ files:
 - lib/cc/analyzer.rb
 - lib/cc/analyzer/config.rb
 - lib/cc/analyzer/engine.rb
+- lib/cc/analyzer/engine_output_filter.rb
 - lib/cc/analyzer/engine_registry.rb
 - lib/cc/analyzer/filesystem.rb
 - lib/cc/analyzer/formatters.rb