codeclimate-services 1.9.8 → 1.10.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: cd62622c4effd89f89c9285ec07b7cd2798148b5
-  data.tar.gz: 746d956aa4ffe90f01b60b138189f3470d0aa824
+  metadata.gz: 2b11c82863c3fe8d7abd190d5d8d1605232348a2
+  data.tar.gz: 7953aafa98f5ff37f3752d6bc0695b35a265a9d7
 SHA512:
-  metadata.gz: e5c2d4cb11d2af026062570d9d7d2cdba70c301fb8f82058538af93c5dae4d5b22d571fe697d3ceb015434770236d6f8e9befbc7f92a4605a01b3092de374ded
-  data.tar.gz: 13adce202c161bed06e78f28439e375834135b365e307234e5f45f1ccdd0c280d5716aa59ec218452968b2c2f4b0bd4d3c9411f5c75a05a8159267e803afc1f6
+  metadata.gz: 73330d3bf0e63289bdb9d40a884782ed6bff091bd455168ff9eb8865abe63f5746c4a7f5fc7506bfcaa41367eb0879d63d0c9db4bc83af33b5eb87504181e580
+  data.tar.gz: 0d3a6ba2497993ae7860e7c5772e827c9c48672e7717169459fae0f0c5dee971f320b3207d195ce791cd1d6f8d757d986c2545cb407eb0d1effcdfed1b1fa518

data/lib/cc/presenters/pull_requests_presenter.rb

@@ -48,14 +48,12 @@ module CC
       def success_message
         if @approved_by
           approved_message
-        elsif @new_count > 0 && @fixed_count > 0
-          "#{@new_count} new #{"issue".pluralize(@new_count)} (#{@fixed_count} fixed)"
-        elsif @new_count <= 0 && @fixed_count > 0
+        elsif @new_count > 0
+          "#{@new_count} #{"issue".pluralize(@new_count)} to fix"
+        elsif @fixed_count > 0
           "#{@fixed_count} fixed #{"issue".pluralize(@fixed_count)}"
-        elsif @new_count > 0 && @fixed_count <= 0
-          "#{@new_count} new #{"issue".pluralize(@new_count)}"
         else
-          "no new or fixed issues"
+          "All good!"
         end
       end
 

data/lib/cc/services/version.rb

@@ -1,5 +1,5 @@
 module CC
   module Services
-    VERSION = "1.9.8".freeze
+    VERSION = "1.10.0".freeze
   end
 end

data/spec/cc/presenters/pull_requests_presenter_spec.rb

@@ -3,12 +3,12 @@ require "cc/presenters/pull_requests_presenter"
 describe CC::Service::PullRequestsPresenter, type: :service do
   it "message singular" do
     expect(build_presenter("fixed" => 1, "new" => 1).success_message).
-      to eq("1 new issue (1 fixed)")
+      to eq("1 issue to fix")
   end
 
   it "message plural" do
     expect(build_presenter("fixed" => 1, "new" => 2).success_message).
-      to eq("2 new issues (1 fixed)")
+      to eq("2 issues to fix")
   end
 
   it "message only fixed" do
@@ -18,12 +18,12 @@ describe CC::Service::PullRequestsPresenter, type: :service do
 
   it "message only new" do
     expect(build_presenter("fixed" => 0, "new" => 3).success_message).
-      to eq("3 new issues")
+      to eq("3 issues to fix")
   end
 
   it "message no new or fixed" do
     expect(build_presenter("fixed" => 0, "new" => 0).success_message).
-      to eq("no new or fixed issues")
+      to eq("All good!")
   end
 
   it "message coverage same" do
@@ -45,7 +45,7 @@ describe CC::Service::PullRequestsPresenter, type: :service do
 
   it "message approved is empty string" do
     expect(build_presenter({"fixed" => 1, "new" => 1}, { "approved_by" => ""}).success_message).
-      to eq("1 new issue (1 fixed)")
+      to eq("1 issue to fix")
   end
 
   private

data/spec/cc/service/github_pull_requests_spec.rb

@@ -10,7 +10,7 @@ describe CC::Service::GitHubPullRequests, type: :service do
 
   it "pull request status success detailed" do
     expect_status_update("pbrisbin/foo", "abc123", "state" => "success",
-      "description" => "2 new issues (1 fixed)")
+      "description" => "2 issues to fix")
 
     receive_pull_request(
       {},
@@ -22,7 +22,7 @@ describe CC::Service::GitHubPullRequests, type: :service do
 
   it "pull request status failure" do
     expect_status_update("pbrisbin/foo", "abc123", "state" => "failure",
-      "description" => "2 new issues (1 fixed)")
+      "description" => "2 issues to fix")
 
     receive_pull_request(
       {},
@@ -34,7 +34,7 @@ describe CC::Service::GitHubPullRequests, type: :service do
 
   it "pull request status success generic" do
     expect_status_update("pbrisbin/foo", "abc123", "state" => "success",
-      "description" => /2 new issues \(1 fixed\)/)
+      "description" => "2 issues to fix")
 
     receive_pull_request({}, github_slug: "pbrisbin/foo",
                              commit_sha:  "abc123",

data/spec/cc/service/gitlab_merge_requests_spec.rb

@@ -20,7 +20,7 @@ describe CC::Service::GitlabMergeRequests, type: :service do
       "hal/hal9000",
       "abc123",
       "state" => "success",
-      "description" => "2 new issues (1 fixed)",
+      "description" => "2 issues to fix",
     )
 
     receive_merge_request(
@@ -36,7 +36,7 @@ describe CC::Service::GitlabMergeRequests, type: :service do
       "hal/hal9000",
       "abc123",
       "state" => "failed",
-      "description" => "2 new issues (1 fixed)",
+      "description" => "2 issues to fix",
     )
 
     receive_merge_request(

data/spec/cc/service/stash_pull_requests_spec.rb

@@ -31,7 +31,7 @@ describe CC::Service::StashPullRequests, type: :service do
 
   it "pull request status success detailed" do
     expect_status_update("abc123", "state" => "SUCCESSFUL",
-      "description" => "2 new issues (1 fixed)")
+      "description" => "2 issues to fix")
 
     receive_pull_request(
       commit_sha: "abc123",
@@ -41,7 +41,7 @@ describe CC::Service::StashPullRequests, type: :service do
 
   it "pull request status failure" do
     expect_status_update("abc123", "state" => "FAILED",
-      "description" => "2 new issues (1 fixed)")
+      "description" => "2 issues to fix")
 
     receive_pull_request(
       commit_sha: "abc123",

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: codeclimate-services
 version: !ruby/object:Gem::Version
-  version: 1.9.8
+  version: 1.10.0
 platform: ruby
 authors:
 - Bryan Helmkamp
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2017-06-29 00:00:00.000000000 Z
+date: 2017-07-10 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: faraday
@@ -238,7 +238,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
       version: '0'
 requirements: []
 rubyforge_project: 
-rubygems_version: 2.6.11
+rubygems_version: 2.4.5
 signing_key: 
 specification_version: 4
 summary: Service classes for Code Climate