codeclimate-services 1.6.0 → 1.6.1

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: ed88d8be8ac49555d5377c666aa801cee1925cf4
-  data.tar.gz: fcb034490cf3433428864320b70d624363ba868c
+  metadata.gz: c5743e344af855362cf8d9de84add9de905ddef4
+  data.tar.gz: 30a6496f74f2ab59c32bacf37435ebf2a85c5649
 SHA512:
-  metadata.gz: 09a9a246394f6278144e7410a79ad54bdb8603dd58b871a57903adf393499aaa5fd438cb9240ec278720fb752d9bbccf7b625f73eb3b33f924bbec267f42c729
-  data.tar.gz: d77d17e723202638ee9340e7ecb472f32104fef4e2b2aadbc54a7e538f24b3b7fb0c43b4bab45615a59fab8aa3557f02abe9bf59d5be575a09472f024a32a85d
+  metadata.gz: 8fceef45fc66347e24f12790454d427be003e8fbdc3dec77849d8c3b0692323b1e56439bcd6baf9fce75859e6a8971607edaba0f9281ff860777c5e6f631d13a
+  data.tar.gz: 404ea8ec662df618b3a8e7e0077dbeb79cbdde38f4899c7c07edc8b921c6d1223537da59c023666d038cbf7a5467453820f2be788e54b87faf5904a157de0da3

data/codeclimate-services.gemspec

@@ -18,7 +18,7 @@ Gem::Specification.new do |spec|
   spec.require_paths = ["lib"]
 
   spec.add_dependency "faraday", "0.8.8"
-  spec.add_dependency "virtus", "1.0.0"
+  spec.add_dependency "virtus", "~> 1.0.0"
   spec.add_dependency "nokogiri", "~> 1.6.0"
   spec.add_dependency "activemodel", ">= 3.0"
   spec.add_dependency "activesupport", ">= 3.0"

data/lib/cc/service.rb

@@ -71,7 +71,7 @@ module CC
     def self.title
       @title ||= begin
         hook = name.dup
-        hook.sub! /.*:/, ''
+        hook.sub!(/.*:/, '')
         hook
       end
     end
@@ -80,7 +80,7 @@ module CC
       @slug ||= begin
         hook = name.dup
         hook.downcase!
-        hook.sub! /.*:/, ''
+        hook.sub!(/.*:/, '')
         hook
       end
     end

data/lib/cc/services/jira.rb

@@ -13,7 +13,11 @@ class CC::Service::Jira < CC::Service
       description: "Your JIRA password"
 
     attribute :project_id, Axiom::Types::String,
-      description: "Your JIRA project ID number (located in your JIRA admin panel). Project must support 'task' issue types and contain only the default required fields."
+      description: "Your JIRA project ID number (located in your JIRA admin panel). Project must contain only the default required fields."
+
+    attribute :issue_type, Axiom::Types::String,
+      description: "The type of Issue to be created.",
+      default: "Task"
 
     attribute :labels, Axiom::Types::String,
       description: "Which labels to add to issues, comma delimited"
@@ -65,7 +69,7 @@ private
           project: { id: config.project_id },
           summary: title,
           description: ticket_body,
-          issuetype: { name: "Task" }
+          issuetype: { name: config.issue_type }
         }
     }
 

data/lib/cc/services/slack.rb

@@ -72,7 +72,11 @@ class CC::Service::Slack < CC::Service
       @response = speak(improvements_message(snapshot.improved_constants_payload), GREEN_HEX)
     end
 
-    @response || { ok: false, ignored: true, message: "No changes in snapshot" }
+    if defined?(@response)
+      @response
+    else
+      { ok: false, ignored: true, message: "No changes in snapshot" }
+    end
   end
 
   def alerts_message(constants_payload)

data/lib/cc/services/version.rb

@@ -1,5 +1,5 @@
 module CC
   module Services
-    VERSION = "1.6.0"
+    VERSION = "1.6.1"
   end
 end

data/test/github_pull_requests_test.rb

@@ -156,7 +156,7 @@ class TestGitHubPullRequests < CC::Service::TestCase
       "state" => "pending",
     })
 
-    response = receive_pull_request({}, {
+    receive_pull_request({}, {
       github_slug: "gordondiggs/ellis",
       commit_sha:  "abc123",
       state:       "pending",
@@ -169,7 +169,7 @@ class TestGitHubPullRequests < CC::Service::TestCase
       "state" => "pending",
     })
 
-    response = receive_pull_request({ context: "sup" }, {
+    receive_pull_request({ context: "sup" }, {
       github_slug: "gordondiggs/ellis",
       commit_sha:  "abc123",
       state:       "pending",

data/test/invocation_test.rb

@@ -76,7 +76,7 @@ class TestInvocation < Test::Unit::TestCase
 
     assert error_occurred
     assert_equal 1, statsd.incremented_keys.length
-    assert_match /^services\.errors\.a_prefix/, statsd.incremented_keys.first
+    assert_match(/^services\.errors\.a_prefix/, statsd.incremented_keys.first)
   end
 
   def test_user_message
@@ -90,7 +90,7 @@ class TestInvocation < Test::Unit::TestCase
     end
 
     assert_equal "Hey do this", result[:message]
-    assert_match /Boom/, result[:log_message]
+    assert_match(/Boom/, result[:log_message])
   end
 
   def test_error_handling
@@ -104,7 +104,7 @@ class TestInvocation < Test::Unit::TestCase
 
     assert_equal({ok: false, message: "Boom", log_message: "Exception invoking service: [a_prefix] (RuntimeError) Boom"}, result)
     assert_equal 1, logger.logged_errors.length
-    assert_match /^Exception invoking service: \[a_prefix\]/, logger.logged_errors.first
+    assert_match(/^Exception invoking service: \[a_prefix\]/, logger.logged_errors.first)
   end
 
   def test_multiple_middleware
@@ -137,7 +137,7 @@ class TestInvocation < Test::Unit::TestCase
       @receive_count += 1
 
       begin
-        raise @fake_error if @fake_error
+        raise fake_error if fake_error
       rescue => e
         if override_user_message
           e.user_message = override_user_message

data/test/jira_test.rb

@@ -64,6 +64,7 @@ class TestJira < CC::Service::TestCase
       assert_equal "Basic Zm9vOmJhcg==", env[:request_headers]["Authorization"]
       assert_equal title, body["fields"]["summary"]
       assert_equal ticket_body, body["fields"]["description"]
+      assert_equal "Task", body["fields"]["issuetype"]["name"]
       [200, {}, '{"id":"10000"}']
     end
 

data/test/service_test.rb

@@ -34,8 +34,8 @@ class TestService < CC::Service::TestCase
   def test_post_success
     stub_http("/my/test/url", [200, {}, '{"ok": true, "thing": "123"}'])
 
-    response = service_post("/my/test/url", {token: "1234"}.to_json, {}) do |response|
-      body = JSON.parse(response.body)
+    response = service_post("/my/test/url", {token: "1234"}.to_json, {}) do |inner_response|
+      body = JSON.parse(inner_response.body)
       { thing: body["thing"] }
     end
 
@@ -49,8 +49,8 @@ class TestService < CC::Service::TestCase
     stub_http("/my/test/url", [307, {"Location" => "/my/redirect/url"}, '{"ok": false, "redirect": true}'])
     stub_http("/my/redirect/url", [200, {}, '{"ok": true, "thing": "123"}'])
 
-    response = service_post_with_redirects("/my/test/url", {token: "1234"}.to_json, {}) do |response|
-      body = JSON.parse(response.body)
+    response = service_post_with_redirects("/my/test/url", {token: "1234"}.to_json, {}) do |inner_response|
+      body = JSON.parse(inner_response.body)
       { thing: body["thing"] }
     end
 

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: codeclimate-services
 version: !ruby/object:Gem::Version
-  version: 1.6.0
+  version: 1.6.1
 platform: ruby
 authors:
 - Bryan Helmkamp
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2016-08-22 00:00:00.000000000 Z
+date: 2016-08-31 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: faraday
@@ -28,14 +28,14 @@ dependencies:
   name: virtus
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - '='
+    - - "~>"
       - !ruby/object:Gem::Version
         version: 1.0.0
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - '='
+    - - "~>"
       - !ruby/object:Gem::Version
         version: 1.0.0
 - !ruby/object:Gem::Dependency