codeclimate-services 1.10.1 → 1.11.2

checksums.yaml

@@ -1,7 +1,7 @@
 ---
-SHA1:
-  metadata.gz: 28a587b7b4dfdf431800b17380549e44b0f9c500
-  data.tar.gz: 65102446840ccaa599271b4875a9be8836c95934
+SHA256:
+  metadata.gz: 96ac3fb2929dbad8aadc4a01e46ae15dfdbd0f624da568dd171349b664cb9da2
+  data.tar.gz: de09b581fb3a7ec8c7d597d65f06d832acc8f00ecbbde05cc2a4a340ea6e75b2
 SHA512:
-  metadata.gz: 2a8d21f29a3a24b42f59c47f3edac13a1fdc25736249d58582b7dabf2d47484c36bed3c6d6b0166ecf5e1f26be3b7c763460d3ec1b132fbcd67669e7329afe1e
-  data.tar.gz: e7e3e23b0698d345fb32cf4bd545ca8f8370ee6de25bd8b64c228e5947c0d024beeb90935bbdf31171aa7d30590a0c233c1f87bab935ae041051c1222baf4602
+  metadata.gz: 9e75e38ea1dbcda5c960c5310a98ab6cade92b8ec51a54a3a4dfb43249ef04f35d318f2733f51e80920d337ed36c77cfbae14ca60ac5efbcafae68da6e3f1df5
+  data.tar.gz: 5ef15601e7864fd5a4287ac48658bd9e2e60847939e19c1a16f9bacc4836ee1d5eec9363b9648708edffdfa0678f662747e0b80b70792321572c52d0f3cc99ca

data/.circleci/config.yml

@@ -0,0 +1,26 @@
+version: 2.0
+jobs:
+  test:
+    environment:
+      CC_TEST_REPORTER_ID: ad21bc049a323138b0a88086069115e9df6dba417912095b7bb17b7a65fc6182
+    docker:
+      - image: "circleci/ruby:2.7.5"
+    working_directory: ~/codeclimate/codeclimate-services
+    steps:
+      - checkout
+      - run:
+          name: Setup Coverage
+          command: |
+           (curl -L https://codeclimate.com/downloads/test-reporter/test-reporter-latest-linux-amd64 > cc-test-reporter && chmod +x ./cc-test-reporter) || echo "Couldn't download test reporter"
+      - run: bundle install && bundle exec rake
+      - persist_to_workspace:
+          root: .
+          paths:
+            - coverage
+      - run: ./cc-test-reporter after-build --exit-code $? || echo "Send coverage skipped..."
+
+workflows:
+  version: 2
+  test:
+    jobs:
+      - test

data/.ruby-version

@@ -1 +1 @@
-2.2.2
+2.7.5

data/Gemfile

@@ -7,5 +7,4 @@ gem "pry"
 
 group :test do
   gem "simplecov"
-  gem "codeclimate-test-reporter", "~> 1.0.0"
 end

data/README.md

@@ -131,6 +131,18 @@ and always return a hash of `{ ok: true|false, message: "String (HTML ok)" }`.
 
 When you open your PR, please include an image for your service.
 
+## Release
+
+1. Bump the version on `lib/cc/services/version`
+2. A gem owner developer should run the following: (check owners here https://rubygems.org/gems/codeclimate-services)
+```shell
+bundle install
+gem build codeclimate-services.gemspec
+gem push codeclimate-services-<VERSION>.gem
+git tag v<VERSION>
+git push origin master --tags
+```
+
 ## License
 
 See LICENSE.txt. This incorporates code from bugsnag-notification-plugins and

data/codeclimate-services.gemspec

@@ -10,7 +10,7 @@ Gem::Specification.new do |spec|
   spec.email = ["bryan@brynary.com"]
   spec.summary = "Service classes for Code Climate"
   spec.description = "Service classes for Code Climate"
-  spec.homepage = ""
+  spec.homepage = "https://codeclimate.com/"
   spec.license = "MIT"
 
   spec.files = `git ls-files`.split($/)

data/lib/cc/presenters/pull_requests_presenter.rb

@@ -36,9 +36,11 @@ module CC
       def coverage_message
         message = "#{formatted_percent(@covered_percent)}%"
 
-        if @covered_percent_delta > 0
+        return message if @covered_percent_delta.nil?
+
+        if @covered_percent_delta.round(2) > 0
           message += " (+#{formatted_percent(@covered_percent_delta)}%)"
-        elsif @covered_percent_delta < 0
+        elsif @covered_percent_delta.round(2) < 0
           message += " (#{formatted_percent(@covered_percent_delta)}%)"
         end
 

data/lib/cc/service/formatter.rb

@@ -19,7 +19,7 @@ class CC::Service::Formatter < SimpleDelegator
   end
 
   def message_prefix
-    prefix = options.fetch(:prefix, "").to_s
+    prefix = (options[:prefix] || "").to_s
 
     if options[:prefix_with_repo]
       prefix << "[#{repo_name}]"

data/lib/cc/services/gitlab_merge_requests.rb

@@ -58,12 +58,12 @@ class CC::Service::GitlabMergeRequests < CC::PullRequests
 
   def setup_http
     http.headers["Content-Type"] = "application/json"
-    http.headers["PRIVATE-TOKEN"] = config.access_token
+    http.headers["Private-Token"] = config.access_token
     http.headers["User-Agent"] = "Code Climate"
   end
 
   def base_status_url(commit_sha)
-    "#{config.base_url}/api/v3/projects/#{CGI.escape(slug)}/statuses/#{commit_sha}"
+    "#{config.base_url}/api/v4/projects/#{CGI.escape(slug)}/statuses/#{commit_sha}"
   end
 
   def slug

data/lib/cc/services/jira.rb

@@ -3,7 +3,7 @@ require "base64"
 class CC::Service::Jira < CC::Service
   class Config < CC::Service::Config
     attribute :domain, Axiom::Types::String,
-      description: "Your JIRA host domain (e.g. yourjira.com:PORT, please exclude https://)"
+      description: "Your JIRA host domain (e.g. yourjira.com[:PORT], please exclude https:// and only add PORT if you are using a different port number to access your own server that is not the default)"
 
     attribute :username, Axiom::Types::String,
       description: "Must exactly match the 'username' that appears on your JIRA profile page."

data/lib/cc/services/version.rb

@@ -1,5 +1,5 @@
 module CC
   module Services
-    VERSION = "1.10.1".freeze
+    VERSION = "1.11.2".freeze
   end
 end

data/spec/cc/presenters/pull_requests_presenter_spec.rb

@@ -30,12 +30,20 @@ describe CC::Service::PullRequestsPresenter, type: :service do
     expect("85%").to eq(build_presenter({}, "covered_percent" => 85, "covered_percent_delta" => 0).coverage_message)
   end
 
+  it "message coverage without delta" do
+    expect("85%").to eq(build_presenter({}, "covered_percent" => 85, "covered_percent_delta" => nil).coverage_message)
+  end
+
+  it "message coverage the same when rounded" do
+    expect("85%").to eq(build_presenter({}, "covered_percent" => 85, "covered_percent_delta" => 0.0005).coverage_message)
+  end
+
   it "message coverage up" do
     expect("85.5% (+2.46%)").to eq(build_presenter({}, "covered_percent" => 85.5, "covered_percent_delta" => 2.4567).coverage_message)
   end
 
   it "message coverage down" do
-    expect("85.35% (-3%)").to eq( build_presenter({}, "covered_percent" => 85.348, "covered_percent_delta" => -3.0).coverage_message)
+    expect("85.35% (-3%)").to eq(build_presenter({}, "covered_percent" => 85.348, "covered_percent_delta" => -3.0).coverage_message)
   end
 
   it "message approved" do

data/spec/cc/service/formatter_spec.rb

@@ -0,0 +1,21 @@
+describe CC::Service::Formatter do
+
+  class TestFormatter < described_class
+    def format_test
+      message = message_prefix
+      message << "This is a test"
+    end
+  end
+
+  FakeService = Struct.new(:receive)
+
+  it "supports passing nil as prefix" do
+    formatter = TestFormatter.new(
+      FakeService.new(:some_result),
+      prefix: nil,
+      prefix_with_repo: false,
+    )
+
+    expect(formatter.format_test).to eq("This is a test")
+  end
+end

data/spec/cc/service/gitlab_merge_requests_spec.rb

@@ -116,13 +116,13 @@ describe CC::Service::GitlabMergeRequests, type: :service do
   end
 
   it "merge request status test success" do
-    http_stubs.post("api/v3/projects/hal%2Fhal9000/statuses/#{"0" * 40}") { |_env| [404, {}, ""] }
+    http_stubs.post("api/v4/projects/hal%2Fhal9000/statuses/#{"0" * 40}") { |_env| [404, {}, ""] }
 
     expect(receive_test({}, git_url: "ssh://git@gitlab.com/hal/hal9000.git")[:ok]).to eq(true)
   end
 
   it "merge request status test failure" do
-    http_stubs.post("api/v3/projects/hal%2Fhal9000/statuses/#{"0" * 40}") { |_env| [401, {}, ""] }
+    http_stubs.post("api/v4/projects/hal%2Fhal9000/statuses/#{"0" * 40}") { |_env| [401, {}, ""] }
 
     expect { receive_test({}, git_url: "ssh://git@gitlab.com/hal/hal9000.git") }.to raise_error(CC::Service::HTTPError)
   end
@@ -134,8 +134,8 @@ describe CC::Service::GitlabMergeRequests, type: :service do
   end
 
   it "different base url" do
-    http_stubs.post("api/v3/projects/hal%2Fhal9000/statuses/#{"0" * 40}") do |env|
-      expect(env[:url].to_s).to eq("https://gitlab.hal.org/api/v3/projects/hal%2Fhal9000/statuses/#{"0" * 40}")
+    http_stubs.post("api/v4/projects/hal%2Fhal9000/statuses/#{"0" * 40}") do |env|
+      expect(env[:url].to_s).to eq("https://gitlab.hal.org/api/v4/projects/hal%2Fhal9000/statuses/#{"0" * 40}")
       [404, {}, ""]
     end
 
@@ -145,8 +145,8 @@ describe CC::Service::GitlabMergeRequests, type: :service do
   private
 
   def expect_status_update(repo, commit_sha, params)
-    http_stubs.post "api/v3/projects/#{CGI.escape(repo)}/statuses/#{commit_sha}" do |env|
-      expect(env[:request_headers]["PRIVATE-TOKEN"]).to eq("123")
+    http_stubs.post "api/v4/projects/#{CGI.escape(repo)}/statuses/#{commit_sha}" do |env|
+      expect(env[:request_headers]["Private-Token"]).to eq("123")
 
       body = JSON.parse(env[:body])
 

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: codeclimate-services
 version: !ruby/object:Gem::Version
-  version: 1.10.1
+  version: 1.11.2
 platform: ruby
 authors:
 - Bryan Helmkamp
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2017-11-03 00:00:00.000000000 Z
+date: 2022-06-10 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: faraday
@@ -129,6 +129,7 @@ executables: []
 extensions: []
 extra_rdoc_files: []
 files:
+- ".circleci/config.yml"
 - ".codeclimate.yml"
 - ".gitignore"
 - ".rspec"
@@ -144,7 +145,6 @@ files:
 - bin/nokogiri
 - bin/pry
 - bin/rake
-- circle.yml
 - codeclimate-services.gemspec
 - config/cacert.pem
 - config/load.rb
@@ -198,6 +198,7 @@ files:
 - spec/cc/service/asana_spec.rb
 - spec/cc/service/campfire_spec.rb
 - spec/cc/service/flowdock_spec.rb
+- spec/cc/service/formatter_spec.rb
 - spec/cc/service/github_issues_spec.rb
 - spec/cc/service/github_pull_requests_spec.rb
 - spec/cc/service/gitlab_merge_requests_spec.rb
@@ -218,7 +219,7 @@ files:
 - spec/support/fake_logger.rb
 - spec/support/resolv_helpers.rb
 - spec/support/service_context.rb
-homepage: ''
+homepage: https://codeclimate.com/
 licenses:
 - MIT
 metadata: {}
@@ -237,8 +238,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
-rubyforge_project: 
-rubygems_version: 2.4.5
+rubygems_version: 3.3.7
 signing_key: 
 specification_version: 4
 summary: Service classes for Code Climate
@@ -251,6 +251,7 @@ test_files:
 - spec/cc/service/asana_spec.rb
 - spec/cc/service/campfire_spec.rb
 - spec/cc/service/flowdock_spec.rb
+- spec/cc/service/formatter_spec.rb
 - spec/cc/service/github_issues_spec.rb
 - spec/cc/service/github_pull_requests_spec.rb
 - spec/cc/service/gitlab_merge_requests_spec.rb

data/circle.yml

@@ -1,3 +0,0 @@
-test:
-  override:
-    - bundle exec rake && bundle exec codeclimate-test-reporter