codeclimate-poseidon 0.0.11 → 0.0.12

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 577a257d21ed35cf7b09178cb0a5a81ecc6db334
-  data.tar.gz: 5d0544002eeb23d1d167b87973916245921c4616
+  metadata.gz: aa02e321bdedaf1f2ab107fa19baa839f8b8975e
+  data.tar.gz: 6be2d71921b325c65013edaa05f4be605f67bf61
 SHA512:
-  metadata.gz: 89825b99bc8aee674c6eea0933708b9e0b4f0ac723b27e9e3a9af664afd7a502b2cae228f5930ce88049d2ad1f9e69e06cd94f494f7fd328a747416b73b04f67
-  data.tar.gz: 3b25ee0806f6fb045d2207f6d208a5d5c6fee05c16b603a0d3b65d609b66bb66ef642e57878b23bc080647909154e4668e38fd2cc8dd2a1056e2514efde03ba4
+  metadata.gz: 343ba22d428d48fb50daecf1ba728be6add2918a0ae7c5fc6df477efb61de63e8f8c2d23d67d95a9aec7e1e65ee0646871ad532f274b74943d8a3c0f032b9e9c
+  data.tar.gz: e75c0e4afff8b28bd50a0ed331727c7f3d432907257616f9cab8ec95b802c5520dbeb80c3159ea6a99b4be54671a71944d930242e39442d7a0f50193e37fb6b4

data/lib/poseidon.rb

@@ -62,6 +62,9 @@ module Poseidon
       10 => MessageSizeTooLarge
     }
 
+    # Raised when messages were not successfully produced to Kafka
+    class MessageDeliveryError < StandardError; end
+
     # Raised when a custom partitioner tries to send
     # a message to a partition that doesn't exist.
     class InvalidPartitionError < StandardError; end

data/lib/poseidon/connection.rb

@@ -11,6 +11,14 @@ module Poseidon
     API_VERSION = 0
     REPLICA_ID = -1 # Replica id is always -1 for non-brokers
 
+    REQUEST_CONNECTION_ERRORS = [
+      Errno::ECONNRESET,
+      Errno::EHOSTUNREACH,
+      Errno::EPIPE,
+      Errno::ETIMEDOUT,
+      TimeoutException,
+    ].freeze
+
     # @yieldparam [Connection]
     def self.open(host, port, client_id, socket_timeout_ms, &block)
       connection = new(host, port, client_id, socket_timeout_ms)
@@ -135,7 +143,7 @@ module Poseidon
       buffer = Protocol::RequestBuffer.new
       request.write(buffer)
       ensure_write_or_timeout([buffer.to_s.bytesize].pack("N") + buffer.to_s)
-    rescue Errno::EPIPE, Errno::ECONNRESET, Errno::ETIMEDOUT, TimeoutException => ex
+    rescue *REQUEST_CONNECTION_ERRORS => ex
       @socket = nil
       raise_connection_failed_from_exception(ex)
     end

data/lib/poseidon/sync_producer.rb

@@ -65,7 +65,7 @@ module Poseidon
       end
 
       if messages_to_send.pending_messages?
-        raise "Failed to send all messages: #{messages_to_send.messages} remaining"
+        raise Errors::MessageDeliveryError, "Failed to send all messages: #{messages_to_send.messages} remaining"
       else
         true
       end

data/lib/poseidon/version.rb

@@ -1,4 +1,4 @@
 module Poseidon
   # Unstable! API May Change!
-  VERSION = "0.0.11"
+  VERSION = "0.0.12"
 end

data/spec/unit/producer_spec.rb

@@ -2,7 +2,7 @@ require 'spec_helper'
 
 RSpec.describe Producer do
   it "requires brokers and client_id" do
-    expect { Producer.new }.to raise_error
+    expect { Producer.new }.to raise_error(ArgumentError)
   end
 
   it "raises ArgumentError on unknown arguments" do

data/spec/unit/protocol_spec.rb

@@ -49,6 +49,6 @@ RSpec.describe "objects with errors" do
                                                   [partition_fetch_response])
     response = FetchResponse.new(double('common'), [topic_fetch_response])
 
-    expect { response.raise_error_if_one_exists }.to raise_error
+    expect { response.raise_error_if_one_exists }.to raise_error(Poseidon::Errors::LeaderNotAvailable)
   end
 end

data/spec/unit/sync_producer_spec.rb

@@ -95,7 +95,7 @@ RSpec.describe SyncProducer do
       it "raises an exception" do
         expect {
           @sp.send_messages([Message.new(:topic => "topic", :value => "value")])
-        }.to raise_error
+        }.to raise_error(Poseidon::Errors::MessageDeliveryError)
       end
     end
 

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: codeclimate-poseidon
 version: !ruby/object:Gem::Version
-  version: 0.0.11
+  version: 0.0.12
 platform: ruby
 authors:
 - Bob Potter