codebase_index 0.2.1 → 0.3.1

data/lib/codebase_index/extractors/mailer_extractor.rb

@@ -71,13 +71,18 @@ module CodebaseIndex
 
       private
 
+      # Locate the source file for a mailer class.
+      #
+      # Convention path first, then introspection via {#resolve_source_location}
+      # which filters out vendor/node_modules paths.
+      #
+      # @param mailer [Class]
+      # @return [String]
       def source_file_for(mailer)
-        if mailer.instance_methods(false).any?
-          method = mailer.instance_methods(false).first
-          mailer.instance_method(method).source_location&.first
-        end || Rails.root.join("app/mailers/#{mailer.name.underscore}.rb").to_s
-      rescue StandardError
-        Rails.root.join("app/mailers/#{mailer.name.underscore}.rb").to_s
+        convention_path = Rails.root.join("app/mailers/#{mailer.name.underscore}.rb").to_s
+        return convention_path if File.exist?(convention_path)
+
+        resolve_source_location(mailer, app_root: Rails.root.to_s, fallback: convention_path)
       end
 
       # ──────────────────────────────────────────────────────────────────────
@@ -139,19 +144,10 @@ module CodebaseIndex
       end
 
       def extract_defaults(mailer)
-        defaults = {}
-
-        begin
-          mailer_defaults = mailer.default
-          defaults[:from] = mailer_defaults[:from] if mailer_defaults[:from]
-          defaults[:reply_to] = mailer_defaults[:reply_to] if mailer_defaults[:reply_to]
-          defaults[:cc] = mailer_defaults[:cc] if mailer_defaults[:cc]
-          defaults[:bcc] = mailer_defaults[:bcc] if mailer_defaults[:bcc]
-        rescue StandardError
-          # Defaults not accessible
-        end
-
-        defaults
+        mailer_defaults = mailer.default
+        mailer_defaults.slice(:from, :reply_to, :cc, :bcc).compact
+      rescue StandardError
+        {}
       end
 
       def extract_callbacks(mailer)
@@ -172,72 +168,6 @@ module CodebaseIndex
         []
       end
 
-      # Extract :only/:except action lists and :if/:unless conditions from a callback.
-      #
-      # Modern Rails (4.2+) stores conditions in @if/@unless ivar arrays.
-      # ActionFilter objects hold action Sets; other conditions are procs/symbols.
-      #
-      # @param callback [ActiveSupport::Callbacks::Callback]
-      # @return [Array(Array<String>, Array<String>, Array<String>, Array<String>)]
-      #   [only_actions, except_actions, if_labels, unless_labels]
-      def extract_callback_conditions(callback)
-        if_conditions = callback.instance_variable_get(:@if) || []
-        unless_conditions = callback.instance_variable_get(:@unless) || []
-
-        only = []
-        except = []
-        if_labels = []
-        unless_labels = []
-
-        if_conditions.each do |cond|
-          actions = extract_action_filter_actions(cond)
-          if actions
-            only.concat(actions)
-          else
-            if_labels << condition_label(cond)
-          end
-        end
-
-        unless_conditions.each do |cond|
-          actions = extract_action_filter_actions(cond)
-          if actions
-            except.concat(actions)
-          else
-            unless_labels << condition_label(cond)
-          end
-        end
-
-        [only, except, if_labels, unless_labels]
-      end
-
-      # Extract action names from an ActionFilter-like condition object.
-      # Duck-types on the @actions ivar being a Set, avoiding dependence
-      # on private class names across Rails versions.
-      #
-      # @param condition [Object] A condition from the callback's @if/@unless array
-      # @return [Array<String>, nil] Action names, or nil if not an ActionFilter
-      def extract_action_filter_actions(condition)
-        return nil unless condition.instance_variable_defined?(:@actions)
-
-        actions = condition.instance_variable_get(:@actions)
-        return nil unless actions.is_a?(Set)
-
-        actions.to_a
-      end
-
-      # Human-readable label for a non-ActionFilter condition.
-      #
-      # @param condition [Object] A proc, symbol, or other condition
-      # @return [String]
-      def condition_label(condition)
-        case condition
-        when Symbol then ":#{condition}"
-        when Proc then 'Proc'
-        when String then condition
-        else condition.class.name
-        end
-      end
-
       def extract_layout(mailer, source)
         # From class definition
         return ::Regexp.last_match(1) if source =~ /layout\s+['":](\w+)/

data/lib/codebase_index/extractors/manager_extractor.rb

@@ -53,7 +53,7 @@ module CodebaseIndex
       # @return [ExtractedUnit, nil] The extracted unit or nil if not a manager
       def extract_manager_file(file_path)
         source = File.read(file_path)
-        class_name = extract_class_name(file_path, source)
+        class_name = extract_class_name(file_path, source, 'managers')
 
         return nil unless class_name
         return nil unless manager_file?(source)
@@ -81,16 +81,6 @@ module CodebaseIndex
       # Class Discovery
       # ──────────────────────────────────────────────────────────────────────
 
-      def extract_class_name(file_path, source)
-        return ::Regexp.last_match(1) if source =~ /^\s*class\s+([\w:]+)/
-
-        file_path
-          .sub("#{Rails.root}/", '')
-          .sub(%r{^app/managers/}, '')
-          .sub('.rb', '')
-          .camelize
-      end
-
       def manager_file?(source)
         source.match?(/< SimpleDelegator/) ||
           source.match?(/< DelegateClass\(/) ||
@@ -178,10 +168,6 @@ module CodebaseIndex
         source.scan(/def\s+(\w+[?!=]?).*?\n.*?super/m).flatten
       end
 
-      def extract_custom_errors(source)
-        source.scan(/class\s+(\w+(?:Error|Exception))\s*</).flatten
-      end
-
       # ──────────────────────────────────────────────────────────────────────
       # Dependency Extraction
       # ──────────────────────────────────────────────────────────────────────

data/lib/codebase_index/extractors/model_extractor.rb

@@ -2,6 +2,7 @@
 
 require 'digest'
 require_relative '../ast/parser'
+require_relative 'shared_utility_methods'
 require_relative 'shared_dependency_scanner'
 require_relative 'callback_analyzer'
 
@@ -23,15 +24,17 @@ module CodebaseIndex
     #   user_unit = units.find { |u| u.identifier == "User" }
     #
     class ModelExtractor
+      include SharedUtilityMethods
       include SharedDependencyScanner
 
-      AR_INTERNAL_METHOD_PATTERNS = [
-        /\A_/,                                    # _run_save_callbacks, _validators, etc.
-        /\Aautosave_associated_records_for_/,     # autosave_associated_records_for_comments
-        /\Avalidate_associated_records_for_/,     # validate_associated_records_for_comments
-        /\Aafter_(?:add|remove)_for_/,            # collection callbacks
-        /\Abefore_(?:add|remove)_for_/            # collection callbacks
-      ].freeze
+      # Single combined regex for filtering AR-generated internal methods.
+      # Replaces 5 separate patterns with one alternation for O(1) matching.
+      AR_INTERNAL_METHOD_PATTERN = /\A(?:
+        _                                         | # _run_save_callbacks, _validators, etc.
+        autosave_associated_records_for_           | # autosave_associated_records_for_comments
+        validate_associated_records_for_           | # validate_associated_records_for_comments
+        (?:after|before)_(?:add|remove)_for_         # collection callbacks
+      )/x
 
       def initialize
         @concern_cache = {}
@@ -84,38 +87,14 @@ module CodebaseIndex
 
       # Find the source file for a model, handling STI and namespacing.
       #
-      # Falls back to convention-based path when reflection points outside
-      # the app (e.g., ActiveRecord::Core#initialize for models that don't
-      # override initialize).
+      # Uses convention path first (most reliable for models), then falls
+      # back to introspection via {#resolve_source_location} which filters
+      # out vendor/node_modules paths.
       def source_file_for(model)
-        app_root = Rails.root.to_s
         convention_path = Rails.root.join("app/models/#{model.name.underscore}.rb").to_s
-
-        # Tier 1: Instance methods defined directly on this model
-        model.instance_methods(false).each do |method_name|
-          loc = model.instance_method(method_name).source_location&.first
-          return loc if loc&.start_with?(app_root)
-        end
-
-        # Tier 2: Class/singleton methods (catches models with only scopes)
-        model.methods(false).each do |method_name|
-          loc = model.method(method_name).source_location&.first
-          return loc if loc&.start_with?(app_root)
-        end
-
-        # Tier 3: Convention path if file exists
         return convention_path if File.exist?(convention_path)
 
-        # Tier 4: const_source_location (Ruby 3.0+)
-        if Object.respond_to?(:const_source_location)
-          loc = Object.const_source_location(model.name)&.first
-          return loc if loc&.start_with?(app_root)
-        end
-
-        # Tier 5: Always return convention path — never a gem path
-        convention_path
-      rescue StandardError
-        convention_path
+        resolve_source_location(model, app_root: Rails.root.to_s, fallback: convention_path)
       end
 
       # Detect Rails-generated HABTM join models (e.g., Product::HABTM_Categories)
@@ -241,7 +220,7 @@ module CodebaseIndex
           # Skip obvious non-app modules (from gems/stdlib)
           if Object.respond_to?(:const_source_location)
             loc = Object.const_source_location(mod.name)
-            next false if loc && !loc.first&.start_with?(app_root)
+            next false if loc && !app_source?(loc.first, app_root)
           end
 
           # Include if it's in app/models/concerns or app/controllers/concerns
@@ -258,16 +237,18 @@ module CodebaseIndex
       # @param mod [Module] The module to check
       # @return [Boolean] true if the module is defined within Rails.root
       def defined_in_app?(mod)
+        app_root = Rails.root.to_s
+
         # Fast path: const_source_location is cheaper than iterating methods
         if mod.respond_to?(:const_source_location) || Object.respond_to?(:const_source_location)
           loc = Object.const_source_location(mod.name)
-          return loc.first.start_with?(Rails.root.to_s) if loc
+          return app_source?(loc.first, app_root) if loc
         end
 
         # Slow path: check instance method source locations
         mod.instance_methods(false).any? do |method|
           loc = mod.instance_method(method).source_location&.first
-          loc&.start_with?(Rails.root.to_s)
+          app_source?(loc, app_root)
         end
       rescue StandardError
         false
@@ -836,19 +817,6 @@ module CodebaseIndex
       # Condition & Filter Helpers
       # ──────────────────────────────────────────────────────────────────────
 
-      # Human-readable label for a condition (Symbol, Proc, String, etc.)
-      #
-      # @param condition [Object] A proc, symbol, or other condition
-      # @return [String]
-      def condition_label(condition)
-        case condition
-        when Symbol then ":#{condition}"
-        when Proc then 'Proc'
-        when String then condition
-        else condition.class.name
-        end
-      end
-
       # Build conditions hash from validator options, converting Procs to labels
       #
       # @param validator [ActiveModel::Validator]
@@ -906,8 +874,7 @@ module CodebaseIndex
       # @return [Array<Symbol>]
       def filter_instance_methods(methods)
         methods.reject do |method_name|
-          name = method_name.to_s
-          AR_INTERNAL_METHOD_PATTERNS.any? { |pattern| pattern.match?(name) }
+          AR_INTERNAL_METHOD_PATTERN.match?(method_name.to_s)
         end
       end
 

data/lib/codebase_index/extractors/phlex_extractor.rb

@@ -96,8 +96,14 @@ module CodebaseIndex
         defined?(ViewComponent::Base) && klass < ViewComponent::Base
       end
 
+      # Locate the source file for a Phlex component class.
+      #
+      # Convention paths first, then introspection via {#resolve_source_location}
+      # which filters out vendor/node_modules paths.
+      #
+      # @param component [Class]
+      # @return [String, nil]
       def source_file_for(component)
-        # Try common locations
         possible_paths = [
           Rails.root.join("app/views/components/#{component.name.underscore}.rb"),
           Rails.root.join("app/components/#{component.name.underscore}.rb"),
@@ -107,13 +113,7 @@ module CodebaseIndex
         found = possible_paths.find { |p| File.exist?(p) }
         return found.to_s if found
 
-        # Try to get from method source location
-        if component.instance_methods(false).any?
-          method = component.instance_methods(false).first
-          component.instance_method(method).source_location&.first
-        end
-      rescue StandardError
-        nil
+        resolve_source_location(component, app_root: Rails.root.to_s, fallback: nil)
       end
 
       def read_source(file_path)

data/lib/codebase_index/extractors/policy_extractor.rb

@@ -56,7 +56,7 @@ module CodebaseIndex
       # @return [ExtractedUnit, nil] The extracted unit or nil if not a policy
       def extract_policy_file(file_path)
         source = File.read(file_path)
-        class_name = extract_class_name(file_path, source)
+        class_name = extract_class_name(file_path, source, 'policies')
 
         return nil unless class_name
         return nil if skip_file?(source)
@@ -80,25 +80,6 @@ module CodebaseIndex
 
       private
 
-      # ──────────────────────────────────────────────────────────────────────
-      # Class Discovery
-      # ──────────────────────────────────────────────────────────────────────
-
-      def extract_class_name(file_path, source)
-        return ::Regexp.last_match(1) if source =~ /^\s*class\s+([\w:]+)/
-
-        file_path
-          .sub("#{Rails.root}/", '')
-          .sub(%r{^app/policies/}, '')
-          .sub('.rb', '')
-          .camelize
-      end
-
-      def skip_file?(source)
-        # Skip module-only files (concerns, base modules)
-        source.match?(/^\s*module\s+\w+\s*$/) && !source.match?(/^\s*class\s+/)
-      end
-
       # ──────────────────────────────────────────────────────────────────────
       # Source Annotation
       # ──────────────────────────────────────────────────────────────────────
@@ -189,10 +170,6 @@ module CodebaseIndex
           source.match?(/attr_reader\s+:user\s*,\s*:record/)
       end
 
-      def extract_custom_errors(source)
-        source.scan(/class\s+(\w+(?:Error|Exception))\s*</).flatten
-      end
-
       # ──────────────────────────────────────────────────────────────────────
       # Dependency Extraction
       # ──────────────────────────────────────────────────────────────────────

data/lib/codebase_index/extractors/poro_extractor.rb

@@ -212,23 +212,6 @@ module CodebaseIndex
         }
       end
 
-      # Extract the parent class name from a class definition.
-      #
-      # @param source [String] Ruby source code
-      # @return [String, nil] Parent class name or nil
-      def extract_parent_class(source)
-        match = source.match(/^\s*class\s+[\w:]+\s*<\s*([\w:]+)/)
-        match ? match[1] : nil
-      end
-
-      # Count non-blank, non-comment lines of code.
-      #
-      # @param source [String] Ruby source code
-      # @return [Integer] LOC count
-      def count_loc(source)
-        source.lines.count { |l| l.strip.length.positive? && !l.strip.start_with?('#') }
-      end
-
       # ──────────────────────────────────────────────────────────────────────
       # Dependency Extraction
       # ──────────────────────────────────────────────────────────────────────

data/lib/codebase_index/extractors/serializer_extractor.rb

@@ -171,13 +171,18 @@ module CodebaseIndex
           source.match?(/view\s+:/) # Blueprinter views
       end
 
+      # Locate the source file for a serializer class.
+      #
+      # Convention path first, then introspection via {#resolve_source_location}
+      # which filters out vendor/node_modules paths.
+      #
+      # @param klass [Class]
+      # @return [String, nil]
       def source_file_for(klass)
-        methods = klass.instance_methods(false)
-        if methods.any?
-          klass.instance_method(methods.first).source_location&.first
-        end || Rails.root.join("app/serializers/#{klass.name.underscore}.rb").to_s
-      rescue StandardError
-        nil
+        convention_path = Rails.root.join("app/serializers/#{klass.name.underscore}.rb").to_s
+        return convention_path if File.exist?(convention_path)
+
+        resolve_source_location(klass, app_root: Rails.root.to_s, fallback: convention_path)
       end
 
       # ──────────────────────────────────────────────────────────────────────
@@ -309,7 +314,7 @@ module CodebaseIndex
 
       def extract_views(source)
         # Blueprinter views: `view :extended do`
-        source.scan(/view\s+:(\w+)/).flatten.map { |v| v }
+        source.scan(/view\s+:(\w+)/).flatten
       end
 
       # ──────────────────────────────────────────────────────────────────────

data/lib/codebase_index/extractors/service_extractor.rb

@@ -57,7 +57,7 @@ module CodebaseIndex
       # @return [ExtractedUnit, nil] The extracted unit or nil if not a service
       def extract_service_file(file_path)
         source = File.read(file_path)
-        class_name = extract_class_name(file_path, source)
+        class_name = extract_class_name(file_path, source, '(?:services|interactors|operations|commands|use_cases)')
 
         return nil unless class_name
         return nil if skip_file?(source)
@@ -81,29 +81,6 @@ module CodebaseIndex
 
       private
 
-      # ──────────────────────────────────────────────────────────────────────
-      # Class Discovery
-      # ──────────────────────────────────────────────────────────────────────
-
-      def extract_class_name(file_path, source)
-        # Try to extract from source first (handles nested modules)
-        return ::Regexp.last_match(1) if source =~ /^\s*class\s+([\w:]+)/
-
-        # Fall back to convention
-        relative_path = file_path.sub("#{Rails.root}/", '')
-
-        # app/services/payments/stripe_service.rb -> Payments::StripeService
-        relative_path
-          .sub(%r{^app/(services|interactors|operations|commands|use_cases)/}, '')
-          .sub('.rb', '')
-          .camelize
-      end
-
-      def skip_file?(source)
-        # Skip module-only files (concerns, base modules)
-        source.match?(/^\s*module\s+\w+\s*$/) && !source.match?(/^\s*class\s+/)
-      end
-
       # ──────────────────────────────────────────────────────────────────────
       # Source Annotation
       # ──────────────────────────────────────────────────────────────────────
@@ -123,16 +100,6 @@ module CodebaseIndex
         annotation + source
       end
 
-      def detect_entry_points(source)
-        points = []
-        points << 'call' if source.match?(/def (self\.)?call\b/)
-        points << 'perform' if source.match?(/def (self\.)?perform\b/)
-        points << 'execute' if source.match?(/def (self\.)?execute\b/)
-        points << 'run' if source.match?(/def (self\.)?run\b/)
-        points << 'process' if source.match?(/def (self\.)?process\b/)
-        points.empty? ? ['unknown'] : points
-      end
-
       # ──────────────────────────────────────────────────────────────────────
       # Metadata Extraction
       # ──────────────────────────────────────────────────────────────────────
@@ -188,10 +155,6 @@ module CodebaseIndex
         deps.uniq
       end
 
-      def extract_custom_errors(source)
-        source.scan(/class\s+(\w+(?:Error|Exception))\s*</).flatten
-      end
-
       def extract_rescue_handlers(source)
         source.scan(/rescue\s+([\w:]+)/).flatten.uniq
       end