code_terminator 0.4.5 → 0.4.6

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 7509514e388e2c045e061ccafa776714aa166cc2
-  data.tar.gz: 9391400890dd1499985ea3161dcd9f43df69d79c
+  metadata.gz: d023b54f3d9e4807758e10c9d8c9c1ad512d1feb
+  data.tar.gz: 81cc874ddd8da35b5ca80ac60cb6c8ad811ef544
 SHA512:
-  metadata.gz: 6729e406cb5949dd4a47c662ed2851daa5a2b1ed4a5b44fef8208022331d1914bb5d44841f36823d340195df391c6a5f22491cae0fb905a80a164506e262770a
-  data.tar.gz: 31d71cfb8a70982460db6cdeecee7cfcd28ec06420d048e1fb0979865d8aacf788431fcb506c7107aaf8769dc6f31f8eba4a8eda8d13c894b63875beba22817e
+  metadata.gz: c75b3ff7b196f630bd6fa95f83bc1b7f480e4c34f932747c744a4729dd979003d9cecf49d05a306dc187b13f04f056420b70b529d0b3c7affda954e94440382a
+  data.tar.gz: c94d216cd485c7f5f5e09e471aeb78f4c6f8a104c9bf2badb39f2bb04ac70b6185b6641783576d9ef3252984e1c4e96d15c56dff8b4727f8ac289f69352bc71c

data/lib/code_terminator/html.rb

@@ -253,7 +253,12 @@ class CodeTerminator::Html
 
      elements = get_elements(source)
 
+     exist_in_body = Array.new
+
+     error333 = nil
+     
      elements.each do |e|
+
        item = e[:tag]
 
        if item=="text"
@@ -280,27 +285,36 @@ class CodeTerminator::Html
         end
 
        else
+
        if code.css(e[:tag]).length > 0
 
+        code.css(e[:tag]).each do |tag|
+
          if !e[:attribute].nil?
           #  Check the tag's attributes
-           if code.css(e[:tag]).attribute(e[:attribute]).nil?
+           if tag.attribute(e[:attribute]).nil?
              html_errors << new_error(element: e, type: 334, description: "#{e[:tag]} should have an attribute named #{e[:attribute]}.")
            else
-             if code.css(e[:tag]).attribute(e[:attribute]).value != e[:value]
-               html_errors << new_error(element: e, type: 333, description: "Make sure that the attribute #{e[:attribute]} in #{e[:tag]} has the value #{e[:value]}.")
+             if tag.attribute(e[:attribute]).value != e[:value]
+                 exist_in_body << false
+                 error333 = new_error(element: e, type: 333, description: "Make sure that the attribute #{e[:attribute]} in #{e[:tag]} has the value #{e[:value]}.")
+             else
+               exist_in_body << true
              end
+
            end
          end
 
         #  Check that tags exist within parent tags
-         if code.css(e[:tag]).count < 2
-           if code.css(e[:tag]).first.parent.name != e[:parent]
+        if tag.first.respond_to? :parent
+
+         if tag.count < 2 && !tag.first.nil?
+           if tag.first.parent.name != e[:parent]
              html_errors << new_error(element: e, type: 440, description: "Remember to add the #{e[:tag]} tag inside #{e[:parent]}.")
            end
          else
-           exist_in_parent = false
-           code.css(e[:tag]).each do |code_css|
+          exist_in_parent = false
+           tag.each do |code_css|
               if code_css.parent.name == e[:parent]
                 exist_in_parent = true
               end
@@ -309,6 +323,8 @@ class CodeTerminator::Html
               html_errors << new_error(element: e, type: 440, description: "Remember to add the #{e[:tag]} tag inside #{e[:parent]}.")
             end
          end
+        end
+        end
 
        else
          #  Check that the tag is present
@@ -317,7 +333,13 @@ class CodeTerminator::Html
           end
        end
 
+       if !exist_in_body.empty? && !exist_in_body.include?(true) && !error333.nil?
+         html_errors << error333
+       end
+       exist_in_body = []
+
       end
+
      end
 
      html_errors

data/lib/code_terminator/version.rb

@@ -1,3 +1,3 @@
 module CodeTerminator
-  VERSION = "0.4.5"
+  VERSION = "0.4.6"
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: code_terminator
 version: !ruby/object:Gem::Version
-  version: 0.4.5
+  version: 0.4.6
 platform: ruby
 authors:
 - Evelin Ponce
 autorequire: 
 bindir: exe
 cert_chain: []
-date: 2016-09-30 00:00:00.000000000 Z
+date: 2016-10-03 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: bundler