code_review_notifier 0.2.3 → 0.3.3

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 5760e7d91fa308531d0ab4c0da163525a0b4cf2ed169822c01ad5fedd5c6e28a
-  data.tar.gz: 86a8c7f51968a37bca25eaa0406a6c3b7af9f33cf9702b4c03a349ba4f0cc577
+  metadata.gz: b1bbcb72b72b62c41bc0280a106b0586cf1a38c73fd03e3ecbb3d7116bb92e99
+  data.tar.gz: 3ec69fa1b947963d2785dc105b9aab845376e930359f9798fae20cff4933fe9d
 SHA512:
-  metadata.gz: b0f8c25880aa149870bc5c39e13d081b35d9f95b5fcb3efea47ed272b2e7acadb860c7283d3efa9b29ec114b552ae92f9910bedaf5b57c003af0017cdb2fb3b1
-  data.tar.gz: b0ed3ddba99bff4fe392847c7f8a5430f68fde44e32f02fdcbfb8deb35edc24526691b3150dc8b4102896667ebf56aa530c7b0647844025522050fba4156f7c1
+  metadata.gz: b84e5254f5d8a6b337de340bca53df13ecc29c5e06cc742815304cd5e07610c2f15708ffe89762b98e6c6a590bae89ef72385ff3c8a323d8268eaa371050cb6e
+  data.tar.gz: 285ec4d1709e9eec4dd27428fc00d20b81b88cccde1c5f52071a002ee071f356a8c9860a87f44be9cf117d827b1c557515398cdfecb63ef1b69b4eb4d4581131

data/Gemfile

@@ -2,4 +2,4 @@ source "https://rubygems.org"
 
 gemspec
 
-gem "rubiclifier", "1.0.0"
+gem "rubiclifier", "2.0.1"

data/bin/code_review_notifier

@@ -1,5 +1,5 @@
 #!/usr/bin/env ruby
 
-require "code_review_notifier"
+require_relative "../lib/code_review_notifier.rb"
 
-CodeReviewNotifier.new(ARGV).call
+CodeReviewNotifier.new(ARGV, __FILE__.split("/").last).call

data/lib/code_review_notifier.rb

@@ -20,24 +20,24 @@ class CodeReviewNotifier < Rubiclifier::BaseApplication
 
   def run_application
     while true
-      is_first_run = is_first_run?
-      puts
-      puts("Querying API...")
-      all_code_changes = Api.current_api.all_code_changes
-      puts("Checking for notifications to display...")
-      all_activity = []
-      all_code_changes.each do |cc|
-        activity_for_code_change = cc.code_change_activity
-        activity_for_code_change.sort! { |a, b| a.created_at <=> b.created_at }
-        cc.activity_from_self_at = activity_for_code_change.find { |a| a.is_self }&.created_at
-        all_activity.concat(activity_for_code_change)
-      end
-      all_activity.select(&:should_notify?).each do |code_change_activity|
-        code_change_activity.notified
-        unless is_first_run
-          puts("Notifying of change!")
-          CodeChangeNotification.new(code_change_activity).send
-          sleep(SECONDS_BETWEEN_NOTIFICATIONS)
+      unless Rubiclifier::IdleDetector.is_idle?
+        is_first_run = is_first_run?
+        puts
+        puts("Querying API...")
+        all_code_changes = Api.current_api.all_code_changes
+        puts("Checking for notifications to display...")
+        all_activity = []
+        all_code_changes.each do |cc|
+          cc.code_change_activity.sort! { |a, b| a.created_at <=> b.created_at }
+          all_activity.concat(cc.code_change_activity)
+        end
+        all_activity.select(&:should_notify?).each do |code_change_activity|
+          code_change_activity.notified
+          unless is_first_run
+            puts("Notifying of change!")
+            CodeChangeNotification.new(code_change_activity).send
+            sleep(SECONDS_BETWEEN_NOTIFICATIONS)
+          end
         end
       end
       sleep(SECONDS_BETWEEN_RUNS)
@@ -55,6 +55,7 @@ class CodeReviewNotifier < Rubiclifier::BaseApplication
     [
       Rubiclifier::Feature::BACKGROUND,
       Rubiclifier::Feature::DATABASE,
+      Rubiclifier::Feature::IDLE_DETECTION,
       Rubiclifier::Feature::NOTIFICATIONS
     ]
   end
@@ -68,10 +69,6 @@ class CodeReviewNotifier < Rubiclifier::BaseApplication
     ]
   end
 
-  def executable_name
-    "code_review_notifier"
-  end
-
   def data_directory
     "~/.code_review_notifier"
   end

data/lib/models/code_change.rb

@@ -3,7 +3,6 @@ require "date"
 class CodeChange
   attr_accessor :code_change_activity
   attr_reader :id, :owner, :project, :subject, :updated_at
-  attr_writer :activity_from_self_at
 
   def initialize(id, owner, project, subject, updated_at)
     @id = id
@@ -14,7 +13,6 @@ class CodeChange
   end
 
   def activity_from_self_at
-    raise "@activity_from_self_at is not set" unless instance_variable_defined?("@activity_from_self_at")
-    @activity_from_self_at
+    @activity_from_self_at ||= code_change_activity.find { |a| a.is_self }&.created_at
   end
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: code_review_notifier
 version: !ruby/object:Gem::Version
-  version: 0.2.3
+  version: 0.3.3
 platform: ruby
 authors:
 - Kyle Grinstead
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2020-07-09 00:00:00.000000000 Z
+date: 2020-07-10 00:00:00.000000000 Z
 dependencies: []
 description: 
 email: kyleag@hey.com