code_review_notifier 0.2.2 → 0.3.2

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 790df27d9acb825ba25b7d709407a665325c197e9ee8033569d5f86e72e0f6a0
-  data.tar.gz: 3dd80bdd477b6f251d40d45bbaf56d574584d194d7b858ddd255fe7327443f9c
+  metadata.gz: 79c56b74f5987e4f35b4fb6c69fe307bcf64509feb0568d656ae4eae03b00239
+  data.tar.gz: b722ba34c4f8f48a060df09a33630219b9660395d4b34dadd5a53dee602870d9
 SHA512:
-  metadata.gz: 557585a22db594cb9f12c20e3ef98898a0e81bb7ba606648f0ea526f3140d8a920652b30816a7614d13dbd6d640aefb837c57ece0df6096b87b35ce5a21f0a74
-  data.tar.gz: 89c9687da7c0b4947b6589b65e5766f0c3bb4cf0ff3767bd3f23ae468dd96656219b515f9705ed09e97fa2e6a8316af8b7418a254867b5e385df28e887465d60
+  metadata.gz: 51023ef8da1ba13111274e44cc2621d7943de7a8f6e5bf87954c94de1ea8575dc2ef3954567c8eabcda8f1cbccad0883d3517e993fdc507081821c7876753776
+  data.tar.gz: 5f7d6cb2a7b57c54068e1f4788a3c082b0ba87720473123cdea47ba13a7b722fe5b9a56e917e64e24f9fe1cdde092ea65c7a61dbd78e8b0c4906c227b934ffba

data/Gemfile

@@ -2,4 +2,4 @@ source "https://rubygems.org"
 
 gemspec
 
-gem "rubiclifier"
+gem "rubiclifier", "2.0.0"

data/bin/code_review_notifier

@@ -1,5 +1,5 @@
 #!/usr/bin/env ruby
 
-require "code_review_notifier"
+require_relative "../lib/code_review_notifier.rb"
 
-CodeReviewNotifier.new(ARGV).call
+CodeReviewNotifier.new(ARGV, __FILE__.split("/").last).call

data/lib/code_review_notifier.rb

@@ -20,24 +20,24 @@ class CodeReviewNotifier < Rubiclifier::BaseApplication
 
   def run_application
     while true
-      is_first_run = is_first_run?
-      puts
-      puts("Querying API...")
-      all_code_changes = Api.current_api.all_code_changes
-      puts("Checking for notifications to display...")
-      all_activity = []
-      all_code_changes.each do |cc|
-        activity_for_code_change = cc.code_change_activity
-        activity_for_code_change.sort! { |a, b| a.created_at <=> b.created_at }
-        cc.activity_from_self_at = activity_for_code_change.find { |a| a.is_self }&.created_at
-        all_activity.concat(activity_for_code_change)
-      end
-      all_activity.select(&:should_notify?).each do |code_change_activity|
-        code_change_activity.notified
-        unless is_first_run
-          puts("Notifying of change!")
-          CodeChangeNotification.new(code_change_activity).send
-          sleep(SECONDS_BETWEEN_NOTIFICATIONS)
+      unless Rubiclifier::IdleDetector.is_idle?
+        is_first_run = is_first_run?
+        puts
+        puts("Querying API...")
+        all_code_changes = Api.current_api.all_code_changes
+        puts("Checking for notifications to display...")
+        all_activity = []
+        all_code_changes.each do |cc|
+          cc.code_change_activity.sort! { |a, b| a.created_at <=> b.created_at }
+          all_activity.concat(cc.code_change_activity)
+        end
+        all_activity.select(&:should_notify?).each do |code_change_activity|
+          code_change_activity.notified
+          unless is_first_run
+            puts("Notifying of change!")
+            CodeChangeNotification.new(code_change_activity).send
+            sleep(SECONDS_BETWEEN_NOTIFICATIONS)
+          end
         end
       end
       sleep(SECONDS_BETWEEN_RUNS)
@@ -51,12 +51,13 @@ class CodeReviewNotifier < Rubiclifier::BaseApplication
     ).send
   end
 
-  def is_background_service?
-    true
-  end
-
-  def sends_notifications?
-    true
+  def features
+    [
+      Rubiclifier::Feature::BACKGROUND,
+      Rubiclifier::Feature::DATABASE,
+      Rubiclifier::Feature::IDLE_DETECTION,
+      Rubiclifier::Feature::NOTIFICATIONS
+    ]
   end
 
   def settings
@@ -68,10 +69,6 @@ class CodeReviewNotifier < Rubiclifier::BaseApplication
     ]
   end
 
-  def executable_name
-    "code_review_notifier"
-  end
-
   def data_directory
     "~/.code_review_notifier"
   end

data/lib/models/code_change.rb

@@ -3,7 +3,6 @@ require "date"
 class CodeChange
   attr_accessor :code_change_activity
   attr_reader :id, :owner, :project, :subject, :updated_at
-  attr_writer :activity_from_self_at
 
   def initialize(id, owner, project, subject, updated_at)
     @id = id
@@ -14,7 +13,6 @@ class CodeChange
   end
 
   def activity_from_self_at
-    raise "@activity_from_self_at is not set" unless instance_variable_defined?("@activity_from_self_at")
-    @activity_from_self_at
+    @activity_from_self_at ||= code_change_activity.find { |a| a.is_self }&.created_at
   end
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: code_review_notifier
 version: !ruby/object:Gem::Version
-  version: 0.2.2
+  version: 0.3.2
 platform: ruby
 authors:
 - Kyle Grinstead
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2020-07-09 00:00:00.000000000 Z
+date: 2020-07-10 00:00:00.000000000 Z
 dependencies: []
 description: 
 email: kyleag@hey.com
@@ -32,7 +32,7 @@ licenses:
 metadata:
   source_code_uri: https://github.com/MrGrinst/code_review_notifier
 post_install_message: "\n\e[32mThanks for installing code_review_notifier!\e[0m\n\e[32mSet
-  it up by running `code_review_notifier --setup`\e[0m\n\n"
+  it up by running `\e[0mcode_review_notifier --setup\e[32m`\e[0m\n\n"
 rdoc_options: []
 require_paths:
 - lib