code_poetry-html 0.1.0 → 0.2.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: e087e52851d0634e55520992d52db1f94e7b4503
-  data.tar.gz: b44b8cdec5026513fb24acc3828e91f4feca7791
+  metadata.gz: a59640d523afcdcd22294bf2fff32d8f957ec747
+  data.tar.gz: c3cdeedd0d6fdb0aafc9e556f20c6d9f0a6ec540
 SHA512:
-  metadata.gz: b7a21c7dc1562c5675408136d6facc59b924eb8ebe57777587d24de748c831cb2be9a9ba7b08e5fa917a77beea441edfc86ccb8ea8404d3aa55649b5e2ab8b00
-  data.tar.gz: 8c36170ff81289cb102d30e8fe8ab4a282de05b0b3a2fbfb949bd983b6a1a288c9c203ab7e59ba1eae7e95990556eadaba0b1965fce7256edac903cd74d2bbd7
+  metadata.gz: a14d366c0dc71769896451bfb614cd6c84d634a8b11ded62a529149229a8d46e258181f3877e75ba7efc4b3fbaec13982a477cd5616c6a046d8538a2edfc863b
+  data.tar.gz: bca34bc40ddfce47b8021d230669a53aabc121be6dc2aa6c5c07dd435738db1a6f48a06e2237f374aece1bb2418fa07641f2a8cd490df2d004d5b0ffc4955934

data/assets/stylesheets/screen.css.scss

@@ -70,6 +70,8 @@ th {
     .smell { color: #000 }
     .smell-name { font-size: 18px }
     .smell-complexity { font-size: 14px }
+
+    ul.duplications { margin-top: 10px }
   }
 
   pre {

data/lib/code_poetry-html/version.rb

@@ -1,7 +1,7 @@
 module CodePoetry
   module Formatter
     class HTMLFormatter
-      VERSION = "0.1.0"
+      VERSION = "0.2.0"
     end
   end
 end

data/lib/code_poetry-html.rb

@@ -11,7 +11,7 @@ class CodePoetry::Formatter::HTMLFormatter
     end
 
     File.open(File.join(output_path, "index.html"), "w+") do |file|
-      file.puts template('layout').result(binding)
+      file.puts template('views', 'layout').result(binding)
     end
 
     puts "Code Poetry report generated to #{output_path}."
@@ -19,8 +19,8 @@ class CodePoetry::Formatter::HTMLFormatter
 
 private
 
-  def template(name)
-    ERB.new(File.read(File.join(File.dirname(__FILE__), '../views/', "#{name}.erb")))
+  def template(path, name)
+    ERB.new(File.read(File.join(File.dirname(__FILE__), "../#{path}/", "#{name}.erb")))
   end
 
   def output_path
@@ -35,11 +35,15 @@ private
   end
 
   def formatted_source_file(stat)
-    template('source_file').result(binding)
+    template('views', 'source_file').result(binding)
   end
 
   def formatted_file_list(stats)
-    template('file_list').result(binding)
+    template('views', 'file_list').result(binding)
+  end
+
+  def formatted_smell(stat, smell)
+    template('views/smells', smell.type).result(binding)
   end
 
   def id(stat)
@@ -47,18 +51,18 @@ private
   end
 
   def timeago(time)
-    %Q(<abbr class="timeago" title="#{time.iso8601}">#{time.iso8601}</abbr>)
+    %(<abbr class="timeago" title="#{time.iso8601}">#{time.iso8601}</abbr>)
   end
 
   def link_to_source_file(stat)
-    %Q(<a href="##{id(stat)}" class="src_link" title="#{stat.name}">#{stat.name}</a>)
+    %(<a href="##{id(stat)}" class="src_link" title="#{stat.name}">#{stat.name}</a>)
   end
 
   def line_status(stat, line_number)
     method = stat.get_method_at_line(line_number)
 
     unless method.nil?
-      'smelly' if method.smelly?
+      'smelly' if method.smelly? || method.duplicated?
     end
   end
 end

data/public/application.css

@@ -480,6 +480,8 @@ th {
   font-size: 18px; }
 .source_table .smell-view .smell-complexity {
   font-size: 14px; }
+.source_table .smell-view ul.duplications {
+  margin-top: 10px; }
 .source_table pre {
   margin: 0;
   padding: 0;

data/views/file_list.erb

@@ -7,6 +7,7 @@
         <th>Lines of Code</th>
         <th>Churns</th>
         <th>Smells</th>
+        <th>Duplication</th>
         <th>Complexity</th>
         <th>Complexity/Method</th>
       </tr>
@@ -19,6 +20,7 @@
         <td><%= stat.lines_of_code %></td>
         <td><%= stat.churns %></td>
         <td><%= stat.smells.count %></td>
+        <td><%= stat.duplication %></td>
         <td><%= stat.complexity %></td>
         <td><%= stat.complexity_per_method %></td>
       </tr>

data/views/smells/complex_class.erb

@@ -0,0 +1,4 @@
+<li>
+  <span class="smell">Complex class</span>
+  <span class="smell-complexity">(complexity <%= stat.complexity %>)</span>
+</li>

data/views/smells/complex_class_definition.erb

@@ -0,0 +1,5 @@
+<li>
+  <span class="smell">Complex</span> code in
+  <span class="smell-name"><%= stat.name %></span> definition outside of methods
+  <span class="smell-complexity">(complexity <%= stat.definition_complexity %>)</span>
+</li>

data/views/smells/complex_method.erb

@@ -0,0 +1,5 @@
+<li>
+  <span class="smell">Complex method</span>
+  <span class="smell-name"><%= smell.object.pretty_name %></span>
+  <span class="smell-complexity">(complexity <%= smell.object.complexity %>)</span>
+</li>

data/views/smells/duplication.erb

@@ -0,0 +1,10 @@
+<li>
+  <span class="smell"><%= smell.object.severity %> Code</span> found in
+  <span class="smell-name">:<%= smell.object.node %></span> nodes
+  <span class="smell-complexity">(mass  = <%= smell.object.mass %>)</span>
+  <ul class="duplications">
+    <% smell.object.methods.each do |method| %>
+      <li><%= method.pretty_location %></li>
+    <% end %>
+  </ul>
+</li>

data/views/source_file.erb

@@ -17,24 +17,7 @@
       <% end %>
 
       <% stat.smells.each do |smell| %>
-        <% if smell.complex_class? %>
-          <li>
-            <span class="smell">Complex class</span>
-            <span class="smell-complexity">(complexity <%= stat.complexity %>)</span>
-          </li>
-        <% elsif smell.complex_class_definition? %>
-          <li>
-            <span class="smell">Complex</span> code in
-            <span class="smell-name"><%= stat.name %></span> definition outside of methods
-            <span class="smell-complexity">(complexity <%= stat.definition_complexity %>)</span>
-          </li>
-        <% elsif smell.complex_method? %>
-          <li>
-            <span class="smell">Complex method</span>
-            <span class="smell-name"><%= smell.method.pretty_name %></span>
-            <span class="smell-complexity">(complexity <%= smell.method.complexity %>)</span>
-          </li>
-        <% end %>
+        <%= formatted_smell(stat, smell) %>
       <% end %>
     </ul>
   </div>

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: code_poetry-html
 version: !ruby/object:Gem::Version
-  version: 0.1.0
+  version: 0.2.0
 platform: ruby
 authors:
 - Bastian Bartmann
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2013-12-01 00:00:00.000000000 Z
+date: 2014-02-22 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: bundler
@@ -103,6 +103,10 @@ files:
 - public/magnify.png
 - views/file_list.erb
 - views/layout.erb
+- views/smells/complex_class.erb
+- views/smells/complex_class_definition.erb
+- views/smells/complex_method.erb
+- views/smells/duplication.erb
 - views/source_file.erb
 homepage: https://github.com/coding-chimp/code_poetry-html
 licenses: