code_ownership 2.1.0 → 2.1.2

data/ext/cargo-vendor/{codeowners-0.3.0 → codeowners-0.3.2}/tests/common/mod.rs

@@ -154,9 +154,10 @@ pub fn build_run_config(project_root: &Path, codeowners_rel_path: &str) -> RunCo
     let config_path = project_root.join("config/code_ownership.yml");
     RunConfig {
         project_root,
-        codeowners_file_path,
+        codeowners_file_path: Some(codeowners_file_path),
         config_path,
         no_cache: true,
+        executable_name: None,
     }
 }
 

data/ext/cargo-vendor/codeowners-0.3.2/tests/executable_name_config_test.rs

@@ -0,0 +1,67 @@
+use indoc::indoc;
+use predicates::prelude::*;
+use std::error::Error;
+
+mod common;
+use common::OutputStream;
+use common::run_codeowners;
+
+#[test]
+fn test_validate_with_custom_executable_name() -> Result<(), Box<dyn Error>> {
+    // When executable_name is configured, error should show that command
+    run_codeowners(
+        "custom_executable_name",
+        &["validate"],
+        false,
+        OutputStream::Stdout,
+        predicate::str::contains("Run `bin/codeownership validate`"),
+    )?;
+    Ok(())
+}
+
+#[test]
+fn test_validate_with_default_executable_name() -> Result<(), Box<dyn Error>> {
+    // When executable_name is not configured, error should show default "codeowners"
+    run_codeowners(
+        "default_executable_name",
+        &["validate"],
+        false,
+        OutputStream::Stdout,
+        predicate::str::contains("Run `codeowners generate`"),
+    )?;
+    Ok(())
+}
+
+#[test]
+fn test_custom_executable_name_full_error_message() -> Result<(), Box<dyn Error>> {
+    // Verify the complete error message format with custom executable
+    run_codeowners(
+        "custom_executable_name",
+        &["validate"],
+        false,
+        OutputStream::Stdout,
+        predicate::eq(indoc! {"
+
+    CODEOWNERS out of date. Run `bin/codeownership validate` to update the CODEOWNERS file
+
+    "}),
+    )?;
+    Ok(())
+}
+
+#[test]
+fn test_default_executable_name_full_error_message() -> Result<(), Box<dyn Error>> {
+    // Verify the complete error message format with default executable
+    run_codeowners(
+        "default_executable_name",
+        &["validate"],
+        false,
+        OutputStream::Stdout,
+        predicate::eq(indoc! {"
+
+    CODEOWNERS out of date. Run `codeowners generate` to update the CODEOWNERS file
+
+    "}),
+    )?;
+    Ok(())
+}

data/ext/cargo-vendor/codeowners-0.3.2/tests/fixtures/custom_codeowners_path/config/code_ownership.yml

@@ -0,0 +1,11 @@
+owned_globs:
+  - "{config,ruby}/**/*.{rb,yml}"
+ruby_package_paths: []
+javascript_package_paths: []
+team_file_glob:
+  - config/teams/**/*.yml
+unbuilt_gems_path: gems
+unowned_globs:
+  - config/code_ownership.yml
+codeowners_path: docs
+

data/ext/cargo-vendor/codeowners-0.3.2/tests/fixtures/custom_codeowners_path/config/teams/test_team.yml

@@ -0,0 +1,6 @@
+name: TestTeam
+github:
+  team: "@TestTeam"
+  members:
+    - testmember
+

data/ext/cargo-vendor/codeowners-0.3.2/tests/fixtures/custom_codeowners_path/docs/CODEOWNERS

@@ -0,0 +1,14 @@
+# STOP! - DO NOT EDIT THIS FILE MANUALLY
+# This file was automatically generated by "bin/codeownership validate".
+#
+# CODEOWNERS is used for GitHub to suggest code/file owners to various GitHub
+# teams. This is useful when developers create Pull Requests since the
+# code/file owner is notified. Reference GitHub docs for more details:
+# https://help.github.com/en/articles/about-code-owners
+
+
+# Annotations at the top of file
+/ruby/app/models/test.rb @TestTeam
+
+# Team YML ownership
+/config/teams/test_team.yml @TestTeam

data/ext/cargo-vendor/codeowners-0.3.2/tests/fixtures/custom_codeowners_path/expected/CODEOWNERS

@@ -0,0 +1,14 @@
+# STOP! - DO NOT EDIT THIS FILE MANUALLY
+# This file was automatically generated by "bin/codeownership validate".
+#
+# CODEOWNERS is used for GitHub to suggest code/file owners to various GitHub
+# teams. This is useful when developers create Pull Requests since the
+# code/file owner is notified. Reference GitHub docs for more details:
+# https://help.github.com/en/articles/about-code-owners
+
+
+# Annotations at the top of file
+/ruby/app/models/test.rb @TestTeam
+
+# Team YML ownership
+/config/teams/test_team.yml @TestTeam

data/ext/cargo-vendor/codeowners-0.3.2/tests/fixtures/custom_codeowners_path/ruby/app/models/test.rb

@@ -0,0 +1,3 @@
+# @team TestTeam
+class Test
+end

data/ext/cargo-vendor/codeowners-0.3.2/tests/fixtures/custom_executable_name/.github/CODEOWNERS

@@ -0,0 +1,10 @@
+# STOP! - DO NOT EDIT THIS FILE MANUALLY
+# This file was automatically generated by "codeowners".
+#
+# CODEOWNERS is used for GitHub to suggest code/file owners to various GitHub
+# teams. This is useful when developers create Pull Requests since the
+# code/file owner is notified. Reference GitHub docs for more details:
+# https://help.github.com/en/articles/about-code-owners
+
+# Outdated content to trigger validation error
+/app/old.rb @FooTeam

data/ext/cargo-vendor/codeowners-0.3.2/tests/fixtures/custom_executable_name/app/foo.rb

@@ -0,0 +1,3 @@
+# @team Foo
+puts 'foo'
+

data/ext/cargo-vendor/codeowners-0.3.2/tests/fixtures/custom_executable_name/config/code_ownership.yml

@@ -0,0 +1,4 @@
+---
+owned_globs:
+  - "{app,config}/**/*.rb"
+executable_name: "bin/codeownership validate"

data/ext/cargo-vendor/codeowners-0.3.2/tests/fixtures/custom_executable_name/config/teams/foo.yml

@@ -0,0 +1,5 @@
+---
+name: Foo
+github:
+  team: '@FooTeam'
+

data/ext/cargo-vendor/codeowners-0.3.2/tests/fixtures/custom_executable_name/config/teams/payments.yml

@@ -0,0 +1,6 @@
+name: Payments
+github:
+  team: "@PaymentTeam"
+owned_globs:
+  - ruby/app/payments/**
+

data/ext/cargo-vendor/codeowners-0.3.2/tests/fixtures/custom_executable_name/ruby/app/payments/foo.rb

@@ -0,0 +1,4 @@
+# A file owned by Payments
+class Foo
+end
+

data/ext/cargo-vendor/codeowners-0.3.2/tests/fixtures/default_executable_name/.github/CODEOWNERS

@@ -0,0 +1,11 @@
+# STOP! - DO NOT EDIT THIS FILE MANUALLY
+# This file was automatically generated by "codeowners".
+#
+# CODEOWNERS is used for GitHub to suggest code/file owners to various GitHub
+# teams. This is useful when developers create Pull Requests since the
+# code/file owner is notified. Reference GitHub docs for more details:
+# https://help.github.com/en/articles/about-code-owners
+
+# Outdated content to trigger validation error
+/app/old.rb @BarTeam
+

data/ext/cargo-vendor/codeowners-0.3.2/tests/fixtures/default_executable_name/app/bar.rb

@@ -0,0 +1,3 @@
+# @team Bar
+puts 'bar'
+

data/ext/cargo-vendor/codeowners-0.3.2/tests/fixtures/default_executable_name/config/code_ownership.yml

@@ -0,0 +1,5 @@
+---
+owned_globs:
+  - "{app,config}/**/*.rb"
+# No executable_name specified - should use default
+

data/ext/cargo-vendor/codeowners-0.3.2/tests/fixtures/default_executable_name/config/teams/bar.yml

@@ -0,0 +1,5 @@
+---
+name: Bar
+github:
+  team: '@BarTeam'
+

data/ext/cargo-vendor/codeowners-0.3.2/tests/fixtures/missing_github_team/.github/CODEOWNERS

@@ -0,0 +1,10 @@
+# STOP! - DO NOT EDIT THIS FILE MANUALLY
+# This file was automatically generated by "bin/codeownership validate".
+#
+# CODEOWNERS is used for GitHub to suggest code/file owners to various GitHub
+# teams. This is useful when developers create Pull Requests since the
+# code/file owner is notified. Reference GitHub docs for more details:
+# https://help.github.com/en/articles/about-code-owners
+
+# Match all files to GoodTeam so for-file --from-codeowners hits the parser path
+* @GoodTeam

data/ext/cargo-vendor/codeowners-0.3.2/tests/fixtures/missing_github_team/config/code_ownership.yml

@@ -0,0 +1,10 @@
+owned_globs:
+  - "{gems}/**/*.{rb,tsx,erb}"
+team_file_glob:
+  - config/teams/**/*.yml
+unbuilt_gems_path: gems
+unowned_globs:
+vendored_gems:
+  path: "gems"
+cache_directory: tmp/cache/codeowners
+ignore_dirs: []

data/ext/cargo-vendor/codeowners-0.3.2/tests/fixtures/missing_github_team/config/teams/bad_team.yml

@@ -0,0 +1 @@
+name: MissingGithub

data/ext/cargo-vendor/codeowners-0.3.2/tests/fixtures/missing_github_team/config/teams/good.yml

@@ -0,0 +1,3 @@
+name: Good
+github:
+  team: '@GoodTeam'

data/ext/cargo-vendor/codeowners-0.3.2/tests/fixtures/valid_project/gems/pets/dog.rb

@@ -0,0 +1,5 @@
+# generated
+# next line should be ignored
+# @team Payments
+
+class Dog; end

data/ext/cargo-vendor/{codeowners-0.3.0 → codeowners-0.3.2}/tests/git_stage_test.rs

@@ -38,7 +38,10 @@ where
     let result = func(&run_config, stage);
     assert_no_run_errors(&result);
 
-    assert!(run_config.codeowners_file_path.exists(), "CODEOWNERS file was not created");
+    assert!(
+        run_config.codeowners_file_path.as_ref().unwrap().exists(),
+        "CODEOWNERS file was not created",
+    );
     let staged = is_file_staged(&run_config.project_root, CODEOWNERS_REL);
     assert_eq!(staged, expected_staged, "unexpected staged state for CODEOWNERS");
 }

data/ext/cargo-vendor/codeowners-0.3.2/tests/missing_github_team_test.rs

@@ -0,0 +1,23 @@
+use predicates::prelude::*;
+use std::error::Error;
+
+mod common;
+use common::OutputStream;
+use common::run_codeowners;
+
+// Exercise the code path that skips invalid team files and prints to stderr
+// (codeowners_file_parser::teams_by_github_team_name). Uses for-file
+// --from-codeowners so the project is not built and the parser globs team
+// files; the invalid bad_team.yml is skipped and an error is printed.
+// With the fix: stderr contains "Error parsing team file:" and "missing field `github`".
+// Without the fix (reverted): stderr only has generic "YAML serialization/deserialization failed".
+#[test]
+fn test_missing_github_team_in_team_file_is_reported_on_stderr() -> Result<(), Box<dyn Error>> {
+    run_codeowners(
+        "missing_github_team",
+        &["for-file", "--from-codeowners", "ruby/foo.rb"],
+        true, // command succeeds; invalid file is skipped
+        OutputStream::Stderr,
+        predicate::str::contains("Error parsing team file:").and(predicate::str::contains("missing field `github`")),
+    )
+}

data/ext/cargo-vendor/codeowners-0.3.2/tests/run_config_executable_override_test.rs

@@ -0,0 +1,98 @@
+use std::error::Error;
+use std::path::Path;
+
+mod common;
+use common::{build_run_config, git_add_all_files, setup_fixture_repo};
+
+#[test]
+fn test_run_config_executable_path_overrides_config_file() -> Result<(), Box<dyn Error>> {
+    use codeowners::runner::validate;
+
+    let fixture_root = Path::new("tests/fixtures/custom_executable_name");
+    let temp_dir = setup_fixture_repo(fixture_root);
+    let project_path = temp_dir.path();
+    git_add_all_files(project_path);
+
+    // This fixture has executable_name: "bin/codeownership validate" in config
+    // But we'll override it with RunConfig.executable_name
+
+    let mut run_config = build_run_config(project_path, ".github/CODEOWNERS");
+    run_config.executable_name = Some("my-wrapper-tool validate".to_string());
+
+    let result = validate(&run_config, vec![]);
+
+    // Should use "my-wrapper-tool validate" from RunConfig, NOT "bin/codeownership validate" from config
+    assert!(!result.validation_errors.is_empty(), "Expected validation errors but got none");
+    let error_msg = result.validation_errors.join("\n");
+    assert!(
+        error_msg.contains("Run `my-wrapper-tool validate`"),
+        "Expected error to contain 'my-wrapper-tool validate' but got: {}",
+        error_msg
+    );
+    assert!(
+        !error_msg.contains("bin/codeownership"),
+        "Error should not contain config file's executable_name when overridden"
+    );
+
+    Ok(())
+}
+
+#[test]
+fn test_run_config_without_executable_path_uses_config_file() -> Result<(), Box<dyn Error>> {
+    use codeowners::runner::validate;
+
+    let fixture_root = Path::new("tests/fixtures/custom_executable_name");
+    let temp_dir = setup_fixture_repo(fixture_root);
+    let project_path = temp_dir.path();
+    git_add_all_files(project_path);
+
+    // This fixture has executable_name: "bin/codeownership validate" in config
+
+    let mut run_config = build_run_config(project_path, ".github/CODEOWNERS");
+    run_config.executable_name = None; // Explicitly no override
+
+    let result = validate(&run_config, vec![]);
+
+    // Should use "bin/codeownership validate" from config file
+    assert!(!result.validation_errors.is_empty(), "Expected validation errors but got none");
+    let error_msg = result.validation_errors.join("\n");
+    assert!(
+        error_msg.contains("Run `bin/codeownership validate`"),
+        "Expected error to contain 'bin/codeownership validate' but got: {}",
+        error_msg
+    );
+
+    Ok(())
+}
+
+#[test]
+fn test_run_config_executable_path_overrides_default() -> Result<(), Box<dyn Error>> {
+    use codeowners::runner::validate;
+
+    let fixture_root = Path::new("tests/fixtures/default_executable_name");
+    let temp_dir = setup_fixture_repo(fixture_root);
+    let project_path = temp_dir.path();
+    git_add_all_files(project_path);
+
+    // This fixture has NO executable_name in config (uses default "codeowners generate")
+
+    let mut run_config = build_run_config(project_path, ".github/CODEOWNERS");
+    run_config.executable_name = Some("custom-command generate".to_string());
+
+    let result = validate(&run_config, vec![]);
+
+    // Should use "custom-command generate" from RunConfig, NOT default "codeowners generate"
+    assert!(!result.validation_errors.is_empty(), "Expected validation errors but got none");
+    let error_msg = result.validation_errors.join("\n");
+    assert!(
+        error_msg.contains("Run `custom-command generate`"),
+        "Expected error to contain 'custom-command generate' but got: {}",
+        error_msg
+    );
+    assert!(
+        !error_msg.contains("codeowners generate"),
+        "Error should not contain default when overridden"
+    );
+
+    Ok(())
+}

data/ext/cargo-vendor/{codeowners-0.3.0 → codeowners-0.3.2}/tests/runner_api.rs

@@ -35,9 +35,10 @@ team_file_glob:
 
     let run_config = RunConfig {
         project_root: temp_dir.path().to_path_buf(),
-        codeowners_file_path: temp_dir.path().join(".github/CODEOWNERS").to_path_buf(),
+        codeowners_file_path: Some(temp_dir.path().join(".github/CODEOWNERS").to_path_buf()),
         config_path: temp_dir.path().join("config/code_ownership.yml").to_path_buf(),
         no_cache: true,
+        executable_name: None,
     };
 
     let file_owner = runner::file_owner_for_file(&run_config, "app/consumers/deep/nesting/nestdir/deep_file.rb")
@@ -60,9 +61,10 @@ fn test_teams_for_files_from_codeowners() {
     ];
     let run_config = RunConfig {
         project_root: project_root.to_path_buf(),
-        codeowners_file_path: project_root.join(".github/CODEOWNERS").to_path_buf(),
+        codeowners_file_path: Some(project_root.join(".github/CODEOWNERS").to_path_buf()),
         config_path: project_root.join("config/code_ownership.yml").to_path_buf(),
         no_cache: true,
+        executable_name: None,
     };
     let teams =
         runner::teams_for_files_from_codeowners(&run_config, &file_paths.iter().map(|s| s.to_string()).collect::<Vec<String>>()).unwrap();
@@ -126,9 +128,10 @@ javascript_package_paths:
 
     let rc = RunConfig {
         project_root: td.path().to_path_buf(),
-        codeowners_file_path: td.path().join(".github/CODEOWNERS"),
+        codeowners_file_path: Some(td.path().join(".github/CODEOWNERS")),
         config_path: td.path().join("config/code_ownership.yml"),
         no_cache: true,
+        executable_name: None,
     };
 
     // Ensure CODEOWNERS file matches generator output to avoid out-of-date errors
@@ -167,9 +170,10 @@ javascript_package_paths:
 
     let rc = RunConfig {
         project_root: td.path().to_path_buf(),
-        codeowners_file_path: td.path().join(".github/CODEOWNERS"),
+        codeowners_file_path: Some(td.path().join(".github/CODEOWNERS")),
         config_path: td.path().join("config/code_ownership.yml"),
         no_cache: true,
+        executable_name: None,
     };
 
     let gv = runner::generate_and_validate(&rc, vec![], true);

data/ext/cargo-vendor/{codeowners-0.3.0 → codeowners-0.3.2}/tests/valid_project_test.rs

@@ -241,7 +241,7 @@ fn test_for_file_same_team_multiple_ownerships() -> Result<(), Box<dyn Error>> {
             Team YML: config/teams/payroll.yml
             Description:
             - Owner annotation at the top of the file
-            - Owner defined in `javascript/packages/PayrollFlow/package.json` with implicity owned glob: `javascript/packages/PayrollFlow/**/**`
+            - Owner defined in `javascript/packages/PayrollFlow/package.json` with implicitly owned glob: `javascript/packages/PayrollFlow/**/**`
         "}));
     Ok(())
 }
@@ -262,7 +262,7 @@ fn test_fast_for_file_same_team_multiple_ownerships() -> Result<(), Box<dyn Erro
             Team YML: config/teams/payroll.yml
             Description:
             - Owner annotation at the top of the file
-            - Owner defined in `javascript/packages/PayrollFlow/package.json` with implicity owned glob: `javascript/packages/PayrollFlow/**/**`
+            - Owner defined in `javascript/packages/PayrollFlow/package.json` with implicitly owned glob: `javascript/packages/PayrollFlow/**/**`
         "}));
     Ok(())
 }
@@ -283,7 +283,7 @@ fn test_for_file_with_2_ownerships() -> Result<(), Box<dyn Error>> {
             Team YML: config/teams/payroll.yml
             Description:
             - Owner annotation at the top of the file
-            - Owner defined in `javascript/packages/PayrollFlow/package.json` with implicity owned glob: `javascript/packages/PayrollFlow/**/**`
+            - Owner defined in `javascript/packages/PayrollFlow/package.json` with implicitly owned glob: `javascript/packages/PayrollFlow/**/**`
         "}));
 
     Ok(())