code_ownership 1.36.1 → 1.36.2

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 668edc0471999590cd95e9953151e6e30d02bf64b2bb14e544e5f7c56099c998
-  data.tar.gz: bbdff6a9af05c8026b33c206d63f083d1c9ed82831bd7b1f3cf3707aa0f54a67
+  metadata.gz: b73797a7557aab4536aef1ae47614f8d43e4dc634ec3ab476913c38efec1ad42
+  data.tar.gz: 5d1724a6eadb02d5bd7f1e521177f760b9134575d34a9bea634f30d45765de2f
 SHA512:
-  metadata.gz: 54a6b78ddb108894b20ddee99d0a6637770485b27c154b6676021f512d2aae39159d052e8f2c7986b71c824eb9f3f7bc4a3b9d5bc0c9e1848e7bceecee3e7728
-  data.tar.gz: b4f39290cfc23f31b73642d3d6a5747ec79efc07210541c4b18c913f448c1df32efe6b4657e91f736055ab30ecf72b4910c22a0266503842aff84ad0e375be62
+  metadata.gz: 404f36c3804c30f3eb0fb5fc3a18faf71667c5fe4eab25f0d4527491ce838ee51c39824f3fcacc608e5e1356e82272bbe1928f18e0bd9a65e1c1941df595e5de
+  data.tar.gz: 326d2644787ee2e9d8c054b38762495db9be3c15305519176e3045c979b96e655136f3fb1def6840b8e975e56ee693fbc72dea8d10c6f69a86f2126376f70746

data/lib/code_ownership/private/glob_cache.rb

@@ -53,14 +53,8 @@ module CodeOwnership
         @expanded_cache ||= begin
           expanded_cache = {}
           @raw_cache_contents.each do |mapper_description, globs_by_owner|
-            expanded_cache[mapper_description] = {}
-            globs_by_owner.each do |glob, owner|
-              Dir.glob(glob).each do |file, owner|
-                expanded_cache[mapper_description][file] = owner
-              end
-            end
+            expanded_cache[mapper_description] = OwnerAssigner.assign_owners(globs_by_owner)
           end
-          
           expanded_cache
         end
       end

data/lib/code_ownership/private/owner_assigner.rb

@@ -0,0 +1,22 @@
+# typed: strict
+# frozen_string_literal: true
+
+module CodeOwnership
+  module Private
+    class OwnerAssigner
+      extend T::Sig
+
+      sig { params(globs_to_owning_team_map: GlobsToOwningTeamMap).returns(GlobsToOwningTeamMap) }
+      def self.assign_owners(globs_to_owning_team_map)
+        globs_to_owning_team_map.each_with_object({}) do |(glob, owner), mapping|
+          # addresses the case where a directory name includes regex characters
+          # such as `app/services/[test]/some_other_file.ts`
+          mapping[glob] = owner if File.exist?(glob)
+          Dir.glob(glob).each do |file|
+            mapping[file] ||= owner
+          end
+        end
+      end
+    end
+  end
+end

data/lib/code_ownership/private.rb

@@ -8,6 +8,7 @@ require 'code_ownership/private/team_plugins/github'
 require 'code_ownership/private/codeowners_file'
 require 'code_ownership/private/parse_js_packages'
 require 'code_ownership/private/glob_cache'
+require 'code_ownership/private/owner_assigner'
 require 'code_ownership/private/validations/files_have_owners'
 require 'code_ownership/private/validations/github_codeowners_up_to_date'
 require 'code_ownership/private/validations/files_have_unique_owners'
@@ -98,7 +99,6 @@ module CodeOwnership
       in_unowned_globs = configuration.unowned_globs.any? do |unowned_glob|
         File.fnmatch?(unowned_glob, file, File::FNM_PATHNAME | File::FNM_EXTGLOB)
       end
-
       in_owned_globs && !in_unowned_globs && File.exist?(file)
     end
 

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: code_ownership
 version: !ruby/object:Gem::Version
-  version: 1.36.1
+  version: 1.36.2
 platform: ruby
 authors:
 - Gusto Engineers
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2023-12-12 00:00:00.000000000 Z
+date: 2024-02-16 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: code_teams
@@ -44,16 +44,16 @@ dependencies:
     requirements:
     - - ">="
       - !ruby/object:Gem::Version
-        version: 0.5.10821
+        version: 0.5.11249
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - ">="
       - !ruby/object:Gem::Version
-        version: 0.5.10821
+        version: 0.5.11249
 - !ruby/object:Gem::Dependency
-  name: pry
+  name: debug
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - ">="
@@ -168,6 +168,7 @@ files:
 - lib/code_ownership/private/codeowners_file.rb
 - lib/code_ownership/private/extension_loader.rb
 - lib/code_ownership/private/glob_cache.rb
+- lib/code_ownership/private/owner_assigner.rb
 - lib/code_ownership/private/ownership_mappers/directory_ownership.rb
 - lib/code_ownership/private/ownership_mappers/file_annotations.rb
 - lib/code_ownership/private/ownership_mappers/js_package_ownership.rb