code_ownership 1.34.1 → 1.35.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 5b59593095e1b124a7e6bf7b929e7f2bc9ab61f65f5f0867fff88b6cf2b5e097
-  data.tar.gz: 1dcef45327a13811dacbe44566dbddae71998145de1b9ca63df5814e848ca899
+  metadata.gz: 687d34f0d9ad8f7421b0a599904c697e10b34ec9f638a47f1e861b2e858bf091
+  data.tar.gz: b8beee01bb8e5ff88d73117a05ad8c99c04e3ee3a7434f1a92da0e15cc7839dd
 SHA512:
-  metadata.gz: 05546e3fb45286c44cc7227675b01d747ada9ee9b5e8cb02ab692fe3b9e30558fd1d8cfbc6716fadbece2c4048d164fe9a00b940a80f7fdf4366dbf0043fcbdf
-  data.tar.gz: '06584d3cb45cfb7ab7cd8e0e55a1a4b1c5db09e0dc022300f75f63714a2121f42301fe9bdbe11c1f5715909a7853d68060244be51925d0edb1fab0985b0112e5'
+  metadata.gz: c30fb93a5e634f648f00ab7269d0744cbb9dc120b3c472769a116e59066190560845ae8ee660750efb81c10d8c483373ffda8058d523ac50f16fa05266cf9e29
+  data.tar.gz: 1843017837ed962de655069fcb64d7d5121e72eb6375df14b8a7be8c35d6b9b55ba3e592bb9a240374964002ea65d1c7f87a0ddd6d565a1c74e4276c51bb56fb

data/README.md

@@ -73,6 +73,12 @@ js_package_paths:
 
 This defaults `**/`, which makes it look for `package.json` files across your application.
 
+> [!NOTE]
+> Javscript package ownership does not respect `unowned_globs`. If you wish to disable usage of this feature you can set `js_package_paths` to an empty list.
+```yml
+js_package_paths: []
+```
+
 ### Custom Ownership
 To enable custom ownership, you can inject your own custom classes into `code_ownership`.
 To do this, first create a class that adheres to the `CodeOwnership::Mapper` and/or `CodeOwnership::Validator` interface.
@@ -155,7 +161,7 @@ unowned_globs:
   - app/services/some_file2.rb
   - frontend/javascripts/**/__generated__/**/*
 ```
-You can call the validation function with the Ruby API 
+You can call the validation function with the Ruby API
 ```ruby
 CodeOwnership.validate!
 ```

data/lib/code_ownership/configuration.rb

@@ -11,6 +11,7 @@ module CodeOwnership
     const :unbuilt_gems_path, T.nilable(String)
     const :skip_codeowners_validation, T::Boolean
     const :raw_hash, T::Hash[T.untyped, T.untyped]
+    const :require_github_teams, T::Boolean
 
     sig { returns(Configuration) }
     def self.fetch
@@ -27,7 +28,8 @@ module CodeOwnership
         unowned_globs: config_hash.fetch('unowned_globs', []),
         js_package_paths: js_package_paths(config_hash),
         skip_codeowners_validation: config_hash.fetch('skip_codeowners_validation', false),
-        raw_hash: config_hash
+        raw_hash: config_hash,
+        require_github_teams: config_hash.fetch('require_github_teams', false)
       )
     end
 

data/lib/code_ownership/private/team_plugins/github.rb

@@ -21,7 +21,7 @@ module CodeOwnership
 
         sig { override.params(teams: T::Array[CodeTeams::Team]).returns(T::Array[String]) }
         def self.validation_errors(teams)
-          all_github_teams = teams.flat_map { |team| self.for(team).github.team }
+          all_github_teams = teams.flat_map { |team| self.for(team).github.team }.compact
 
           teams_used_more_than_once = all_github_teams.tally.select do |_team, count|
             count > 1
@@ -29,6 +29,18 @@ module CodeOwnership
 
           errors = T.let([], T::Array[String])
 
+          if require_github_teams?
+            missing_github_teams = teams.select { |team| self.for(team).github.team.nil? }
+
+            if missing_github_teams.any?
+              errors << <<~ERROR
+                The following teams are missing `github.team` entries:
+
+                #{missing_github_teams.map(&:config_yml).join("\n")}
+              ERROR
+            end
+          end
+
           if teams_used_more_than_once.any?
             errors << <<~ERROR
               The following teams are specified multiple times:
@@ -40,6 +52,11 @@ module CodeOwnership
 
           errors
         end
+
+        sig { returns(T::Boolean) }
+        def self.require_github_teams?
+          CodeOwnership.configuration.require_github_teams
+        end
       end
     end
   end

data/lib/code_ownership.rb

@@ -6,7 +6,7 @@ require 'set'
 require 'code_teams'
 require 'sorbet-runtime'
 require 'json'
-require 'packs'
+require 'packs-specification'
 require 'code_ownership/mapper'
 require 'code_ownership/validator'
 require 'code_ownership/private'

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: code_ownership
 version: !ruby/object:Gem::Version
-  version: 1.34.1
+  version: 1.35.0
 platform: ruby
 authors:
 - Gusto Engineers
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2023-08-08 00:00:00.000000000 Z
+date: 2023-11-29 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: code_teams
@@ -25,7 +25,7 @@ dependencies:
       - !ruby/object:Gem::Version
         version: '1.0'
 - !ruby/object:Gem::Dependency
-  name: packs
+  name: packs-specification
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - ">="