code_ownership 1.32.9 → 1.32.11

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 71768f254f9fbb891679c002c16c20bd70a2125460e3c66995821cfe2784fe56
-  data.tar.gz: ce5698b1505d306026f807a142f648942ea06d3ab65576d05c623f6bdbdc1dfa
+  metadata.gz: 766c909e87feb435319240d22675e5bd3bbbb2da5e9984098df27eb6586b2d46
+  data.tar.gz: 74e9e35278a45fce5aecf0de4131c56785c774eb6abe9e3d6db599f3bf6332f1
 SHA512:
-  metadata.gz: 7b2e5da9f4e02b4db10c47be40b1b4bce33f7c44ad18797ff326a6e245f5dc57b2a8534c74fde74a1966970720a9bedf50d59858923e07f64d8e21d9f8411df1
-  data.tar.gz: b08f25b9008d86b19207931cb44c13adea814b998af8700b1fa445ad09e48e6549f86d6e4b75db41e5a783bf080ea5e25371d97db5307de8c5451bcd3d4fe3da
+  metadata.gz: eae6b000156ff509afe12b70019d3b73a62d30718f890f62dcd8ff46c8a03687e5cbc041463ef5b28e0de85bbb96c72799db95334d575bd5b42669ece4960885
+  data.tar.gz: e4c4b07430f1b611fb2e1493210a67c2a0e69013fdeddaa2042f8b6334e3b1c66d666343030da1af79b7af2dd9d8873af88556143cfa60406aa0991f72f7a9be

data/lib/code_ownership/mapper.rb

@@ -68,9 +68,10 @@ module CodeOwnership
 
       Mapper.all.each do |mapper|
         mapped_files = mapper.globs_to_owner(Private.tracked_files)
+        glob_to_owner_map_by_mapper_description[mapper.description] ||= {}
+
         mapped_files.each do |glob, owner|
           next if owner.nil?
-          glob_to_owner_map_by_mapper_description[mapper.description] ||= {}
           glob_to_owner_map_by_mapper_description.fetch(mapper.description)[glob] = owner
         end
       end

data/lib/code_ownership/private/ownership_mappers/file_annotations.rb

@@ -18,8 +18,6 @@ module CodeOwnership
         extend T::Sig
         include Mapper
 
-        @@map_files_to_owners = T.let({}, T.nilable(T::Hash[String, ::CodeTeams::Team])) # rubocop:disable Style/ClassVars
-
         TEAM_PATTERN = T.let(/\A(?:#|\/\/) @team (?<team>.*)\Z/.freeze, Regexp)
         DESCRIPTION = 'Annotations at the top of file'
 
@@ -37,9 +35,7 @@ module CodeOwnership
             returns(T::Hash[String, ::CodeTeams::Team])
         end
         def globs_to_owner(files)
-          return @@map_files_to_owners if @@map_files_to_owners&.keys && @@map_files_to_owners.keys.count > 0
-
-          @@map_files_to_owners = files.each_with_object({}) do |filename_relative_to_root, mapping| # rubocop:disable Style/ClassVars
+          files.each_with_object({}) do |filename_relative_to_root, mapping| # rubocop:disable Style/ClassVars
             owner = file_annotation_based_owner(filename_relative_to_root)
             next unless owner
 
@@ -119,7 +115,6 @@ module CodeOwnership
 
         sig { override.void }
         def bust_caches!
-          @@map_files_to_owners = {} # rubocop:disable Style/ClassVars
         end
       end
     end

data/lib/code_ownership/private/ownership_mappers/package_ownership.rb

@@ -9,8 +9,6 @@ module CodeOwnership
         extend T::Sig
         include Mapper
 
-        @@package_yml_cache = T.let({}, T::Hash[String, T.nilable(Packs::Pack)]) # rubocop:disable Style/ClassVars
-
         sig do
           override.params(file: String).
             returns(T.nilable(::CodeTeams::Team))
@@ -69,7 +67,6 @@ module CodeOwnership
 
         sig { override.void }
         def bust_caches!
-          @@package_yml_cache = {} # rubocop:disable Style/ClassVars
         end
       end
     end

data/lib/code_ownership/private/ownership_mappers/team_globs.rb

@@ -12,8 +12,6 @@ module CodeOwnership
 
         @@map_files_to_owners = T.let(@map_files_to_owners, T.nilable(T::Hash[String, ::CodeTeams::Team])) # rubocop:disable Style/ClassVars
         @@map_files_to_owners = {} # rubocop:disable Style/ClassVars
-        @@codeowners_lines_to_owners = T.let(@codeowners_lines_to_owners, T.nilable(T::Hash[String, ::CodeTeams::Team])) # rubocop:disable Style/ClassVars
-        @@codeowners_lines_to_owners = {} # rubocop:disable Style/ClassVars
 
         sig do
           params(files: T::Array[String]).
@@ -103,9 +101,7 @@ module CodeOwnership
             returns(T::Hash[String, ::CodeTeams::Team])
         end
         def globs_to_owner(files)
-          return @@codeowners_lines_to_owners if @@codeowners_lines_to_owners&.keys && @@codeowners_lines_to_owners.keys.count > 0
-
-          @@codeowners_lines_to_owners = CodeTeams.all.each_with_object({}) do |team, map| # rubocop:disable Style/ClassVars
+          CodeTeams.all.each_with_object({}) do |team, map| # rubocop:disable Style/ClassVars
             TeamPlugins::Ownership.for(team).owned_globs.each do |owned_glob|
               map[owned_glob] = team
             end
@@ -114,7 +110,6 @@ module CodeOwnership
 
         sig { override.void }
         def bust_caches!
-          @@codeowners_lines_to_owners = {} # rubocop:disable Style/ClassVars
           @@map_files_to_owners = {} # rubocop:disable Style/ClassVars
         end
 

data/lib/code_ownership/private/ownership_mappers/team_yml_ownership.rb

@@ -11,8 +11,6 @@ module CodeOwnership
 
         @@map_files_to_owners = T.let(@map_files_to_owners, T.nilable(T::Hash[String, ::CodeTeams::Team])) # rubocop:disable Style/ClassVars
         @@map_files_to_owners = {} # rubocop:disable Style/ClassVars
-        @@codeowners_lines_to_owners = T.let(@codeowners_lines_to_owners, T.nilable(T::Hash[String, ::CodeTeams::Team])) # rubocop:disable Style/ClassVars
-        @@codeowners_lines_to_owners = {} # rubocop:disable Style/ClassVars
 
         sig do
           params(files: T::Array[String]).
@@ -39,16 +37,13 @@ module CodeOwnership
             returns(T::Hash[String, ::CodeTeams::Team])
         end
         def globs_to_owner(files)
-          return @@codeowners_lines_to_owners if @@codeowners_lines_to_owners&.keys && @@codeowners_lines_to_owners.keys.count > 0
-
-          @@codeowners_lines_to_owners = CodeTeams.all.each_with_object({}) do |team, map| # rubocop:disable Style/ClassVars
+          CodeTeams.all.each_with_object({}) do |team, map| # rubocop:disable Style/ClassVars
             map[team.config_yml] = team
           end
         end
 
         sig { override.void }
         def bust_caches!
-          @@codeowners_lines_to_owners = {} # rubocop:disable Style/ClassVars
           @@map_files_to_owners = {} # rubocop:disable Style/ClassVars
         end
 

data/lib/code_ownership.rb

@@ -43,27 +43,23 @@ module CodeOwnership
 
   sig { params(team: T.any(CodeTeams::Team, String)).returns(String) }
   def for_team(team)
-    Private.load_configuration!
-
     team = T.must(CodeTeams.find(team)) if team.is_a?(String)
     ownership_information = T.let([], T::Array[String])
 
     ownership_information << "# Code Ownership Report for `#{team.name}` Team"
-    Mapper.all.each do |mapper|
-      ownership_information << "## #{mapper.description}"
-      codeowners_lines = mapper.globs_to_owner(Private.tracked_files)
+
+    Private.glob_cache.raw_cache_contents.each do |mapper_description, glob_to_owning_team_map|
+      ownership_information << "## #{mapper_description}"
       ownership_for_mapper = []
-      codeowners_lines.each do |line, team_for_line|
-        next if team_for_line.nil?
-        if team_for_line.name == team.name
-          ownership_for_mapper << "- #{line}"
-        end
+      glob_to_owning_team_map.each do |glob, owning_team|
+        next if owning_team != team
+        ownership_for_mapper << "- #{glob}"
       end
 
       if ownership_for_mapper.empty?
         ownership_information << 'This team owns nothing in this category.'
       else
-        ownership_information += ownership_for_mapper
+        ownership_information += ownership_for_mapper.sort
       end
 
       ownership_information << ""

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: code_ownership
 version: !ruby/object:Gem::Version
-  version: 1.32.9
+  version: 1.32.11
 platform: ruby
 authors:
 - Gusto Engineers
@@ -53,7 +53,7 @@ dependencies:
       - !ruby/object:Gem::Version
         version: '0'
 - !ruby/object:Gem::Dependency
-  name: rake
+  name: pry
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - ">="
@@ -67,7 +67,7 @@ dependencies:
       - !ruby/object:Gem::Version
         version: '0'
 - !ruby/object:Gem::Dependency
-  name: pry
+  name: rake
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - ">="