code_ownership 1.32.5 → 1.32.7

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 18268f7457aeb632f100ea698349530dc29a4be7ae62611f416fe43782705a5b
-  data.tar.gz: 937353d0f07b1ff21ddf813dff047e59d4029c8ff6b08a29f75f31db61e342bb
+  metadata.gz: 76d700471a2e895926f184939c856b08ac75d5240a0d924a8e4474ac733a7204
+  data.tar.gz: 3b62947009df98089b522614022643762c4c51d82af4f90f957606bcedfe60bc
 SHA512:
-  metadata.gz: 33c6f36e7a037a8495a370b738715cc2eb557912d4cb2f14df9184b329a6cc18e2c8e0a3f56fc0afd86d028ea321c2737043b8f94a88e5b3ea7c3486ff026216
-  data.tar.gz: 1665092ef4a69c4eecd08039fa1315be6bca38aaec17ead77573ede1c408c4b1e4a9c5a1746505310abaebe07f14c95cb088b691d71ee66b35eaa84ef40db8bd
+  metadata.gz: df833467c3721e6b7d67aebd0732d59c46073589210251bd0859cb05979103741876264dd336df10401005360bca7a2937c65e861044b22abd698a2b8b65a20d
+  data.tar.gz: 1b8f489aa18295cd8c534f3d5bcb3e2ab569553f26ec7e5a9445faff90da3aee3860bd3d7a02d6e91b80815d65b96680b0f54b085770ba85a54efa13aa0109b1

data/lib/code_ownership/private/codeowners_file.rb

@@ -56,14 +56,15 @@ module CodeOwnership
           ownership_map_cache.each do |path, code_team|
             team_mapping = github_team_map[code_team.name]
             next if team_mapping.nil?
-            next if ignored_teams.include?(code_team.name)
-            entry = "/#{path} #{team_mapping}"
-            # In order to use the codeowners file as a proper cache, we'll need to insert commented out entries for ignored teams
-            # entry = if ignored_teams.include?(code_team.name)
-            #   "# /#{path} #{team_mapping}"
-            # else
-            #   "/#{path} #{team_mapping}"
-            # end
+
+            # Leaving a commented out entry has two major benefits:
+            # 1) It allows the CODEOWNERS file to be used as a cache for validations
+            # 2) It allows users to specifically see what their team will not be notified about.
+            entry = if ignored_teams.include?(code_team.name)
+              "# /#{path} #{team_mapping}"
+            else
+              "/#{path} #{team_mapping}"
+            end
             ownership_entries << entry
           end
 

data/lib/code_ownership/private/validations/files_have_owners.rb

@@ -10,22 +10,19 @@ module CodeOwnership
 
         sig { override.params(files: T::Array[String], autocorrect: T::Boolean, stage_changes: T::Boolean).returns(T::Array[String]) }
         def validation_errors(files:, autocorrect: true, stage_changes: true)
-          allow_list = Dir.glob(Private.configuration.unowned_globs)
           files_by_mapper = Private.glob_cache.files_by_mapper
 
           files_not_mapped_at_all = files.select do |file|
             files_by_mapper.fetch(file, []).count == 0
           end
 
-          files_without_owners = files_not_mapped_at_all - allow_list
-
           errors = T.let([], T::Array[String])
 
-          if files_without_owners.any?
+          if files_not_mapped_at_all.any?
             errors << <<~MSG
               Some files are missing ownership:
 
-              #{files_without_owners.map { |file| "- #{file}" }.join("\n")}
+              #{files_not_mapped_at_all.map { |file| "- #{file}" }.join("\n")}
             MSG
           end
 

data/lib/code_ownership/private.rb

@@ -76,7 +76,7 @@ module CodeOwnership
     sig { returns(T::Array[String]) }
     def self.tracked_files
       @tracked_files ||= T.let(@tracked_files, T.nilable(T::Array[String]))
-      @tracked_files ||= Dir.glob(configuration.owned_globs)
+      @tracked_files ||= Dir.glob(configuration.owned_globs) - Dir.glob(configuration.unowned_globs)
     end
 
     sig { params(team_name: String, location_of_reference: String).returns(CodeTeams::Team) }

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: code_ownership
 version: !ruby/object:Gem::Version
-  version: 1.32.5
+  version: 1.32.7
 platform: ruby
 authors:
 - Gusto Engineers
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2023-04-10 00:00:00.000000000 Z
+date: 2023-04-11 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: code_teams