code_ownership 1.32.19 → 1.33.1

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 994693da06866743ce4cf2fa3b6bee1df754ac26e10884c999f0c37c9b72c23c
-  data.tar.gz: 5b2643e5ecd989f8ea15984a59b0b0a2522dbc614441228e10f7e25958141af0
+  metadata.gz: db417ae94561fc36906b23a65105d40bb48c6a084ae79fa33f49a84a903344f1
+  data.tar.gz: b0ba72d4cfd3f5c34e90352f1c009fd3e9093cea73f6a7b5044e6ae4632040c7
 SHA512:
-  metadata.gz: e832b86888eb90bb0beaff6410565f20c9224029af7d434698238039422ca67a6e34a0629a4441ab428fe73dddfac2bf606200191c621836989bbf67daff05a6
-  data.tar.gz: 2e5b208eb94ff9cc870e53d3673cc794f87af20f7d78c80a1493e3b9edfd2c2403285731b6b5b07292df5855ddf6e55c4f0b16d102bcb65c1dc6844ed39dfcf1
+  metadata.gz: 24b6290597a69fd80b62a70a0268dc559a8704f12f67800aa5640ed71d3af6c57b551f7fc757ea57a92503cc5cca89556872b13159bf13dfaef06b868dd51e09
+  data.tar.gz: 28ad95acd3dcba5b2b94577a6b8355bd4d78b044cd96c7c608a9ece82a89bd4c0792143503b29d4a3ca81a0b0c71fb57427c3c1ca684a0ba31cbc0a5cb4f541b

data/README.md

@@ -21,6 +21,15 @@ metadata:
   owner: Team
 ```
 
+You can also define `owner` as a top-level key, e.g.
+```yml
+enforce_dependency: true
+enforce_privacy: true
+owner: Team
+```
+
+To do this, add `code_ownership` to the `require` key of your `packwerk.yml`. See https://github.com/Shopify/packwerk/blob/main/USAGE.md#loading-extensions for more information.
+
 ### Glob-Based Ownership
 In your team's configured YML (see [`code_teams`](https://github.com/rubyatscale/code_teams)), you can set `owned_globs` to be a glob of files your team owns. For example, in `my_team.yml`:
 ```yml

data/lib/code_ownership/private/ownership_mappers/package_ownership.rb

@@ -56,7 +56,7 @@ module CodeOwnership
 
         sig { params(package: Packs::Pack).returns(T.nilable(CodeTeams::Team)) }
         def owner_for_package(package)
-          raw_owner_value = package.metadata['owner']
+          raw_owner_value = package.raw_hash['owner'] || package.metadata['owner']
           return nil if !raw_owner_value
 
           Private.find_team!(

data/lib/code_ownership/private/permit_pack_owner_top_level_key.rb

@@ -0,0 +1,24 @@
+
+# typed: strict
+# frozen_string_literal: true
+
+require 'packwerk'
+
+module CodeOwnership
+  module Private
+    class PackOwnershipValidator
+      extend T::Sig
+      include Packwerk::Validator
+
+      sig { override.params(package_set: Packwerk::PackageSet, configuration: Packwerk::Configuration).returns(Result) }
+      def call(package_set, configuration)
+        Result.new(ok: true)
+      end
+
+      sig { override.returns(T::Array[String]) }
+      def permitted_keys
+        %w[owner]
+      end
+    end
+  end
+end

data/lib/code_ownership/private.rb

@@ -70,6 +70,8 @@ module CodeOwnership
       else
         nil
       end
+    rescue NameError
+      nil
     end
 
     #

data/lib/code_ownership.rb

@@ -13,6 +13,10 @@ require 'code_ownership/private'
 require 'code_ownership/cli'
 require 'code_ownership/configuration'
 
+if defined?(Packwerk)
+  require 'code_ownership/private/permit_pack_owner_top_level_key'
+end
+
 module CodeOwnership
   extend self
   extend T::Sig

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: code_ownership
 version: !ruby/object:Gem::Version
-  version: 1.32.19
+  version: 1.33.1
 platform: ruby
 authors:
 - Gusto Engineers
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2023-05-15 00:00:00.000000000 Z
+date: 2023-06-30 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: code_teams
@@ -122,6 +122,34 @@ dependencies:
     - - ">="
       - !ruby/object:Gem::Version
         version: '0'
+- !ruby/object:Gem::Dependency
+  name: packwerk
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: '0'
+  type: :development
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: '0'
+- !ruby/object:Gem::Dependency
+  name: railties
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: '0'
+  type: :development
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: '0'
 description: A gem to help engineering teams declare ownership of code
 email:
 - dev@gusto.com
@@ -146,6 +174,7 @@ files:
 - lib/code_ownership/private/ownership_mappers/team_globs.rb
 - lib/code_ownership/private/ownership_mappers/team_yml_ownership.rb
 - lib/code_ownership/private/parse_js_packages.rb
+- lib/code_ownership/private/permit_pack_owner_top_level_key.rb
 - lib/code_ownership/private/team_plugins/github.rb
 - lib/code_ownership/private/team_plugins/ownership.rb
 - lib/code_ownership/private/validations/files_have_owners.rb