code_ownership 1.32.16 → 1.32.18

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 7a5c5f4a43ef44ffca514c001aa9eae7042bcdf445913afaa15adf40520e1d6d
-  data.tar.gz: e6cb1255f18886edabdd09086ed86d616742b9683311b657e7ba4c418baff443
+  metadata.gz: f00d3f6cebe0c0c1a832fe6bd5487b39edb84a0cb316ecbcea33bbf2b090d9bd
+  data.tar.gz: 6092a31cf222e8b734f19338d612ac1b08c121c20dbc822b1271e97ab11980c0
 SHA512:
-  metadata.gz: ede48eace0e4e7096671816ba0c1264fad5d3ea465ba5473a5724da95623e4982e5058b81f8eca0df39602889d88a3ea041cdb12fbb0a9e489b029fe32fa8579
-  data.tar.gz: 55c7bd2a181710065712eb211b969dbefbfb9d83daedbfec324816cc8aae38fd1161ddde6b049370866a00d75b6a4df5d374629a5a619cabbb8f8e1e8b511182
+  metadata.gz: 054d5179ae0516d621f71e222308c28c769dfcfe1fd66595ddbe23f6f18126bbfc683ef9a6882a67e8599e88b5fd6800eb95c8f1b55e80c66a13bd8c13a245ba
+  data.tar.gz: a1bcaa5dce9cb34158ce59d73b17d7cdc1494502ca802aa01b5bc3f5af507fd8187b5561e8b26f24151ec1e72eeee24a12c4b314f853af4a0f9230530e6d500d

data/README.md

@@ -96,7 +96,7 @@ See `code_ownership_spec.rb` for an example.
 `CodeOwnership.for_class` can be given a class and will either return `nil`, or a `CodeTeams::Team`.
 
 ```ruby
-CodeOwnership.for_class(MyClass.name)
+CodeOwnership.for_class(MyClass)
 ```
 
 Under the hood, this finds the file where the class is defined and returns the owner of that file.

data/lib/code_ownership/mapper.rb

@@ -12,16 +12,16 @@ module CodeOwnership
     class << self
       extend T::Sig
 
-      sig { params(base: Class).void }
+      sig { params(base: T::Class[Mapper]).void }
       def included(base)
-        @mappers ||= T.let(@mappers, T.nilable(T::Array[Class]))
+        @mappers ||= T.let(@mappers, T.nilable(T::Array[T::Class[Mapper]]))
         @mappers ||= []
         @mappers << base
       end
 
       sig { returns(T::Array[Mapper]) }
       def all
-        T.unsafe(@mappers).map(&:new)
+        (@mappers || []).map(&:new)
       end
     end
 

data/lib/code_ownership/private/ownership_mappers/file_annotations.rb

@@ -49,6 +49,7 @@ module CodeOwnership
         def update_cache(cache, files)
           # We map files to nil owners so that files whose annotation have been removed will be properly
           # overwritten (i.e. removed) from the cache.
+          fileset = Set.new(files)
           updated_cache_for_files = globs_to_owner(files)
           cache.merge!(updated_cache_for_files)
 
@@ -57,7 +58,8 @@ module CodeOwnership
             !Private.file_tracked?(file) ||
             # If a file no longer has a file annotation (i.e. `globs_to_owner` doesn't map it)
             # it should be removed from the cache
-            !updated_cache_for_files.key?(file)
+            # We make sure to only apply this to the input files since otherwise `updated_cache_for_files.key?(file)` would always return `false` when files == []
+            (fileset.include?(file) && !updated_cache_for_files.key?(file))
           end
 
           invalid_files.each do |invalid_file|

data/lib/code_ownership/validator.rb

@@ -14,16 +14,16 @@ module CodeOwnership
     class << self
       extend T::Sig
 
-      sig { params(base: Class).void }
+      sig { params(base: T::Class[Validator]).void }
       def included(base)
-        @validators ||= T.let(@validators, T.nilable(T::Array[Class]))
+        @validators ||= T.let(@validators, T.nilable(T::Array[T::Class[Validator]]))
         @validators ||= []
         @validators << base
       end
 
       sig { returns(T::Array[Validator]) }
       def all
-        T.unsafe(@validators).map(&:new)
+        (@validators || []).map(&:new)
       end
     end
   end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: code_ownership
 version: !ruby/object:Gem::Version
-  version: 1.32.16
+  version: 1.32.18
 platform: ruby
 authors:
 - Gusto Engineers
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2023-04-21 00:00:00.000000000 Z
+date: 2023-05-12 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: code_teams
@@ -44,14 +44,14 @@ dependencies:
     requirements:
     - - ">="
       - !ruby/object:Gem::Version
-        version: '0'
+        version: 0.5.10821
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - ">="
       - !ruby/object:Gem::Version
-        version: '0'
+        version: 0.5.10821
 - !ruby/object:Gem::Dependency
   name: pry
   requirement: !ruby/object:Gem::Requirement