code_ownership 1.32.10 → 1.32.12

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: e0713332aa7dacd9ec6f097bba250555cb25208f594fd08bfba4a4ecf951d06b
-  data.tar.gz: aa039e732cfa8aad7a16439bc2608f51c043eef2f9b642513a7616b95b319c01
+  metadata.gz: b1b8e7ef51559926e34ee47610390c8f5db30d4db7f4cdcfc2abd84381b49130
+  data.tar.gz: cf479183e50a26c9a19f37b8160c14ad0ab81f5f0c2906b4cefa4f45e19aad76
 SHA512:
-  metadata.gz: 1c7b7a855b051aa6c856f39144e17484180fa6ff530ec7af3b7870ebf4cbf61b5b33c1a17d2402a319d784a7a17d7b226b64542c65a002707bb87419e1a660dd
-  data.tar.gz: b91f701455620e4fe27f2a99b20b58f6b03d78fa04d66548d3f85b1e4202cdf9c09ec2b53a454a3bca419d33b65150c5c24977e9eca93efc102c25e36df21303
+  metadata.gz: 37d5cd46fda60ec57244bc2b654dd81ea3bbd48c47cb3008804dbdb48249ae7c9a2163f9d2776bdc08989aaa945f3e8f2718784a27009b578b131cf9259307e3
+  data.tar.gz: a89b8b30f8acb6f82c6727ede45e3c372cdca5204343e155a2d4300c221fc50ab1feea708afdee8a123601078979e6accfbfec5d4381af2bf67a684db938fda8

data/lib/code_ownership/mapper.rb

@@ -68,9 +68,10 @@ module CodeOwnership
 
       Mapper.all.each do |mapper|
         mapped_files = mapper.globs_to_owner(Private.tracked_files)
+        glob_to_owner_map_by_mapper_description[mapper.description] ||= {}
+
         mapped_files.each do |glob, owner|
           next if owner.nil?
-          glob_to_owner_map_by_mapper_description[mapper.description] ||= {}
           glob_to_owner_map_by_mapper_description.fetch(mapper.description)[glob] = owner
         end
       end

data/lib/code_ownership/private/codeowners_file.rb

@@ -135,6 +135,12 @@ module CodeOwnership
             # This will skip over lines that are not of the correct form
             next if split_line.count > 2
             entry, github_team = split_line
+            code_team = github_team_to_code_team_map[T.must(github_team)]
+            # If a GitHub team is changed and a user runs `bin/codeownership validate`, we won't be able to identify
+            # what team is associated with the removed github team.
+            # Therefore, if we can't determine the team, we just skip it.
+            # This affects how complete the cache is, but that will still be caught by `bin/codeownership validate`.
+            next if code_team.nil?
             raw_cache_contents[current_mapper] ||= {}
             raw_cache_contents.fetch(current_mapper)[T.must(entry)] = github_team_to_code_team_map.fetch(T.must(github_team))
           end

data/lib/code_ownership.rb

@@ -43,27 +43,23 @@ module CodeOwnership
 
   sig { params(team: T.any(CodeTeams::Team, String)).returns(String) }
   def for_team(team)
-    Private.load_configuration!
-
     team = T.must(CodeTeams.find(team)) if team.is_a?(String)
     ownership_information = T.let([], T::Array[String])
 
     ownership_information << "# Code Ownership Report for `#{team.name}` Team"
-    Mapper.all.each do |mapper|
-      ownership_information << "## #{mapper.description}"
-      codeowners_lines = mapper.globs_to_owner(Private.tracked_files)
+
+    Private.glob_cache.raw_cache_contents.each do |mapper_description, glob_to_owning_team_map|
+      ownership_information << "## #{mapper_description}"
       ownership_for_mapper = []
-      codeowners_lines.each do |line, team_for_line|
-        next if team_for_line.nil?
-        if team_for_line.name == team.name
-          ownership_for_mapper << "- #{line}"
-        end
+      glob_to_owning_team_map.each do |glob, owning_team|
+        next if owning_team != team
+        ownership_for_mapper << "- #{glob}"
       end
 
       if ownership_for_mapper.empty?
         ownership_information << 'This team owns nothing in this category.'
       else
-        ownership_information += ownership_for_mapper
+        ownership_information += ownership_for_mapper.sort
       end
 
       ownership_information << ""

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: code_ownership
 version: !ruby/object:Gem::Version
-  version: 1.32.10
+  version: 1.32.12
 platform: ruby
 authors:
 - Gusto Engineers
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2023-04-12 00:00:00.000000000 Z
+date: 2023-04-13 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: code_teams