code_ownership 1.32.0 → 1.32.2

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 62401f4e5d0f4c94669144b049a2e47f0f436b0dec4977db339827aa2378afb6
-  data.tar.gz: be8561814a7c648b659b15fbe5c860edd409d3aa5aef91c1818820d447537a57
+  metadata.gz: 32fde48e3bfda45fef25ea894835a45548aac619699a8c56549000ca373916b5
+  data.tar.gz: e9155c7e859a17a8d31bc0f092822bd161f65a965b356060295be61ee695858b
 SHA512:
-  metadata.gz: d75fed2acaf64ba6ae82b7692531ad3d4629745d48a5567cfe954851d0edcd623b619be3d2a0f89f52e01125029bb01f5c1983bc39e4294640410f3d52229bd5
-  data.tar.gz: 290e5caeef1ed81b45a048d55800ee1d2772418d25ff749fc3dab33eef3f85190e294b4e0d7082f51ac2590df458011b5a859ea2faddfc96eec9d238163bb3a6
+  metadata.gz: d407ad1c1437c75b7ee9b5df5e22bfe74d90b5e353f62546879fdaf09b7be6d9bbb4c67f70fe0721d55729215377f407f03a83bb094f0fd8d24ad209cbd65957
+  data.tar.gz: dcef3ed24a4af4825a3f8320bcd704885dee0f4f65d7db08515844a67a094dca32f06024275a4d4361908f85f5cbbbdffb27e53c79efab1c384cd1348bb642db

data/lib/code_ownership/private.rb

@@ -25,6 +25,14 @@ module CodeOwnership
       @configuration ||= Configuration.fetch
     end
 
+    # This is just an alias for `configuration` that makes it more explicit what we're doing instead of just calling `configuration`.
+    # This is necessary because configuration may contain extensions of code ownership, so those extensions should be loaded prior to
+    # calling APIs that provide ownership information.
+    sig { returns(Configuration) }
+    def self.load_configuration!
+      configuration
+    end
+
     sig { void }
     def self.bust_caches!
       @configuration = nil
@@ -50,10 +58,10 @@ module CodeOwnership
 
     # Returns a string version of the relative path to a Rails constant,
     # or nil if it can't find something
-    sig { params(klass: T.nilable(T.any(Class, Module))).returns(T.nilable(String)) }
-    def self.path_from_klass(klass)
-      if klass
-        path = Object.const_source_location(klass.to_s)&.first
+    sig { params(klass_string: T.nilable(String)).returns(T.nilable(String)) }
+    def self.path_from_klass_string(klass_string)
+      if klass_string
+        path = Object.const_source_location(klass_string)&.first
         (path && Pathname.new(path).relative_path_from(Pathname.pwd).to_s) || nil
       else
         nil

data/lib/code_ownership.rb

@@ -28,6 +28,8 @@ module CodeOwnership
     return nil if file.start_with?('./')
     return @for_file[file] if @for_file.key?(file)
 
+    Private.load_configuration!
+
     owner = T.let(nil, T.nilable(CodeTeams::Team))
 
     Mapper.all.each do |mapper|
@@ -40,6 +42,8 @@ module CodeOwnership
 
   sig { params(team: T.any(CodeTeams::Team, String)).returns(String) }
   def for_team(team)
+    Private.load_configuration!
+
     team = T.must(CodeTeams.find(team)) if team.is_a?(String)
     ownership_information = T.let([], T::Array[String])
 
@@ -87,6 +91,7 @@ module CodeOwnership
     autocorrect: true,
     stage_changes: true
   )
+    Private.load_configuration!
     tracked_file_subset = Private.tracked_files & files
     Private.validate!(files: tracked_file_subset, autocorrect: autocorrect, stage_changes: stage_changes)
   end
@@ -144,20 +149,23 @@ module CodeOwnership
   end
   private_class_method(:backtrace_with_ownership)
 
-  sig { params(klass: T.nilable(T.any(Class, Module))).returns(T.nilable(::CodeTeams::Team)) }
+  sig { params(klass: T.nilable(T.any(Class, Module, String))).returns(T.nilable(::CodeTeams::Team)) }
   def for_class(klass)
     @memoized_values ||= T.let(@memoized_values, T.nilable(T::Hash[String, T.nilable(::CodeTeams::Team)]))
     @memoized_values ||= {}
+
+    klass_string = klass.to_s
+
     # We use key because the memoized value could be `nil`
-    if !@memoized_values.key?(klass.to_s)
-      path = Private.path_from_klass(klass)
+    if !@memoized_values.key?(klass_string)
+      path = Private.path_from_klass_string(klass_string)
       return nil if path.nil?
 
       value_to_memoize = for_file(path)
-      @memoized_values[klass.to_s] = value_to_memoize
+      @memoized_values[klass_string] = value_to_memoize
       value_to_memoize
     else
-      @memoized_values[klass.to_s]
+      @memoized_values[klass_string]
     end
   end
 

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: code_ownership
 version: !ruby/object:Gem::Version
-  version: 1.32.0
+  version: 1.32.2
 platform: ruby
 authors:
 - Gusto Engineers
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2023-03-08 00:00:00.000000000 Z
+date: 2023-03-10 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: code_teams