code_ownership 1.28.0 → 1.28.2

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: d73cb8995d6430d05780252417863b38bd14a461bf8f3afe4b9724abb407efea
-  data.tar.gz: 7cc3c3c4a2968b8e3a265f990c28395b0c4e6163b7ba48ad2b0c8be64123990c
+  metadata.gz: bf48240fd31979132287823a3f9d40d6b03776df405583c31a56cb87e6dfbe40
+  data.tar.gz: 1cbd9b0fee826c7a23dd71335043eab358f99157bb7f677a94b8d4abc1782f4e
 SHA512:
-  metadata.gz: 6f2a2c2331aa980b414343e54429ba3ab367fa6a38cdad44811b84193afd8a6d3846baf77ae8b7cd78a2754b65865b5799644382ff5182ba0439bb3cb3884cf6
-  data.tar.gz: d0ecc33dd542a3dc606caceb52fb38ed32743a12076f5253b96a2c2c6b7fa24a0b1445df6d1a41878ef350a87fe5075cbb17ebc5bb3964211cbac18ee005bfd5
+  metadata.gz: 68721e648bcd3e8888f3f94d33baf0d38b642c3d6104db0964e6aff3194860407e72c9ad88ffec357285006bff87490b49b92a238fbbf83d37509d34868ea0fe
+  data.tar.gz: 0d878620986f0fe3e6168fa8ea0db1a1a530d27c0f35410f70b3f876146df2b184f9db3486ef9e4e74c0583a067b48ad4462af6877d7452e5d1574bec61ebd8f

data/README.md

@@ -1,14 +1,17 @@
 # CodeOwnership
-This gem helps engineering teams declare ownership of code.
 
-Check out `lib/code_ownership.rb` to see the public API.
+This gem helps engineering teams declare ownership of code. This gem works best in large, usually monolithic code bases where many teams work together.
 
-Check out `code_ownership_spec.rb` to see examples of how code ownership is used.
+Check out [`lib/code_ownership.rb`](https://github.com/rubyatscale/code_ownership/blob/main/lib/code_ownership.rb) to see the public API.
+
+Check out [`code_ownership_spec.rb`](https://github.com/rubyatscale/code_ownership/blob/main/spec/lib/code_ownership_spec.rb) to see examples of how code ownership is used.
 
 There is also a [companion VSCode Extension]([url](https://github.com/rubyatscale/code-ownership-vscode)) for this gem. Just search `Gusto.code-ownership-vscode` in the VSCode Extension Marketplace.
 
 ## Usage: Declaring Ownership
+
 There are three ways to declare code ownership using this gem.
+
 ### Package-Based Ownership
 Package based ownership integrates [`packwerk`](https://github.com/Shopify/packwerk) and has ownership defined per package. To define that all files within a package are owned by one team, configure your `package.yml` like this:
 ```yml
@@ -31,6 +34,29 @@ File annotations are a last resort if there is no clear home for your code. File
 ```ruby
 # @team MyTeam
 ```
+
+### Javascript Package Ownership
+Javascript package based ownership allows you to specify an owenrship key in a `package.json`. To use this, configure your `package.json` like this:
+
+```json
+{
+  // other keys
+  "metadata": {
+    "owner": "My Team"
+  }
+  // other keys
+}
+```
+
+You can also tell `code_ownership` where to find JS packages in the configuration, like this:
+```yml
+js_package_paths:
+  - frontend/javascripts/packages/*
+  - frontend/other_location_for_packages/*
+```
+
+This defaults `**/`, which makes it look for `package.json` files across your application.
+
 ## Usage: Reading CodeOwnership
 ### `for_file`
 `CodeOwnership.for_file`, given a relative path to a file returns a `CodeTeams::Team` if there is a team that owns the file, `nil` otherwise.
@@ -71,7 +97,9 @@ See `code_ownership_spec.rb` for an example.
 A `CODEOWNERS` file defines who owns specific files or paths in a repository. When you run `bin/codeownership validate`, a `.github/CODEOWNERS` file will automatically be generated and updated.
 
 ## Proper Configuration & Validation
+
 CodeOwnership comes with a validation function to ensure the following things are true:
+
 1) Only one mechanism is defining file ownership. That is -- you can't have a file annotation on a file owned via package-based or glob-based ownership. This helps make ownership behavior more clear by avoiding concerns about precedence.
 2) All teams referenced as an owner for any file or package is a valid team (i.e. it's in the list of `CodeTeams.all`).
 3) All files have ownership. You can specify in `unowned_globs` to represent a TODO list of files to add ownership to.

data/lib/code_ownership/private/ownership_mappers/package_ownership.rb

@@ -16,7 +16,7 @@ module CodeOwnership
             returns(T.nilable(::CodeTeams::Team))
         end
         def map_file_to_owner(file)
-          package = map_file_to_relevant_package(file)
+          package = ParsePackwerk.package_from_path(file)
 
           return nil if package.nil?
 
@@ -80,41 +80,6 @@ module CodeOwnership
         def bust_caches!
           @@package_yml_cache = {} # rubocop:disable Style/ClassVars
         end
-
-        private
-
-        # takes a file and finds the relevant `package.yml` file by walking up the directory
-        # structure. Example, given `packs/a/b/c.rb`, this looks for `packs/a/b/package.yml`, `packs/a/package.yml`,
-        # `packs/package.yml`, and `package.yml` in that order, stopping at the first file to actually exist.
-        # We do additional caching so that we don't have to check for file existence every time
-        sig { params(file: String).returns(T.nilable(ParsePackwerk::Package)) }
-        def map_file_to_relevant_package(file)
-          file_path = Pathname.new(file)
-          path_components = file_path.each_filename.to_a.map { |path| Pathname.new(path) }
-
-          (path_components.length - 1).downto(0).each do |i|
-            potential_relative_path_name = T.must(path_components[0...i]).reduce(Pathname.new('')) { |built_path, path| built_path.join(path) }
-            potential_package_yml_path = potential_relative_path_name.
-              join(ParsePackwerk::PACKAGE_YML_NAME)
-
-            potential_package_yml_string = potential_package_yml_path.to_s
-
-            package = nil
-            if @@package_yml_cache.key?(potential_package_yml_string)
-              package = @@package_yml_cache[potential_package_yml_string]
-            elsif potential_package_yml_path.exist?
-              package = ParsePackwerk::Package.from(potential_package_yml_path)
-
-              @@package_yml_cache[potential_package_yml_string] = package
-            else
-              @@package_yml_cache[potential_package_yml_string] = nil
-            end
-
-            return package unless package.nil?
-          end
-
-          nil
-        end
       end
     end
   end

data/lib/code_ownership/private/parse_js_packages.rb

@@ -32,6 +32,16 @@ module CodeOwnership
             name: package_name,
             metadata: package_loaded_json[METADATA] || {}
           )
+        rescue JSON::ParserError => e
+          error_message = <<~MESSAGE
+            #{e.inspect}
+
+            #{pathname} has invalid JSON, so code ownership cannot be determined.
+
+            Please either make the JSON in that file valid or specify `js_package_paths` in config/code_ownership.yml.
+          MESSAGE
+
+          raise InvalidCodeOwnershipConfigurationError.new(error_message)
         end
 
         sig { returns(Pathname) }

data/sorbet/rbi/gems/{parse_packwerk@0.7.0.rbi → parse_packwerk@0.12.0.rbi}

@@ -6,12 +6,18 @@
 
 module ParsePackwerk
   class << self
-    sig { params(package_yml_pathnames: T.nilable(T::Array[::Pathname])).returns(T::Array[::ParsePackwerk::Package]) }
-    def all(package_yml_pathnames: T.unsafe(nil)); end
+    sig { returns(T::Array[::ParsePackwerk::Package]) }
+    def all; end
+
+    sig { void }
+    def bust_cache!; end
 
     sig { params(name: ::String).returns(T.nilable(::ParsePackwerk::Package)) }
     def find(name); end
 
+    sig { params(file_path: T.any(::Pathname, ::String)).returns(T.nilable(::ParsePackwerk::Package)) }
+    def package_from_path(file_path); end
+
     sig { params(package: ::ParsePackwerk::Package).void }
     def write_package_yml!(package); end
 
@@ -27,12 +33,24 @@ end
 
 class ParsePackwerk::Configuration < ::T::Struct
   const :exclude, T::Array[::String]
+  const :package_paths, T::Array[::String]
 
   class << self
+    sig { params(config_hash: T::Hash[T.untyped, T.untyped]).returns(T::Array[::String]) }
+    def excludes(config_hash); end
+
+    sig { returns(::ParsePackwerk::Configuration) }
+    def fetch; end
+
     def inherited(s); end
+
+    sig { params(config_hash: T::Hash[T.untyped, T.untyped]).returns(T::Array[::String]) }
+    def package_paths(config_hash); end
   end
 end
 
+ParsePackwerk::DEFAULT_EXCLUDE_GLOBS = T.let(T.unsafe(nil), Array)
+ParsePackwerk::DEFAULT_PACKAGE_PATHS = T.let(T.unsafe(nil), Array)
 ParsePackwerk::DEPENDENCIES = T.let(T.unsafe(nil), String)
 ParsePackwerk::DEPRECATED_REFERENCES_YML_NAME = T.let(T.unsafe(nil), String)
 
@@ -91,6 +109,23 @@ class ParsePackwerk::Package < ::T::Struct
   end
 end
 
+class ParsePackwerk::PackageSet
+  class << self
+    sig do
+      params(
+        package_pathspec: T::Array[::String],
+        exclude_pathspec: T::Array[::String]
+      ).returns(T::Array[::ParsePackwerk::Package])
+    end
+    def from(package_pathspec:, exclude_pathspec:); end
+
+    private
+
+    sig { params(globs: T::Array[::String], path: ::Pathname).returns(T::Boolean) }
+    def exclude_path?(globs, path); end
+  end
+end
+
 ParsePackwerk::ROOT_PACKAGE_NAME = T.let(T.unsafe(nil), String)
 
 class ParsePackwerk::Violation < ::T::Struct

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: code_ownership
 version: !ruby/object:Gem::Version
-  version: 1.28.0
+  version: 1.28.2
 platform: ruby
 authors:
 - Gusto Engineers
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2022-06-14 00:00:00.000000000 Z
+date: 2022-08-18 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: code_teams
@@ -150,7 +150,7 @@ files:
 - lib/code_ownership/private/validations/interface.rb
 - sorbet/config
 - sorbet/rbi/gems/code_teams@1.0.0.rbi
-- sorbet/rbi/gems/parse_packwerk@0.7.0.rbi
+- sorbet/rbi/gems/parse_packwerk@0.12.0.rbi
 - sorbet/rbi/manual.rbi
 - sorbet/rbi/todo.rbi
 homepage: https://github.com/rubyatscale/code_ownership