code_owners 1.0.8 → 1.0.9

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 0c170835202aa29d1d863ac544a039dfa2aaca9b
-  data.tar.gz: 732f6a87815efa4092ea1404b55180d9bde78f39
+  metadata.gz: add8d9474667ea07ea6ad3e207e9a0e085109ac9
+  data.tar.gz: 86f55b021ef6314614ac2e5f2a59dfec43adbcd1
 SHA512:
-  metadata.gz: b205789714617196c0e067504e8beae29dc585a6601a79279475a3a17cc36b249d61e896c6972d8d2fc2b4780e5df406a86c92226ef6013fd6fb262087733ae6
-  data.tar.gz: 4e7766d5ee8b1adf676974e8dce8345ce93d2b4b9e868d4295578d35b5656897621c0dcf00e227377024946e2d7429c695e2bf86539fbd24a5992fdce2c9e4fd
+  metadata.gz: 6bc09a62ef1d0b86e7a9be070b27c5ed0e21be5b797f29b2597b3c06ffecc8210fd50906319f67028bc8e8a4df3aa2b575ab5ae49a083f2af029f43182d9d074
+  data.tar.gz: 62e13f5c44667eff192eabb510dca677a2088e58ce123e3dbaf4ccd16c8ebf9eb1dffa8125d5524161de36df730b9eea83093776ea6a55fb40c72df6f741eec3

data/Gemfile.lock

@@ -1,7 +1,7 @@
 PATH
   remote: .
   specs:
-    code_owners (1.0.8)
+    code_owners (1.0.9)
       rake
 
 GEM

data/lib/code_owners/version.rb

@@ -1,3 +1,3 @@
 module CodeOwners
-  VERSION = "1.0.8"
+  VERSION = "1.0.9"
 end

data/lib/code_owners.rb

@@ -19,6 +19,10 @@ module CodeOwners
       puts message
     end
 
+    def file_ownerships
+      Hash[ ownerships.map { |o| [o[:file], o] } ]
+    end
+
     def ownerships
       patterns = pattern_owners
       git_owner_info(patterns.map { |p| p[0] }).map do |line, pattern, file|
@@ -77,7 +81,7 @@ module CodeOwners
       Tempfile.open('codeowner_patterns') do |file|
         file.write(patterns.join("\n"))
         file.rewind
-        `cd #{current_repo_path} && git -c \"core.quotepath=off\" ls-files | xargs -- git -c \"core.quotepath=off\" -c \"core.excludesfile=#{file.path}\" check-ignore --no-index -v -n`
+        `cd #{current_repo_path} && git -c \"core.quotepath=off\" ls-files -z | xargs -0 -- git -c \"core.quotepath=off\" -c \"core.excludesfile=#{file.path}\" check-ignore --no-index -v -n`
       end
     end
 

data/spec/code_owners_spec.rb

@@ -2,6 +2,23 @@ require 'code_owners'
 require 'tmpdir'
 
 RSpec.describe CodeOwners do |rspec|
+  describe ".file_ownerships" do
+    it "returns a hash of ownerships keyed by file path" do
+      expect(CodeOwners).to receive(:ownerships).and_return(
+        [
+          { file: "pat2file", owner: "own2", line: "2", pattern: "pat2*" },
+          { file: "unowned/file", owner: "UNOWNED", line: nil, pattern: nil }
+        ]
+      )
+      expect(CodeOwners.file_ownerships).to eq(
+        {
+          "pat2file" => { file: "pat2file", owner: "own2", line: "2", pattern: "pat2*" },
+          "unowned/file" => { file: "unowned/file", owner: "UNOWNED", line: nil, pattern: nil }
+        }
+      )
+    end
+  end
+
   describe ".ownerships" do
     it "assigns owners to things" do
       expect(CodeOwners).to receive(:pattern_owners).and_return([["pat1", "own1"], ["pat2*", "own2"], ["pat3", "own3"]])
@@ -29,7 +46,7 @@ RSpec.describe CodeOwners do |rspec|
 lib/* @jcheatham
 some/path/** @someoneelse
 other/path/* @someoneelse @anotherperson
-invalid/codeowners/line 
+invalid/code owners/line
      @AnotherInvalidLine
 #comment-line (empty line next)
 
@@ -60,7 +77,7 @@ CODEOWNERS
 
     it "prints validation errors and skips lines that aren't the expected format" do
       expect(CodeOwners).to receive(:current_repo_path).and_return(@d)
-      expect(CodeOwners).to receive(:log).with("Parse error line 4: \"invalid/codeowners/line \"")
+      expect(CodeOwners).to receive(:log).with("Parse error line 4: \"invalid/code owners/line\"")
       expect(CodeOwners).to receive(:log).with("Parse error line 5: \"     @AnotherInvalidLine\"")
       pattern_owners = CodeOwners.pattern_owners
       expect(pattern_owners).not_to include(["", "@AnotherInvalidLine"])
@@ -86,6 +103,13 @@ CODEOWNERS
       expect(raw_ownership.size).to be >= 1
       expect(raw_ownership).to match(/^(?:.*:\d*:.*\t.*\n)+$/)
     end
+
+    context "when path includes a space" do
+      it "returns the path in single line" do
+        raw_ownership = CodeOwners.raw_git_owner_info(["/spec/files/*"])
+        expect(raw_ownership).to match(/.+:\d+:.+\tspec\/files\/file name\.txt\n/)
+      end
+    end
   end
 
   describe "code_owners" do

data/spec/files/file name.txt

@@ -0,0 +1 @@
+This file's name includes a space.

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: code_owners
 version: !ruby/object:Gem::Version
-  version: 1.0.8
+  version: 1.0.9
 platform: ruby
 authors:
 - Jonathan Cheatham
@@ -57,6 +57,7 @@ files:
 - lib/code_owners.rb
 - lib/code_owners/version.rb
 - spec/code_owners_spec.rb
+- spec/files/file name.txt
 - spec/files/☃.txt
 homepage: https://github.com/jcheatham/code_owners
 licenses:
@@ -78,7 +79,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
       version: '0'
 requirements: []
 rubyforge_project:
-rubygems_version: 2.5.2.3
+rubygems_version: 2.6.14.4
 signing_key:
 specification_version: 4
 summary: ".github/CODEOWNERS introspection utility gem"