code_driven_development 0.0.4 → 0.0.5

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 546316dbe66b0a333a9dd89b55222bacd74e502b
-  data.tar.gz: 07c3576f12dc0b9667ed79145994e55c5dc344d3
+  metadata.gz: 9038114a834973a515c4328adb8cf027fcab116a
+  data.tar.gz: a5092ebdb605227e0f1262833289d0e08b01fc99
 SHA512:
-  metadata.gz: 01bc5e3a0b27dcc595473b5bb8312f538c785c1e33efa341e12b7c85f25514ff83e11eded00b194031f6006298f3df764e8b2b316c59542db03e6b9f154af936
-  data.tar.gz: a023a61a8c1ecd86ae3c5e5e353902b53ce51da33e98af64ca36c759d993d9e2c1baddd6b366e3c8e6123aa1875fe7aeb48c3db98db47ccf6c1cb6ec4fe5029f
+  metadata.gz: 32b147b182e1f910937102822813e4ed2d6812e34fd89408fda80422da7744e16a32384000f71cec2742eae1907ec166290d4a9bc2ca3328835a2bc73ce24669
+  data.tar.gz: 7e0d462f9ac49184b3491c8940fe61bd800d0ba0e57a2af3721b9dc75fbbf19ef5a1d6df85bd759e0b424498d36e5bc64bc95438d9709be5bdff589e9d0610de

data/README.md

@@ -9,6 +9,7 @@ class Bunker < ActiveRecord::Base
   validate :location, :protected => true
 
   def alert_staff
+    staph.all_alert
     Staff.alert_all
   end
 
@@ -27,9 +28,19 @@ describe Bunker do
   it { should validate_protected_of :location }
   describe "#alert_staff" do
     let(:obj) { described_class.new }
+    let(:all_alert) { double(:all_alert) }
+    let(:staph) { double(:staph) }
+    let(:alert_all) { double(:alert_all) }
     subject { obj.alert_staff }
     before do
-      allow(Staff).to receive :alert_all
+      allow(staph).to receive(:all_alert).and_return(all_alert)
+      allow(obj).to receive(:staph).and_return(staph)
+      allow(Staff).to receive(:alert_all).and_return(alert_all)
+    end
+    it "calls staph.all_alert" do
+      subject
+      expect(staph).to have_received :all_alert
+      expect(obj).to have_received :staph
     end
     it "calls Staff.alert_all" do
       subject
@@ -38,9 +49,10 @@ describe Bunker do
   end
   describe "#alert_president" do
     let(:obj) { described_class.new }
+    let(:stand_down) { double(:stand_down) }
     subject { obj.alert_president }
     before do
-      allow(SecretService).to receive :stand_down
+      allow(SecretService).to receive(:stand_down).and_return(stand_down)
     end
     it "calls SecretService.stand_down" do
       subject

data/Rakefile

@@ -1,8 +1,10 @@
 $:.unshift(File.dirname(__FILE__) + '/../../lib')
 
-require "bundler/gem_tasks"
+require 'bundler/gem_tasks'
 require 'cucumber/rake/task'
+require 'rspec/core/rake_task'
 
+RSpec::Core::RakeTask.new(:spec)
 Cucumber::Rake::Task.new
 
-task default: :cucumber
+task default: [:spec, :cucumber]

data/bin/cdd

@@ -1,4 +1,13 @@
 #!/usr/bin/env ruby
 
-require 'code_driven_development'
-puts CodeDrivenDevelopment::CodeDrivenDevelopment.new(ARGF.read).test_code.strip
+require_relative '../lib/code_driven_development'
+
+
+output = CodeDrivenDevelopment::CodeDrivenDevelopment.new(ARGF.read).test_code.strip
+
+if STDOUT.tty?
+  require 'coderay'
+  puts CodeRay.scan(output, :ruby).term
+else
+  puts output
+end

data/code_driven_development.gemspec

@@ -19,6 +19,8 @@ Gem::Specification.new do |spec|
   spec.require_paths = ["lib"]
 
   spec.add_dependency "ruby_parser"
+  spec.add_dependency "require_all"
+  spec.add_dependency "coderay"
 
   spec.add_development_dependency "bundler", "~> 1.3"
   spec.add_development_dependency "rake"

data/features/my_feature.feature

@@ -30,9 +30,10 @@ Feature: Creates awesome specs
       """ruby
         describe "#i_call_things" do
           let(:obj) { described_class.new }
+          let(:file_report) { double(:file_report) }
           subject { obj.i_call_things }
           before do
-            allow(CentralBureaucracy).to receive :file_report
+            allow(CentralBureaucracy).to receive(:file_report).and_return(file_report)
           end
           it "calls CentralBureaucracy.file_report" do
             subject
@@ -46,7 +47,7 @@ Feature: Creates awesome specs
       """ruby
       class Lolcat
         def i_call_instance_methods
-          meth
+          meth.is_bad_for_you
         end
       end
       """
@@ -56,13 +57,17 @@ Feature: Creates awesome specs
       """ruby
         describe "#i_call_instance_methods" do
           let(:obj) { described_class.new }
+          let(:meth) { double(:meth) }
+          let(:is_bad_for_you) { double(:is_bad_for_you) }
           subject { obj.i_call_instance_methods }
           before do
-            allow(obj).to receive :meth
+            allow(obj).to receive(:meth).and_return(meth)
+            allow(meth).to receive(:is_bad_for_you).and_return(is_bad_for_you)
           end
-          it "calls #meth" do
+          it "calls meth.is_bad_for_you" do
             subject
             expect(obj).to have_received :meth
+            expect(meth).to have_received :is_bad_for_you
           end
         end
       """

data/lib/code_driven_development.rb

@@ -1,21 +1,4 @@
 require 'ruby_parser'
+require 'require_all'
 
-require "code_driven_development/version"
-require "code_driven_development/code_driven_development"
-require "code_driven_development/indented_output"
-
-require "code_driven_development/test_component/test"
-require "code_driven_development/test_component/one_line_test"
-require "code_driven_development/test_component/context"
-require "code_driven_development/test_component/blank_slate"
-require "code_driven_development/test_component/let"
-
-require "code_driven_development/rule/abstract_rule"
-require "code_driven_development/rule/set"
-require "code_driven_development/rule/constant_method_call"
-require "code_driven_development/rule/instance_method_call"
-require "code_driven_development/rule/default"
-require "code_driven_development/rule/boolean_or"
-require "code_driven_development/rule/class"
-require "code_driven_development/rule/validation"
-require "code_driven_development/rule/instance_method"
+require_rel "code_driven_development"

data/lib/code_driven_development/code_driven_development.rb

@@ -23,8 +23,7 @@ module CodeDrivenDevelopment
         Rule::Class,
         Rule::Validation,
         Rule::InstanceMethod,
-        Rule::ConstantMethodCall,
-        Rule::InstanceMethodCall,
+        Rule::MethodCall,
         Rule::BooleanOr,
         default: Rule::Default
       )

data/lib/code_driven_development/rule/method_call.rb

@@ -0,0 +1,22 @@
+module CodeDrivenDevelopment
+  module Rule
+    class MethodCall < AbstractRule
+      def capable?
+        code.sexp_type == :call &&
+          stubber.method_name != :validate
+      end
+
+      def test
+        test_context.doubles.concat(stubber.doubles.map { |sym| TestComponent::Double.new(sym) })
+        test_context.befores.concat(stubber.befores)
+        test_context << TestComponent::Test.new("calls #{stubber.human_name}", ["subject"] + stubber.body)
+      end
+
+      private
+
+      def stubber
+        @stubber ||= Stubber::Stubber.new(code)
+      end
+    end
+  end
+end

data/lib/code_driven_development/stubber/abstract_stubber.rb

@@ -0,0 +1,39 @@
+module CodeDrivenDevelopment
+  module Stubber
+    class AbstractStubber
+      def initialize(sexp)
+        @sexp = sexp
+      end
+
+      def method_name
+        sexp[2]
+      end
+
+      def befores
+        [
+          "allow(#{receiver_value}).to receive(:#{method_name}).and_return(#{method_name})"
+        ]
+      end
+
+      def doubles
+        [
+          method_name.to_sym
+        ]
+      end
+
+      def body
+        [
+          "expect(#{receiver_value}).to have_received :#{method_name}"
+        ]
+      end
+
+      private
+
+      attr_reader :sexp
+
+      def receiver
+        sexp[1]
+      end
+    end
+  end
+end

data/lib/code_driven_development/stubber/const_stubber.rb

@@ -0,0 +1,13 @@
+module CodeDrivenDevelopment
+  module Stubber
+    class ConstStubber < AbstractStubber
+      def receiver_value
+        receiver.value
+      end
+
+      def human_name
+        "#{receiver_value}.#{method_name}"
+      end
+    end
+  end
+end

data/lib/code_driven_development/stubber/instance_method_stubber.rb

@@ -0,0 +1,13 @@
+module CodeDrivenDevelopment
+  module Stubber
+    class InstanceMethodStubber < AbstractStubber
+      def receiver_value
+        "obj"
+      end
+
+      def human_name
+        method_name.to_s
+      end
+    end
+  end
+end

data/lib/code_driven_development/stubber/nested_call_stubber.rb

@@ -0,0 +1,31 @@
+module CodeDrivenDevelopment
+  module Stubber
+    class NestedCallStubber < AbstractStubber
+      def receiver_value
+        receiver[2]
+      end
+
+      def human_name
+        "#{substubber.human_name}.#{method_name}"
+      end
+
+      def befores
+        substubber.befores << "allow(#{substubber.method_name}).to receive(:#{method_name}).and_return(#{method_name})"
+      end
+
+      def body
+        substubber.body << "expect(#{substubber.method_name}).to have_received :#{method_name}"
+      end
+
+      def doubles
+        substubber.doubles << method_name.to_sym
+      end
+
+      private
+
+      def substubber
+        @substubber ||= Stubber.new(receiver)
+      end
+    end
+  end
+end

data/lib/code_driven_development/stubber/stubber.rb

@@ -0,0 +1,22 @@
+module CodeDrivenDevelopment
+  module Stubber
+    class Stubber
+      def self.new(sexp)
+        raise "That's not a call!" unless sexp.sexp_type == :call
+
+        receiver = sexp[1] && sexp[1].sexp_type
+
+        case receiver
+        when nil
+          InstanceMethodStubber.new(sexp)
+        when :const
+          ConstStubber.new(sexp)
+        when :call
+          NestedCallStubber.new(sexp)
+        else
+          raise "Can't stub #{receiver.inspect} :("
+        end
+      end
+    end
+  end
+end

data/lib/code_driven_development/test_component/context.rb

@@ -2,10 +2,10 @@ module CodeDrivenDevelopment
   module TestComponent
     class Context
       def initialize(description = nil, befores = [], tests = [], lets = [], subject = nil)
-        @description, @befores, @tests, @lets, @subject = description, befores, tests, lets, subject
+        @description, @befores, @tests, @lets, @subject, @doubles = description, befores, tests, lets, subject, []
       end
 
-      attr_reader :tests, :befores, :lets
+      attr_reader :tests, :befores, :lets, :doubles
       attr_accessor :description, :subject
 
       def << child
@@ -18,6 +18,9 @@ module CodeDrivenDevelopment
           lets.each do |let|
             let.indented_output(io)
           end
+          doubles.each do |double|
+            double.indented_output(io)
+          end
           if subject
             io << "subject { #{subject} }"
           end

data/lib/code_driven_development/test_component/double.rb

@@ -0,0 +1,13 @@
+module CodeDrivenDevelopment
+  module TestComponent
+    class Double
+      def initialize(name)
+        @name = name
+      end
+
+      def indented_output(io)
+        io << "let(:#@name) { double(:#@name) }"
+      end
+    end
+  end
+end

data/lib/code_driven_development/version.rb

@@ -1,3 +1,3 @@
 module CodeDrivenDevelopment
-  VERSION = "0.0.4"
+  VERSION = "0.0.5"
 end

data/samples/president.rb

@@ -3,6 +3,7 @@ class Bunker < ActiveRecord::Base
   validate :location, :protected => true
 
   def alert_staff
+    staph.all_alert
     Staff.alert_all
   end
 

data/spec/spec_helper.rb

@@ -1,4 +1,3 @@
-require 'yaml'
 require_relative '../lib/code_driven_development'
 
 RSpec.configure do |config|

data/spec/stubber_spec.rb

@@ -0,0 +1,110 @@
+require 'spec_helper'
+
+describe CodeDrivenDevelopment::Stubber::Stubber do
+  let(:sexp) { RubyParser.new.parse(code) }
+  let(:stubber) { CodeDrivenDevelopment::Stubber::Stubber.new(sexp) }
+
+  context "invoking a constant's method" do
+    let(:code) { "Constant.zulu.force" }
+
+    it "stubs like a boss" do
+      expect(stubber.befores).to match_array [
+        "allow(Constant).to receive(:zulu).and_return(zulu)",
+        "allow(zulu).to receive(:force).and_return(force)",
+      ]
+    end
+
+    it "has a legit human name" do
+      expect(stubber.human_name).to eq "Constant.zulu.force"
+    end
+
+    it "can create a test body" do
+      expect(stubber.body).to match_array [
+        "expect(Constant).to have_received :zulu",
+        "expect(zulu).to have_received :force",
+      ]
+    end
+
+    it "has some doubles" do
+      expect(stubber.doubles).to match_array [:zulu, :force]
+    end
+  end
+
+  context "invoking an instance method of self" do
+    let(:code) { "zulu" }
+
+    it "stubs like a boss" do
+      expect(stubber.befores).to eq ["allow(obj).to receive(:zulu).and_return(zulu)"]
+    end
+
+    it "has a legit human name" do
+      expect(stubber.human_name).to eq "zulu"
+    end
+
+    it "can create a test body" do
+      expect(stubber.body).to eq [
+        "expect(obj).to have_received :zulu"
+      ]
+    end
+
+    it "has some doubles" do
+      expect(stubber.doubles).to match_array [:zulu]
+    end
+  end
+
+  context "a double method call" do
+    let(:code) { "alpha.beta" }
+
+    it "stubs like a boss" do
+      expect(stubber.befores).to match_array [
+        "allow(obj).to receive(:alpha).and_return(alpha)",
+        "allow(alpha).to receive(:beta).and_return(beta)",
+      ]
+    end
+
+    it "has a legit human name" do
+      expect(stubber.human_name).to eq "alpha.beta"
+    end
+
+    it "can create a test body" do
+      expect(stubber.body).to match_array [
+        "expect(obj).to have_received :alpha",
+        "expect(alpha).to have_received :beta",
+      ]
+    end
+
+    it "has some doubles" do
+      expect(stubber.doubles).to match_array [:alpha, :beta]
+    end
+  end
+
+  context "infinitely nested method calls on self" do
+    let(:code) { "alpha.beta.gamma.delta" }
+
+    it "stubs like a boss" do
+      expect(stubber.befores).to match_array [
+        "allow(obj).to receive(:alpha).and_return(alpha)",
+        "allow(alpha).to receive(:beta).and_return(beta)",
+        "allow(beta).to receive(:gamma).and_return(gamma)",
+        "allow(gamma).to receive(:delta).and_return(delta)",
+      ]
+    end
+
+    it "has a legit human name" do
+      expect(stubber.human_name).to eq "alpha.beta.gamma.delta"
+    end
+
+    it "can create a test body" do
+      expect(stubber.body).to match_array [
+        "expect(obj).to have_received :alpha",
+        "expect(alpha).to have_received :beta",
+        "expect(beta).to have_received :gamma",
+        "expect(gamma).to have_received :delta",
+      ]
+    end
+
+    it "has some doubles" do
+      expect(stubber.doubles).to match_array [:alpha, :beta, :gamma, :delta]
+    end
+  end
+end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: code_driven_development
 version: !ruby/object:Gem::Version
-  version: 0.0.4
+  version: 0.0.5
 platform: ruby
 authors:
 - Dan Finnie
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2014-02-09 00:00:00.000000000 Z
+date: 2014-02-14 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: ruby_parser
@@ -24,6 +24,34 @@ dependencies:
     - - '>='
       - !ruby/object:Gem::Version
         version: '0'
+- !ruby/object:Gem::Dependency
+  name: require_all
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - '>='
+      - !ruby/object:Gem::Version
+        version: '0'
+  type: :runtime
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - '>='
+      - !ruby/object:Gem::Version
+        version: '0'
+- !ruby/object:Gem::Dependency
+  name: coderay
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - '>='
+      - !ruby/object:Gem::Version
+        version: '0'
+  type: :runtime
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - '>='
+      - !ruby/object:Gem::Version
+        version: '0'
 - !ruby/object:Gem::Dependency
   name: bundler
   requirement: !ruby/object:Gem::Requirement
@@ -132,21 +160,26 @@ files:
 - lib/code_driven_development/rule/abstract_rule.rb
 - lib/code_driven_development/rule/boolean_or.rb
 - lib/code_driven_development/rule/class.rb
-- lib/code_driven_development/rule/constant_method_call.rb
 - lib/code_driven_development/rule/default.rb
 - lib/code_driven_development/rule/instance_method.rb
-- lib/code_driven_development/rule/instance_method_call.rb
+- lib/code_driven_development/rule/method_call.rb
 - lib/code_driven_development/rule/set.rb
 - lib/code_driven_development/rule/validation.rb
+- lib/code_driven_development/stubber/abstract_stubber.rb
+- lib/code_driven_development/stubber/const_stubber.rb
+- lib/code_driven_development/stubber/instance_method_stubber.rb
+- lib/code_driven_development/stubber/nested_call_stubber.rb
+- lib/code_driven_development/stubber/stubber.rb
 - lib/code_driven_development/test_component/blank_slate.rb
 - lib/code_driven_development/test_component/context.rb
+- lib/code_driven_development/test_component/double.rb
 - lib/code_driven_development/test_component/let.rb
 - lib/code_driven_development/test_component/one_line_test.rb
 - lib/code_driven_development/test_component/test.rb
 - lib/code_driven_development/version.rb
 - samples/president.rb
-- spec/samples/lone_sample.yaml
 - spec/spec_helper.rb
+- spec/stubber_spec.rb
 homepage: https://github.com/danfinnie/code-driven-development
 licenses:
 - MIT
@@ -175,5 +208,5 @@ summary: Ever see a test and think, "wow, this test cares a lot about the exact
 test_files:
 - features/my_feature.feature
 - features/support/aruba.rb
-- spec/samples/lone_sample.yaml
 - spec/spec_helper.rb
+- spec/stubber_spec.rb

data/lib/code_driven_development/rule/constant_method_call.rb

@@ -1,38 +0,0 @@
-module CodeDrivenDevelopment
-  module Rule
-    class ConstantMethodCall < AbstractRule
-      def capable?
-        code.sexp_type == :call &&
-          method_name != :validate &&
-          receiver_type == :const
-      end
-
-      def test
-        test_context.befores << "allow(#{receiver_value}).to receive :#{method_name}"
-        body = [
-          "subject",
-          "expect(#{receiver_value}).to have_received :#{method_name}"
-        ]
-        test_context << TestComponent::Test.new("calls #{receiver_value}.#{method_name}", body)
-      end
-
-      private
-
-      def receiver_value
-        receiver.value
-      end
-
-      def receiver_type
-        receiver && receiver.sexp_type
-      end
-
-      def receiver
-        code[1]
-      end
-
-      def method_name
-        code[2]
-      end
-    end
-  end
-end

data/lib/code_driven_development/rule/instance_method_call.rb

@@ -1,38 +0,0 @@
-module CodeDrivenDevelopment
-  module Rule
-    class InstanceMethodCall < AbstractRule
-      def capable?
-        code.sexp_type == :call &&
-          method_name != :validate &&
-          receiver_type.nil?
-      end
-
-      def test
-        test_context.befores << "allow(#{receiver_value}).to receive :#{method_name}"
-        body = [
-          "subject",
-          "expect(#{receiver_value}).to have_received :#{method_name}"
-        ]
-        test_context << TestComponent::Test.new("calls ##{method_name}", body)
-      end
-
-      private
-
-      def receiver_value
-        "obj"
-      end
-
-      def receiver_type
-        receiver && receiver.sexp_type
-      end
-
-      def receiver
-        code[1]
-      end
-
-      def method_name
-        code[2]
-      end
-    end
-  end
-end

data/spec/samples/lone_sample.yaml

@@ -1,54 +0,0 @@
--
-  title: creates shoulda_matchers
-  input: |
-    class Lolcat < ActiveRecord::Base
-      validate :cuteness, presence: true
-    end
-  output: |
-    describe Lolcat do
-      it { should validate_presence_of :cuteness }
-    end
--
-  title: instance methods that call constants
-  input: |
-    class Lolcat
-      def i_call_things
-        CentralBureaucracy.file_report
-      end
-    end
-  output: |
-    describe Lolcat do
-      
-      describe "#i_call_things" do
-        let(:obj) { described_class.new }
-        before do
-          allow(CentralBureaucracy).to receive :file_report
-          obj.i_call_things
-        end
-        it "calls CentralBureaucracy.file_report" do
-          expect(CentralBureaucracy).to have_received :file_report
-        end
-      end
-    end
--
-  title: instance methods that call instance methods
-  input: |
-    class Lolcat
-      def i_call_instance_methods
-        meth
-      end
-    end
-  output: |
-    describe Lolcat do
-      
-      describe "#i_call_instance_methods" do
-        let(:obj) { described_class.new }
-        before do
-          allow(obj).to receive :meth
-          obj.i_call_instance_methods
-        end
-        it "calls #meth" do
-          expect(obj).to have_received :meth
-        end
-      end
-    end