code0-zero_track 0.0.1 → 0.0.2

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 528e1dc7d30d7cc16b1507b9649429a03196747fe18b27086c23cbdfe9b85147
-  data.tar.gz: ff9eae6c20639f631b0fce5b3de912a73d76bb1f0e77a7e16b32fac2d645cbbc
+  metadata.gz: 6d7131b86c5135e76e99a0b4edb22b76c5fdcc765ef7d00160ce6e85dc8f3ea4
+  data.tar.gz: ab601c8af299d5679e16a57748977b0762a71aab0802470acb2a43873109c892
 SHA512:
-  metadata.gz: 7ee327ee87f60a1d8865d6abb3b1dc322a28bdc57b7a6d31f06a7d1af17425ed8e7d6af4178417d8db5ad9e84cd6794ae4a2612c1ebd65dfb4968f7b3d1e1e35
-  data.tar.gz: eb42c512f19919608444053fb33be11229e7968a1e6bb231b82ec9415d528baabe83051d41ba5a0335afbc0a2ec6b428c4dd420c29a03d4afcf812667b34cad0
+  metadata.gz: 18fb171af0b27a2d1cf48a690a3d4529ad8daa95bb4d192e2ac6c0a7a5a2c501b922fa5ce48effee6ebced6ec545522b8ef9008587fd6b24d1115b21628ffd16
+  data.tar.gz: 5c6e8f01a01d2427aa75265260ea603eb902480e29b4342fa8c6d6ff9e7103da7c3a2be93d4b5b0ee739248de50e4c83d848c1701c8232e5d267e132b39da8a4

data/lib/code0/zero_track/version.rb

@@ -2,6 +2,6 @@
 
 module Code0
   module ZeroTrack
-    VERSION = '0.0.1'
+    VERSION = '0.0.2'
   end
 end

data/lib/rubocop/code0/zero_track/file_helpers.rb

@@ -0,0 +1,25 @@
+# frozen_string_literal: true
+
+module RuboCop
+  module Code0
+    module ZeroTrack
+      module FileHelpers
+        def dirname(node)
+          File.dirname(filepath(node))
+        end
+
+        def basename(node)
+          File.basename(filepath(node))
+        end
+
+        def filepath(node)
+          node.location.expression.source_buffer.name
+        end
+
+        def in_migration?(node)
+          dirname(node).end_with?('db/migrate')
+        end
+      end
+    end
+  end
+end

data/lib/rubocop/cop/code0/zero_track/logs/rails_logger.rb

@@ -0,0 +1,31 @@
+# frozen_string_literal: true
+
+module RuboCop
+  module Cop
+    module Code0
+      module ZeroTrack
+        module Logs
+          # Cop that checks if 'timestamps' method is called with timezone information.
+          class RailsLogger < RuboCop::Cop::Base
+            MSG = 'Do not use `Rails.logger` directly, include `Code0::ZeroTrack::Loggable` instead'
+            LOG_METHODS = %i[debug error fatal info warn].freeze
+            LOG_METHODS_PATTERN = LOG_METHODS.map(&:inspect).join(' ').freeze
+
+            def_node_matcher :rails_logger_log?, <<~PATTERN
+              (send
+                (send (const nil? :Rails) :logger)
+                {#{LOG_METHODS_PATTERN}} ...
+              )
+            PATTERN
+
+            def on_send(node)
+              return unless rails_logger_log?(node)
+
+              add_offense(node)
+            end
+          end
+        end
+      end
+    end
+  end
+end

data/lib/rubocop/cop/code0/zero_track/migration/create_table_with_timestamps.rb

@@ -0,0 +1,72 @@
+# frozen_string_literal: true
+
+require_relative '../../../../code0/zero_track/file_helpers'
+
+module RuboCop
+  module Cop
+    module Code0
+      module ZeroTrack
+        module Migration
+          class CreateTableWithTimestamps < RuboCop::Cop::Base
+            include RuboCop::Code0::ZeroTrack::FileHelpers
+
+            MSG = 'Add timestamps when creating a new table.'
+            RESTRICT_ON_SEND = %i[create_table].freeze
+
+            def_node_matcher :create_table_with_timestamps_proc?, <<~PATTERN
+              (send nil? :create_table (sym _) ... (block-pass (sym :timestamps_with_timezone)))
+            PATTERN
+
+            def_node_search :timestamps_included?, <<~PATTERN
+              (send _var :timestamps_with_timezone ...)
+            PATTERN
+
+            def_node_search :created_at_included?, <<~PATTERN
+              (send _var :datetime_with_timezone
+                {(sym :created_at)(str "created_at")}
+                ...)
+            PATTERN
+
+            def_node_search :updated_at_included?, <<~PATTERN
+              (send _var :datetime_with_timezone
+                {(sym :updated_at)(str "updated_at")}
+                ...)
+            PATTERN
+
+            def_node_matcher :create_table_with_block?, <<~PATTERN
+              (block
+                (send nil? :create_table ...)
+                (args (arg _var)+)
+                _)
+            PATTERN
+
+            def on_send(node)
+              return unless in_migration?(node)
+              return unless node.command?(:create_table)
+
+              parent = node.parent
+
+              if create_table_with_block?(parent)
+                add_offense(parent) if parent.body.nil? || !time_columns_included?(parent.body)
+              elsif create_table_with_timestamps_proc?(node)
+                # nothing to do
+              else
+                add_offense(node)
+              end
+            end
+
+            private
+
+            def time_columns_included?(node)
+              timestamps_included?(node) || created_at_and_updated_at_included?(node)
+            end
+
+            def created_at_and_updated_at_included?(node)
+              created_at_included?(node) && updated_at_included?(node)
+            end
+          end
+        end
+      end
+    end
+  end
+end

data/lib/rubocop/cop/code0/zero_track/migration/datetime.rb

@@ -0,0 +1,53 @@
+# frozen_string_literal: true
+
+require_relative '../../../../code0/zero_track/file_helpers'
+
+module RuboCop
+  module Cop
+    module Code0
+      module ZeroTrack
+        module Migration
+          # Cop that checks if datetime data type is added with timezone information.
+          class Datetime < RuboCop::Cop::Base
+            include RuboCop::Code0::ZeroTrack::FileHelpers
+            extend AutoCorrector
+
+            MSG = 'Do not use the `%s` data type, use `datetime_with_timezone` instead'
+
+            # Check methods in table creation.
+            def on_def(node)
+              return unless in_migration?(node)
+
+              node.each_descendant(:send) do |send_node|
+                method_name = send_node.children[1]
+
+                next unless %i[datetime timestamp].include?(method_name)
+
+                add_offense(send_node.loc.selector, message: format(MSG, method_name)) do |corrector|
+                  corrector.replace(send_node.loc.selector, 'datetime_with_timezone')
+                end
+              end
+            end
+
+            # Check methods.
+            def on_send(node)
+              return unless in_migration?(node)
+
+              node.each_descendant do |descendant|
+                next unless descendant.type == :sym
+
+                last_argument = descendant.children.last
+
+                next unless %i[datetime timestamp].include?(last_argument)
+
+                add_offense(descendant, message: format(MSG, last_argument)) do |corrector|
+                  corrector.replace(descendant, ':datetime_with_timezone')
+                end
+              end
+            end
+          end
+        end
+      end
+    end
+  end
+end

data/lib/rubocop/cop/code0/zero_track/migration/timestamps.rb

@@ -0,0 +1,38 @@
+# frozen_string_literal: true
+
+require_relative '../../../../code0/zero_track/file_helpers'
+
+module RuboCop
+  module Cop
+    module Code0
+      module ZeroTrack
+        module Migration
+          # Cop that checks if 'timestamps' method is called with timezone information.
+          class Timestamps < RuboCop::Cop::Base
+            include RuboCop::Code0::ZeroTrack::FileHelpers
+            extend AutoCorrector
+
+            MSG = 'Do not use `timestamps`, use `timestamps_with_timezone` instead'
+
+            # Check methods in table creation.
+            def on_def(node)
+              return unless in_migration?(node)
+
+              node.each_descendant(:send) do |send_node|
+                next unless method_name(send_node) == :timestamps
+
+                add_offense(send_node.loc.selector) do |corrector|
+                  corrector.replace(send_node.loc.selector, 'timestamps_with_timezone')
+                end
+              end
+            end
+
+            def method_name(node)
+              node.children[1]
+            end
+          end
+        end
+      end
+    end
+  end
+end

data/lib/rubocop/cop/code0/zero_track/migration/versioned_class.rb

@@ -0,0 +1,93 @@
+# frozen_string_literal: true
+
+require_relative '../../../../code0/zero_track/file_helpers'
+
+module RuboCop
+  module Cop
+    module Code0
+      module ZeroTrack
+        module Migration
+          class VersionedClass < RuboCop::Cop::Base
+            include RuboCop::Code0::ZeroTrack::FileHelpers
+            extend AutoCorrector
+
+            MIGRATION_CLASS = 'Code0::ZeroTrack::Database::Migration'
+
+            # rubocop:disable Layout/LineLength
+            MSG_WRONG_BASE_CLASS = "Don't use `%<base_class>s`. Use `#{MIGRATION_CLASS}` instead.".freeze
+            MSG_WRONG_VERSION = "Don't use version `%<current_version>s` of `#{MIGRATION_CLASS}`. Use version `%<allowed_version>s` instead.".freeze
+            # rubocop:enable Layout/LineLength
+
+            def on_class(node)
+              return unless in_migration?(node)
+
+              return on_zerotrack_migration(node) if zerotrack_migration?(node)
+
+              add_offense(
+                node.parent_class,
+                message: format(MSG_WRONG_BASE_CLASS, base_class: superclass(node))
+              ) do |corrector|
+                corrector.replace(node.parent_class, "#{MIGRATION_CLASS}[#{find_allowed_versions(node).last}]")
+              end
+            end
+
+            private
+
+            def on_zerotrack_migration(node)
+              return if cop_config['AllowedVersions'].nil? # allow all versions if nothing configured
+              return if correct_migration_version?(node)
+
+              current_version = get_migration_version(node)
+              allowed_version = find_allowed_versions(node).last
+
+              version_node = get_migration_version_node(node)
+
+              add_offense(
+                version_node,
+                message: format(MSG_WRONG_VERSION, current_version: current_version, allowed_version: allowed_version)
+              ) do |corrector|
+                corrector.replace(version_node, find_allowed_versions(node).last.to_s)
+              end
+            end
+
+            def zerotrack_migration?(node)
+              superclass(node) == MIGRATION_CLASS
+            end
+
+            def superclass(class_node)
+              _, *others = class_node.descendants
+
+              others.find { |node| node.const_type? && node.const_name != 'Types' }&.const_name
+            end
+
+            def correct_migration_version?(node)
+              find_allowed_versions(node).include?(get_migration_version(node))
+            end
+
+            def get_migration_version_node(node)
+              node.parent_class.arguments[0]
+            end
+
+            def get_migration_version(node)
+              get_migration_version_node(node).value
+            end
+
+            def find_allowed_versions(node)
+              migration_version = basename(node).split('_').first.to_i
+              allowed_versions.select do |range, _|
+                range.include?(migration_version)
+              end.values
+            end
+
+            def allowed_versions
+              cop_config['AllowedVersions'].transform_keys do |range|
+                range_ints = range.split('..').map(&:to_i)
+                range_ints[0]..range_ints[1]
+              end
+            end
+          end
+        end
+      end
+    end
+  end
+end

data/lib/rubocop/zero_track.rb

@@ -0,0 +1,5 @@
+# frozen_string_literal: true
+
+# rubocop:disable Lint/RedundantDirGlobSort
+Dir[File.join(__dir__, 'cop', '**', '*.rb')].sort.each { |file| require file }
+# rubocop:enable Lint/RedundantDirGlobSort

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: code0-zero_track
 version: !ruby/object:Gem::Version
-  version: 0.0.1
+  version: 0.0.2
 platform: ruby
 authors:
 - Niklas van Schrick
 autorequire:
 bindir: bin
 cert_chain: []
-date: 2025-02-22 00:00:00.000000000 Z
+date: 2025-02-26 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: rails
@@ -181,6 +181,13 @@ files:
 - lib/code0/zero_track/memoize.rb
 - lib/code0/zero_track/railtie.rb
 - lib/code0/zero_track/version.rb
+- lib/rubocop/code0/zero_track/file_helpers.rb
+- lib/rubocop/cop/code0/zero_track/logs/rails_logger.rb
+- lib/rubocop/cop/code0/zero_track/migration/create_table_with_timestamps.rb
+- lib/rubocop/cop/code0/zero_track/migration/datetime.rb
+- lib/rubocop/cop/code0/zero_track/migration/timestamps.rb
+- lib/rubocop/cop/code0/zero_track/migration/versioned_class.rb
+- lib/rubocop/zero_track.rb
 - lib/tasks/code0/zero_track_tasks.rake
 homepage: https://github.com/code0-tech/code0-zero_track
 licenses: