codat 0.1.4 → 0.1.5

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 9b359100d300f095792668b5566510b28d0c417c62884b09b82986c5e29ce050
-  data.tar.gz: f060ecf8c9fb2b2aab07cac48a16f76468bdcf1f650180cf041bf1873d95be7b
+  metadata.gz: d09022df4a8325e87d98203d4441da3bb0767abc37b654c2ed2b0901d0f45f4b
+  data.tar.gz: f75d4d5a4e8ef1f66201e53d70ea8449d289e18ca0b7355dbd8484a112bb6a6b
 SHA512:
-  metadata.gz: 2efbbac8dc086eaf8def830cc9abdbcdff3de04d17c4af1acd788533597c69a0c8f0b52ff3c1f46f119db2cc9aeaead363eb598786aa225ce11452d144be3f07
-  data.tar.gz: 6576d8cb03153ed9a409b0c95f94992a95387437a85abf7d7d4bc003f2a2c2c9f97e2914bd2be952834fafb7ef3321d526011ef7ca9a1040caba0f97861cc105
+  metadata.gz: ee8f01dfbe68c0b176164b054e6191bf9bf2b68dc6c87740eaf6bab195c6dc9e8724b35dd3179612bb2778d12a69da7b20c9db5adbec0595c6330392504c85af
+  data.tar.gz: f94df3242b171c2c63d5c130505484143c81697dce53b9d714817f53f28f329f3872c9b147376abcc57fe5664034e844b1a000c49f67ef00beb1fe0387b041be

data/bin/console

@@ -12,8 +12,8 @@ Codat.configure do |config|
 end
 
 # To avoid having to namespace everything when inside the console.
-Object.send(:include, Codat)
-Object.send(:include, Codat::Models)
+Object.include(Codat)
+Object.include(Codat::Models)
 
 require 'pry'
 Pry.start

data/lib/codat/base_model.rb

@@ -39,6 +39,12 @@ module Codat
 
         formatted
       end
+
+      # As per Codat API doc
+      # https://docs.codat.io/reference/errors
+      def successful_response?(result)
+        result.status < 400
+      end
     end
 
     # Sets all the instance variables by reading the JSON from Codat and converting the keys from

data/lib/codat/models/bank_account.rb

@@ -16,7 +16,7 @@ module Codat
 
         result = get(url)
 
-        return [] if result.status == 404
+        return [] unless successful_response?(result)
 
         result.body.map { |account| new(json: account) }
       end

data/lib/codat/models/bank_statement_list.rb

@@ -18,7 +18,7 @@ module Codat
 
         result = get(url, accountId: account_id.to_s.strip, page: page.to_s.strip)
 
-        return nil if result.status == 404
+        return nil unless successful_response?(result)
 
         new(json: result.body)
       end

data/lib/codat/models/company.rb

@@ -18,9 +18,7 @@ module Codat
       def self.all(params = {})
         result = get(ENDPOINTS[:collection], params)
 
-        return [] if result.status == 404
-
-        return result.body if result.status == 400
+        return [] unless successful_response?(result)
 
         result.body[:results].map { |company| new(json: company) }
       end
@@ -30,7 +28,7 @@ module Codat
 
         result = get(url)
 
-        return nil if result.status == 404
+        return nil unless successful_response?(result)
 
         new(json: result.body)
       end
@@ -38,7 +36,7 @@ module Codat
       def self.create(params = {})
         result = post(ENDPOINTS[:collection], params)
 
-        return { error: 'An error occured.' } if result.status == 404 || result.status == 400
+        return { error: 'An error occured.' } unless successful_response?(result)
 
         new(json: result.body)
       end

data/lib/codat/models/financial_sheet.rb

@@ -36,7 +36,7 @@ module Codat
 
         result = get(url, build_query(params))
 
-        return nil if result.status == 404 || result.status == 400
+        return nil unless successful_response?(result)
 
         new(json: result.body)
       end

data/lib/codat/models/integration.rb

@@ -12,9 +12,7 @@ module Codat
       def self.all(params = {})
         result = get(ENDPOINT, params)
 
-        return [] if result.status == 404
-
-        return result.body if result.status == 400
+        return [] unless successful_response?(result)
 
         result.body.map { |integration| new(json: integration) }
       end

data/lib/codat/models/report.rb

@@ -16,7 +16,7 @@ module Codat
 
         result = get(url)
 
-        return [] if result.status == 404
+        return [] unless successful_response?(result)
 
         result.body[:data].map { |report| new(json: report) }
       end

data/lib/codat/version.rb

@@ -1,5 +1,5 @@
 # frozen_string_literal: true
 
 module Codat
-  VERSION = '0.1.4'
+  VERSION = '0.1.5'
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: codat
 version: !ruby/object:Gem::Version
-  version: 0.1.4
+  version: 0.1.5
 platform: ruby
 authors:
 - Ricardo Otero
 autorequire: 
 bindir: exe
 cert_chain: []
-date: 2019-09-13 00:00:00.000000000 Z
+date: 2020-01-05 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: faraday