coda_standard 0.1.9 → 0.2.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: dda9c638d689bcea9637bbac5a47a1a2158b6e89
-  data.tar.gz: ca9292bdbab414c7bb4592a1a4cbf2d25f104064
+  metadata.gz: f1dbb0e0db4bc5c06941b94ca4a7a36f8cee8291
+  data.tar.gz: ecea24627d4a271c938863c81cf0abc5d2414268
 SHA512:
-  metadata.gz: 193f1a011ec3fd8aedea410340d7de00e34f04c07a2f9479d63c783b2cd1b9a8b0ce82efe0fbf8569d94946db53b35f339519c98b6aba375b23deec62ecde12c
-  data.tar.gz: ac36c1f4530a2e2c125e8c7914be1d07f3b09b13cddf1e2759d12a36499ce86db6bc277e5cf709c7e8306466677d03fd2edf847cb8a202e7274ce8a58a40fa0c
+  metadata.gz: 9a72a672dd4b470872a43158a3d08ab5321d9e6afe896c2527e3b7c0354ab6c34593ebe907f2f254dfa93b236f55f8b7f6227bc6b34c15d78a30261f7cc3a1ac
+  data.tar.gz: b9be352b5843db3068d858408ccbd160125808506fd6c0553ad21496fbc1e25831bc088128aff48d6b5047a9f5d906360999fe411222c3e81d00e9293e373b67

data/.gitignore

@@ -14,6 +14,8 @@
 *.a
 mkmf.log
 
+inv.cod
+
 *.gem
 *.rbc
 /.config

data/README.md

@@ -37,6 +37,12 @@ CodaStandard::Parser.new(filename).parse.first.transactions[0].amount
 # or print a more readable representation of the file
 CodaStandard::Parser.new(filename).show
 
+# or check if the file is valid (the validation is not yet implemented for every field)
+CodaStandard::Parser.new(filename).valid? => true
+
+# by default the parse and show methods have validation but you can skip it if you dare
+CodaStandard::Parser.new(filename).parse(skip_validation: true)
+
 # you can also find a transaction inside a transaction list object by the structured communication number
 CodaStandard::Parser.new(filename).parse.first.find_by_structured_communication('100000001234')
 ```

data/lib/coda_standard/parser.rb

@@ -9,7 +9,16 @@ module CodaStandard
       @current_transaction = Transaction.new
     end
 
-    def parse
+    def valid?
+      File.open(@filename).each do |line|
+        record = Record.new(line)
+        return false unless record.valid?
+      end
+      true
+    end
+
+    def parse(skip_validation: skip_validation = false)
+      return [] if !skip_validation && !valid?
       File.open(@filename).each do |line|
         record = Record.new(line)
         case
@@ -71,8 +80,9 @@ module CodaStandard
       @current_transaction.account  = record.account
     end
 
-    def show
-      parse
+    def show(skip_validation: skip_validation = false)
+      puts "The file is invalid" if !skip_validation && !valid?
+      parse(skip_validation: skip_validation)
       @transactions.each_with_index do |transaction, index|
         puts "**--Transaction List #{ index + 1 }--**\n\n"
         puts "Account: #{transaction.current_account} Account type: #{transaction.current_account_type} BIC: #{transaction.current_bic}"

data/lib/coda_standard/record.rb

@@ -103,10 +103,28 @@ module CodaStandard
       extract(:structured_communication)
     end
 
+    def valid?
+      if data_old_balance?
+        return false if !field_valid?(:current_account)
+      end
+      true
+    end
+
+    def field_valid?(field)
+      if field == :current_account
+        return raw_extract(:current_account).scan(CLEAN_FIELDS[:sep_account]).flatten.size == 3
+      end
+      true
+    end
+
     private
 
+    def raw_extract(field)
+      @line.scan(FIELDS[field]).join.strip
+    end
+
     def extract(field)
-      result = @line.scan(FIELDS[field]).join.strip
+      result = raw_extract(field)
       case field
         when :address
           separate_address(result)
@@ -126,6 +144,7 @@ module CodaStandard
       { address: address_fields[0].strip, postcode: address_fields[1], city: address_fields[2], country: address_fields[3] }
     end
 
+
     def clean_account(account)
       account_type = account.scan(CLEAN_FIELDS[:sep_account])[0][0]
       raw_account = account.scan(CLEAN_FIELDS[:sep_account])[0][2]

data/lib/coda_standard/version.rb

@@ -1,3 +1,3 @@
 module CodaStandard
-  VERSION = "0.1.9"
+  VERSION = "0.2.0"
 end

data/spec/invalid.cod

@@ -0,0 +1,18 @@
+0000031031520005                  MMIF SA/BANK              GEBABEBB   00538839354 00000                                       2
+10016539007547034 EUR0BE                  0000000057900000300315MMIF SA/EVOCURE                                              017
+21000100000001500000103        0000000000500860010415001500001101100000834941                                      31031501601 0
+2200010000                                                                                        GKCCBEBB                   1 0
+2300010000BE53900754703405                  EURLASTNM PERSON                                                                 0 1
+31000100010001500000103        001500001001LASTNM PERSON                                                                     1 0
+3200010001CHAUSSEE DE BIERE 10             1978 SOMECITY                                                                     0 0
+21000200000001500000104        0000000000200000010415001500001102100000835749                                      31031501601 0
+2200020000                                                                                        BILLLULL                   1 0
+2300020000LU539007547034898400              EURM.JOHN DOE                                                                    0 1
+31000200010001500000104        001500001001M.JOHN DOE                                                                        1 0
+32000200015 STREET                                     3654 CITY BELGIQUE                                                    0 0
+8016035918134040 EUR0BE                  0000000058900000310315                                                                0
+9               000027000000000000000000000001000000
+
+
+
+100/0000/00135

data/spec/parser_spec.rb

@@ -3,6 +3,8 @@ require_relative 'spec_helper'
 describe CodaStandard::Parser do
   let(:filename) { 'spec/coda.cod' }
   let(:parser) { CodaStandard::Parser.new(filename) }
+  let(:filename_invalid) { 'spec/invalid.cod' }
+  let(:parser_invalid) { CodaStandard::Parser.new(filename_invalid) }
 
   describe "initialize" do
     it "initializes some class variables" do
@@ -15,6 +17,18 @@ describe CodaStandard::Parser do
       parser.parse
     end
 
+    context "skip_validation is false or not specified" do
+      it "returns an empty array if the file is invalid" do
+        expect(parser_invalid.parse).to eq []
+      end
+    end
+
+    context "skip_validation is true" do
+      it "raises an exception when invalid" do
+        expect{ parser_invalid.parse(skip_validation: true) }.to raise_error
+      end
+    end
+
     it "returns an array of TransactionLists" do
         expect(parser.parse).to be_a(Array)
         parser.parse.each{ |tl| expect(tl).to be_a(CodaStandard::TransactionList) }
@@ -61,9 +75,29 @@ describe CodaStandard::Parser do
   end
 
   describe "show" do
+    context "skip_validation is false or not specified" do
+      it "returns a message if the file is invalid" do
+        expect{ parser_invalid.show }.to output("The file is invalid\n").to_stdout
+      end
+    end
+    context "skip_validation is true" do
+      it "raises an exception when invalid" do
+        expect{ parser_invalid.show(skip_validation: true) }.to raise_error
+      end
+    end
+
     it "shows the info from the transactions" do
       expect{ parser.show }.to output("**--Transaction List 1--**\n\nAccount: 539007547034 Account type: bban_be_account BIC: GEBABEBB\nOld balance: 57900.000 \n\n-- Transaction n.1 - number 100000834941 - in date 2015-03-31-- \n\n   RN: 0001500000103 Account: BE53900754703405 BIC: GKCCBEBB\n   Amount: 500,86 EUR\n   Name: LASTNM PERSON\n   Address: CHAUSSEE DE BIERE 10 1978 SOMECITY  \n\n-- Transaction n.2 - number 100000835749 - in date 2015-03-31-- \n\n   RN: 0001500000104 Account: LU539007547034898400 BIC: BILLLULL\n   Amount: 200,00 EUR\n   Name: M.JOHN DOE\n   Address: 5 STREET 3654 CITY  BELGIQUE \n\n").to_stdout
     end
   end
 
+  describe "valid?" do
+    it "returns true if the file is valid" do
+      expect(parser.valid?).to be true
+    end
+
+    it "returns false if the file is invalid" do
+      expect(parser_invalid.valid?).to be false
+    end
+  end
 end

data/spec/record_spec.rb

@@ -4,6 +4,7 @@ describe CodaStandard::Record do
 
   let(:header_record) { CodaStandard::Record.new("0000031031520005                  MMIF SA/BANK              GEBABEBB   00538839354 00000                                       2")}
   let(:old_balance_data_record) {  CodaStandard::Record.new("10016539007547034 EUR0BE                  0000000057900000300315MMIF SA/EVOCURE                                              017")}
+  let(:old_balance_data_record_invalid) {  CodaStandard::Record.new("100/0000/00135")}
   let(:data_movement1_record) {  CodaStandard::Record.new("21000100000001500000103        0000000000500860010415001500001101100000834941                                      31031501601 0")}
   let(:data_movement1b_record) {  CodaStandard::Record.new("21000100000001500000103        0000000000500860010415001500001001100000834941                                      31031501601 0")}
   let(:data_movement2_record) {  CodaStandard::Record.new("2200010000                                                                                        GKCCBEBB                   1 0")}
@@ -136,6 +137,7 @@ describe CodaStandard::Record do
         expect(data_movement1_record.structured_communication).to eq("100000834941")
       end
     end
+
     context "non-structured_number" do
       it "returns not structured" do
         expect(data_movement1b_record.structured_communication).to eq("not structured")
@@ -149,4 +151,13 @@ describe CodaStandard::Record do
     end
   end
 
+  describe "valid?" do
+    it "returns true if the record is valid" do
+      expect(old_balance_data_record.valid?).to be true
+    end
+
+    it "returns false if the record is invalid" do
+      expect(old_balance_data_record_invalid.valid?).to be false
+    end
+  end
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: coda_standard
 version: !ruby/object:Gem::Version
-  version: 0.1.9
+  version: 0.2.0
 platform: ruby
 authors:
 - Alvaro Leal
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2015-05-18 00:00:00.000000000 Z
+date: 2015-05-19 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: bundler
@@ -72,6 +72,7 @@ files:
 - lib/coda_standard/transaction_list.rb
 - lib/coda_standard/version.rb
 - spec/coda.cod
+- spec/invalid.cod
 - spec/parser_spec.rb
 - spec/record_spec.rb
 - spec/spec_helper.rb
@@ -102,6 +103,7 @@ specification_version: 4
 summary: CODA bank standard file parser
 test_files:
 - spec/coda.cod
+- spec/invalid.cod
 - spec/parser_spec.rb
 - spec/record_spec.rb
 - spec/spec_helper.rb