coda_standard 0.1.4 → 0.1.5

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: c747a72bd151e0741c2f0652934829fbc1414563
-  data.tar.gz: 8ff61da7a6ff285449b50983284063aecebc14f5
+  metadata.gz: 4a1ce079c0bc3adf0c772294905d02bba9e645f3
+  data.tar.gz: a9a8f8c3516b715c26e52a8187569f08cefeb735
 SHA512:
-  metadata.gz: 0dbd5e47ecc16eae6426567c7dd1ce4e28d21f893b6dd5c9ba65c43ec1308b89516f9c5cc27ae6554a60fc32c268d0f4a6a7506d2230dc12794f7aa3342909c3
-  data.tar.gz: 18c23f3a27786da2289c6e888a4b0ff93605089ba45181bfa71349c29546b1241475a00ceb45eda2d7bc9e38c1037dd7f35d7e3314be8bb9c8206b5295d26c1d
+  metadata.gz: 05f544cf123702072bd15eb11742ea7e7c3a859b5e10aef9ce0df714ec0f3529ba165bcaadd88cebdc9076449edd87a6435115f1d81e335fa0e1ee7b1522cd25
+  data.tar.gz: 3206307f035f57558bcaa0b781d131b6bf07570ade4ab1762323249a70a0539caaf8db5acd50aaf90f3be8f8d35eb466ade9d1c97e66d28c3ed253161c80de56

data/lib/coda_standard/parser.rb

@@ -9,28 +9,28 @@ module CodaStandard
     end
 
     def parse
-      File.open(@filename).each do |row|
-        line = Line.new(row)
+      File.open(@filename).each do |line|
+        record = Record.new(line)
         case
-          when line.line =~ /^0/
-            @transactions.current_bic = line.current_bic
-          when line.line =~ /^1/
-            set_account(line.current_account)
-            @transactions.old_balance = line.old_balance
-          when line.line =~ /^21/
+          when record.header?
+            @transactions.current_bic = record.current_bic
+          when record.data_old_balance?
+            set_account(record.current_account)
+            @transactions.old_balance = record.old_balance
+          when record.data_movement1?
             @current_transaction = @transactions.create
-            @current_transaction.entry_date         = line.entry_date
-            @current_transaction.reference_number   = line.reference_number
-            @current_transaction.amount             = line.amount
-            @current_transaction.transaction_number = line.transaction_number
-          when line.line =~ /^22/
-            @current_transaction.bic = line.bic
-          when line.line =~ /^23/
-            @current_transaction.currency = line.currency
-            @current_transaction.name     = line.name
-            @current_transaction.account  = line.account
-          when line.line =~ /^32/
-            set_address(line.address)
+            @current_transaction.entry_date         = record.entry_date
+            @current_transaction.reference_number   = record.reference_number
+            @current_transaction.amount             = record.amount
+            @current_transaction.transaction_number = record.transaction_number
+          when record.data_movement2?
+            @current_transaction.bic = record.bic
+          when record.data_movement3?
+            @current_transaction.currency = record.currency
+            @current_transaction.name     = record.name
+            @current_transaction.account  = record.account
+          when record.data_information2?
+            set_address(record.address)
         end
       end
       @transactions
@@ -55,7 +55,7 @@ module CodaStandard
       puts "Old balance: #{@transactions.old_balance} \n\n"
       @transactions.each_with_index do |transaction, index|
         puts "-- Transaction n.#{index + 1} - number #{transaction.transaction_number} - in date #{transaction.entry_date}-- \n\n"
-        puts "   RN: #{transaction.reference_number} Account: #{transaction.account} BIC:#{transaction.bic}"
+        puts "   RN: #{transaction.reference_number} Account: #{transaction.account} BIC: #{transaction.bic}"
         puts "   Amount: #{transaction.amount} #{transaction.currency}"
         puts "   Name: #{transaction.name}"
         puts "   Address: #{transaction.address} #{transaction.postcode} #{transaction.city} #{transaction.country} \n\n"

data/lib/coda_standard/{line.rb → record.rb}

@@ -1,7 +1,5 @@
 module CodaStandard
-  class Line
-    attr_reader :line
-
+  class Record
     FIELDS = {
       current_bic: /^0.{59}(.{11})/,
       current_account: /^1(.{41})/,
@@ -31,6 +29,30 @@ module CodaStandard
       @line = line
     end
 
+    def header?
+      @line.start_with? "0"
+    end
+
+    def data_old_balance?
+      @line.start_with? "1"
+    end
+
+    def data_movement1?
+      @line.start_with? "21"
+    end
+
+    def data_movement2?
+      @line.start_with? "22"
+    end
+
+    def data_movement3?
+      @line.start_with? "23"
+    end
+
+    def data_information2?
+      @line.start_with? "32"
+    end
+
     def current_bic
       extract(:current_bic)
     end

data/lib/coda_standard/version.rb

@@ -1,3 +1,3 @@
 module CodaStandard
-  VERSION = "0.1.4"
+  VERSION = "0.1.5"
 end

data/lib/coda_standard.rb

@@ -2,7 +2,7 @@ require "coda_standard/version"
 require "coda_standard/parser"
 require "coda_standard/transaction"
 require "coda_standard/transaction_list"
-require "coda_standard/line"
+require "coda_standard/record"
 
 module CodaStandard
 end

data/spec/parser_spec.rb

@@ -1,69 +1,66 @@
 require_relative 'spec_helper'
 
 describe CodaStandard::Parser do
-
-  before :each do
-    filename = 'spec/coda.cod'
-    @parser = CodaStandard::Parser.new(filename)
-  end
+  let(:filename) { 'spec/coda.cod' }
+  let(:parser) { CodaStandard::Parser.new(filename) }
 
   describe "initialize" do
     it "initializes some class variables" do
-      expect(@parser.transactions).to be_a(CodaStandard::TransactionList)
+      expect(parser.transactions).to be_a(CodaStandard::TransactionList)
     end
   end
 
   describe "parse" do
     before :each do
-      @parser.parse
+      parser.parse
     end
 
     it "returns a Transactions object" do
-        expect(@parser.parse).to be_a(CodaStandard::TransactionList)
+        expect(parser.parse).to be_a(CodaStandard::TransactionList)
     end
   end
 
   describe "set_address" do
     before :each do
       address = {:address=>"5 RUE DU CENTCINQUANTENAIRE", :postcode=>"6750", :city=>"MUSSY-LA-VILLE", :country=>" BELGIQUE"}
-      @parser.set_address(address)
+      parser.set_address(address)
     end
 
     it "sets the address field to the current transaction" do
-      expect(@parser.current_transaction.address).to eq("5 RUE DU CENTCINQUANTENAIRE")
+      expect(parser.current_transaction.address).to eq("5 RUE DU CENTCINQUANTENAIRE")
     end
 
     it "sets the postcode field to the current transaction" do
-      expect(@parser.current_transaction.postcode).to eq("6750")
+      expect(parser.current_transaction.postcode).to eq("6750")
     end
 
     it "sets the city field to the current transaction" do
-      expect(@parser.current_transaction.city).to eq("MUSSY-LA-VILLE")
+      expect(parser.current_transaction.city).to eq("MUSSY-LA-VILLE")
     end
 
     it "sets the country field to the current transaction" do
-      expect(@parser.current_transaction.country).to eq(" BELGIQUE")
+      expect(parser.current_transaction.country).to eq(" BELGIQUE")
     end
   end
 
  describe "set_account" do
     before :each do
       account = {account_number:"035918134040", account_type:"bban_be_account"}
-      @parser.set_account(account)
+      parser.set_account(account)
     end
 
     it "sets the current_account field to the TransactionList" do
-      expect(@parser.transactions.current_account).to eq("035918134040")
+      expect(parser.transactions.current_account).to eq("035918134040")
     end
 
     it "sets the account_type field to the TransactionList" do
-      expect(@parser.transactions.current_account_type).to eq("bban_be_account")
+      expect(parser.transactions.current_account_type).to eq("bban_be_account")
     end
   end
 
   describe "show" do
     it "shows the info from the transactions" do
-      expect{@parser.show}.to output("**--Transactions--**\n\nAccount: 539007547034 Account type: bban_be_account BIC: GEBABEBB\nOld balance: 57900,000 \n\n-- Transaction n.1 - number 100000834941 - in date 310315-- \n\n   RN: 0001500000103 Account: BE53900754703405 BIC:GKCCBEBB\n   Amount: 500,000 EUR\n   Name: LASTNM PERSON\n   Address: CHAUSSEE DE BIERE 10 1978 SOMECITY  \n\n-- Transaction n.2 - number 100000835749 - in date 310315-- \n\n   RN: 0001500000104 Account: LU539007547034898400 BIC:BILLLULL\n   Amount: 200,000 EUR\n   Name: M.JOHN DOE\n   Address: 5 STREET 3654 CITY  BELGIQUE \n\n").to_stdout
+      expect{parser.show}.to output("**--Transactions--**\n\nAccount: 539007547034 Account type: bban_be_account BIC: GEBABEBB\nOld balance: 57900,000 \n\n-- Transaction n.1 - number 100000834941 - in date 310315-- \n\n   RN: 0001500000103 Account: BE53900754703405 BIC: GKCCBEBB\n   Amount: 500,000 EUR\n   Name: LASTNM PERSON\n   Address: CHAUSSEE DE BIERE 10 1978 SOMECITY  \n\n-- Transaction n.2 - number 100000835749 - in date 310315-- \n\n   RN: 0001500000104 Account: LU539007547034898400 BIC: BILLLULL\n   Amount: 200,000 EUR\n   Name: M.JOHN DOE\n   Address: 5 STREET 3654 CITY  BELGIQUE \n\n").to_stdout
     end
   end
 

data/spec/record_spec.rb

@@ -0,0 +1,152 @@
+require_relative 'spec_helper'
+
+describe CodaStandard::Record do
+
+  let(:header_record) { CodaStandard::Record.new("0000031031520005                  MMIF SA/BANK              GEBABEBB   00538839354 00000                                       2")}
+  let(:old_balance_data_record) {  CodaStandard::Record.new("10016539007547034 EUR0BE                  0000000057900000300315MMIF SA/EVOCURE                                              017")}
+  let(:data_movement1_record) {  CodaStandard::Record.new("21000100000001500000103        0000000000500000010415001500001101100000834941                                      31031501601 0")}
+  let(:data_movement1b_record) {  CodaStandard::Record.new("21000100000001500000103        0000000000500000010415001500001001100000834941                                      31031501601 0")}
+  let(:data_movement2_record) {  CodaStandard::Record.new("2200010000                                                                                        GKCCBEBB                   1 0")}
+  let(:data_movement3_record) {  CodaStandard::Record.new("2300010000BE53900754703405                  EURLASTNM PERSON                                                                 0 1")}
+  let(:data_information2_record) {  CodaStandard::Record.new("32000200015 STREET                                     3654 CITY BELGIQUE                                                    0 0")}
+
+  describe "data_header" do
+    it "returns true if the line starts with a zero" do
+      expect(header_record.header?).to be true
+    end
+
+    it "returns false if the line does not start with a zero" do
+      expect(old_balance_data_record.header?).to be false
+    end
+  end
+
+  describe "data_old_balance" do
+    it "returns true if the line starts with a one" do
+      expect(old_balance_data_record.data_old_balance?).to be true
+    end
+
+    it "returns false if the line does not start with a one" do
+      expect(header_record.data_old_balance?).to be false
+    end
+  end
+
+  describe "data_movement1" do
+    it "returns true if the line starts with a 21" do
+      expect(data_movement1_record.data_movement1?).to be true
+    end
+
+    it "returns false if the line does not start with 21" do
+      expect(header_record.data_movement1?).to be false
+    end
+  end
+
+  describe "data_movement2" do
+    it "returns true if the line starts with a 22" do
+      expect(data_movement2_record.data_movement2?).to be true
+    end
+
+    it "returns false if the line does not start with 22" do
+      expect(header_record.data_movement2?).to be false
+    end
+  end
+
+  describe "data_movement3" do
+    it "returns true if the line starts with a 23" do
+      expect(data_movement3_record.data_movement3?).to be true
+    end
+
+    it "returns false if the line does not start with 23" do
+      expect(header_record.data_movement3?).to be false
+    end
+  end
+
+  describe "data_information2" do
+    it "returns true if the line starts with a 32" do
+      expect(data_information2_record.data_information2?).to be true
+    end
+
+    it "returns false if the line does not start with 32" do
+      expect(header_record.data_information2?).to be false
+    end
+  end
+
+  describe "current_bic" do
+    it "extracts the current_bic" do
+      expect(header_record.current_bic).to eq("GEBABEBB")
+    end
+  end
+
+  describe "current_account" do
+    it "extracts the current_account" do
+      expect(old_balance_data_record.current_account).to eq({account_number:"539007547034", account_type:"bban_be_account"})
+    end
+  end
+
+  describe "old_balance" do
+    it "extracts the old_balance" do
+      expect(old_balance_data_record.old_balance).to eq("57900,000")
+    end
+  end
+
+  describe "entry_date" do
+    it "extracts the entry_date" do
+      expect(data_movement1_record.entry_date).to eq("310315")
+    end
+  end
+
+  describe "reference_number" do
+    it "extracts the reference_number" do
+      expect(data_movement1_record.reference_number).to eq("0001500000103")
+    end
+  end
+
+  describe "amount" do
+    it "extracts the amount" do
+      expect(data_movement1_record.amount).to eq("500,000")
+    end
+  end
+
+  describe "bic" do
+    it "extracts the bic" do
+      expect(data_movement2_record.bic).to eq("GKCCBEBB")
+    end
+  end
+
+  describe "currency" do
+    it "extracts the currency" do
+      expect(data_movement3_record.currency).to eq("EUR")
+    end
+  end
+
+  describe "name" do
+    it "extracts the name" do
+      expect(data_movement3_record.name).to eq("LASTNM PERSON")
+    end
+  end
+
+  describe "account" do
+    it "extracts the account" do
+      expect(data_movement3_record.account).to eq("BE53900754703405")
+    end
+  end
+
+  describe "transaction_number" do
+    context "structured_number" do
+      it "extracts the number" do
+        expect(data_movement1_record.transaction_number).to eq("100000834941")
+      end
+    end
+    context "non-structured_number" do
+      it "returns not structured" do
+        expect(data_movement1b_record.transaction_number).to eq("not structured")
+      end
+    end
+  end
+
+  describe "address" do
+    it "extracts the address" do
+      expect(data_information2_record.address).to eq({:address=>"5 STREET", :postcode=>"3654", :city=>"CITY", :country=>" BELGIQUE"})
+    end
+  end
+
+end

data/spec/transaction_list_spec.rb

@@ -1,20 +1,18 @@
 require_relative 'spec_helper'
 
 describe CodaStandard::TransactionList do
-  before :each do
-    @transaction_list = CodaStandard::TransactionList.new
-  end
+  let(:transaction_list) { CodaStandard::TransactionList.new }
 
   describe "initialize some values" do
     it "has an transactions array" do
-      expect(@transaction_list.transactions).to eq([])
+      expect(transaction_list.transactions).to eq([])
     end
   end
 
   describe "create" do
     it "creates a new transaction and puts it into the array" do
-      @transaction_list.create
-      expect(@transaction_list.create).to eq @transaction_list.transactions.last
+      transaction_list.create
+      expect(transaction_list.create).to eq transaction_list.transactions.last
     end
   end
-end
+end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: coda_standard
 version: !ruby/object:Gem::Version
-  version: 0.1.4
+  version: 0.1.5
 platform: ruby
 authors:
 - Alvaro Leal
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2015-04-14 00:00:00.000000000 Z
+date: 2015-04-15 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: bundler
@@ -66,14 +66,14 @@ files:
 - Rakefile
 - coda_standard.gemspec
 - lib/coda_standard.rb
-- lib/coda_standard/line.rb
 - lib/coda_standard/parser.rb
+- lib/coda_standard/record.rb
 - lib/coda_standard/transaction.rb
 - lib/coda_standard/transaction_list.rb
 - lib/coda_standard/version.rb
 - spec/coda.cod
-- spec/line_spec.rb
 - spec/parser_spec.rb
+- spec/record_spec.rb
 - spec/spec_helper.rb
 - spec/transaction_list_spec.rb
 homepage: https://github.com/Bluesmile82/coda_standard
@@ -102,7 +102,7 @@ specification_version: 4
 summary: CODA bank standard file parser
 test_files:
 - spec/coda.cod
-- spec/line_spec.rb
 - spec/parser_spec.rb
+- spec/record_spec.rb
 - spec/spec_helper.rb
 - spec/transaction_list_spec.rb

data/spec/line_spec.rb

@@ -1,93 +0,0 @@
-require_relative 'spec_helper'
-
-describe CodaStandard::Line do
-  before :each do
-    @line0 = CodaStandard::Line.new("0000031031520005                  MMIF SA/BANK              GEBABEBB   00538839354 00000                                       2")
-    @line1 = CodaStandard::Line.new("10016539007547034 EUR0BE                  0000000057900000300315MMIF SA/EVOCURE                                              017")
-    @line21 = CodaStandard::Line.new("21000100000001500000103        0000000000500000010415001500001101100000834941                                      31031501601 0")
-    @line21b = CodaStandard::Line.new("21000100000001500000103        0000000000500000010415001500001001100000834941                                      31031501601 0")
-    @line22 = CodaStandard::Line.new("2200010000                                                                                        GKCCBEBB                   1 0")
-    @line23 = CodaStandard::Line.new("2300010000BE53900754703405                  EURLASTNM PERSON                                                                 0 1")
-    @line32 = CodaStandard::Line.new("32000200015 STREET                                     3654 CITY BELGIQUE                                                    0 0")
-    end
-
-  describe "current_bic" do
-    it "extracts the current_bic" do
-      expect(@line0.current_bic).to eq("GEBABEBB")
-    end
-  end
-
-  describe "current_account" do
-    it "extracts the current_account" do
-      expect(@line1.current_account).to eq({account_number:"539007547034", account_type:"bban_be_account"})
-    end
-  end
-
-  describe "old_balance" do
-    it "extracts the old_balance" do
-      expect(@line1.old_balance).to eq("57900,000")
-    end
-  end
-
-  describe "entry_date" do
-    it "extracts the entry_date" do
-      expect(@line21.entry_date).to eq("310315")
-    end
-  end
-
-  describe "reference_number" do
-    it "extracts the reference_number" do
-      expect(@line21.reference_number).to eq("0001500000103")
-    end
-  end
-
-  describe "amount" do
-    it "extracts the amount" do
-      expect(@line21.amount).to eq("500,000")
-    end
-  end
-
-  describe "bic" do
-    it "extracts the bic" do
-      expect(@line22.bic).to eq("GKCCBEBB")
-    end
-  end
-
-  describe "currency" do
-    it "extracts the currency" do
-      expect(@line23.currency).to eq("EUR")
-    end
-  end
-
-  describe "name" do
-    it "extracts the name" do
-      expect(@line23.name).to eq("LASTNM PERSON")
-    end
-  end
-
-  describe "account" do
-    it "extracts the account" do
-      expect(@line23.account).to eq("BE53900754703405")
-    end
-  end
-
-  describe "transaction_number" do
-    context "structured_number" do
-      it "extracts the number" do
-        expect(@line21.transaction_number).to eq("100000834941")
-      end
-    end
-    context "non-structured_number" do
-      it "returns not structured" do
-        expect(@line21b.transaction_number).to eq("not structured")
-      end
-    end
-  end
-
-  describe "address" do
-    it "extracts the address" do
-      expect(@line32.address).to eq({:address=>"5 STREET", :postcode=>"3654", :city=>"CITY", :country=>" BELGIQUE"})
-    end
-  end
-
-end