coda_standard 0.1.2 → 0.1.3

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 642ed89a40b23ef43c468b8087c29f0af3e1bea3
-  data.tar.gz: d3c4a4a533aad85c8fb64ccd4c414737f85c39d1
+  metadata.gz: 4736e6a722c4f15a13d9ca03d58d0aee055173a4
+  data.tar.gz: 326312b1f946d0946fa6fae52b8b2285f037cf96
 SHA512:
-  metadata.gz: 409f68bb12632332bffe9a980f35bef829896e843c10a128dd03c7a5c3d0eb6f6f7d7adfadd895b60f301b391b20b2fb1a8aeec714d325d302ae4497a8d20ddd
-  data.tar.gz: 64416cd18dbca8e0f696fc023ef3132e84cc831f9cac51b3a2628d200a4eed543f3b06ee7b51a5ea77a3fc5a9e946cd806c7f4ea9d4fec2e5289c980c33ca094
+  metadata.gz: c1eda00743d3e70d3ce79fa2781067bb81c20b3b236f84f1a0465f4dcad8a3665bed5e0bf08971c527a0c3f95382d766ad0c51a6867345d2bbe7ff962a164eed
+  data.tar.gz: f72454d377adacc424be90df42cd8107058138ecf46d15ed0254453c59034f35e1c9d47b00fe7b14c6d7fcc769688d73f39359efe97ba713a0f84f74f60ce5f9

data/README.md

@@ -35,6 +35,9 @@ You can get different common data from the TransactionList (current_bic, old_bal
 
 Shows the transactions info in the terminal
 
+The info you can get from each transaction is:
+  name, currency, bic, address, postcode, city, country, amount, account, entry_date, reference_number and transaction_number
+
 ## Contributing
 
 1. Fork it ( https://github.com/Bluesmile82/coda_standard/fork )

data/lib/coda_standard/line.rb

@@ -23,6 +23,8 @@ module CodaStandard
         bban_foreign_account: /(^.{34})/,
         iban_be_account: /(^.{31})/,
         iban_foreign_account: /(^.{34})/,
+        transaction_number: /^21.{60}(.{15})/,
+        clean_structured: /.{3}(.{12})/,
         currencies:/(^.+)(AED|AFN|ALL|AMD|ANG|AOA|ARS|AUD|AWG|AZN|BAM|BBD|BDT|BGN|BHD|BIF|BMD|BND|BOB|BOV|BRL|BSD|BTN|BWP|BYR|BZD|CAD|CDF|CHE|CHF|CHW|CLF|CLP|CNY|COP|COU|CRC|CUC|CUP|CVE|CZK|DJF|DKK|DOP|DZD|EGP|ERN|ETB|EUR|FJD|FKP|GBP|GEL|GHS|GIP|GMD|GNF|GTQ|GYD|HKD|HNL|HRK|HTG|HUF|IDR|ILS|INR|IQD|IRR|ISK|JMD|JOD|JPY|KES|KGS|KHR|KMF|KPW|KRW|KWD|KYD|KZT|LAK|LBP|LKR|LRD|LSL|LTL|LVL|LYD|MAD|MDL|MGA|MKD|MMK|MNT|MOP|MRO|MUR|MVR|MWK|MXN|MXV|MYR|MZN|NAD|NGN|NIO|NOK|NPR|NZD|OMR|PAB|PEN|PGK|PHP|PKR|PLN|PYG|QAR|RON|RSD|RUB|RWF|SAR|SBD|SCR|SDG|SEK|SGD|SHP|SLL|SOS|SRD|SSP|STD|SVC|SYP|SZL|THB|TJS|TMT|TND|TOP|TRY|TTD|TWD|TZS|UAH|UGX|USD|USN|USS|UYI|UYU|UZS|VEF|VND|VUV|WST|XAF|XAG|XAU|XBA|XBB|XBC|XBD|XCD|XDR|XFU|XOF|XPD|XPF|XPT|XSU|XTS|XUA|XXX|YER|ZAR|ZMW|ZWL)/
       }
     end
@@ -71,6 +73,10 @@ module CodaStandard
       extract(:address)
     end
 
+    def transaction_number
+      extract(:transaction_number)
+    end
+
     private
 
     def extract(field)
@@ -82,6 +88,8 @@ module CodaStandard
           result = clean_account(result)
         when :old_balance, :amount
           result = clean_zeros(result)
+        when :transaction_number
+          result = check_structured(result)
       end
       result
     end
@@ -93,7 +101,7 @@ module CodaStandard
 
     def clean_account(account)
       account_type = account.scan(@regexp[:sep_account])[0][0]
-      sequence_number = account.scan(@regexp[:sep_account])[0][1]
+      # sequence_number = account.scan(@regexp[:sep_account])[0][1]
       raw_account = account.scan(@regexp[:sep_account])[0][2]
       case account_type
         when "0" then account_type = "bban_be_account"
@@ -112,5 +120,14 @@ module CodaStandard
       separator = ","
       amount_sign + amount_integral + separator + amount_decimals
     end
+
+    def check_structured(number)
+      if number[0] == "1"
+        structured = true
+        number.scan(@regexp[:clean_structured]).join
+      else
+        "not structured"
+      end
+    end
   end
 end

data/lib/coda_standard/parser.rb

@@ -20,6 +20,7 @@ module CodaStandard
           @current_transaction.entry_date = line.entry_date
           @current_transaction.reference_number = line.reference_number
           @current_transaction.amount = line.amount
+          @current_transaction.transaction_number = line.transaction_number
         when line.line =~ /^22/
           @current_transaction.bic = line.bic
         when line.line =~ /^23/
@@ -51,7 +52,7 @@ module CodaStandard
       puts "Account: #{@transactions.current_account} Account type: #{@transactions.current_account_type} BIC: #{@transactions.current_bic}"
       puts "Old balance: #{@transactions.old_balance} \n\n"
       @transactions.each_with_index do |transaction, index|
-        puts "-- Transaction n.#{index + 1} in date #{transaction.entry_date}-- \n\n"
+        puts "-- Transaction n.#{index + 1} - number #{transaction.transaction_number} - in date #{transaction.entry_date}-- \n\n"
         puts "   RN: #{transaction.reference_number} Account: #{transaction.account} BIC:#{transaction.bic}"
         puts "   Amount: #{transaction.amount} #{transaction.currency}"
         puts "   Name: #{transaction.name}"

data/lib/coda_standard/transaction.rb

@@ -1,5 +1,5 @@
 module CodaStandard
   class Transaction
-    attr_accessor :name, :currency, :bic, :address, :postcode, :city, :country, :amount, :account, :entry_date, :reference_number
+    attr_accessor :name, :currency, :bic, :address, :postcode, :city, :country, :amount, :account, :entry_date, :reference_number, :transaction_number
   end
 end

data/lib/coda_standard/version.rb

@@ -1,3 +1,3 @@
 module CodaStandard
-  VERSION = "0.1.2"
+  VERSION = "0.1.3"
 end

data/spec/line_spec.rb

@@ -2,12 +2,13 @@ require_relative 'spec_helper'
 
 describe CodaStandard::Line do
   before :each do
-    @line0 = CodaStandard::Line.new("0000031031520005                  MMIF SA/EVOCURE           GEBABEBB   00538839354 00000                                       2")
-    @line1 = CodaStandard::Line.new("10016035918134040 EUR0BE                  0000000057900000300315MMIF SA/EVOCURE                                              017")
+    @line0 = CodaStandard::Line.new("0000031031520005                  MMIF SA/BANK              GEBABEBB   00538839354 00000                                       2")
+    @line1 = CodaStandard::Line.new("10016539007547034 EUR0BE                  0000000057900000300315MMIF SA/EVOCURE                                              017")
     @line21 = CodaStandard::Line.new("21000100000001500000103        0000000000500000010415001500001101100000834941                                      31031501601 0")
+    @line21b = CodaStandard::Line.new("21000100000001500000103        0000000000500000010415001500001001100000834941                                      31031501601 0")
     @line22 = CodaStandard::Line.new("2200010000                                                                                        GKCCBEBB                   1 0")
-    @line23 = CodaStandard::Line.new("2300010000BE96553242750005                  EURCOUREL PASCAL                                                                 0 1")
-    @line32 = CodaStandard::Line.new("3200010001CHAUSSEE DE MALINES 10             1970 WEZEMBEEK-OPPEM                                                            0 0")
+    @line23 = CodaStandard::Line.new("2300010000BE53900754703405                  EURLASTNM PERSON                                                                 0 1")
+    @line32 = CodaStandard::Line.new("32000200015 STREET                                     3654 CITY BELGIQUE                                                    0 0")
     end
 
   describe "current_bic" do
@@ -18,7 +19,7 @@ describe CodaStandard::Line do
 
   describe "current_account" do
     it "extracts the current_account" do
-      expect(@line1.current_account).to eq({account_number:"035918134040", account_type:"bban_be_account"})
+      expect(@line1.current_account).to eq({account_number:"539007547034", account_type:"bban_be_account"})
     end
   end
 
@@ -60,19 +61,32 @@ describe CodaStandard::Line do
 
   describe "name" do
     it "extracts the name" do
-      expect(@line23.name).to eq("COUREL PASCAL")
+      expect(@line23.name).to eq("LASTNM PERSON")
     end
   end
 
   describe "account" do
     it "extracts the account" do
-      expect(@line23.account).to eq("BE96553242750005")
+      expect(@line23.account).to eq("BE53900754703405")
+    end
+  end
+
+  describe "transaction_number" do
+    context "structured_number" do
+      it "extracts the number" do
+        expect(@line21.transaction_number).to eq("100000834941")
+      end
+    end
+    context "non-structured_number" do
+      it "returns not structured" do
+        expect(@line21b.transaction_number).to eq("not structured")
+      end
     end
   end
 
   describe "address" do
     it "extracts the address" do
-      expect(@line32.address).to eq({:address=>"CHAUSSEE DE MALINES 10", :postcode=>"1970", :city=>"WEZEMBEEK-OPPEM", :country=>nil})
+      expect(@line32.address).to eq({:address=>"5 STREET", :postcode=>"3654", :city=>"CITY", :country=>" BELGIQUE"})
     end
   end
 

data/spec/parser_spec.rb

@@ -63,7 +63,7 @@ describe CodaStandard::Parser do
 
   describe "show" do
     it "shows the info from the transactions" do
-      expect{@parser.show(@file_name)}.to output("**--Transactions--**\n\nAccount: 539007547034 Account type: bban_be_account BIC: GEBABEBB\nOld balance: 57900,000 \n\n-- Transaction n.1 in date 310315-- \n\n   RN: 0001500000103 Account: BE53900754703405 BIC:GKCCBEBB\n   Amount: 500,000 EUR\n   Name: LASTNM PERSON\n   Address: CHAUSSEE DE BIERE 10 1978 SOMECITY  \n\n-- Transaction n.2 in date 310315-- \n\n   RN: 0001500000104 Account: LU539007547034898400 BIC:BILLLULL\n   Amount: 200,000 EUR\n   Name: M.JOHN DOE\n   Address: 5 STREET 3654 CITY  BELGIQUE \n\n").to_stdout
+      expect{@parser.show(@file_name)}.to output("**--Transactions--**\n\nAccount: 539007547034 Account type: bban_be_account BIC: GEBABEBB\nOld balance: 57900,000 \n\n-- Transaction n.1 - number 100000834941 - in date 310315-- \n\n   RN: 0001500000103 Account: BE53900754703405 BIC:GKCCBEBB\n   Amount: 500,000 EUR\n   Name: LASTNM PERSON\n   Address: CHAUSSEE DE BIERE 10 1978 SOMECITY  \n\n-- Transaction n.2 - number 100000835749 - in date 310315-- \n\n   RN: 0001500000104 Account: LU539007547034898400 BIC:BILLLULL\n   Amount: 200,000 EUR\n   Name: M.JOHN DOE\n   Address: 5 STREET 3654 CITY  BELGIQUE \n\n").to_stdout
     end
   end
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: coda_standard
 version: !ruby/object:Gem::Version
-  version: 0.1.2
+  version: 0.1.3
 platform: ruby
 authors:
 - Alvaro Leal
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2015-04-09 00:00:00.000000000 Z
+date: 2015-04-13 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: bundler