cocoapods 0.33.1 → 0.34.0.rc1

data/lib/cocoapods/hooks/library_representation.rb

@@ -1,7 +1,6 @@
 module Pod
   module Hooks
     class LibraryRepresentation
-
       # Stores the information of the target installer
 
       #-----------------------------------------------------------------------#
@@ -27,11 +26,11 @@ module Pod
       # @return [Pathname] The path of the prefix_header
       #
       def prefix_header_path
-        UI.warn "LibraryRepresentation#prefix_header_path is deprecated. " \
-          "Use the specification `prefix_header_contents` attribute."
+        UI.warn 'LibraryRepresentation#prefix_header_path is deprecated. ' \
+          'Use the specification `prefix_header_contents` attribute.'
         library.prefix_header_path
       end
-      alias :prefix_header_filename :prefix_header_path
+      alias_method :prefix_header_filename, :prefix_header_path
 
       # @return [Pathname] The path of the script used to copy the resources.
       #
@@ -83,13 +82,10 @@ module Pod
       def initialize(sandbox, library)
         @sandbox = sandbox
         @library = library
-        raise "[BUG]" unless library.is_a?(AggregateTarget)
+        raise '[BUG]' unless library.is_a?(AggregateTarget)
       end
 
       #-----------------------------------------------------------------------#
-
     end
   end
 end
-
-

data/lib/cocoapods/hooks/pod_representation.rb

@@ -1,19 +1,16 @@
 module Pod
-
   class Specification
     def config
       UI.warn "[#{name}] Specification#config is deprecated. The config is accessible from " \
-        "the parameter passed to the hooks"
+        'the parameter passed to the hooks'
       Config.instance
     end
   end
 
   module Hooks
-
     # Stores the information of the Installer for the hooks
     #
     class PodRepresentation
-
       # @return [String]
       #
       attr_accessor :name
@@ -68,7 +65,6 @@ module Pod
       attr_reader :file_accessors
 
       #-----------------------------------------------------------------------#
-
     end
   end
 end

data/lib/cocoapods/hooks_manager.rb

@@ -0,0 +1,63 @@
+module Pod
+  # Provides support for the hook system of CocoaPods. The system is designed
+  # especially for plugins. Interested clients can register to notifications by
+  # name.
+  #
+  # The blocks, to prevent compatibility issues, will receive
+  # one and only one argument: a context object. This object should be simple
+  # storage of information (a typed hash). Notifications senders are
+  # responsible to indicate the class of the object associated with their
+  # notification name.
+  #
+  # Context object should not remove attribute accessors to not break
+  # compatibility with the plugins (this promise will be honoured strictly
+  # from CocoaPods 1.0).
+  #
+  module HooksManager
+    class << self
+      # @return [Hash{Symbol => Proc}] The list of the blocks that are
+      #         registered for each notification name.
+      #
+      attr_reader :registrations
+
+      # Registers a block for the hook with the given name.
+      #
+      # @param  [Symbol] name
+      #         The name of the notification.
+      #
+      # @param  [Proc] block
+      #         The block.
+      #
+      def register(name, &block)
+        raise ArgumentError, 'Missing name' unless name
+        raise ArgumentError, 'Missing block' unless block
+
+        @registrations ||= {}
+        @registrations[name] ||= []
+        @registrations[name] << block
+      end
+
+      # Runs all the registered blocks for the hook with the given name.
+      #
+      # @param  [Symbol] name
+      #         The name of the hook.
+      #
+      # @param  [Object] context
+      #         The context object which should be passed to the blocks.
+      #
+      def run(name, context)
+        raise ArgumentError, 'Missing name' unless name
+        raise ArgumentError, 'Missing options' unless context
+
+        if @registrations
+          blocks = @registrations[name]
+          if blocks
+            blocks.each do |block|
+              block.call(context)
+            end
+          end
+        end
+      end
+    end
+  end
+end

data/lib/cocoapods/installer.rb

@@ -1,7 +1,6 @@
 require 'active_support/core_ext/string/inflections'
 
 module Pod
-
   # The Installer is responsible of taking a Podfile and transform it in the
   # Pods libraries. It also integrates the user project so the Pods
   # libraries can be used out of the box.
@@ -29,13 +28,14 @@ module Pod
   # source control.
   #
   class Installer
-
+    autoload :AggregateTargetInstaller, 'cocoapods/installer/target_installer/aggregate_target_installer'
     autoload :Analyzer,                 'cocoapods/installer/analyzer'
     autoload :FileReferencesInstaller,  'cocoapods/installer/file_references_installer'
+    autoload :HooksContext,             'cocoapods/installer/hooks_context'
+    autoload :Migrator,                 'cocoapods/installer/migrator'
     autoload :PodSourceInstaller,       'cocoapods/installer/pod_source_installer'
-    autoload :TargetInstaller,          'cocoapods/installer/target_installer'
-    autoload :AggregateTargetInstaller, 'cocoapods/installer/target_installer/aggregate_target_installer'
     autoload :PodTargetInstaller,       'cocoapods/installer/target_installer/pod_target_installer'
+    autoload :TargetInstaller,          'cocoapods/installer/target_installer'
     autoload :UserProjectIntegrator,    'cocoapods/installer/user_project_integrator'
 
     include Config::Mixin
@@ -73,7 +73,7 @@ module Pod
 
     # Installs the Pods.
     #
-    # The installation process of is mostly linear with few minor complications
+    # The installation process is mostly linear with a few minor complications
     # to keep in mind:
     #
     # - The stored podspecs need to be cleaned before the resolution step
@@ -86,6 +86,7 @@ module Pod
     # @return [void]
     #
     def install!
+      prepare
       resolve_dependencies
       download_dependencies
       generate_pods_project
@@ -93,16 +94,24 @@ module Pod
       perform_post_install_actions
     end
 
+    def prepare
+      UI.section 'Preparing' do
+        sandbox.prepare
+        Migrator.migrate(sandbox)
+      end
+    end
+
     def resolve_dependencies
-      UI.section "Analyzing dependencies" do
+      UI.section 'Analyzing dependencies' do
         analyze
+        validate_build_configurations
         prepare_for_legacy_compatibility
         clean_sandbox
       end
     end
 
     def download_dependencies
-      UI.section "Downloading dependencies" do
+      UI.section 'Downloading dependencies' do
         create_file_accessors
         install_pod_sources
         run_pre_install_hooks
@@ -111,13 +120,12 @@ module Pod
     end
 
     def generate_pods_project
-      UI.section "Generating Pods project" do
+      UI.section 'Generating Pods project' do
         prepare_pods_project
         install_file_references
         install_libraries
         set_target_dependencies
-        link_aggregate_target
-        run_post_install_hooks
+        run_podfile_post_install_hooks
         write_pod_project
         write_lockfiles
       end
@@ -177,6 +185,23 @@ module Pod
       @aggregate_targets = analyzer.result.targets
     end
 
+    # Ensures that the white-listed build configurations are known to prevent
+    # silent typos.
+    #
+    # @raise  If a unknown user configuration is found.
+    #
+    def validate_build_configurations
+      whitelisted_configs = pod_targets.map do |target|
+        target.target_definition.all_whitelisted_configurations.map(&:downcase)
+      end.flatten.uniq
+      all_user_configurations = analysis_result.all_user_build_configurations.keys.map(&:downcase)
+
+      remainder = whitelisted_configs - all_user_configurations
+      unless remainder.empty?
+        raise Informative, "Unknown #{'configuration'.pluralize(remainder.size)} whitelisted: #{remainder.sort.to_sentence}."
+      end
+    end
+
     # Prepares the Pods folder in order to be compatible with the most recent
     # version of CocoaPods.
     #
@@ -201,7 +226,7 @@ module Pod
       end
 
       unless sandbox_state.deleted.empty?
-        title_options = { :verbose_prefix => "-> ".red }
+        title_options = { :verbose_prefix => '-> '.red }
         sandbox_state.deleted.each do |pod_name|
           UI.titled_section("Removing #{pod_name}".red, title_options) do
             sandbox.clean_pod(pod_name)
@@ -235,7 +260,7 @@ module Pod
     def install_pod_sources
       @installed_specs = []
       pods_to_install = sandbox_state.added | sandbox_state.changed
-      title_options = { :verbose_prefix => "-> ".green }
+      title_options = { :verbose_prefix => '-> '.green }
       root_specs.sort_by(&:name).each do |spec|
         if pods_to_install.include?(spec.name)
           if sandbox_state.changed.include?(spec.name) && sandbox.manifest
@@ -270,7 +295,6 @@ module Pod
 
       @pod_installers ||= []
       pod_installer = PodSourceInstaller.new(sandbox, specs_by_platform)
-      pod_installer.aggressive_cache = config.aggressive_cache?
       pod_installer.install!
       @pod_installers << pod_installer
       @installed_specs.concat(specs_by_platform.values.flatten.uniq)
@@ -283,9 +307,7 @@ module Pod
     def clean_pod_sources
       return unless config.clean?
       return unless @pod_installers
-      @pod_installers.each do |pod_installer|
-        pod_installer.clean!
-      end
+      @pod_installers.each(&:clean!)
     end
 
     # Performs any post-installation actions
@@ -293,9 +315,17 @@ module Pod
     # @return [void]
     #
     def perform_post_install_actions
+      run_plugins_post_install_hooks
       warn_for_deprecations
     end
 
+    # Runs the registered callbacks for the plugins post install hooks.
+    #
+    def run_plugins_post_install_hooks
+      context = HooksContext.generate(sandbox, aggregate_targets)
+      HooksManager.run(:post_install, context)
+    end
+
     # Prints a warning for any pods that are deprecated
     #
     # @return [void]
@@ -321,7 +351,7 @@ module Pod
     # @todo   Clean and modify the project if it exists.
     #
     def prepare_pods_project
-      UI.message "- Creating Pods project" do
+      UI.message '- Creating Pods project' do
         @pods_project = Pod::Project.new(sandbox.project_path)
 
         analysis_result.all_user_build_configurations.each do |name, type|
@@ -353,7 +383,6 @@ module Pod
       end
     end
 
-
     # Installs the file references in the Pods project. This is done once per
     # Pod as the same file reference might be shared by multiple aggregate
     # targets.
@@ -371,7 +400,7 @@ module Pod
     # @return [void]
     #
     def install_libraries
-      UI.message"- Installing libraries" do
+      UI.message '- Installing targets' do
         pod_targets.sort_by(&:name).each do |pod_target|
           next if pod_target.target_definition.empty?
           target_installer = PodTargetInstaller.new(sandbox, pod_target)
@@ -415,21 +444,6 @@ module Pod
       end
     end
 
-    # Links the aggregate targets with all the dependent libraries.
-    #
-    # @note   This is run in the integration step to ensure that targets
-    #         have been created for all per spec libraries.
-    #
-    def link_aggregate_target
-      aggregate_targets.each do |aggregate_target|
-        native_target = aggregate_target.target
-        aggregate_target.pod_targets.each do |pod_target|
-          product = pod_target.target.product_reference
-          native_target.frameworks_build_phase.add_file_reference(product)
-        end
-      end
-    end
-
     # Writes the Pods project to the disk.
     #
     # @return [void]
@@ -438,7 +452,7 @@ module Pod
       UI.message "- Writing Xcode project file to #{UI.path sandbox.project_path}" do
         pods_project.pods.remove_from_project if pods_project.pods.empty?
         pods_project.development_pods.remove_from_project if pods_project.development_pods.empty?
-        pods_project.sort({:groups_position => :below})
+        pods_project.sort(:groups_position => :below)
         pods_project.recreate_user_schemes(false)
         pods_project.save
       end
@@ -494,9 +508,9 @@ module Pod
     # @return [void]
     #
     def run_pre_install_hooks
-      UI.message "- Running pre install hooks" do
+      UI.message '- Running pre install hooks' do
         executed = run_podfile_pre_install_hook
-        UI.message "- Podfile" if executed
+        UI.message '- Podfile' if executed
       end
     end
 
@@ -509,8 +523,8 @@ module Pod
     def run_podfile_pre_install_hook
       podfile.pre_install!(installer_rep)
     rescue => e
-      raise Informative, "An error occurred while processing the pre-install " \
-        "hook of the Podfile." \
+      raise Informative, 'An error occurred while processing the pre-install ' \
+        'hook of the Podfile.' \
         "\n\n#{e.message}\n\n#{e.backtrace * "\n"}"
     end
 
@@ -521,10 +535,10 @@ module Pod
     #
     # @return [void]
     #
-    def run_post_install_hooks
-      UI.message "- Running post install hooks" do
+    def run_podfile_post_install_hooks
+      UI.message '- Running post install hooks' do
         executed = run_podfile_post_install_hook
-        UI.message "- Podfile" if executed
+        UI.message '- Podfile' if executed
       end
     end
 
@@ -537,8 +551,8 @@ module Pod
     def run_podfile_post_install_hook
       podfile.post_install!(installer_rep)
     rescue => e
-      raise Informative, "An error occurred while processing the post-install " \
-        "hook of the Podfile." \
+      raise Informative, 'An error occurred while processing the post-install ' \
+        'hook of the Podfile.' \
         "\n\n#{e.message}\n\n#{e.backtrace * "\n"}"
     end
 
@@ -582,7 +596,7 @@ module Pod
     # @return [Array<PodRepresentation>]
     #
     def pod_reps
-      root_specs.sort_by { |spec| spec.name }.map { |spec| pod_rep(spec.name) }
+      root_specs.sort_by(&:name).map { |spec| pod_rep(spec.name) }
     end
 
     # Returns the libraries which use the given specification.
@@ -615,7 +629,7 @@ module Pod
     #         installation.
     #
     def root_specs
-      analysis_result.specifications.map { |spec| spec.root }.uniq
+      analysis_result.specifications.map(&:root).uniq
     end
 
     # @return [SpecsState] The state of the sandbox returned by the analyzer.
@@ -625,6 +639,5 @@ module Pod
     end
 
     #-------------------------------------------------------------------------#
-
   end
 end

data/lib/cocoapods/installer/analyzer.rb

@@ -1,11 +1,9 @@
 module Pod
   class Installer
-
     # Analyzes the Podfile, the Lockfile, and the sandbox manifest to generate
     # the information relative to a CocoaPods installation.
     #
     class Analyzer
-
       include Config::Mixin
 
       autoload :SandboxAnalyzer, 'cocoapods/installer/analyzer/sandbox_analyzer'
@@ -49,10 +47,10 @@ module Pod
       def analyze(allow_fetches = true)
         update_repositories_if_needed if allow_fetches
         @result = AnalysisResult.new
+        compute_target_platforms
         @result.podfile_state = generate_podfile_state
         @locked_dependencies  = generate_version_locking_dependencies
 
-        compute_target_platforms
         fetch_external_sources if allow_fetches
         @result.specs_by_target = resolve_dependencies
         @result.specifications  = generate_specifications
@@ -111,7 +109,7 @@ module Pod
           :none
         elsif update == true
           :all
-        elsif update[:pods] != nil
+        elsif !update[:pods].nil?
           :selected
         end
       end
@@ -125,7 +123,7 @@ module Pod
       #         modification of the sandbox in the resolution process.
       #
       attr_accessor :allow_pre_downloads
-      alias_method  :allow_pre_downloads?, :allow_pre_downloads
+      alias_method :allow_pre_downloads?, :allow_pre_downloads
 
       #-----------------------------------------------------------------------#
 
@@ -149,10 +147,11 @@ module Pod
       def generate_podfile_state
         if lockfile
           pods_state = nil
-          UI.section "Finding Podfile changes" do
+          UI.section 'Finding Podfile changes' do
             pods_by_state = lockfile.detect_changes_with_podfile(podfile)
             pods_by_state.dup.each do |state, full_names|
-              pods_by_state[state] = full_names.map { |fn| Specification.root_name(fn) }
+              pods = full_names.map { |fn| Specification.root_name(fn) }.uniq
+              pods_by_state[state] = pods
             end
             pods_state = SpecsState.new(pods_by_state)
             pods_state.print
@@ -167,8 +166,6 @@ module Pod
 
       # Updates the source repositories unless the config indicates to skip it.
       #
-      # @return [void]
-      #
       def update_repositories_if_needed
         unless config.skip_repo_update?
           UI.section 'Updating spec repositories' do
@@ -200,7 +197,7 @@ module Pod
           else
             target.client_root = config.installation_root
             target.user_target_uuids = []
-            target.user_build_configurations = {}
+            target.user_build_configurations = target_definition.build_configurations || {}
             if target_definition.platform.name == :osx
               target.archs = '$(ARCHS_STANDARD_64_BIT)'
             end
@@ -212,15 +209,15 @@ module Pod
 
           grouped_specs.each do |pod_specs|
             pod_target = PodTarget.new(pod_specs, target_definition, sandbox)
-          if config.integrate_targets?
-            pod_target.user_build_configurations = target.user_build_configurations
-            pod_target.archs = @archs_by_target_def[target_definition]
-          else
-            pod_target.user_build_configurations = {}
-            if target_definition.platform.name == :osx
-              pod_target.archs = '$(ARCHS_STANDARD_64_BIT)'
+            if config.integrate_targets?
+              pod_target.user_build_configurations = target.user_build_configurations
+              pod_target.archs = @archs_by_target_def[target_definition]
+            else
+              pod_target.user_build_configurations = {}
+              if target_definition.platform.name == :osx
+                pod_target.archs = '$(ARCHS_STANDARD_64_BIT)'
+              end
             end
-          end
             target.pod_targets << pod_target
           end
         end
@@ -247,8 +244,8 @@ module Pod
             locking_pods = locking_pods.select { |pod| !update[:pods].include?(pod) }
           end
           locking_pods.map do |pod|
-            lockfile.dependency_to_lock_pod_named(pod)
-          end
+            lockfile.dependencies_to_lock_pod_named(pod)
+          end.flatten
         end
       end
 
@@ -275,7 +272,7 @@ module Pod
         return unless allow_pre_downloads?
         deps_to_fetch = []
         deps_to_fetch_if_needed = []
-        deps_with_external_source = podfile.dependencies.select { |dep| dep.external_source }
+        deps_with_external_source = podfile.dependencies.select(&:external_source)
 
         if update_mode == :all
           deps_to_fetch = deps_with_external_source
@@ -290,7 +287,7 @@ module Pod
         end
 
         unless deps_to_fetch.empty?
-          UI.section "Fetching external sources" do
+          UI.section 'Fetching external sources' do
             deps_to_fetch.uniq.sort.each do |dependency|
               source = ExternalSources.from_dependency(dependency, podfile.defined_in_file)
               source.fetch(sandbox)
@@ -321,7 +318,13 @@ module Pod
       def resolve_dependencies
         specs_by_target = nil
         UI.section "Resolving dependencies of #{UI.path podfile.defined_in_file}" do
-          resolver = Resolver.new(sandbox, podfile, locked_dependencies)
+          if podfile.sources.empty?
+            sources = SourcesManager.master
+          else
+            sources = SourcesManager.sources(podfile.sources)
+          end
+
+          resolver = Resolver.new(sandbox, podfile, locked_dependencies, sources)
           specs_by_target = resolver.resolve
         end
         specs_by_target
@@ -343,7 +346,7 @@ module Pod
       #
       def generate_sandbox_state
         sandbox_state = nil
-        UI.section "Comparing resolved specification to the sandbox manifest" do
+        UI.section 'Comparing resolved specification to the sandbox manifest' do
           sandbox_analyzer = SandboxAnalyzer.new(sandbox, result.specifications, update_mode?, lockfile)
           sandbox_state = sandbox_analyzer.analyze
           sandbox_state.print
@@ -381,7 +384,7 @@ module Pod
           path = "#{path}.xcodeproj" unless File.extname(path) == '.xcodeproj'
           path = Pathname.new(path)
           unless path.exist?
-            raise Informative, "Unable to find the Xcode project " \
+            raise Informative, 'Unable to find the Xcode project ' \
               "`#{path}` for the target `#{target_definition.label}`."
           end
 
@@ -390,7 +393,7 @@ module Pod
           if xcodeprojs.size == 1
             path = xcodeprojs.first
           else
-            raise Informative, "Could not automatically select an Xcode project. " \
+            raise Informative, 'Could not automatically select an Xcode project. ' \
               "Specify one in your Podfile like so:\n\n" \
               "    xcodeproj 'path/to/Project.xcodeproj'\n"
           end
@@ -417,12 +420,12 @@ module Pod
           targets = native_targets(user_project).select { |t| link_with.include?(t.name) }
           raise Informative, "Unable to find the targets named `#{link_with.to_sentence}` to link with target definition `#{target_definition.name}`" if targets.empty?
         elsif target_definition.link_with_first_target?
-          targets = [ native_targets(user_project).first ].compact
-          raise Informative, "Unable to find a target" if targets.empty?
+          targets = [native_targets(user_project).first].compact
+          raise Informative, 'Unable to find a target' if targets.empty?
         else
           target = native_targets(user_project).find { |t| t.name == target_definition.name.to_s }
-          targets = [ target ].compact
-          raise Informative, "Unable to find a target named `#{target_definition.name.to_s}`" if targets.empty?
+          targets = [target].compact
+          raise Informative, "Unable to find a target named `#{target_definition.name}`" if targets.empty?
         end
         targets
       end
@@ -442,10 +445,8 @@ module Pod
       #
       def compute_user_build_configurations(target_definition, user_targets)
         if user_targets
-          user_targets.map { |t| t.build_configurations.map(&:name) }.flatten.inject({}) do |hash, name|
-            unless name == 'Debug' || name == 'Release'
-              hash[name] = :release
-            end
+          user_targets.map { |t| t.build_configurations.map(&:name) }.flatten.reduce({}) do |hash, name|
+            hash[name] = name == 'Debug' ? :debug : :release
             hash
           end.merge(target_definition.build_configurations || {})
         else
@@ -468,7 +469,7 @@ module Pod
 
         user_targets.each do |target|
           name ||= target.platform_name
-          raise Informative, "Targets with different platforms" unless name == target.platform_name
+          raise Informative, 'Targets with different platforms' unless name == target.platform_name
           if !deployment_target || deployment_target > Version.new(target.deployment_target)
             deployment_target = Version.new(target.deployment_target)
           end
@@ -494,12 +495,10 @@ module Pod
         end
 
         archs = archs.compact.uniq.sort
-        if archs.count > 1
-          UI.warn "Found multiple values (`#{archs.join('`, `')}`) for the " \
-          "architectures (`ARCHS`) build setting for the " \
-          "`#{target_definition}` target definition. Using the first."
-        end
-        archs.first
+        UI.message("Using `ARCHS` setting to build architectures of " \
+                   "target `#{target_definition.label}`: " \
+                   "(`#{archs.join('`, `')}`)")
+        archs.length > 1 ? archs : archs.first
       end
 
       # Precompute the platforms for each target_definition in the Podfile
@@ -511,17 +510,19 @@ module Pod
       # @return [void]
       #
       def compute_target_platforms
-        podfile.target_definition_list.each do |target_definition|
-          if config.integrate_targets?
-            project_path = compute_user_project_path(target_definition)
-            user_project = Xcodeproj::Project.open(project_path)
-            targets = compute_user_project_targets(target_definition, user_project)
-            platform = compute_platform_for_target_definition(target_definition, targets)
-            archs = compute_archs_for_target_definition(target_definition, targets)
-            @archs_by_target_def[target_definition] = archs
-          else
-            unless target_definition.platform
-              raise Informative, "It is necessary to specify the platform in the Podfile if not integrating."
+        UI.section 'Inspecting targets to integrate' do
+          podfile.target_definition_list.each do |target_definition|
+            if config.integrate_targets?
+              project_path = compute_user_project_path(target_definition)
+              user_project = Xcodeproj::Project.open(project_path)
+              targets = compute_user_project_targets(target_definition, user_project)
+              platform = compute_platform_for_target_definition(target_definition, targets)
+              archs = compute_archs_for_target_definition(target_definition, targets)
+              @archs_by_target_def[target_definition] = archs
+            else
+              unless target_definition.platform
+                raise Informative, 'It is necessary to specify the platform in the Podfile if not integrating.'
+              end
             end
           end
         end
@@ -530,7 +531,6 @@ module Pod
       #-----------------------------------------------------------------------#
 
       class AnalysisResult
-
         # @return [SpecsState] the states of the Podfile specs.
         #
         attr_accessor :podfile_state
@@ -561,7 +561,7 @@ module Pod
         #         its type (`:debug` or `:release`).
         #
         def all_user_build_configurations
-          targets.inject({}) do |result, target|
+          targets.reduce({}) do |result, target|
             result.merge(target.user_build_configurations)
           end
         end
@@ -578,7 +578,6 @@ module Pod
       #       subspecs are added instead of the name of the Pods.
       #
       class SpecsState
-
         # @param  [Hash{Symbol=>String}] pods_by_state
         #         The **root** name of the pods grouped by their state
         #         (`:added`, `:removed`, `:changed` or `:unchanged`).
@@ -618,10 +617,10 @@ module Pod
         # @return [void]
         #
         def print
-          added    .sort.each { |pod| UI.message("A".green  + " #{pod}", '', 2) }
-          deleted  .sort.each { |pod| UI.message("R".red    + " #{pod}", '', 2) }
-          changed  .sort.each { |pod| UI.message("M".yellow + " #{pod}", '', 2) }
-          unchanged.sort.each { |pod| UI.message("-"        + " #{pod}", '', 2) }
+          added    .sort.each { |pod| UI.message('A'.green  + " #{pod}", '', 2) }
+          deleted  .sort.each { |pod| UI.message('R'.red    + " #{pod}", '', 2) }
+          changed  .sort.each { |pod| UI.message('M'.yellow + " #{pod}", '', 2) }
+          unchanged.sort.each { |pod| UI.message('-'        + " #{pod}", '', 2) }
         end
 
         # Adds the name of a Pod to the give state.
@@ -637,10 +636,9 @@ module Pod
         # @return [void]
         #
         def add_name(name, state)
-          raise "[Bug] Attempt to add subspec to the pods state" if name.include?('/')
-          self.send(state) << name
+          raise '[Bug] Attempt to add subspec to the pods state' if name.include?('/')
+          send(state) << name
         end
-
       end
     end
   end