cocoapods-try 0.5.1 → 1.0.0.beta.1

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: a92663028e7b28c2a9ed6b458c4fe1d359848f3b
-  data.tar.gz: 46175a930b382956baace16fd0142562ed85c51f
+  metadata.gz: 57c6b5b53b39607c80d19f9d0da0034842ff3b9c
+  data.tar.gz: 01f73347266b2ba72d4eb0aa825930e8db018576
 SHA512:
-  metadata.gz: 8005ccf9ffc8a7d3cde0c398a12afd33f7f9d65e35ab8cc96e4d63fa4a0b42e42fa7ebc74820383fbcba459fd6478291ba86d002a2410c01e6a171c79af12b6c
-  data.tar.gz: 934c37c1aa9df3e4a12aa8f639fc2d13dad329dd1e1153fe2ba4645bd66b1c4d9251c3028e9be8cd5c394edb6941092bf198cadd485faf8e53fa0dd19cf75b1d
+  metadata.gz: ebfac998db0581b7fed0695675a59ef71e615d983733570ca8cc82e7164ef99a16daeb89c9fb73a178dcabcfbcbc0b6e881cd6aa22d903a0b677299b6a9c99d4
+  data.tar.gz: 80b9dc933c7a471a15314d100c3d866828497e72378a2face4095303633a107ab21680e516e451344e8939fcefae113f335e7f74e9c6ec94f129d6ff289a8f22

data/CHANGELOG.md

@@ -1,5 +1,15 @@
 # Cocoapods::Try Changelog
 
+
+## 1.0.0.beta.1 (2015-12-30)
+
+##### Bug Fixes
+
+* Ensure commands in the `.cocoapods` file are strings, and uses the pods folder when executing commands.  
+  [Samuel Giddins](https://github.com/segiddins)
+  [CocoaPods-Try#40](https://github.com/CocoaPods/cocoapods-try/issues/40)
+
+
 ## 0.5.1 (2015-08-28)
 
 ##### Bug Fixes

data/Gemfile.lock

@@ -18,7 +18,7 @@ GIT
       cocoapods-plugins (~> 0.4.2)
       cocoapods-stats (~> 0.5.3)
       cocoapods-trunk (~> 0.6.1)
-      cocoapods-try (~> 0.5.0)
+      cocoapods-try (~> 1.0.0.beta.1)
       colored (~> 1.2)
       escape (~> 0.0.4)
       molinillo (~> 0.3.1)
@@ -38,7 +38,7 @@ GIT
 PATH
   remote: .
   specs:
-    cocoapods-try (0.5.1)
+    cocoapods-try (1.0.0.beta.1)
 
 GEM
   remote: https://rubygems.org/
@@ -123,4 +123,4 @@ DEPENDENCIES
   rubocop
 
 BUNDLED WITH
-   1.10.6
+   1.11.2

data/lib/cocoapods_try.rb

@@ -1,6 +1,5 @@
-
 # The namespace of the Cocoapods try plugin.
 #
 module CocoapodsTry
-  VERSION = '0.5.1'
+  VERSION = '1.0.0.beta.1'.freeze
 end

data/lib/pod/command/try.rb

@@ -42,7 +42,7 @@ module Pod
         UI.title "Trying #{spec.name}" do
           pod_dir = install_pod(spec, sandbox)
           settings = TrySettings.settings_from_folder(pod_dir)
-          settings.run_pre_install_commands(true)
+          Dir.chdir(pod_dir) { settings.run_pre_install_commands(true) }
           proj = settings.project_path || pick_demo_project(pod_dir)
           file = install_podfile(proj)
           if file
@@ -124,12 +124,11 @@ module Pod
       #
       def install_pod(spec, sandbox)
         specs = { :ios => spec, :osx => spec }
-        clean = config.clean
-        config.clean = false
-        installer = Installer::PodSourceInstaller.new(sandbox, specs)
-        installer.install!
-        config.clean = clean
-        sandbox.root + spec.name
+        config.with_changes(:clean => false) do
+          installer = Installer::PodSourceInstaller.new(sandbox, specs)
+          installer.install!
+          sandbox.root + spec.name
+        end
       end
 
       # Picks a project or workspace suitable for the demo purposes in the

data/lib/pod/try_settings.rb

@@ -46,7 +46,7 @@ module Pod
     def run_pre_install_commands(prompt)
       if pre_install_commands
         prompt_for_permission if prompt
-        pre_install_commands.each { |command| Executable.execute_command('bash', ['-e', command], true) }
+        pre_install_commands.each { |command| Executable.execute_command('bash', ['-ec', command], true) }
       end
     end
   end

data/spec/command/try_settings_spec.rb

@@ -59,8 +59,8 @@ YAML
 YAML
         File.open(dir + '/.cocoapods.yml', 'w') { |f| f.write(yaml) }
 
-        Executable.expects(:execute_command).with('bash', ['-e', 'pod install'], true)
-        Executable.expects(:execute_command).with('bash', ['-e', 'git submodule init'], true)
+        Executable.expects(:execute_command).with('bash', ['-ec', 'pod install'], true)
+        Executable.expects(:execute_command).with('bash', ['-ec', 'git submodule init'], true)
 
         settings = TrySettings.settings_from_folder dir
         settings.run_pre_install_commands false

data/spec/command/try_spec.rb

@@ -19,14 +19,28 @@ module Pod
         end.message.should.match(/A Pod name or URL is required/)
       end
 
+      before do
+        @original_install_method = method = Pod::Command::Try.instance_method(:install_pod)
+        Pod::Command::Try.send(:define_method, :install_pod) do |*args|
+          dir = method.bind(self).call(*args)
+          FileUtils.mkdir_p(dir)
+          dir
+        end
+      end
+
+      after do
+        Pod::Command::Try.send(:define_method, :install_pod, @original_install_method)
+      end
+
       it 'allows the user to try the Pod with the given name' do
-        Config.instance.skip_repo_update = false
-        command = Pod::Command.parse(%w(try ARAnalytics))
-        Installer::PodSourceInstaller.any_instance.expects(:install!)
-        command.expects(:update_specs_repos)
-        command.expects(:pick_demo_project).returns(XCODE_PROJECT)
-        command.expects(:open_project).with(XCODE_PROJECT)
-        command.run
+        Config.instance.with_changes(:skip_repo_update => false) do
+          command = Pod::Command.parse(%w(try ARAnalytics))
+          Installer::PodSourceInstaller.any_instance.expects(:install!)
+          command.expects(:update_specs_repos)
+          command.expects(:pick_demo_project).returns(XCODE_PROJECT)
+          command.expects(:open_project).with(XCODE_PROJECT)
+          command.run
+        end
       end
 
       it 'allows the user to try the Pod with the given Git URL' do

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: cocoapods-try
 version: !ruby/object:Gem::Version
-  version: 0.5.1
+  version: 1.0.0.beta.1
 platform: ruby
 authors:
 - Fabio Pelosin
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2015-08-28 00:00:00.000000000 Z
+date: 2015-12-30 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: bundler
@@ -78,12 +78,12 @@ required_ruby_version: !ruby/object:Gem::Requirement
       version: '0'
 required_rubygems_version: !ruby/object:Gem::Requirement
   requirements:
-  - - '>='
+  - - '>'
     - !ruby/object:Gem::Version
-      version: '0'
+      version: 1.3.1
 requirements: []
 rubyforge_project: 
-rubygems_version: 2.4.8
+rubygems_version: 2.5.1
 signing_key: 
 specification_version: 4
 summary: CocoaPods plugin which allows to quickly try the demo project of a Pod.