cocoapods-trunk 1.0.0.beta.2 → 1.0.0.beta.3

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 1c41415e0fb060d2aeeab80a8d5feacaca2597c6
-  data.tar.gz: f98ea9c2582d5420292044aa1fc4f6630cd4e3b7
+  metadata.gz: aa6bb38c9906111357691750b2a15a2c387f681d
+  data.tar.gz: 0c7526a32a20805483a28c403f13071561da109e
 SHA512:
-  metadata.gz: ac7dd609a4f0534c96fd7a0bdf4e8d7976b7347c7e7ca6c2c111e3188df3b42fba7b2fbd2d2948ffd3398df0d94f3b3381ceba4d97f46eef155f5ccf49452644
-  data.tar.gz: 57d32e37e9217cc7275fd1af902b5a74c6bf1ca1b123270ebe8ab16d2bf263fb2d6555cb571e363162410e553c020245dff4234601194f6b072c28358286aa6f
+  metadata.gz: 0a87ba47fe14b1f854c3d80bddc3015d6713f8ee94c0c3b03f2b71e45f3d37f45830255e5b56702af113396bbc081e62cb2ae29c5b13aec71af32a009d1af5b9
+  data.tar.gz: f7b6c0b764af002e0b5789085cb62a98ad38a485f4cc84469eaa617e1fdd966a46d4ee10d27de7ef3e6e3d455bc6222354558451c82c53de01d2645e88a69a50

data/.rubocop_cocoapods.yml

@@ -40,7 +40,10 @@ Encoding:
 
 # Having these make it easier to *not* forget to add one when adding a new
 # value and you can simply copy the previous line.
-TrailingComma:
+Style/TrailingCommaInArguments:
+  EnforcedStyleForMultiline: comma
+
+Style/TrailingCommaInLiteral:
   EnforcedStyleForMultiline: comma
 
 Style/MultilineOperationIndentation:
@@ -54,6 +57,11 @@ GuardClause:
 Next:
   Enabled: false
 
+# Autocorrect makes this cop much more useful, taking away needless guessing
+Lint/EndAlignment:
+  AutoCorrect: true
+
+
 # Arbitrary max lengths for classes simply do not work and enabling this will
 # lead to a never ending stream of annoyance and changes.
 Metrics/ClassLength:
@@ -83,6 +91,11 @@ Metrics/AbcSize:
 Metrics/CyclomaticComplexity:
   Enabled: false
 
+# It will be obvious which code is complex, Rubocop should only lint simple
+# rules for us.
+Metrics/PerceivedComplexity:
+  Enabled: false
+
 #- CocoaPods support for Ruby 1.8.7 ------------------------------------------#
 
 HashSyntax:
@@ -107,6 +120,10 @@ AmbiguousRegexpLiteral:
   Exclude:
     - spec/**/*
 
+Performance/RedundantMatch:
+  Exclude:
+    - spec/**/*
+
 # Allow `object.should == object` syntax.
 Void:
   Exclude:

data/CHANGELOG.md

@@ -1,3 +1,16 @@
+## 1.0.0.beta.3 (2016-04-14)
+
+##### Enhancements
+
+* The failure reason is printed when validation fails during `pod trunk push`.  
+  [Samuel Giddins](https://github.com/segiddins)
+  [CocoaPods#5073](https://github.com/CocoaPods/CocoaPods/issues/5073)
+
+##### Bug Fixes
+
+* None.  
+
+
 ## 1.0.0.beta.2 (2016-02-03)
 
 ##### Bug Fixes

data/Gemfile.lock

@@ -39,7 +39,7 @@ GIT
 PATH
   remote: .
   specs:
-    cocoapods-trunk (1.0.0.beta.2)
+    cocoapods-trunk (1.0.0.beta.3)
       nap (>= 0.8, < 2.0)
       netrc (= 0.7.8)
 
@@ -53,9 +53,7 @@ GEM
       thread_safe (~> 0.3, >= 0.3.4)
       tzinfo (~> 1.1)
     addressable (2.3.8)
-    ast (2.1.0)
-    astrolabe (1.3.1)
-      parser (~> 2.2)
+    ast (2.2.0)
     bacon (1.2.0)
     cocoapods-downloader (0.9.3)
     cocoapods-plugins (0.4.2)
@@ -89,27 +87,27 @@ GEM
       mocha (>= 0.13.0)
     molinillo (0.4.0)
     multi_json (1.11.2)
-    nap (1.0.0)
+    nap (1.1.0)
     netrc (0.7.8)
     notify (0.5.2)
-    parser (2.2.2.6)
-      ast (>= 1.1, < 3.0)
+    parser (2.3.0.7)
+      ast (~> 2.2)
     powerpack (0.1.1)
     prettybacon (0.0.2)
       bacon (~> 1.2)
-    rainbow (2.0.0)
+    rainbow (2.1.0)
     rake (10.4.2)
     rb-fsevent (0.9.5)
     rb-inotify (0.9.5)
       ffi (>= 0.5.0)
     rb-kqueue (0.2.4)
       ffi (>= 0.5.0)
-    rubocop (0.33.0)
-      astrolabe (~> 1.3)
-      parser (>= 2.2.2.5, < 3.0)
+    rubocop (0.39.0)
+      parser (>= 2.3.0.7, < 3.0)
       powerpack (~> 0.1)
       rainbow (>= 1.99.1, < 3.0)
-      ruby-progressbar (~> 1.4)
+      ruby-progressbar (~> 1.7)
+      unicode-display_width (~> 1.0, >= 1.0.1)
     ruby-progressbar (1.7.5)
     safe_yaml (1.0.4)
     simplecov (0.9.2)
@@ -120,6 +118,7 @@ GEM
     thread_safe (0.3.5)
     tzinfo (1.2.2)
       thread_safe (~> 0.1)
+    unicode-display_width (1.0.3)
     webmock (1.21.0)
       addressable (>= 2.3.6)
       crack (>= 0.3.2)

data/lib/cocoapods_trunk.rb

@@ -1,3 +1,3 @@
 module CocoaPodsTrunk
-  VERSION = '1.0.0.beta.2'.freeze
+  VERSION = '1.0.0.beta.3'.freeze
 end

data/lib/pod/command/trunk/push.rb

@@ -106,7 +106,7 @@ module Pod
           validator.use_frameworks = @use_frameworks
           validator.validate
           unless validator.validated?
-            raise Informative, 'The podspec does not validate.'
+            raise Informative, "The spec did not pass validation, due to #{validator.failure_reason}."
           end
         end
 

data/lib/pod/command/trunk.rb

@@ -11,7 +11,7 @@ module Pod
       self.summary = 'Interact with the CocoaPods API (e.g. publishing new specs)'
 
       SCHEME_AND_HOST = ENV['TRUNK_SCHEME_AND_HOST'] || 'https://trunk.cocoapods.org'
-      BASE_URL = "#{SCHEME_AND_HOST}/api/v1"
+      BASE_URL = "#{SCHEME_AND_HOST}/api/v1".freeze
 
       require 'pod/command/trunk/add_owner'
       require 'pod/command/trunk/delete'
@@ -26,7 +26,7 @@ module Pod
 
       def request_url(action, url, *args)
         response = create_request(action, url, *args)
-        if (400...600).include?(response.status_code)
+        if (400...600).cover?(response.status_code)
           print_error(response.body)
         end
         response

data/spec/command/trunk/addowner_spec.rb

@@ -40,7 +40,7 @@ module Pod
     it 'should successfully add an owner' do
       url = 'https://trunk.cocoapods.org/api/v1/pods/QueryKit/owners'
       WebMock::API.stub_request(:patch, url).
-        with(:body => "{\"email\":\"kyle@cocoapods.org\"}",
+        with(:body => '{"email":"kyle@cocoapods.org"}',
              :headers => { 'Authorization' => 'Token 527d11fe429f3426cb8dbeba183a0d80' }).
         to_return(:status => 200, :body => '[]', :headers => {})
 

data/spec/command/trunk/delete_spec.rb

@@ -25,7 +25,6 @@ module Pod
       command.send(:confirm_deletion?).should.be.true
       command.send(:confirm_deletion?).should.be.false
 
-      # rubocop:disable Metrics/LineLength
       UI.output.should == <<-OUTPUT.gsub(/^>$/, '> ')
 \e[33mWARNING: It is generally considered bad behavior to remove versions of a Pod that others are depending on!
 Please consider using the `deprecate` command instead.\e[0m
@@ -38,7 +37,6 @@ Please consider using the `deprecate` command instead.\e[0m
 Are you sure you want to delete this Pod version?
 >
       OUTPUT
-      # rubocop:enable Metrics/LineLength
     end
 
     it 'does not delete if the user does not confirm' do

data/spec/command/trunk/push_spec.rb

@@ -126,6 +126,16 @@ module Pod
         cmd = Command.parse(%w(trunk push spec/fixtures/BananaLib.podspec --use-libraries))
         cmd.send(:validate_podspec)
       end
+
+      it 'prints the failure reason' do
+        Validator.any_instance.expects(:validated?).returns(false)
+        Validator.any_instance.expects(:validate)
+        Validator.any_instance.expects(:failure_reason).returns('failure_reason')
+
+        cmd = Command.parse(%w(trunk push spec/fixtures/BananaLib.podspec --use-libraries))
+        e = should.raise(Informative) { cmd.send(:validate_podspec) }
+        e.message.should.include 'The spec did not pass validation, due to failure_reason.'
+      end
     end
 
     describe 'updating the master repo' do

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: cocoapods-trunk
 version: !ruby/object:Gem::Version
-  version: 1.0.0.beta.2
+  version: 1.0.0.beta.3
 platform: ruby
 authors:
 - Eloy Durán
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2016-02-03 00:00:00.000000000 Z
+date: 2016-04-14 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: nap
@@ -134,7 +134,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
       version: 1.3.1
 requirements: []
 rubyforge_project: 
-rubygems_version: 2.5.2
+rubygems_version: 2.6.3
 signing_key: 
 specification_version: 4
 summary: Interact with trunk.cocoapods.org