cocoapods-plugins 0.1.0 → 0.1.1

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: c7bc267f848ee30507851b6302b4291ac9472c34
-  data.tar.gz: b8dc5813586a454949f0b45f6ffdbc6259ffa300
+  metadata.gz: 7c552838da447d326048d02eec308967695cec8f
+  data.tar.gz: 2b0144ca6eea883bdb3e05bd847fa5e61fbea201
 SHA512:
-  metadata.gz: d75983946efe356128770b4670ce9ec2380f0a954bf8f9932570766d2b201f3713bf16d99ee7a6de0e248a82808ce7dca0e7602790c1ab880421480ee4cb4bf3
-  data.tar.gz: e71de6205045275b61cd0bfced542d725784aa7bd55a08e4381cd5817f804c888093fce575491270d73a6b1e238d5e5aae08f05cf68b93f7ab416df0c90e7195
+  metadata.gz: dce8fd8cb5e3e86461b77ac2c8e23ea46282bbd2b9f319f06857db96d0749eb993dc2a65cad4159baf7827e84eb01db6905879e751afff5381229ca7034faa72
+  data.tar.gz: 89da3e37f4788a30393fd6bae3f99657bb7a25d77ab9ff6fa0f4eb567878f1c41a1f299537ff62ab333df7557d0a173b3d63c9821177638b52a8a4c2414e4ce8

data/.gitignore

@@ -34,3 +34,7 @@ build/
 .rvmrc
 
 /coverage/
+
+# RubyMine Editor
+.idea
+

data/.rubocop-cocoapods.yml

@@ -0,0 +1,61 @@
+AllCops:
+  Include:
+    - Rakefile
+  Exclude:
+    - spec/fixtures/**
+
+#- CocoaPods -----------------------------------------------------------------#
+
+# We adopted raise instead of fail.
+SignalException:
+  EnforcedStyle: only_raise
+
+# They are idiomatic
+AssignmentInCondition:
+  Enabled: false
+
+# Allow backticks
+AsciiComments:
+  Enabled: false
+
+# Indentation clarifies logic branches in implementations
+IfUnlessModifier:
+  Enabled: false
+
+# No enforced convention here.
+SingleLineBlockParams:
+  Enabled: false
+
+# We only add the comment when needed.
+Encoding:
+  Enabled: false
+
+#- CocoaPods support for Ruby 1.8.7 ------------------------------------------#
+
+HashSyntax:
+  EnforcedStyle: hash_rockets
+
+Lambda:
+  Enabled: false
+
+
+#- CocoaPods specs -----------------------------------------------------------#
+
+# Allow for `should.match /regexp/`.
+AmbiguousRegexpLiteral:
+  Exclude:
+    - spec/**
+
+# Allow `object.should == object` syntax.
+Void:
+  Exclude:
+    - spec/**
+
+ClassAndModuleChildren:
+  Exclude:
+    - spec/**
+
+UselessComparison:
+  Exclude:
+    - spec/**
+

data/.rubocop.yml

@@ -1,51 +1,4 @@
-HashSyntax:
-  EnforcedStyle: hash_rockets
-
-StringLiterals:
-  Enabled: false
-  EnforcedStyle: double_quotes
-
-SignalException:
-  EnforcedStyle: only_raise
-
-ConstantName:
-  Enabled: false
-
-IfUnlessModifier:
-  Enabled: false
-
-EmptyLinesAroundBody:
-  Enabled: false
-
-AsciiComments:
-  Enabled: false
-
-Proc:
-  Enabled: false
-
-BracesAroundHashParameters:
-  Enabled: false
-
-Encoding:
-  Enabled: false
-
-TrailingComma:
-  EnforcedStyleForMultiline: comma
-
-FileName:
-  Enabled: false
-
-#------------------------------------------------------------------------------
-# Needs fixing
-#------------------------------------------------------------------------------
-
-ClassLength:
-  Max: 200
-
-MethodLength:
-  Max: 18
-
-LineLength:
-  Enabled: false
+inherit_from:
+ - .rubocop-cocoapods.yml
 
 

data/CHANGELOG.md

@@ -1,6 +1,19 @@
 # Cocoapods::Plugins Changelog
 
+## 0.1.1
+
+* Making `pod plugins` an abstract command, with `list` the default subcommand (#11, #12)
+  [Olivier Halligon](https://github.com/AliSoftware)
+* Added `search` subcommand to search plugins by name, author and description. (#9)
+  [Olivier Halligon](https://github.com/AliSoftware)
+* Refactoring (#10, #13), improved output formatting (#8)
+  [Olivier Halligon](https://github.com/AliSoftware)
+* Fixing coding conventions and Rubocop offenses (#17)
+  [Olivier Halligon](https://github.com/AliSoftware)
+
 ## 0.1.0
 
 * Initial implementation.  
   [David Grandinetti](https://github.com/dbgrandi)
+* Added `create` subcommand to create an empty project for a new plugin.
+  [Boris Bügling](https://github.com/neonichu)

data/Gemfile

@@ -3,6 +3,7 @@ source 'https://rubygems.org'
 gemspec
 
 group :development do
+  gem 'cocoapods'
   gem 'bacon'
   gem 'coveralls', :require => false
   gem 'mocha-on-bacon'

data/Gemfile.lock

@@ -1,8 +1,7 @@
 PATH
   remote: .
   specs:
-    cocoapods-plugins (0.1.0)
-      cocoapods
+    cocoapods-plugins (0.1.1)
       nap
 
 GEM
@@ -12,7 +11,7 @@ GEM
       i18n (~> 0.6, >= 0.6.4)
       multi_json (~> 1.0)
     addressable (2.3.6)
-    ast (1.1.0)
+    ast (2.0.0)
     bacon (1.2.0)
     claide (0.5.0)
     cocoapods (0.32.1)
@@ -58,8 +57,8 @@ GEM
     multi_json (1.9.2)
     nap (0.7.0)
     open4 (1.3.3)
-    parser (2.1.7)
-      ast (~> 1.1)
+    parser (2.1.9)
+      ast (>= 1.1, < 3.0)
       slop (~> 3.4, >= 3.4.5)
     powerpack (0.0.9)
     prettybacon (0.0.1)
@@ -68,7 +67,7 @@ GEM
     rake (10.2.2)
     rest-client (1.6.7)
       mime-types (>= 1.16)
-    rubocop (0.20.0)
+    rubocop (0.20.1)
       json (>= 1.7.7, < 2)
       parser (~> 2.1.7)
       powerpack (~> 0.0.6)
@@ -99,6 +98,7 @@ PLATFORMS
 DEPENDENCIES
   bacon
   bundler (~> 1.3)
+  cocoapods
   cocoapods-plugins!
   coveralls
   mocha-on-bacon

data/README.md

@@ -4,12 +4,36 @@
 [![Coverage Status](https://coveralls.io/repos/CocoaPods/cocoapods-plugins/badge.png)](https://coveralls.io/r/CocoaPods/cocoapods-plugins)
 [![Code Climate](https://img.shields.io/codeclimate/github/CocoaPods/cocoapods-plugins.svg)](https://codeclimate.com/github/CocoaPods/cocoapods-plugins)
 
-CocoaPods plugin which shows info about available CocoaPods plugins. Yeah, it's very meta.
+CocoaPods plugin which shows info about available CocoaPods plugins or helps you get started developing a new plugin. Yeah, it's very meta.
+
+## Installation
+
+    $ gem install cocoapods-plugins
 
 ## Usage
 
+#####List plugins
+
     $ pod plugins
 
-## Installation
+List all known plugins (according to the list hosted on github.com/CocoaPods/cocoapods.org)
+
+#####Search plugins
+
+    $ pod plugins search QUERY
+
+Searches plugins whose name contains the given text (ignoring case). With --full, it searches by name but also by author and description.
+
+#####Create a new plugin
+
+    $ pod plugins create NAME [TEMPLATE_URL]
+
+Creates a scaffold for the development of a new plugin according to the CocoaPods best practices.
+If a `TEMPLATE_URL`, pointing to a git repo containing a compatible template, is specified, it will be used in place of the default one.
+
+## Get your plugin listed
+
+The list of plugins is in the cocoapods.org repository at [https://github.com/CocoaPods/cocoapods.org/blob/master/data/plugins.json](https://github.com/CocoaPods/cocoapods.org/blob/master/data/plugins.json).
+
+To have your plugin listed, submit a pull request that adds your plugin details.
 
-    $ gem install cocoapods-plugins

data/Rakefile

@@ -1,24 +1,24 @@
-require "bundler/gem_tasks"
+require 'bundler/gem_tasks'
 
-task :default => "spec"
+task :default => 'spec'
 
 # Bootstrap
 #-----------------------------------------------------------------------------#
 
 task :bootstrap do
-  sh "bundle install"
+  sh 'bundle install'
 end
 
 # Spec
 #-----------------------------------------------------------------------------#
 
-desc "Runs all the specs"
+desc 'Runs all the specs'
 task :spec do
   start_time = Time.now
   sh "bundle exec bacon #{specs('**')}"
   duration = Time.now - start_time
   puts "Tests completed in #{duration}s"
-  Rake::Task["rubocop"].invoke
+  Rake::Task['rubocop'].invoke
 end
 
 def specs(dir)
@@ -36,6 +36,6 @@ task :rubocop do
     result = cli.run(FileList['{spec,lib}/**/*.rb'])
     abort('RuboCop failed!') unless result == 0
   else
-    puts "[!] Ruby > 1.9 is required to run style checks"
+    puts '[!] Ruby > 1.9 is required to run style checks'
   end
 end

data/cocoapods-plugins.gemspec

@@ -4,21 +4,26 @@ $LOAD_PATH.unshift(lib) unless $LOAD_PATH.include?(lib)
 require 'cocoapods_plugins.rb'
 
 Gem::Specification.new do |spec|
-  spec.name          = "cocoapods-plugins"
+  spec.name          = 'cocoapods-plugins'
   spec.version       = CocoapodsPlugins::VERSION
-  spec.authors       = ["David Grandinetti"]
+  spec.authors       = ['David Grandinetti', 'Olivier Halligon']
   spec.summary       = %q{CocoaPods plugin which shows info about available CocoaPods plugins.}
-  spec.homepage      = "https://github.com/cocoapods/cocoapods-plugins"
-  spec.license       = "MIT"
+  spec.description   = <<-DESC
+                         This CocoaPods plugin shows information about all available CocoaPods plugins
+                         (yes, this is very meta!).
+                         This CP plugin adds the "pod plugins" command to CocoaPods so that you can list
+                         all plugins (registered in the reference JSON hosted at CocoaPods/cocoapods.org)
+                       DESC
+  spec.homepage      = 'https://github.com/cocoapods/cocoapods-plugins'
+  spec.license       = 'MIT'
 
   spec.files         = `git ls-files`.split($/)
   spec.executables   = spec.files.grep(%r{^bin/}) { |f| File.basename(f) }
   spec.test_files    = spec.files.grep(%r{^(test|spec|features)/})
-  spec.require_paths = ["lib"]
+  spec.require_paths = ['lib']
 
-  spec.add_runtime_dependency "cocoapods"
   spec.add_runtime_dependency 'nap'
 
-  spec.add_development_dependency "bundler", "~> 1.3"
-  spec.add_development_dependency "rake"
+  spec.add_development_dependency 'bundler', '~> 1.3'
+  spec.add_development_dependency 'rake'
 end

data/lib/cocoapods_plugins.rb

@@ -2,5 +2,5 @@
 # The namespace of the Cocoapods plugins plugin.
 #
 module CocoapodsPlugins
-  VERSION = "0.1.0"
+  VERSION = '0.1.1'
 end

data/lib/pod/command/plugins.rb

@@ -5,151 +5,24 @@ require 'json'
 #
 module Pod
   class Command
-
     # The pod plugins command.
     #
     class Plugins < Command
+      require 'pod/command/plugins/list'
+      require 'pod/command/plugins/search'
+      require 'pod/command/plugins/create'
 
-      PLUGINS_URL = 'https://raw.githubusercontent.com/CocoaPods/cocoapods.org/master/data/plugins.json'
-
-      attr_accessor :json
+      self.abstract_command = true
+      self.default_subcommand = 'list'
 
       self.summary = 'Show available CocoaPods plugins'
-
       self.description = <<-DESC
-        Shows the available CocoaPods plugins and if you have them installed or not.
-      DESC
-
-      def download_json
-        response = REST.get(PLUGINS_URL)
-        if response.ok?
-          @json = JSON.parse(response.body)
-        end
-      end
-
-      def installed?(gemname)
-        if Gem::Specification.methods.include?(:find_all_by_name)
-          Gem::Specification.find_all_by_name(gemname).any?
-        else
-          # Fallback to Gem.available? for old versions of rubygems
-          Gem.available?(gemname)
-        end
-      end
-
-      def run
-        UI.puts "Downloading Plugins list..."
-        begin
-          download_json unless json
-        rescue => e
-          UI.puts e.message
-        end
-
-        if !json
-          UI.puts "Could not download plugins list from cocoapods.org"
-        else
-          print_plugins
-        end
-      end
-
-      def print_plugins
-        UI.puts "Available CocoaPods Plugins\n\n"
-
-        @json['plugins'].each do |plugin|
-          UI.puts "Name: #{plugin['name']}"
-
-          if installed?(plugin['gem'])
-            UI.puts "Gem: #{plugin['gem']}".green
-          else
-            UI.puts "Gem: #{plugin['gem']}".yellow
-          end
-
-          UI.puts "URL: #{plugin['url']}"
-          UI.puts "\n#{plugin['description']}\n\n"
-        end
-      end
-
-      #-----------------------------------------------------------------------#
-
-      # The create subcommand. Used to create a new plugin using either the
-      # default template (CocoaPods/cocoapods-plugin-template) or a custom
-      # template
-      #
-      class Create < Plugins
-        self.summary = 'Creates a new plugin'
-
-        self.description = <<-DESC
-          Creates a scaffold for the development of a new plugin according to the CocoaPods best practices.
-          If a `TEMPLATE_URL`, pointing to a git repo containing a compatible template, is specified, it will be used in place of the default one.
-        DESC
-
-        self.arguments = 'NAME [TEMPLATE_URL]'
-
-        def initialize(argv)
-          @name = argv.shift_argument
-          @template_url = argv.shift_argument
-          super
-        end
-
-        def validate!
-          super
-          help! "A name for the plugin is required." if @name.nil? || @name.empty?
-          help! "The plugin name cannot contain spaces." if @name.match(/\s/)
-        end
-
-        def run
-          clone_template
-          configure_template
-        end
-
-        private
-
-        #----------------------------------------#
-
-        # !@group Private helpers
-
-        extend Executable
-        executable :git
-        executable :ruby
-
-        TEMPLATE_REPO = "https://github.com/CocoaPods/cocoapods-plugin-template.git"
-        TEMPLATE_INFO_URL = "https://github.com/CocoaPods/cocoapods-plugin-template"
-
-        # Clones the template from the remote in the working directory using
-        # the name of the plugin.
-        #
-        # @return [void]
-        #
-        def clone_template
-          UI.section("Creating `#{@name}` plugin") do
-            git! "clone '#{template_repo_url}' #{@name}"
-          end
-        end
-
-        # Runs the template configuration utilities.
-        #
-        # @return [void]
-        #
-        def configure_template
-          UI.section("Configuring template") do
-            Dir.chdir(@name) do
-              if File.file? "configure"
-                system "./configure #{@name}"
-              else
-                UI.warn "Template does not have a configure file."
-              end
-            end
-          end
-        end
-
-        # Checks if a template URL is given else returns the TEMPLATE_REPO URL
-        #
-        # @return String
-        #
-        def template_repo_url
-          @template_url || TEMPLATE_REPO
-        end
-      end
+        Lists or searches the available CocoaPods plugins
+        and show if you have them installed or not.
 
+        Also allows you to quickly create a new Cocoapods
+        plugin using a provided template.
+      DESC
     end
   end
 end

data/lib/pod/command/plugins/create.rb

@@ -0,0 +1,93 @@
+module Pod
+  class Command
+    class Plugins
+      # The create subcommand. Used to create a new plugin using either the
+      # default template (CocoaPods/cocoapods-plugin-template) or a custom
+      # template
+      #
+      class Create < Plugins
+        self.summary = 'Creates a new plugin'
+        self.description = <<-DESC
+                Creates a scaffold for the development of a new plugin
+                according to the CocoaPods best practices.
+
+                If a `TEMPLATE_URL`, pointing to a git repo containing a
+                compatible template, is specified, it will be used
+                in place of the default one.
+        DESC
+
+        self.arguments = 'NAME [TEMPLATE_URL]'
+
+        def initialize(argv)
+          @name = argv.shift_argument
+          @template_url = argv.shift_argument
+          super
+        end
+
+        def validate!
+          super
+          if @name.nil? || @name.empty?
+            help! 'A name for the plugin is required.'
+          end
+          if @name.match(/\s/)
+            help! 'The plugin name cannot contain spaces.'
+          end
+        end
+
+        def run
+          clone_template
+          configure_template
+        end
+
+        #----------------------------------------#
+
+        private
+
+        # !@group Private helpers
+
+        extend Executable
+        executable :git
+        executable :ruby
+
+        TEMPLATE_BASE_URL = 'https://github.com/CocoaPods/'
+        TEMPLATE_REPO = TEMPLATE_BASE_URL + 'cocoapods-plugin-template.git'
+        TEMPLATE_INFO_URL = TEMPLATE_BASE_URL + 'cocoapods-plugin-template'
+
+        # Clones the template from the remote in the working directory using
+        # the name of the plugin.
+        #
+        # @return [void]
+        #
+        def clone_template
+          UI.section("Creating `#{@name}` plugin") do
+            git! "clone '#{template_repo_url}' #{@name}"
+          end
+        end
+
+        # Runs the template configuration utilities.
+        #
+        # @return [void]
+        #
+        def configure_template
+          UI.section('Configuring template') do
+            Dir.chdir(@name) do
+              if File.file? 'configure'
+                system "./configure #{@name}"
+              else
+                UI.warn 'Template does not have a configure file.'
+              end
+            end
+          end
+        end
+
+        # Checks if a template URL is given else returns the TEMPLATE_REPO URL
+        #
+        # @return String
+        #
+        def template_repo_url
+          @template_url || TEMPLATE_REPO
+        end
+      end
+    end
+  end
+end

data/lib/pod/command/plugins/list.rb

@@ -0,0 +1,31 @@
+require 'pod/command/plugins_helper'
+
+module Pod
+  class Command
+    class Plugins
+      # The list subcommand. Used to list all known plugins
+      #
+      class List < Plugins
+        self.summary = 'List all known plugins'
+        self.description = <<-DESC
+                List all known plugins (according to the list
+                hosted on github.com/CocoaPods/cocoapods.org)
+        DESC
+
+        def self.options
+          super.reject { |option, _| option == '--silent' }
+        end
+
+        def run
+          plugins = PluginsHelper.known_plugins
+
+          UI.title 'Available CocoaPods Plugins:' do
+            plugins.each do |plugin|
+              PluginsHelper.print_plugin plugin, self.verbose?
+            end
+          end
+        end
+      end
+    end
+  end
+end

data/lib/pod/command/plugins/search.rb

@@ -0,0 +1,54 @@
+require 'pod/command/plugins_helper'
+
+module Pod
+  class Command
+    class Plugins
+      # The search subcommand.
+      # Used to search a plugin in the list of known plugins,
+      # searching into the name, author description fields
+      #
+      class Search < Plugins
+        self.summary = 'Search for known plugins'
+        self.description = <<-DESC
+                Searches plugins whose name contains the given text
+                (ignoring case).
+
+                With --full, it also searches by author and description.
+        DESC
+
+        self.arguments = 'QUERY'
+
+        def self.options
+          [
+            ['--full',  'Search by name, author, and description']
+          ].concat(super.reject { |option, _| option == '--silent' })
+        end
+
+        def initialize(argv)
+          @full_text_search = argv.flag?('full')
+          @query = argv.shift_argument unless argv.arguments.empty?
+          super
+        end
+
+        def validate!
+          super
+          help! 'A search query is required.' if @query.nil? || @query.empty?
+          begin
+            /#{@query}/
+          rescue RegexpError
+            help! 'A valid regular expression is required.'
+          end
+        end
+
+        def run
+          plugins = PluginsHelper.matching_plugins(@query, @full_text_search)
+
+          UI.title "Available CocoaPods Plugins matching '#{@query}':"
+          plugins.each do |plugin|
+            PluginsHelper.print_plugin plugin, self.verbose?
+          end
+        end
+      end
+    end
+  end
+end

data/lib/pod/command/plugins_helper.rb

@@ -0,0 +1,128 @@
+module Pod
+  class Command
+    # This module is used by Command::Plugins::List
+    # and Command::Plugins::Search to download and parse
+    # the JSON describing the plugins list and manipulate it
+    #
+    module PluginsHelper
+      PLUGINS_URL = 'https://raw.githubusercontent.com/CocoaPods/' \
+        'cocoapods.org/master/data/plugins.json'
+
+      # Force-download the JSON
+      #
+      # @return [Hash] The hash representing the JSON with all known plugins
+      #
+      def self.download_json
+        UI.puts 'Downloading Plugins list...'
+        response = REST.get(PLUGINS_URL)
+        if response.ok?
+          parse_json(response.body)
+        else
+          raise Informative, 'Could not download plugins list ' \
+            "from cocoapods.org: #{response.inspect}"
+        end
+      end
+
+      # The list of all known plugins, according to
+      # the JSON hosted on github's cocoapods.org
+      #
+      # @return [Array] all known plugins, as listed in the downloaded JSON
+      #
+      def self.known_plugins
+        json = download_json
+        json['plugins']
+      end
+
+      # Filter plugins to return only matching ones
+      #
+      # @param [String] query
+      #        A query string that corresponds to a valid RegExp pattern.
+      #
+      # @param [Bool] full_text_search
+      #        false only searches in the plugin's name.
+      #        true searches in the plugin's name, author and description.
+      #
+      # @return [Array] all plugins matching the query
+      #
+      def self.matching_plugins(query, full_text_search)
+        query_regexp = /#{query}/i
+        known_plugins.reject do |plugin|
+          texts = [plugin['name']]
+          if full_text_search
+            texts << plugin['author'] if plugin['author']
+            texts << plugin['description'] if plugin['description']
+          end
+          texts.grep(query_regexp).empty?
+        end
+      end
+
+      # Tells if a gem is installed
+      #
+      # @param [String] gem_name
+      #        The name of the plugin gem to test
+      #
+      # @return [Bool] true if the gem is installed, false otherwise.
+      #
+      def self.gem_installed?(gem_name)
+        if Gem::Specification.methods.include?(:find_all_by_name)
+          Gem::Specification.find_all_by_name(gem_name).any?
+        else
+          # Fallback to Gem.available? for old versions of rubygems
+          Gem.available?(gem_name)
+        end
+      end
+
+      # Display information about a plugin
+      #
+      # @param [Hash] plugin
+      #        The hash describing the plugin
+      #
+      # @param [Bool] verbose
+      #        If true, will also print the author of the plugins.
+      #        Defaults to false.
+      #
+      def self.print_plugin(plugin, verbose = false)
+        plugin_colored_name = plugin_title(plugin)
+
+        UI.title(plugin_colored_name, '', 1) do
+          UI.puts_indented plugin['description']
+          UI.labeled('Gem', plugin['gem'])
+          UI.labeled('URL',   plugin['url'])
+          UI.labeled('Author', plugin['author']) if verbose
+        end
+      end
+
+      #----------------#
+
+      private
+
+      # Parse the given JSON data, handling parsing errors if any
+      #
+      # @param [String] json_str
+      #        The string representation of the JSON to parse
+      #
+      def self.parse_json(json_str)
+        JSON.parse(json_str)
+      rescue JSON::ParserError => e
+        raise Informative, "Invalid plugins list from cocoapods.org: #{e}"
+      end
+
+      # Format the title line to print the plugin info with print_plugin
+      # coloring it according to whether the plugin is installed or not
+      #
+      # @param [Hash] plugin
+      #               The hash describing the plugin
+      #
+      # @return [String] The formatted and colored title
+      #
+      def self.plugin_title(plugin)
+        plugin_name = "-> #{plugin['name']}"
+        if gem_installed?(plugin['gem'])
+          plugin_name.green
+        else
+          plugin_name.yellow
+        end
+      end
+    end
+  end
+end

data/spec/command/plugins/create_spec.rb

@@ -0,0 +1,72 @@
+require File.expand_path('../../../spec_helper', __FILE__)
+
+# The CocoaPods namespace
+#
+module Pod
+  describe Command::Plugins::Create do
+    extend SpecHelper::PluginsCreateCommand
+
+    before do
+      UI.output = ''
+    end
+
+    it 'registers itself' do
+      Command.parse(%w(plugins create))
+      .should.be.instance_of Command::Plugins::Create
+    end
+
+    #--- Validation
+
+    it 'should require a name is passed in' do
+      @command = create_command
+      # rubocop:disable Lambda
+      lambda { @command.validate! }
+      .should.raise(CLAide::Help)
+      .message.should.match(/A name for the plugin is required./)
+      # rubocop:enable Lambda
+    end
+
+    it 'should require a non-empty name is passed in' do
+      @command = create_command('')
+      # rubocop:disable Lambda
+      lambda { @command.validate! }
+      .should.raise(CLAide::Help)
+      .message.should.match(/A name for the plugin is required./)
+      # rubocop:enable Lambda
+    end
+
+    it 'should require the name does not have spaces' do
+      @command = create_command('my gem')
+      # rubocop:disable Lambda
+      lambda { @command.validate! }
+      .should.raise(CLAide::Help)
+      .message.should.match(/The plugin name cannot contain spaces./)
+      # rubocop:enable Lambda
+    end
+
+    #--- Template download
+
+    it 'should download the default template repository' do
+      @command = create_command('cocoapods-banana')
+
+      template_repo = 'https://github.com/CocoaPods/' \
+        'cocoapods-plugin-template.git'
+      git_command = "clone '#{template_repo}' cocoapods-banana"
+      @command.expects(:git!).with(git_command)
+      @command.expects(:configure_template)
+      @command.run
+      UI.output.should.include('Creating `cocoapods-banana` plugin')
+    end
+
+    it 'should download the passed in template repository' do
+      alt_repo = 'https://github.com/CocoaPods/' \
+        'cocoapods-banana-plugin-template.git'
+      @command = create_command('cocoapods-banana', alt_repo)
+
+      @command.expects(:git!).with("clone '#{alt_repo}' cocoapods-banana")
+      @command.expects(:configure_template)
+      @command.run
+      UI.output.should.include('Creating `cocoapods-banana` plugin')
+    end
+  end
+end

data/spec/command/plugins/list_spec.rb

@@ -0,0 +1,29 @@
+require File.expand_path('../../../spec_helper', __FILE__)
+
+# The CocoaPods namespace
+#
+module Pod
+  describe Command::Plugins::List do
+    extend SpecHelper::PluginsStubs
+
+    before do
+      UI.output = ''
+      @command = Pod::Command::Plugins::List.new CLAide::ARGV.new []
+    end
+
+    it 'registers itself' do
+      Command.parse(%w(plugins list))
+      .should.be.instance_of Command::Plugins::List
+    end
+
+    #--- Output printing
+
+    it 'prints out all plugins' do
+      stub_plugins_json_request
+      @command.run
+      UI.output.should.include('github.com/CocoaPods/cocoapods-fake-1')
+      UI.output.should.include('github.com/CocoaPods/cocoapods-fake-2')
+      UI.output.should.include('github.com/chneukirchen/bacon')
+    end
+  end
+end

data/spec/command/plugins/search_spec.rb

@@ -0,0 +1,59 @@
+require File.expand_path('../../../spec_helper', __FILE__)
+
+# The CocoaPods namespace
+#
+module Pod
+  describe Command::Plugins::Search do
+    extend SpecHelper::PluginsStubs
+    extend SpecHelper::PluginsSearchCommand
+
+    before do
+      UI.output = ''
+    end
+
+    it 'registers itself' do
+      Command.parse(%w(plugins search))
+      .should.be.instance_of Command::Plugins::Search
+    end
+
+    #--- Validation
+
+    it 'should require a non-empty query' do
+      @command = search_command
+      # rubocop:disable Lambda
+      lambda { @command.validate! }
+      .should.raise(CLAide::Help)
+      .message.should.match(/A search query is required./)
+      # rubocop:enable Lambda
+    end
+
+    it 'should require a valid RegExp as query' do
+      @command = search_command('[invalid')
+      # rubocop:disable Lambda
+      lambda { @command.validate! }
+      .should.raise(CLAide::Help)
+      .message.should.match(/A valid regular expression is required./)
+      # rubocop:enable Lambda
+    end
+
+    #--- Output printing
+
+    it 'should filter plugins only by name without full search' do
+      stub_plugins_json_request
+      @command = search_command('search')
+      @command.run
+      UI.output.should.not.include('-> CocoaPods Fake Gem')
+      UI.output.should.include('-> CocoaPods Searchable Fake Gem')
+      UI.output.should.not.include('-> Bacon')
+    end
+
+    it 'should filter plugins by name, author, description with full search' do
+      stub_plugins_json_request
+      @command = search_command('--full', 'search')
+      @command.run
+      UI.output.should.include('-> CocoaPods Fake Gem')
+      UI.output.should.include('-> CocoaPods Searchable Fake Gem')
+      UI.output.should.not.include('-> Bacon')
+    end
+  end
+end

data/spec/command/plugins_helper_spec.rb

@@ -0,0 +1,42 @@
+require File.expand_path('../spec_helper', File.dirname(__FILE__))
+
+# The CocoaPods namespace
+#
+module Pod
+  describe Command::PluginsHelper do
+    extend SpecHelper::PluginsStubs
+
+    it 'downloads the json file' do
+      stub_plugins_json_request
+      json = Command::PluginsHelper.download_json
+      json.should.not.be.nil?
+      json.should.be.kind_of? Hash
+      json['plugins'].size.should.eql? 3
+    end
+
+    it 'handles empty/bad JSON' do
+      stub_plugins_json_request 'This is not JSON'
+      # rubocop:disable Lambda
+      lambda { Command::PluginsHelper.download_json }
+      .should.raise(Pod::Informative)
+      .message.should.match(/Invalid plugins list from cocoapods.org/)
+      # rubocop:enable Lambda
+    end
+
+    it 'notifies the user if the download fails' do
+      stub_plugins_json_request '', [404, 'Not Found']
+      # rubocop:disable Lambda
+      lambda { Command::PluginsHelper.download_json }
+      .should.raise(Pod::Informative)
+      .message.should
+      .match(/Could not download plugins list from cocoapods.org/)
+      # rubocop:enable Lambda
+    end
+
+    it 'detects if a gem is installed' do
+      Helper = Command::PluginsHelper
+      Helper.gem_installed?('bacon').should.be.true
+      Helper.gem_installed?('fake-fake-fake-gem').should.be.false
+    end
+  end
+end

data/spec/command/plugins_spec.rb

@@ -4,118 +4,17 @@ require File.expand_path('../../spec_helper', __FILE__)
 #
 module Pod
   describe Command::Plugins do
-
     before do
       argv = CLAide::ARGV.new([])
       @command = Command::Plugins.new(argv)
     end
 
-    it "registers it self" do
-      Command.parse(%w(plugins)).should.be.instance_of Command::Plugins
+    it 'registers itself and uses the default subcommand' do
+      Command.parse(%w(plugins)).should.be.instance_of Command::Plugins::List
     end
 
-    it "exists" do
+    it 'exists' do
       @command.should.not.be.nil?
     end
-
-    it "has a json attribute that starts out nil" do
-      @command.json.should.be.nil?
-    end
-
-    it "downloads the json file" do
-      json = File.read(fixture('plugins.json'))
-      stub_request(:get, Command::Plugins::PLUGINS_URL).to_return(:status => 200, :body => json, :headers => {})
-      @command.download_json
-      @command.json.should.not.be.nil?
-      @command.json.should.be.kind_of? Hash
-      @command.json['plugins'].size.should.eql? 2
-    end
-
-    it "handles empty/bad JSON" do
-      stub_request(:get, Command::Plugins::PLUGINS_URL).to_return(:status => 200, :body => "This is not JSON", :headers => {})
-      @command.run
-      UI.output.should.include("Could not download plugins list from cocoapods.org")
-      @command.json.should.be.nil?
-    end
-
-    it "notifies the user if the download fails" do
-      stub_request(:get, Command::Plugins::PLUGINS_URL).to_return(:status => [404, "Not Found"])
-      @command.run
-      UI.output.should.include("Could not download plugins list from cocoapods.org")
-      @command.json.should.be.nil?
-    end
-
-    it "prints out each plugin" do
-      json_fixture = fixture('plugins.json')
-      @json = JSON.parse(File.read(json_fixture))
-      @command.json = @json
-      @command.run
-      UI.output.should.include("github.com/CocoaPods/cocoapods-fake")
-      UI.output.should.include("github.com/chneukirchen/bacon")
-    end
-
-    it "detects if a gem is installed" do
-      @command.installed?("bacon").should.be.true
-      @command.installed?("fake-fake-fake-gem").should.be.false
-    end
-
-  end
-
-  describe Command::Plugins::Create do
-    extend SpecHelper::PluginCreateCommand
-
-    it "registers itself" do
-      Command.parse(%w(plugins create)).should.be.instance_of Command::Plugins::Create
-    end
-
-    it "should require a name is passed in" do
-      @command = create_command(argv)
-      # rubocop:disable Lambda
-      lambda { @command.validate! }
-            .should.raise(CLAide::Help)
-            .message.should.match(/A name for the plugin is required./)
-      # rubocop:enable Lambda
-    end
-
-    it "should require a non-empty name is passed in" do
-      @command = create_command(argv(""))
-      # rubocop:disable Lambda
-      lambda { @command.validate! }
-            .should.raise(CLAide::Help)
-            .message.should.match(/A name for the plugin is required./)
-      # rubocop:enable Lambda
-    end
-
-    it "should require the name does not have spaces" do
-      @command = create_command(argv("my gem"))
-      # rubocop:disable Lambda
-      lambda { @command.validate! }
-            .should.raise(CLAide::Help)
-            .message.should.match(/The plugin name cannot contain spaces./)
-      # rubocop:enable Lambda
-    end
-
-    it "should download the default template repository" do
-      @command = create_command(argv("cocoapods-banana"))
-      # @command = Command::Plugins::Create.new(argv("cocoapods-banana"))
-
-      git_command = "clone 'https://github.com/CocoaPods/cocoapods-plugin-template.git' cocoapods-banana"
-      @command.expects(:git!).with(git_command)
-      @command.expects(:configure_template)
-      @command.run
-      UI.output.should.include("Creating `cocoapods-banana` plugin")
-    end
-
-    it "should download the passed in template repository" do
-      alt_repository = "https://github.com/CocoaPods/cocoapods-banana-plugin-template.git"
-      @command = create_command(argv("cocoapods-banana", alt_repository))
-
-      @command.expects(:git!).with("clone '#{alt_repository}' cocoapods-banana")
-      @command.expects(:configure_template)
-      @command.run
-      UI.output.should.include("Creating `cocoapods-banana` plugin")
-    end
-
   end
-
 end

data/spec/fixtures/plugins.json

@@ -1,16 +1,22 @@
 {
 	"plugins":[
 		{
-			"gem":"cocoapods-fake-fake-fake",
+			"gem":"cocoapods-fake-fake-fake-1",
 		    "name":"CocoaPods Fake Gem",
-		    "url":"https://github.com/CocoaPods/cocoapods-fake",
-		    "description":"A Pod that should not exist."
+		    "url":"https://github.com/CocoaPods/cocoapods-fake-1",
+		    "description":"A Pod that should not exist and should only be found by full search"
 		},
 		{
 			"gem":"bacon",
 			"name":"Bacon",
 			"url":"https://github.com/chneukirchen/bacon",
 			"description":"A minimal RSpec clone."
-		}
+		},
+        {
+            "gem":"cocoapods-fake-fake-fake-2",
+            "name":"CocoaPods Searchable Fake Gem",
+            "url":"https://github.com/CocoaPods/cocoapods-fake-2",
+            "description":"A Pod that should not exist but should be found with search"
+        }
 	]
 }

data/spec/spec_helper.rb

@@ -38,7 +38,6 @@ require 'cocoapods_plugin'
 # The CocoaPods namespace
 #
 module Pod
-
   # Disable the wrapping so the output is deterministic in the tests.
   #
   UI.disable_wrap = true
@@ -85,19 +84,30 @@ end
 
 #-----------------------------------------------------------------------------#
 
-# Pod namespace
+# SpecHelper namespace
 #
 module SpecHelper
-  # Add this as an extention into the Create specs
-  module PluginCreateCommand
-
-    def argv(*args)
-      CLAide::ARGV.new(args)
+  # Add this as an extension into the Search and List specs
+  # to help stub the plugins.json request
+  module PluginsStubs
+    def stub_plugins_json_request(json = nil, status = 200)
+      body = json || File.read(fixture('plugins.json'))
+      stub_request(:get, Pod::Command::PluginsHelper::PLUGINS_URL)
+      .to_return(:status => status, :body => body, :headers => {})
     end
+  end
 
-    def create_command(args)
-      Pod::Command::Plugins::Create.new(args)
+  # Add this as an extension into the Create specs
+  module PluginsCreateCommand
+    def create_command(*args)
+      Pod::Command::Plugins::Create.new CLAide::ARGV.new(args)
     end
+  end
 
+  # Add this as an extension into the Search specs
+  module PluginsSearchCommand
+    def search_command(*args)
+      Pod::Command::Plugins::Search.new CLAide::ARGV.new(args)
+    end
   end
 end

metadata

@@ -1,29 +1,16 @@
 --- !ruby/object:Gem::Specification
 name: cocoapods-plugins
 version: !ruby/object:Gem::Version
-  version: 0.1.0
+  version: 0.1.1
 platform: ruby
 authors:
 - David Grandinetti
+- Olivier Halligon
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2014-04-22 00:00:00.000000000 Z
+date: 2014-05-02 00:00:00.000000000 Z
 dependencies:
-- !ruby/object:Gem::Dependency
-  name: cocoapods
-  requirement: !ruby/object:Gem::Requirement
-    requirements:
-    - - '>='
-      - !ruby/object:Gem::Version
-        version: '0'
-  type: :runtime
-  prerelease: false
-  version_requirements: !ruby/object:Gem::Requirement
-    requirements:
-    - - '>='
-      - !ruby/object:Gem::Version
-        version: '0'
 - !ruby/object:Gem::Dependency
   name: nap
   requirement: !ruby/object:Gem::Requirement
@@ -66,13 +53,18 @@ dependencies:
     - - '>='
       - !ruby/object:Gem::Version
         version: '0'
-description: 
+description: |2
+                           This CocoaPods plugin shows information about all available CocoaPods plugins
+                           (yes, this is very meta!).
+                           This CP plugin adds the "pod plugins" command to CocoaPods so that you can list
+                           all plugins (registered in the reference JSON hosted at CocoaPods/cocoapods.org)
 email: 
 executables: []
 extensions: []
 extra_rdoc_files: []
 files:
 - .gitignore
+- .rubocop-cocoapods.yml
 - .rubocop.yml
 - .travis.yml
 - CHANGELOG.md
@@ -85,6 +77,14 @@ files:
 - lib/cocoapods_plugin.rb
 - lib/cocoapods_plugins.rb
 - lib/pod/command/plugins.rb
+- lib/pod/command/plugins/create.rb
+- lib/pod/command/plugins/list.rb
+- lib/pod/command/plugins/search.rb
+- lib/pod/command/plugins_helper.rb
+- spec/command/plugins/create_spec.rb
+- spec/command/plugins/list_spec.rb
+- spec/command/plugins/search_spec.rb
+- spec/command/plugins_helper_spec.rb
 - spec/command/plugins_spec.rb
 - spec/fixtures/plugins.json
 - spec/spec_helper.rb
@@ -108,11 +108,15 @@ required_rubygems_version: !ruby/object:Gem::Requirement
       version: '0'
 requirements: []
 rubyforge_project: 
-rubygems_version: 2.2.2
+rubygems_version: 2.0.6
 signing_key: 
 specification_version: 4
 summary: CocoaPods plugin which shows info about available CocoaPods plugins.
 test_files:
+- spec/command/plugins/create_spec.rb
+- spec/command/plugins/list_spec.rb
+- spec/command/plugins/search_spec.rb
+- spec/command/plugins_helper_spec.rb
 - spec/command/plugins_spec.rb
 - spec/fixtures/plugins.json
 - spec/spec_helper.rb