cocoapods-core 0.31.1 → 0.32.0

data/lib/cocoapods-core/source/github_data_provider.rb

@@ -1,12 +1,10 @@
 module Pod
   class Source
-
     # Data provider for a `Pod::Source` backed by a repository hosted on GitHub
     # and accessed via the HTTP API. Only pure JSON repos using the `Specs`
     # subdir to store the specifications are supported.
     #
     class GitHubDataProvider < AbstractDataProvider
-
       # @return [String] The identifier of the repository (user name and repo
       #         name) or the full URL of the repo.
       #
@@ -39,14 +37,14 @@ module Pod
       # @return [String] The user friendly type of the source.
       #
       def type
-        "GitHub API"
+        'GitHub API'
       end
 
       # @return [Array<String>] The list of the name of all the Pods known to
       #         the Source.
       #
       def pods
-        root_contents = get_github_contents("Specs")
+        root_contents = get_github_contents('Specs')
         pods = dir_names(root_contents)
         pods.sort if pods
       end
@@ -58,9 +56,13 @@ module Pod
       #         The name of the Pod.
       #
       def versions(name)
-        raise ArgumentError, "No name" unless name
+        raise ArgumentError, 'No name' unless name
         contents = get_github_contents("Specs/#{name}")
-        dir_names(contents)
+        pre_vers = dir_names(contents)
+        return nil if pre_vers.nil?
+        pre_vers.each do |v|
+          Version.new(v)
+        end.sort.reverse.map(&:to_s)
       end
 
       # @return [Specification] The specification for a given version of a Pod.
@@ -72,8 +74,8 @@ module Pod
       #         The version of the Pod.
       #
       def specification(name, version)
-        raise ArgumentError, "No name" unless name
-        raise ArgumentError, "No version" unless version
+        raise ArgumentError, 'No name' unless name
+        raise ArgumentError, 'No version' unless version
         spec_content = specification_contents(name, version)
         if spec_content
           Pod::Specification.from_json(spec_content)
@@ -90,13 +92,13 @@ module Pod
       #         the version of the Pod.
       #
       def specification_contents(name, version)
-        raise ArgumentError, "No name" unless name
-        raise ArgumentError, "No version" unless version
+        raise ArgumentError, 'No name' unless name
+        raise ArgumentError, 'No version' unless version
         path = "Specs/#{name}/#{version}/#{name}.podspec.json"
         file_contents = get_github_contents(path)
         if file_contents
           if file_contents['encoding'] == 'base64'
-            require "base64"
+            require 'base64'
             Base64.decode64(file_contents['content'])
           end
         end
@@ -137,7 +139,6 @@ module Pod
       end
 
       #-----------------------------------------------------------------------#
-
     end
   end
 end

data/lib/cocoapods-core/source/health_reporter.rb

@@ -1,10 +1,8 @@
 module Pod
   class Source
-
     # Checks a source for errors and warnings.
     #
     class HealthReporter
-
       # @return [Source] the source to check.
       #
       attr_reader :source
@@ -127,7 +125,7 @@ module Pod
         all_paths = Pathname.glob(source.data_provider.repo + '**/*.podspec{,.json}')
         stray_specs = all_paths - report.analyzed_paths
         stray_specs.each do |path|
-          report.add_message(:error, "Stray spec", path)
+          report.add_message(:error, 'Stray spec', path)
         end
       end
 
@@ -136,7 +134,6 @@ module Pod
       # Encapsulates the information about the state of a repo.
       #
       class HealthReport
-
         # @return [Source] the source analyzed.
         #
         attr_reader :source
@@ -195,7 +192,6 @@ module Pod
       end
 
       #-----------------------------------------------------------------------#
-
     end
   end
 end

data/lib/cocoapods-core/source.rb

@@ -6,7 +6,6 @@ require 'cocoapods-core/source/file_system_data_provider'
 require 'cocoapods-core/source/github_data_provider'
 
 module Pod
-
   # The Source class is responsible to manage a collection of podspecs.
   #
   # The backing store of the podspecs collection is an implementation detail
@@ -18,7 +17,6 @@ module Pod
   #     "#{SPEC_NAME}/#{VERSION}/#{SPEC_NAME}.podspec"
   #
   class Source
-
     # @return [AbstractDataProvider] the data provider for this source.
     #
     attr_accessor :data_provider
@@ -300,6 +298,5 @@ module Pod
     end
 
     #-------------------------------------------------------------------------#
-
   end
 end

data/lib/cocoapods-core/specification/consumer.rb

@@ -2,7 +2,6 @@ require 'active_support/core_ext/string/strip.rb'
 
 module Pod
   class Specification
-
     # Allows to conveniently access a Specification programmatically.
     #
     # It takes care of:
@@ -18,7 +17,6 @@ module Pod
     # serializing a specification back exactly as defined in a file.
     #
     class Consumer
-
       # @return [Specification] The specification to consume.
       #
       attr_reader :spec
@@ -157,8 +155,6 @@ module Pod
 
       #-----------------------------------------------------------------------#
 
-      # @!group Dependencies
-
       # @return [Array<Dependency>] the dependencies on other Pods.
       #
       def dependencies
@@ -168,10 +164,10 @@ module Pod
         end
       end
 
+      # Raw values need to be prepared as soon as they are read so they can be
+      # safely merged to support multi platform attributes and inheritance
       #-----------------------------------------------------------------------#
 
-      private
-
       # Returns the value for the attribute with the given name for the
       # specification. It takes into account inheritance, multi-platform
       # attributes and default values.
@@ -297,37 +293,8 @@ module Pod
         end
       end
 
-      #-----------------------------------------------------------------------#
-
-      private
-
-      # Converts the keys of the given hash to a string.
-      #
-      # @todo   Removed if not used by `resources_bundle`
-      #
-      # @param  [Object] value
-      #         the value that needs to be stripped from the Symbols.
-      #
-      # @return [Hash] the hash with the strings instead of the keys.
-      #
-      # def convert_keys_to_symbol(value)
-      #   return unless value
-      #   result = {}
-      #   value.each do |key, subvalue|
-      #     subvalue = convert_keys_to_symbol(subvalue) if subvalue.is_a?(Hash)
-      #     result[key.to_sym] = subvalue
-      #   end
-      #   result
-      # end
-
-      #-----------------------------------------------------------------------#
-
-      private
-
       # @!group Preparing Values
-      #
-      # Raw values need to be prepared as soon as they are read so they can be
-      # safely merged to support multi platform attributes and inheritance
+      #-----------------------------------------------------------------------#
 
       # @return [String] the name of the prepare hook for this attribute.
       #
@@ -372,7 +339,6 @@ module Pod
       end
 
       #-----------------------------------------------------------------------#
-
     end
   end
 end

data/lib/cocoapods-core/specification/dsl/attribute.rb

@@ -1,12 +1,10 @@
 module Pod
   class Specification
     module DSL
-
       # A Specification attribute stores the information of an attribute. It
       # also provides logic to implement any required logic.
       #
       class Attribute
-
         require 'active_support/inflector/inflections'
 
         # @return [Symbol] the name of the attribute.
@@ -112,28 +110,38 @@ module Pod
         # @return [Bool] whether the specification should be considered invalid
         #         if a value for the attribute is not specified.
         #
-        def required?; @required; end
+        def required?
+          @required
+        end
 
         # @return [Bool] whether the attribute should be specified only on the
         #         root specification.
         #
-        def root_only?; @root_only; end
+        def root_only?
+          @root_only
+        end
 
         # @return [Bool] whether the attribute is multi-platform and should
         #         work in conjunction with #{PlatformProxy}.
         #
-        def multi_platform?; @multi_platform; end
+        def multi_platform?
+          @multi_platform
+        end
 
         # @return [Bool] whether there should be a singular alias for the
         #         attribute writer.
         #
-        def singularize?; @singularize; end
+        def singularize?
+          @singularize
+        end
 
         # @return [Bool] whether the attribute describes file patterns.
         #
         # @note   This is mostly used by the linter.
         #
-        def file_patterns?; @file_patterns; end
+        def file_patterns?
+          @file_patterns
+        end
 
         # @return [Bool] defines whether the attribute reader should join the
         # values with the parent.
@@ -236,7 +244,6 @@ module Pod
       end
 
       #-----------------------------------------------------------------------#
-
     end
   end
 end

data/lib/cocoapods-core/specification/dsl/attribute_support.rb

@@ -1,7 +1,6 @@
 module Pod
   class Specification
     module DSL
-
       # @return [Array<Attribute>] The attributes of the class.
       #
       def self.attributes
@@ -12,7 +11,6 @@ module Pod
       # {Specification} DSL.
       #
       module AttributeSupport
-
         # Defines a root attribute for the extended class.
         #
         # Root attributes make sense only in root specification, they never are

data/lib/cocoapods-core/specification/dsl/deprecations.rb

@@ -1,11 +1,9 @@
 module Pod
   class Specification
     module DSL
-
       # Provides warning and errors for the deprecated attributes of the DSL.
       #
       module Deprecations
-
         def preferred_dependency=(name)
           self.default_subspec = name
           CoreUI.warn "[#{self}] `preferred_dependency` has been renamed "\
@@ -16,14 +14,14 @@ module Pod
           if method == :pre_install
             CoreUI.warn "[#{self}] The use of `#{method}` by overriding " \
               "the method is deprecated."
-            @pre_install_callback = Proc.new do |pod, target_definition|
+            @pre_install_callback = proc do |pod, target_definition|
               pre_install(pod, target_definition)
             end
 
           elsif method == :post_install
             CoreUI.warn "[#{self}] The use of `#{method}` by overriding the " \
               "method is deprecated."
-            @post_install_callback = Proc.new do |target_installer|
+            @post_install_callback = proc do |target_installer|
               post_install(target_installer)
             end
 
@@ -95,7 +93,9 @@ module Pod
         def pre_install(&block)
           CoreUI.warn "[#{self}] The pre install hook of the specification " \
             "DSL has been deprecated, use the `resource_bundles` or the " \
-              "`prepare_command` attributes."
+            "`prepare_command` attributes."
+          CoreUI.warn "[#{self}] The pre_install hook will be removed in " \
+            "the next release"
           @pre_install_callback = block
         end
 
@@ -125,12 +125,13 @@ module Pod
         def post_install(&block)
           CoreUI.warn "[#{self}] The post install hook of the specification " \
             "DSL has been deprecated, use the `resource_bundles` or the " \
-              "`prepare_command` attributes."
+            "`prepare_command` attributes."
+          CoreUI.warn "[#{self}] The post_install hook will be removed in " \
+            "the next release"
           @post_install_callback = block
         end
 
         #-----------------------------------------------------------------------#
-
       end
     end
   end

data/lib/cocoapods-core/specification/dsl/platform_proxy.rb

@@ -1,12 +1,10 @@
 module Pod
   class Specification
     module DSL
-
       # The PlatformProxy works in conjunction with Specification#_on_platform.
       # It provides support for a syntax like `spec.ios.source_files = 'file'`.
       #
       class PlatformProxy
-
         # @return [Specification] the specification for this platform proxy.
         #
         attr_accessor :spec
@@ -52,8 +50,8 @@ module Pod
           name, *version_requirements = args
           platform_name = platform.to_s
           platform_hash = spec.attributes_hash[platform_name] || {}
-          platform_hash["dependencies"] ||= {}
-          platform_hash["dependencies"][name] = version_requirements
+          platform_hash['dependencies'] ||= {}
+          platform_hash['dependencies'][name] = version_requirements
           spec.attributes_hash[platform_name] = platform_hash
         end
 
@@ -63,8 +61,8 @@ module Pod
         #
         def deployment_target=(value)
           platform_name = platform.to_s
-          spec.attributes_hash["platforms"] ||= {}
-          spec.attributes_hash["platforms"][platform_name] = value
+          spec.attributes_hash['platforms'] ||= {}
+          spec.attributes_hash['platforms'][platform_name] = value
         end
       end
     end