cocoapods-core 0.17.0.rc6 → 0.17.0.rc7

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 3f16df566bf9d03c8f0e5026dbc78ed3d2b2224b
-  data.tar.gz: 67af4c059d2f9ffc0cccf953e86b534027a18a43
+  metadata.gz: efc2bb9d0631f1b6892c062e5c66eeb9f8a876ef
+  data.tar.gz: 73fe2a60460bd2f95c0212bffa3d1d2dbe4f86c3
 SHA512:
-  metadata.gz: e0ac43dc421675a3dc4f717251d150a3c981147acda279caa52f7e5f5bf3d13c0a4c19a81903f814fa221f364a3354b65583df777abc8369ffbdd19fadb70515
-  data.tar.gz: adb5be37a6b3d9fea4f8b9b5be0c42af1432c9c3cc9f89e1a8792033616088a19a3b8f0e9c12b1cfcb27131229995658c587a6f9b266ce367775ac09fe52a2ba
+  metadata.gz: fdf7ab2b16c17c019275d916c18c81fbc1cc5b33f91c730b9c9100c8ea4cb70baf4efb9fbf7a6f37292abca9435cb6349dcf9627cc28276d0d652170f2bd2075
+  data.tar.gz: 3cf61b76148d7ea8e07026df2ab1d76f2e766dabfc6e81547571b42387555ccfd7b57a9e48c22d9a4e0b066f02d4e4a1872fb4436d6e37394fc9d3831a385d21

data/lib/cocoapods-core.rb

@@ -27,6 +27,11 @@ module Pod
   require 'cocoapods-core/specification'
   require 'cocoapods-core/standard_error'
   require 'cocoapods-core/yaml_converter'
+
+  # TODO: Temporary support for FileList
+  #
+  require 'rake'
+  FileList = Rake::FileList
 end
 
 

data/lib/cocoapods-core/gem_version.rb

@@ -2,5 +2,5 @@ module Pod
 
   # The version of the cocoapods-core.
   #
-  CORE_VERSION = '0.17.0.rc6' unless defined? Pod::CORE_VERSION
+  CORE_VERSION = '0.17.0.rc7' unless defined? Pod::CORE_VERSION
 end

data/lib/cocoapods-core/source/acceptor.rb

@@ -56,10 +56,13 @@ module Pod
       # Checks whether the source of the proposed specification is different
       # from the one of the reference specification.
       #
+      # @note   HTTP Sources are ignored as they change per version.
+      #
       # @return [void]
       #
       def check_spec_source_change(spec, errors)
         return unless spec
+        return if spec.source[:http]
         return unless reference_spec(spec)
         keys = Spec::DSL::SOURCE_KEYS.keys
         source = spec.source.values_at(*keys).compact.first
@@ -101,8 +104,8 @@ module Pod
         end
       end
 
-      # Checks that there is a specification available for the dependencies of
-      # the given specification.
+      # Checks that there is a specification available for each of the
+      # dependencies of the given specification.
       #
       # @return [void]
       #

data/lib/cocoapods-core/source/health_reporter.rb

@@ -17,12 +17,6 @@ module Pod
         @linter_results = {}
       end
 
-      # @return [Bool] Whether the more strict validation of the master repo
-      #         should be used. Specifically The master repo treats certain
-      #         warnings as errors.
-      #
-      attr_accessor :master_repo_mode
-
       public
 
       # @!group Configuration
@@ -93,7 +87,6 @@ module Pod
       #
       def lint_spec(name, version, spec_path)
         linter = Specification::Linter.new(spec_path)
-        linter.master_repo_mode = master_repo_mode
         linter.lint
         linter.results.each do |result|
           type = result.type == :error ? :error : :warning
@@ -117,8 +110,8 @@ module Pod
       # @return [void]
       #
       def check_spec_path(name, version, spec)
-        unless spec.name == name && spec.version == version
-          report.add_message(:error, "Incorrect path", name)
+        unless spec.name == name && spec.version.to_s == version.to_s
+          report.add_message(:error, "Incorrect path", name, spec.version)
         end
       end
 

data/lib/cocoapods-core/specification/linter.rb

@@ -35,12 +35,6 @@ module Pod
         end
       end
 
-      # @return [Bool] Whether the more strict validation of the master repo
-      #         should be used. Specifically The master repo treats certain
-      #         warnings as errors.
-      #
-      attr_accessor :master_repo_mode
-
       # Lints the specification adding a {Result} for any failed check to the
       # {#results} list.
       #
@@ -98,7 +92,10 @@ module Pod
         text = @file.read
         error "`config.ios?` and `config.osx?` are deprecated."  if text =~ /config\..?os.?/
         error "clean_paths are deprecated (use preserve_paths)." if text =~ /clean_paths/
-        master_repo_error "Comments must be deleted." if text.scan(/^\s*#\s+/).length > 24
+        all_lines_count = text.lines.count
+        comments_lines_count = text.scan(/^\s*#\s+/).length
+        comments_ratio = comments_lines_count.fdiv(all_lines_count)
+        warning "Comments must be deleted." if comments_lines_count > 20 && comments_ratio > 0.2
       end
 
       # Checks that every root only attribute which is required has a value.
@@ -204,18 +201,18 @@ module Pod
       # Performs validations related to the `summary` attribute.
       #
       def _validate_summary(s)
-        master_repo_error "The summary should be short use `description` (max 140 characters)." if s.length > 140
-        master_repo_error "The summary is not meaningful." if s =~ /A short description of/
+        warning "The summary should be short use `description` (max 140 characters)." if s.length > 140
+        warning "The summary is not meaningful." if s =~ /A short description of/
         warning "The summary should end with proper punctuation." if s !~ /(\.|\?|!)$/
       end
 
       # Performs validations related to the `description` attribute.
       #
       def _validate_description(d)
-        master_repo_error "The description is not meaningful." if d =~ /An optional longer description of/
-        master_repo_error "The description should end with proper punctuation." if d !~ /(\.|\?|!)$/
-        master_repo_error "The description is equal to the summary." if d == spec.summary
-        master_repo_error "The description is shorter than the summary." if d.length < spec.summary.length
+        warning "The description is not meaningful." if d =~ /An optional longer description of/
+        warning "The description should end with proper punctuation." if d !~ /(\.|\?|!)$/
+        warning "The description is equal to the summary." if d == spec.summary
+        warning "The description is shorter than the summary." if d.length < spec.summary.length
       end
 
       # Performs validations related to the `license` attribute.
@@ -223,7 +220,7 @@ module Pod
       def _validate_license(l)
         type = l[:type]
         warning "Missing license type." if type.nil?
-        master_repo_error "Invalid license type." if type && type.gsub(' ', '').gsub("\n", '').empty?
+        warning "Invalid license type." if type && type.gsub(' ', '').gsub("\n", '').empty?
         error   "Sample license type."  if type && type =~ /\(example\)/
       end
 
@@ -237,14 +234,14 @@ module Pod
 
           error "Example source." if git =~ /http:\/\/EXAMPLE/
           error 'The commit of a Git source cannot be `HEAD`.'    if commit && commit.downcase =~ /head/
-          master_repo_error 'The version should be included in the Git tag.' if tag && !tag.include?(version)
-          master_repo_error "Github repositories should end in `.git`."      if github && !git.end_with?('.git')
-          master_repo_error "Github repositories should use `https` link."   if github && !git.start_with?('https://github.com') && !git.start_with?('git://gist.github.com')
+          warning 'The version should be included in the Git tag.' if tag && !tag.include?(version)
+          warning "Github repositories should end in `.git`."      if github && !git.end_with?('.git')
+          warning "Github repositories should use `https` link."   if github && !git.start_with?('https://github.com') && !git.start_with?('git://gist.github.com')
 
           if version == '0.0.1'
             error 'Git sources should specify either a commit or a tag.' if commit.nil? && tag.nil?
           else
-            master_repo_error 'Git sources should specify a tag.' if tag.nil?
+            warning 'Git sources should specify a tag.' if tag.nil?
           end
         end
       end
@@ -277,9 +274,7 @@ module Pod
           patterns.each do |pattern|
             if pattern.is_a?(Rake::FileList)
               # TODO: enable for the 0.17 release
-              unless master_repo_mode
-                warning "Rake::FileList is deprecated, use `exclude_files` (#{attrb.name})."
-              end
+              # warning "Rake::FileList is deprecated, use `exclude_files` (#{attrb.name})."
             else
               if pattern.start_with?('/')
                 error "File patterns must be relative and cannot start with a slash (#{attrb.name})."
@@ -336,22 +331,6 @@ module Pod
         add_result(:warning, message)
       end
 
-      # Adds an error if the master repo mode is enabled, otherwise logs a
-      # warning.
-      #
-      # @param  [String] message
-      #         The message of the result.
-      #
-      # @return [void]
-      #
-      def master_repo_error(message)
-        if master_repo_mode
-          error(message)
-        else
-          warning(message)
-        end
-      end
-
       # Adds a result of the given type with the given message. If there is a
       # current platform it is added to the result. If a result with the same
       # type and the same message is already available the current platform is

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: cocoapods-core
 version: !ruby/object:Gem::Version
-  version: 0.17.0.rc6
+  version: 0.17.0.rc7
 platform: ruby
 authors:
 - Eloy Duran
@@ -9,7 +9,7 @@ authors:
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2013-03-20 00:00:00.000000000 Z
+date: 2013-03-26 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: activesupport
@@ -17,14 +17,14 @@ dependencies:
     requirements:
     - - ~>
       - !ruby/object:Gem::Version
-        version: 3.2.6
+        version: 3.2.13
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - ~>
       - !ruby/object:Gem::Version
-        version: 3.2.6
+        version: 3.2.13
 - !ruby/object:Gem::Dependency
   name: faraday
   requirement: !ruby/object:Gem::Requirement