cocoapods-bugsnag 2.1.0 → 2.2.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
-SHA256:
-  metadata.gz: 8b6be2d67d8a7328337375f824d428008832765847d254e443c524ac9eacc0e6
-  data.tar.gz: d94c59ef08d73b5cc15c0b679bb7c40226c2c3ac8e2d1740a17d2fbe56d483ba
+SHA1:
+  metadata.gz: 482f70c66ea52e9633b644d594c1c8ef9bdddbe5
+  data.tar.gz: f4a0810109c18cf8edd07bcbda48d2d84ec37d9b
 SHA512:
-  metadata.gz: 8e1cdcba0c5564af91b44a6ef46afef0eb4a49618d7eee82cf9e3641ced0ae82043ecac4ad0f68f07d461b9fce8442f22e32bdfa8be89800f3b255b63e0349eb
-  data.tar.gz: 2888cc1f3cecce524327ca998791e996d3919c77dbe9dc6b052183776b0f00dfe3c961747e918ebc198f093b7b53f7c319edfb21161539f88e42e87876bc607e
+  metadata.gz: 17a00ed6b43c406eba7390a722cf06930b32780c030efc2218b4d856a8a71981994fbc3925c87d4185b1ff988c7a2631c6445e1f45328e725b71dfa69a11e5ad
+  data.tar.gz: 8432e08a32cf59006b02fbe56fc846221544aaea895eea9c5eb3ae76d6e9d7a01dd3dd0c729028ef2b5899f8c25cbc276914ffca24bea94a34d722587d9c4e57

data/CHANGELOG.md

@@ -1,5 +1,15 @@
 # Changelog
 
+## 2.2.0 (30 Sept 2020)
+
+### Enhancements
+
+* This plugin now finds `Info.plist` using Xcode environment variables, rather than a `glob` operation for robustness.
+  | [#15](https://github.com/bugsnag/cocoapods-bugsnag/pull/15)
+
+* This plugin will now only add itself to your Xcode project if it is explicitly added as a plugin in your `Podfile`. Previously it would install if `Bugsnag` was detected in your `Podfile`.
+  | [#16](https://github.com/bugsnag/cocoapods-bugsnag/pull/16)
+
 ## 2.1.0 (14 Aug 2020)
 
 ### Enhancements

data/README.md

@@ -24,12 +24,21 @@ install, run:
 
 ## Usage
 
-To add the build phase to your project, add pod ‘Bugsnag’ to your Podfile and run:
+To add the build phase to your project, add `pod 'Bugsnag'`, and `plugin 'cocoapods-bugsnag'` to your `Podfile`:
+
+```ruby
+pod 'Bugsnag'
+plugin 'cocoapods-bugsnag'
+```
+
+Then, install with: 
 
 ```bash
 pod install
 ```
 
+Once added, uploading your dSYM files to Bugsnag will occur automatically.
+
 By default, your Bugsnag API key will either be read from the `BUGSNAG_API_KEY`
 environment variable or from the `:bugsnag:apiKey` (or `BugsnagAPIKey`) value in your
 `Info.plist`. Alternatively edit the script in the new "Upload Bugsnag dSYM" build 

data/cocoapods-bugsnag.gemspec

@@ -1,6 +1,6 @@
 Gem::Specification.new do |spec|
   spec.name = "cocoapods-bugsnag"
-  spec.version = "2.1.0"
+  spec.version = "2.2.0"
   spec.homepage = "https://bugsnag.com"
   spec.description = "Configures the dSYM upload phase of your project when integrated with bugsnag."
   spec.summary = "To get meaningful stacktraces from your crashes, the Bugsnag service needs your dSYM file for your build. This plugin adds an upload phase to your project where needed."

data/lib/cocoapods_bugsnag.rb

@@ -11,7 +11,7 @@ unless api_key
 
   # If not present, attempt to lookup the value from the Info.plist
   unless api_key
-    info_plist_path = Dir.glob("./{ios/,}*/Info.plist").reject {|path| path =~ /build|test/i }.first
+    info_plist_path = "#{ENV["BUILT_PRODUCTS_DIR"]}/#{ENV["INFOPLIST_PATH"]}"
     plist_buddy_response = `/usr/libexec/PlistBuddy -c "print :bugsnag:apiKey" "#{info_plist_path}"`
     plist_buddy_response = `/usr/libexec/PlistBuddy -c "print :BugsnagAPIKey" "#{info_plist_path}"` if !$?.success?
     api_key = plist_buddy_response if $?.success?
@@ -40,7 +40,7 @@ RUBY
     alias_method :integrate_without_bugsnag!, :integrate!
     def integrate!
       integrate_without_bugsnag!
-      return unless has_bugsnag_dependency?
+      return unless should_add_build_phase?
       return if bugsnag_native_targets.empty?
       UI.section("Integrating with Bugsnag") do
         add_bugsnag_upload_script_phase
@@ -62,10 +62,12 @@ RUBY
       end
     end
 
-    def has_bugsnag_dependency?
-      target.target_definition.dependencies.detect do |dep|
+    def should_add_build_phase?
+      has_bugsnag_dep = target.target_definition.dependencies.any? do |dep|
         dep.name.include?('Bugsnag')
-      end != nil
+      end
+      uses_bugsnag_plugin = target.target_definition.podfile.plugins.key?('cocoapods-bugsnag')
+      return has_bugsnag_dep && uses_bugsnag_plugin
     end
 
     def bugsnag_native_targets

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: cocoapods-bugsnag
 version: !ruby/object:Gem::Version
-  version: 2.1.0
+  version: 2.2.0
 platform: ruby
 authors:
 - Delisa Mason
-autorequire: 
+autorequire:
 bindir: bin
 cert_chain: []
-date: 2020-08-14 00:00:00.000000000 Z
+date: 2020-09-30 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: cocoapods
@@ -72,7 +72,7 @@ homepage: https://bugsnag.com
 licenses:
 - MIT
 metadata: {}
-post_install_message: 
+post_install_message:
 rdoc_options: []
 require_paths:
 - lib
@@ -87,8 +87,9 @@ required_rubygems_version: !ruby/object:Gem::Requirement
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
-rubygems_version: 3.1.4
-signing_key: 
+rubyforge_project:
+rubygems_version: 2.6.14
+signing_key:
 specification_version: 4
 summary: To get meaningful stacktraces from your crashes, the Bugsnag service needs
   your dSYM file for your build. This plugin adds an upload phase to your project