cocoapods-browser 0.1.1 → 0.1.2

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: dd9d62c2e1e3efd549983f97f84d4a31363c56a6
-  data.tar.gz: a55410493e431904e3b175e2b4527e9be4142234
+  metadata.gz: 9fc4fe49fc22093aa7d045638f3af073db82fea9
+  data.tar.gz: b7aefbdd73fd2342ed4c1bf8317d5b55aeef044c
 SHA512:
-  metadata.gz: d696ffa9677951eb65e51b75c50ea213feff468ce5de9296faccc80f084ab7c5ae7e84a56e113c998b8be7a7a2f8db05789ec2f1280356971ad3f534dc6aa6ca
-  data.tar.gz: 38647dd89b80dc21ce3965f33d20f91d9ff7890c9551c2013a654e02e6efcdf8631e90b11de9dd49059ab4adaa2209886f48583ba0a8ad70b69d392ab7dcdce4
+  metadata.gz: 95b477fe184fd9d134ed71f52beae3d461b682d5ecfb72b7e48dc4d63c263f3ff1404d658eeec0b1ac2891564b1f7fe4ffb4b6568c2e33b826d48aecf1dc0f1b
+  data.tar.gz: e2e219d1936b782e6401a241ce39b7f66a3e6a4239c5ea86ac357c2f71d5400416b16ecdbffa7ddb5b791254b7dc46688f71a3cd8a719f7195a55816ab6c0eb7

data/.rubocop-cocoapods.yml

@@ -0,0 +1,74 @@
+AllCops:
+  Include:
+    - Rakefile
+    - Gemfile
+    - ./*.gemspec
+  Exclude:
+    - spec/fixtures/**/*
+
+# At the moment not ready to be used
+# https://github.com/bbatsov/rubocop/issues/947
+Documentation:
+  Enabled: false
+
+#- CocoaPods -----------------------------------------------------------------#
+
+# We adopted raise instead of fail.
+SignalException:
+  EnforcedStyle: only_raise
+
+# They are idiomatic
+AssignmentInCondition:
+  Enabled: false
+
+# Allow backticks
+AsciiComments:
+  Enabled: false
+
+# Indentation clarifies logic branches in implementations
+IfUnlessModifier:
+  Enabled: false
+
+# No enforced convention here.
+SingleLineBlockParams:
+  Enabled: false
+
+# We only add the comment when needed.
+Encoding:
+  Enabled: false
+
+# Having these make it easier to *not* forget to add one when adding a new
+# value and you can simply copy the previous line.
+TrailingComma:
+  EnforcedStyleForMultiline: comma
+
+#- CocoaPods support for Ruby 1.8.7 ------------------------------------------#
+
+HashSyntax:
+  EnforcedStyle: hash_rockets
+
+Lambda:
+  Enabled: false
+
+DotPosition:
+  EnforcedStyle: trailing
+
+#- CocoaPods specs -----------------------------------------------------------#
+
+# Allow for `should.match /regexp/`.
+AmbiguousRegexpLiteral:
+  Exclude:
+    - spec/**/*
+
+# Allow `object.should == object` syntax.
+Void:
+  Exclude:
+    - spec/**/*
+
+ClassAndModuleChildren:
+  Exclude:
+    - spec/**/*
+
+UselessComparison:
+  Exclude:
+    - spec/**/*

data/.rubocop.yml

@@ -0,0 +1,3 @@
+inherit_from:
+ - rubocop-todo.yml
+ - .rubocop-cocoapods.yml

data/.travis.yml

@@ -1,10 +1,26 @@
+# Sets Travis to run the Ruby specs on OS X machines which are required to
+# build the native extensions of Xcodeproj.
+#
 language: objective-c
+
 env:
-  # This is what 10.8.x comes with and we want to support that.
-  - RVM_RUBY_VERSION=system NOEXEC_DISABLE=1 RUBY_VERSION_SPECIFIC='sudo ln -s /usr/bin/llvm-gcc-4.2 /usr/bin/gcc-4.2' SSL_CERT_FILE=/usr/local/share/cacert.pem GIT_AUTHOR_NAME=dealforest GIT_AUTHOR_EMAIL=dealforest.net@gmail.com PYTHONPATH=/usr/local/lib/python2.7/site-packages
-  - RVM_RUBY_VERSION=2.0.0-p247 NOEXEC_DISABLE=1 RUBY_VERSION_SPECIFIC='sudo gem install bundler --no-ri --no-rdoc' GIT_AUTHOR_NAME=dealforest GIT_AUTHOR_EMAIL=dealforest@gmail.com PYTHONPATH=/usr/local/lib/python2.7/site-packages
+  - RVM_RUBY_VERSION=system
+  - RVM_RUBY_VERSION=ruby-2.0.0-p247
+
+addons:
+ code_climate:
+   repo_token: 6806682857c395155713502a40d890d1d694191bb29e53ac37d435d4fea760eb
+
 before_install:
+  - export LANG=en_US.UTF-8
   - curl http://curl.haxx.se/ca/cacert.pem -o /usr/local/share/cacert.pem
-  - source ~/.rvm/scripts/rvm && rvm use $RVM_RUBY_VERSION
-install: eval $RUBY_VERSION_SPECIFIC && rake bootstrap[use_bundle_dir]
-script: bundle exec rake spec:ci
+  - source ~/.rvm/scripts/rvm
+  - if [[ $RVM_RUBY_VERSION != 'system' ]]; then rvm install $RVM_RUBY_VERSION; fi
+  - rvm use $RVM_RUBY_VERSION
+  - if [[ $RVM_RUBY_VERSION == 'system' ]]; then export ARCHFLAGS=-Wno-error=unused-command-line-argument-hard-error-in-future; fi
+  - if [[ $RVM_RUBY_VERSION == 'system' ]]; then sudo gem install bundler --no-ri --no-rdoc; else gem install bundler --no-ri --no-rdoc; fi
+
+install:
+  - bundle install --without=debugging documentation --path ./travis_bundle_dir
+
+script: bundle exec rake spec

data/Gemfile

@@ -3,10 +3,18 @@ source 'https://rubygems.org'
 gemspec
 
 group :development do
-  gem 'cocoapods'
+  gem 'cocoapods',    :git => "https://github.com/CocoaPods/CocoaPods.git", :branch => 'master'
+  gem 'claide',       :git => "https://github.com/CocoaPods/CLAide.git", :branch => 'master'
   gem 'bacon'
   gem 'mocha-on-bacon'
-  gem 'mocha', '~> 0.11.4'
-  gem 'rake'
-  gem 'prettybacon', :git => 'https://github.com/irrationalfab/PrettyBacon.git', :branch => 'master'
+  gem 'mocha'
+  gem 'prettybacon'
+
+  if RUBY_VERSION >= '1.9.3'
+    gem 'rubocop'
+
+    gem 'codeclimate-test-reporter', :require => nil
+    # Bug: https://github.com/colszowka/simplecov/issues/281
+    gem 'simplecov', '0.7.1'
+  end
 end

data/README.md

@@ -1,6 +1,9 @@
 # Cocoapods::Browser
 
-[![Build Status](https://secure.travis-ci.org/dealforest/cocoapods-browser.png?branch=master)](http://travis-ci.org/dealforest/cocoapods-browser)
+[![Build Status](http://img.shields.io/travis/dealforest/cocoapods-browser.svg?style=flat)](http://travis-ci.org/dealforestcocoapods-browser)
+[![Coverage](https://img.shields.io/codeclimate/coverage/github/dealforest/cocoapods-browser.svg?style=flat)](https://codeclimate.com/github/dealforest/cocoapods-browser)
+[![Code Climate](http://img.shields.io/codeclimate/github/dealforest/cocoapods-browser.svg?style=flat)](http://travis-ci.org/dealforest/cocoapods-browser)
+[![Gem](http://img.shields.io/gem/v/cocoapods-browser.svg?style=flat)](http://rubygems.org/gems/cocoapods-browser)
 
 CocoaPods plugin to open a pods homepage in the browser.
 

data/Rakefile

@@ -1,22 +1,63 @@
-require "bundler/gem_tasks"
-
-def specs(dir)
-  FileList["spec/#{dir}/*_spec.rb"].shuffle.join(' ')
-end
+# Bootstrap
+#-----------------------------------------------------------------------------#
 
 task :bootstrap, :use_bundle_dir? do |t, args|
-  if args[:use_bundle_dir?]
-    sh "bundle install --path ./travis_bundle_dir"
+  if system('which bundle')
+    if args[:use_bundle_dir?]
+      sh 'bundle install --path ./travis_bundle_dir'
+    else
+      sh 'bundle install'
+    end
   else
-    sh "bundle install"
+    $stderr.puts "\033[0;31m" \
+      "[!] Please install the bundler gem manually:\n" \
+      '    $ [sudo] gem install bundler' \
+      "\e[0m"
+    exit 1
   end
 end
 
-namespace :spec do
-  desc "Runs all the specs"
-  task :ci do
+begin
+
+  require 'bundler/gem_tasks'
+
+  task :default => 'spec'
+
+  # Spec
+  #-----------------------------------------------------------------------------#
+
+  desc 'Runs all the specs'
+  task :spec do
+    puts "\033[0;32mUsing #{`ruby --version`}\033[0m"
+    start_time = Time.now
     sh "bundle exec bacon #{specs('**')}"
+    duration = Time.now - start_time
+    puts "Tests completed in #{duration}s"
+    Rake::Task['rubocop'].invoke
   end
-end
 
-task :default => "spec:ci"
+  def specs(dir)
+    FileList["spec/#{dir}/*_spec.rb"].shuffle.join(' ')
+  end
+
+  # Rubocop
+  #-----------------------------------------------------------------------------#
+
+  desc 'Checks code style'
+  task :rubocop do
+    if RUBY_VERSION >= '1.9.3'
+      require 'rubocop'
+      cli = Rubocop::CLI.new
+      result = cli.run(FileList['{spec,lib}/**/*.rb'])
+      abort('RuboCop failed!') unless result == 0
+    else
+      puts '[!] Ruby > 1.9 is required to run style checks'
+    end
+  end
+
+rescue LoadError
+  $stderr.puts "\033[0;31m" \
+    '[!] Some Rake tasks haven been disabled because the environment' \
+    ' couldn’t be loaded. Be sure to run `rake bootstrap` first.' \
+    "\e[0m"
+end

data/lib/cocoapods/browser/version.rb

@@ -1,5 +1,5 @@
 module Cocoapods
   module Browser
-    VERSION = '0.1.1'
+    VERSION = '0.1.2'
   end
 end

data/lib/cocoapods/browser.rb

@@ -1,4 +1,4 @@
-require "cocoapods/browser/version"
+require 'cocoapods/browser/version'
 
 module Cocoapods
   module Browser

data/lib/pod/command/browse.rb

@@ -7,12 +7,12 @@ module Pod
         Opens the homepage of a pod in the browser.
       DESC
 
-      self.arguments = '[NAME]'
+      self.arguments = [['[NAME]', :optional]]
 
       def self.options
         [
-          [ '--spec', 'Open the podspec in the browser.' ],
-          [ '--release', 'Open the releases in the browser.' ],
+          ['--spec', 'Open the podspec in the browser.'],
+          ['--release', 'Open the releases in the browser.'],
         ].concat(super)
       end
 
@@ -32,24 +32,25 @@ module Pod
       executable :open
 
       def run
-#         update_specs_repos
+        # update_specs_repos
         @names.each do |name|
-          if specs = specs_with_name(name)
-            specs.each do |spec|
-              UI.title "Opening #{spec.name}" do
-                url = pick_open_url(spec)
-                open!(url)
-              end
+          specs = specs_with_name(name)
+          next unless specs
+
+          specs.each do |spec|
+            UI.title "Opening #{spec.name}" do
+              url = pick_open_url(spec)
+              open!(url)
             end
           end
         end
       end
 
       def update_specs_repos
-        unless config.skip_repo_update?
-          UI.section 'Updating spec repositories' do
-            SourcesManager.update
-          end
+        return if config.skip_repo_update?
+
+        UI.section 'Updating spec repositories' do
+          SourcesManager.update
         end
       end
 
@@ -88,25 +89,24 @@ module Pod
       end
 
       def formated_name(pod)
-        "%-40s (Watchers: %5s, Forks: %5s, Pushed: %s)" % [
-          pod.name.green,
-          pod.github_watchers || '-',
-          pod.github_forks || '-',
-          pod.github_last_activity.try(:yellow) || '-',
-        ]
+        format('%-40s (Watchers: %5s, Forks: %5s, Pushed: %s)',
+               pod.name.green,
+               pod.github_watchers || '-',
+               pod.github_forks || '-',
+               pod.github_last_activity.try(:yellow) || '-',
+              )
       end
 
       def pick_open_url(spec)
         url = spec.homepage
-        if @spec && url =~ %r|^https?://github.com/|
-          "%s/tree/master/%s.podspec" % [ url, spec.name ]
-        elsif @release && url =~ %r|^https?://github.com/|
-          "%s/releases" % [ url ]
+        if @spec && url =~ %r{^https?://github.com/}
+          format('%s/tree/master/%s.podspec', url, spec.name)
+        elsif @release && url =~ %r{^https?://github.com/}
+          format('%s/releases', url)
         else
           url
         end
       end
-
     end
   end
 end

data/rubocop-todo.yml

@@ -0,0 +1,18 @@
+# This configuration was generated by `rubocop --auto-gen-config`
+# on 2014-05-19 20:21:03 +0200 using RuboCop version 0.21.0.
+# The point is for the user to remove these configuration records
+# one by one as the offenses are removed from the code base.
+# Note that changes in the inspected code, or installation of new
+# versions of RuboCop, may require this file to be generated again.
+
+# Offense count: 1
+LineLength:
+  Max: 82
+
+# Offense count: 1
+MethodLength:
+  Max: 30
+
+# Offense count: 1
+CyclomaticComplexity:
+  Max: 12

data/spec/command/browse_spec.rb

@@ -1,31 +1,26 @@
 require File.expand_path('../../spec_helper', __FILE__)
 
-module Pod 
-
+module Pod
   describe Command::Browse do
-
-    describe "CLAide" do
-      it "registers it self" do
-        Command.parse(%w{ browse }).should.be.instance_of Command::Browse
+    describe 'CLAide' do
+      it 'registers it self' do
+        Command.parse(%w( browse )).should.be.instance_of Command::Browse
       end
 
-      it "presents the help if no name is provided" do
+      it 'presents the help if no name is provided' do
         command = Pod::Command.parse(['browse'])
         should.raise CLAide::Help do
           command.validate!
         end.message.should.match /A Pod name is required/
       end
 
-      it "runs" do
+      it 'runs' do
         Config.instance.skip_repo_update = false
-        command = Pod::Command.parse(['browse', 'iOS-FakeWeb'])
-#         command.expects(:update_specs_repos)
-        command.expects(:spec_with_name)
+        command = Pod::Command.parse(%w(browse iOS-FakeWeb))
+        # command.expects(:update_specs_repos)
+        command.expects(:specs_with_name)
         command.run
       end
     end
-
   end
-
 end
-

data/spec/spec_helper.rb

@@ -1,6 +1,6 @@
 ROOT = Pathname.new(File.expand_path('../../', __FILE__))
-$:.unshift((ROOT + 'lib').to_s)
-$:.unshift((ROOT + 'spec').to_s)
+$LOAD_PATH.unshift((ROOT + 'lib').to_s)
+$LOAD_PATH.unshift((ROOT + 'spec').to_s)
 
 require 'bundler/setup'
 require 'bacon'
@@ -13,7 +13,6 @@ require 'cocoapods_plugin'
 #-----------------------------------------------------------------------------#
 
 module Pod
-
   # Disable the wrapping so the output is deterministic in the tests.
   #
   UI.disable_wrap = true
@@ -32,8 +31,10 @@ module Pod
         @output << "#{message}\n"
       end
 
-      def warn(message = '', actions = [])
-        @warnings << "#{message}\n"      end
+      def warn(message = '', _actions = [])
+        @warnings << "#{message}\n"
+      end
+
       def print(message)
         @output << message
       end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: cocoapods-browser
 version: !ruby/object:Gem::Version
-  version: 0.1.1
+  version: 0.1.2
 platform: ruby
 authors:
 - Toshihiro Morimoto
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2014-02-01 00:00:00.000000000 Z
+date: 2014-06-10 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: bundler
@@ -60,6 +60,8 @@ extensions: []
 extra_rdoc_files: []
 files:
 - ".gitignore"
+- ".rubocop-cocoapods.yml"
+- ".rubocop.yml"
 - ".travis.yml"
 - Gemfile
 - LICENSE.txt
@@ -70,6 +72,7 @@ files:
 - lib/cocoapods/browser/version.rb
 - lib/cocoapods_plugin.rb
 - lib/pod/command/browse.rb
+- rubocop-todo.yml
 - spec/command/browse_spec.rb
 - spec/spec_helper.rb
 homepage: https://github.com/dealforest/cocoapods-browser
@@ -92,7 +95,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
       version: '0'
 requirements: []
 rubyforge_project: 
-rubygems_version: 2.2.0
+rubygems_version: 2.2.2
 signing_key: 
 specification_version: 4
 summary: Open a pods homepage in the browser