cocoapods-binary-bugfix 0.0.1

data/lib/cocoapods-binary-bugfix/helper/podfile_options.rb

@@ -0,0 +1,139 @@
+module Pod
+
+    class Prebuild
+        def self.keyword
+            :binary
+        end
+    end
+
+    class Podfile
+      class TargetDefinition
+
+        ## --- option for setting using prebuild framework ---
+        def parse_prebuild_framework(name, requirements)
+            should_prebuild = Pod::Podfile::DSL.prebuild_all && (not Pod::Podfile::DSL.framework_source_all)
+
+            options = requirements.last
+            if options.is_a?(Hash) && options[Pod::Prebuild.keyword] != nil 
+                should_prebuild = options.delete(Pod::Prebuild.keyword) && (not Pod::Podfile::DSL.framework_source_all)
+                requirements.pop if options.empty?
+            end
+
+            if Pod::Command::Install.all_use_source
+                should_prebuild = false
+            end
+    
+            pod_name = Specification.root_name(name)
+            set_prebuild_for_pod(pod_name, should_prebuild)
+        end
+        
+        def set_prebuild_for_pod(pod_name, should_prebuild)
+            
+            if should_prebuild == true
+                @prebuild_framework_pod_names ||= []
+                @prebuild_framework_pod_names.push pod_name
+            elsif should_prebuild == false
+                @should_not_prebuild_framework_pod_names ||= []
+                @should_not_prebuild_framework_pod_names.push pod_name
+            end
+        end
+
+        def prebuild_framework_pod_names
+            names = @prebuild_framework_pod_names || []
+            if parent != nil and parent.kind_of? TargetDefinition
+                names += parent.prebuild_framework_pod_names
+            end
+            names
+        end
+        def should_not_prebuild_framework_pod_names
+            names = @should_not_prebuild_framework_pod_names || []
+            if parent != nil and parent.kind_of? TargetDefinition
+                names += parent.should_not_prebuild_framework_pod_names
+            end
+            names
+        end
+
+        # ---- patch method ----
+        # We want modify `store_pod` method, but it's hard to insert a line in the 
+        # implementation. So we patch a method called in `store_pod`.
+        old_method = instance_method(:parse_inhibit_warnings)
+
+        define_method(:parse_inhibit_warnings) do |name, requirements|
+            variables = requirements
+            parse_prebuild_framework(name, requirements)
+            old_method.bind(self).(name, variables)
+        end
+        
+      end
+    end
+end
+
+
+module Pod
+    class Installer
+
+        def prebuild_pod_targets
+            @prebuild_pod_targets ||= (
+            all = []
+
+            aggregate_targets = self.aggregate_targets
+            aggregate_targets.each do |aggregate_target|
+                target_definition = aggregate_target.target_definition
+                targets = aggregate_target.pod_targets || []
+                # filter prebuild
+                prebuild_names = target_definition.prebuild_framework_pod_names
+                if not Podfile::DSL.prebuild_all
+                    targets = targets.select { |pod_target| prebuild_names.include?(pod_target.pod_name) } 
+                end
+            
+                dependency_targets = targets.map {|t| t.recursive_dependent_targets }.flatten.uniq || []
+             
+                targets = (targets + dependency_targets).uniq
+                # filter should not prebuild
+                explict_should_not_names = target_definition.should_not_prebuild_framework_pod_names
+                Pod::UI.puts(">>>>>>> 不需要二进制的framework: #{explict_should_not_names} ") if config.verbose
+                targets = targets.reject { |pod_target| explict_should_not_names.include?(pod_target.pod_name) } 
+
+                all += targets
+       
+            end
+            all = all.reject {|pod_target| sandbox.local?(pod_target.pod_name) }
+            Pod::UI.puts(">>>>>>> 需要二进制的framework: #{all}") if config.verbose
+            all.uniq
+
+       
+            
+            )
+        end
+
+        # the root names who needs prebuild, including dependency pods.
+        def prebuild_pod_names 
+           @prebuild_pod_names ||= self.prebuild_pod_targets.map(&:pod_name)
+        end
+
+
+        def validate_every_pod_only_have_one_form
+
+            multi_targets_pods = self.pod_targets.group_by do |t|
+                t.pod_name
+            end.select do |k, v|
+                v.map{|t| t.platform.name }.count > 1
+            end
+
+            multi_targets_pods = multi_targets_pods.reject do |name, targets|
+                contained = targets.map{|t| self.prebuild_pod_targets.include? t }
+                contained.uniq.count == 1 # all equal
+            end
+
+            return if multi_targets_pods.empty?
+
+            warnings = "One pod can only be prebuilt or not prebuilt. These pod have different forms in multiple targets:\n"
+            warnings += multi_targets_pods.map{|name, targets| "         #{name}: #{targets.map{|t|t.platform.name}}"}.join("\n")
+            raise Informative, warnings
+        end
+
+    end
+end
+
+
+

data/lib/cocoapods-binary-bugfix/helper/prebuild_sandbox.rb

@@ -0,0 +1,82 @@
+require_relative "names"
+
+module Pod
+    class PrebuildSandbox < Sandbox
+
+        # [String] standard_sandbox_path
+        def self.from_standard_sanbox_path(path)
+            prebuild_sandbox_path = Pathname.new(path).realpath + "_Prebuild"
+            self.new(prebuild_sandbox_path)
+        end
+
+        def self.from_standard_sandbox(sandbox)
+            self.from_standard_sanbox_path(sandbox.root)
+        end
+
+        def standard_sanbox_path
+            self.root.parent
+        end
+        
+        def generate_framework_path
+            self.root + "GeneratedFrameworks"
+        end
+
+        # @param name [String] pass the target.name (may containing platform suffix)
+        # @return [Pathname] the folder containing the framework file.
+        def framework_folder_path_for_target_name(name)
+            self.generate_framework_path + name
+        end
+
+        def plist_path_for_target_name(name)
+            framework_path = framework_folder_path_for_target_name(name)
+            "#{framework_path}/#{name}.framework/Info.plist"
+        end
+
+        def source_framework_path(name)
+            self.root + name
+        end
+
+        
+        def exsited_framework_target_names
+            exsited_framework_name_pairs.map {|pair| pair[0]}.uniq
+        end
+        def exsited_framework_pod_names
+            exsited_framework_name_pairs.map {|pair| pair[1]}.uniq
+        end
+        def existed_target_names_for_pod_name(pod_name)
+            exsited_framework_name_pairs.select {|pair| pair[1] == pod_name }.map { |pair| pair[0]}
+        end
+
+
+
+        def save_pod_name_for_target(target)
+            folder = framework_folder_path_for_target_name(target.name)
+            return unless folder.exist?
+            flag_file_path = folder + "#{target.pod_name}.pod_name"
+            File.write(flag_file_path.to_s, "")
+        end
+
+
+        private
+
+        def pod_name_for_target_folder(target_folder_path)
+            name = Pathname.new(target_folder_path).children.find do |child|
+                child.to_s.end_with? ".pod_name"
+            end
+            name = name.basename(".pod_name").to_s unless name.nil?
+            name ||= Pathname.new(target_folder_path).basename.to_s # for compatibility with older version
+        end
+
+        # Array<[target_name, pod_name]>
+        def exsited_framework_name_pairs
+            return [] unless generate_framework_path.exist?
+            generate_framework_path.children().map do |framework_path|
+                if framework_path.directory? && (not framework_path.children.empty?)
+                    [framework_path.basename.to_s,  pod_name_for_target_folder(framework_path)]
+                else
+                    nil
+                end
+            end.reject(&:nil?).uniq
+        end
+    end
+end

data/lib/cocoapods-binary-bugfix/helper/target_checker.rb

@@ -0,0 +1,49 @@
+
+module Pod
+  class Prebuild
+
+    # Check the targets, for the current limitation of the plugin
+    #
+    # @param [Array<PodTarget>] prebuilt_targets
+    def self.check_one_pod_should_have_only_one_target(prebuilt_targets)
+
+      targets_have_different_platforms = prebuilt_targets.select {|t| t.pod_name != t.name }
+
+      if targets_have_different_platforms.count > 0
+        names = targets_have_different_platforms.map(&:pod_name)
+        raw_names = targets_have_different_platforms.map(&:name)
+        message = "Oops, you came across a limitation of cocoapods-binary-bugfix.
+
+The plugin requires that one pod should have ONLY ONE target in the 'Pod.xcodeproj'. There are mainly 2 situations \
+causing this problem:
+
+1. One pod integrates in 2 or more different platforms' targets. e.g.
+    ```
+    target 'iphoneApp' do
+      pod 'A', :binary => true
+    end
+    target 'watchApp' do
+      pod 'A'
+    end
+    ```
+
+2. Use different subspecs in multiple targets. e.g.
+    ```
+    target 'iphoneApp' do
+      pod 'A/core'
+      pod 'A/network'
+    end
+    target 'iphoneAppTest' do
+      pod 'A/core'
+    end
+    ```
+
+Related pods: #{names}, target names: #{raw_names}
+        "
+        raise Informative, message
+      end
+    end
+
+
+  end
+end

data/lib/cocoapods-binary-bugfix/rome/build_framework.rb

@@ -0,0 +1,222 @@
+require 'fourflusher'
+require 'xcpretty'
+
+CONFIGURATION = "Debug"
+PLATFORMS = { 'iphonesimulator' => 'iOS',
+              'appletvsimulator' => 'tvOS',
+              'watchsimulator' => 'watchOS' }
+
+#  Build specific target to framework file
+#  @param [PodTarget] target
+#         a specific pod target
+#
+def build_for_iosish_platform(sandbox, 
+                              build_dir, 
+                              output_path,
+                              target, 
+                              device, 
+                              simulator,
+                              bitcode_enabled,
+                              custom_build_options = [], # Array<String>
+                              custom_build_options_simulator = [] # Array<String>
+                              )
+
+  deployment_target = target.platform.deployment_target.to_s
+  
+  target_label = target.label # name with platform if it's used in multiple platforms
+  Pod::UI.puts "Prebuilding #{target_label}..."
+  
+  other_options = []
+  # bitcode enabled
+  other_options += ['BITCODE_GENERATION_MODE=bitcode'] if bitcode_enabled
+  # make less arch to iphone simulator for faster build
+  custom_build_options_simulator += ['ARCHS=x86_64', 'ONLY_ACTIVE_ARCH=NO'] if simulator == 'iphonesimulator'
+
+  is_succeed, _ = xcodebuild(sandbox, target_label, device, deployment_target, other_options + custom_build_options)
+  exit 1 unless is_succeed
+  is_succeed, _ = xcodebuild(sandbox, target_label, simulator, deployment_target, other_options + custom_build_options_simulator)
+  exit 1 unless is_succeed
+
+  # paths
+  target_name = target.name # equals target.label, like "AFNeworking-iOS" when AFNetworking is used in multiple platforms.
+  module_name = target.product_module_name
+  device_framework_path = "#{build_dir}/#{CONFIGURATION}-#{device}/#{target_name}/#{module_name}.framework"
+  simulator_framework_path = "#{build_dir}/#{CONFIGURATION}-#{simulator}/#{target_name}/#{module_name}.framework"
+
+  device_binary = device_framework_path + "/#{module_name}"
+  simulator_binary = simulator_framework_path + "/#{module_name}"
+  # if device_binary exist && simulator_binary exist 继续执行下面的代码
+  # else return
+  return unless File.file?(device_binary) || File.file?(simulator_binary)
+
+  # the device_lib path is the final output file path
+  # combine the binaries
+  tmp_lipoed_binary_path = "#{build_dir}/#{target_name}"
+  if File.file?(device_binary) && File.file?(simulator_binary)
+    lipo_log = `lipo -create -output #{tmp_lipoed_binary_path} #{device_binary} #{simulator_binary}`
+  elsif File.file?(device_binary)
+    lipo_log = `lipo -create -output #{tmp_lipoed_binary_path} #{device_binary}`
+  else
+    lipo_log = `lipo -create -output #{tmp_lipoed_binary_path} #{simulator_binary}`
+  end
+  puts lipo_log unless File.exist?(tmp_lipoed_binary_path)
+  FileUtils.mv tmp_lipoed_binary_path, device_binary, :force => true
+  
+  # collect the swiftmodule file for various archs.
+  device_swiftmodule_path = device_framework_path + "/Modules/#{module_name}.swiftmodule"
+  simulator_swiftmodule_path = simulator_framework_path + "/Modules/#{module_name}.swiftmodule"
+  if File.exist?(simulator_swiftmodule_path) and not File.exist?(device_swiftmodule_path)
+    FileUtils.cp_r simulator_swiftmodule_path + "/.", device_swiftmodule_path
+  end
+
+  if File.exist?(device_swiftmodule_path) and not File.exist?(simulator_swiftmodule_path)
+    FileUtils.cp_r device_swiftmodule_path + "/.", simulator_swiftmodule_path
+  end
+
+  # combine the generated swift headers
+  # (In xcode 10.2, the generated swift headers vary for each archs)
+  # https://github.com/leavez/cocoapods-binary/issues/58
+  simulator_generated_swift_header_path = simulator_framework_path + "/Headers/#{module_name}-Swift.h"
+  device_generated_swift_header_path = device_framework_path + "/Headers/#{module_name}-Swift.h"
+  
+  device_header = ""
+  if File.exist? simulator_generated_swift_header_path
+    device_header = File.read(device_generated_swift_header_path)
+  end
+
+  simulator_header = ""
+  if File.exist? device_generated_swift_header_path
+    simulator_header = File.read(device_generated_swift_header_path)
+  end
+
+  # https://github.com/Carthage/Carthage/issues/2718#issuecomment-473870461
+  combined_header_content = %Q{
+#if TARGET_OS_SIMULATOR // merged by cocoapods-binary-bugfix
+
+#{simulator_header}
+
+#else // merged by cocoapods-binary-bugfix
+
+#{device_header}
+
+#endif // merged by cocoapods-binary-bugfix
+}
+  File.write(device_generated_swift_header_path, combined_header_content.strip)
+
+  # # handle the dSYM files
+  # device_dsym = "#{device_framework_path}.dSYM"
+  # if File.exist? device_dsym
+  #   # lipo the simulator dsym
+  #   simulator_dsym = "#{simulator_framework_path}.dSYM"
+  #   if File.exist? simulator_dsym
+  #     tmp_lipoed_binary_path = "#{output_path}/#{module_name}.draft"
+  #     lipo_log = `lipo -create -output #{tmp_lipoed_binary_path} #{device_dsym}/Contents/Resources/DWARF/#{module_name} #{simulator_dsym}/Contents/Resources/DWARF/#{module_name}`
+  #     puts lipo_log unless File.exist?(tmp_lipoed_binary_path)
+  #     FileUtils.mv tmp_lipoed_binary_path, "#{device_framework_path}.dSYM/Contents/Resources/DWARF/#{module_name}", :force => true
+  #   end
+  #   # move
+  #   FileUtils.mv device_dsym, output_path, :force => true
+  # end
+
+  # # output
+  output_path.mkpath unless output_path.exist?
+  FileUtils.mv device_framework_path, output_path, :force => true
+
+end
+
+def xcodebuild(sandbox, target, sdk='macosx', deployment_target=nil, other_options=[])
+  args = %W(-project #{sandbox.project_path.realdirpath} -scheme #{target} -configuration #{CONFIGURATION} -sdk #{sdk} )
+  platform = PLATFORMS[sdk]
+  args += Fourflusher::SimControl.new.destination(:oldest, platform, deployment_target) unless platform.nil?
+  args += other_options
+  log = `xcodebuild #{args.join(" ")} 2>&1`
+  exit_code = $?.exitstatus  # Process::Status
+  is_succeed = (exit_code == 0)
+
+  if !is_succeed
+    Pod::UI.puts("xcodebuild failed exitstatus:#{exit_code}") 
+    begin
+        if log.include?('** BUILD FAILED **')
+            # use xcpretty to print build log
+            # 64 represent command invalid. http://www.manpagez.com/man/3/sysexits/
+            printer = XCPretty::Printer.new({:formatter => XCPretty::Simple, :colorize => 'auto'})
+            log.each_line do |line|
+              printer.pretty_print(line)
+            end
+        else
+            raise "shouldn't be handle by xcpretty"
+        end
+    rescue
+        puts log.red
+    end
+  end
+  [is_succeed, log]
+end
+
+
+
+module Pod
+  class Prebuild
+
+    # Build the frameworks with sandbox and targets
+    #
+    # @param  [String] sandbox_root_path
+    #         The sandbox root path where the targets project place
+    #         
+    #         [PodTarget] target
+    #         The pod targets to build
+    #
+    #         [Pathname] output_path
+    #         output path for generated frameworks
+    #
+    def self.build(sandbox_root_path, target, output_path, bitcode_enabled = false, custom_build_options=[], custom_build_options_simulator=[])
+    
+      return if target.nil?
+    
+      sandbox_root = Pathname(sandbox_root_path)
+      sandbox = Pod::Sandbox.new(sandbox_root)
+      build_dir = self.build_dir(sandbox_root)
+
+      # -- build the framework
+      case target.platform.name
+      when :ios then build_for_iosish_platform(sandbox, build_dir, output_path, target, 'iphoneos', 'iphonesimulator', bitcode_enabled, custom_build_options, custom_build_options_simulator)
+      when :osx then xcodebuild(sandbox, target.label, 'macosx', nil, custom_build_options)
+      # when :tvos then build_for_iosish_platform(sandbox, build_dir, target, 'appletvos', 'appletvsimulator')
+      when :watchos then build_for_iosish_platform(sandbox, build_dir, output_path, target, 'watchos', 'watchsimulator', true, custom_build_options, custom_build_options_simulator)
+      else raise "Unsupported platform for '#{target.name}': '#{target.platform.name}'" end
+    
+      raise Pod::Informative, 'The build directory was not found in the expected location.' unless build_dir.directory?
+
+      # # --- copy the vendored libraries and framework
+      # frameworks = build_dir.children.select{ |path| File.extname(path) == ".framework" }
+      # Pod::UI.puts "Built #{frameworks.count} #{'frameworks'.pluralize(frameworks.count)}"
+    
+      # pod_target = target
+      # consumer = pod_target.root_spec.consumer(pod_target.platform.name)
+      # file_accessor = Pod::Sandbox::FileAccessor.new(sandbox.pod_dir(pod_target.pod_name), consumer)
+      # frameworks += file_accessor.vendored_libraries
+      # frameworks += file_accessor.vendored_frameworks
+
+      # frameworks.uniq!
+    
+      # frameworks.each do |framework|
+      #   FileUtils.mkdir_p destination
+      #   FileUtils.cp_r framework, destination, :remove_destination => true
+      # end
+      # build_dir.rmtree if build_dir.directory?
+    end
+    
+    def self.remove_build_dir(sandbox_root)
+      path = build_dir(sandbox_root)
+      path.rmtree if path.exist?
+    end
+
+    private 
+    
+    def self.build_dir(sandbox_root)
+      # don't know why xcode chose this folder
+      sandbox_root.parent + 'build' 
+    end
+
+  end
+end

data/lib/cocoapods-binary-bugfix/tool/tool.rb

@@ -0,0 +1,12 @@
+# attr_accessor for class variable.
+# usage:
+#
+#   ```
+#   class Pod
+#       class_attr_accessor :is_prebuild_stage
+#   end
+#   ```
+#
+def class_attr_accessor(symbol)
+    self.class.send(:attr_accessor, symbol)
+end

data/lib/cocoapods_plugin.rb

@@ -0,0 +1,2 @@
+require 'cocoapods-binary-bugfix/Main'
+

data/spec/spec_helper.rb

@@ -0,0 +1,50 @@
+require 'pathname'
+ROOT = Pathname.new(File.expand_path('../../', __FILE__))
+$:.unshift((ROOT + 'lib').to_s)
+$:.unshift((ROOT + 'spec').to_s)
+
+require 'bundler/setup'
+require 'bacon'
+require 'mocha-on-bacon'
+require 'pretty_bacon'
+require 'pathname'
+require 'cocoapods'
+
+Mocha::Configuration.prevent(:stubbing_non_existent_method)
+
+require 'cocoapods_plugin'
+
+#-----------------------------------------------------------------------------#
+
+module Pod
+
+  # Disable the wrapping so the output is deterministic in the tests.
+  #
+  UI.disable_wrap = true
+
+  # Redirects the messages to an internal store.
+  #
+  module UI
+    @output = ''
+    @warnings = ''
+
+    class << self
+      attr_accessor :output
+      attr_accessor :warnings
+
+      def puts(message = '')
+        @output << "#{message}\n"
+      end
+
+      def warn(message = '', actions = [])
+        @warnings << "#{message}\n"
+      end
+
+      def print(message)
+        @output << message
+      end
+    end
+  end
+end
+
+#-----------------------------------------------------------------------------#