cocoapods-acknowledgements 1.1.3 → 1.2.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: dea90b6cc9946925808971560e4e4748f40c709d1ab31f19d6d1c3fdeeb6ee84
-  data.tar.gz: 59db6e539ddb3bd7e3956c3dd505c85f039a26b94042309b2637ca92f0e47472
+  metadata.gz: 0f75510ee94aabecc1ad7344e4f06d1f48137321fc153b970ec73c3c4bf68d81
+  data.tar.gz: f032430ac9827e8dbb6753c2e415d860992c213850c7a2ee38178297a5104594
 SHA512:
-  metadata.gz: 8e4b19c4eb23677ebe75d919e24cae38b2bb029b64120ee7092e6799a255dacebbf47fe035ac69d7aed58e97e1040f50627feb6ad85d7ddeeb152bb3dc4cf570
-  data.tar.gz: c65a59d01d3337e5dcec5729d1dd855c098584d3c342503ea9a1ef534b1f9d97edfc50c5866331c9b274ecd194e8c51f69dc47526eb5b95f37add8a25afdbe9b
+  metadata.gz: 7df979610134e829e971ed8ecd92ac7bfcac68b9dd70b9995a64c3ecafa8b54baee1ff0e514d87d5f8adaddd1abc7e1a27b8b681c366e9c2208870cd3a8bcfaf
+  data.tar.gz: 1ad0eb6bcbd3f6472851c9990dfbee26cd22e7d9e6de9507a8f6d97fa40a4e82522872675119d1f0224b6b9263b1e52f3f98c1edee9e363136bca8732f0b6e2e

data/.gitignore

@@ -3,7 +3,6 @@
 .bundle
 .config
 .yardoc
-Gemfile.lock
 InstalledFiles
 _yardoc
 coverage

data/CHANGELOG.md

@@ -1,5 +1,30 @@
 # CocoaPods Acknowledgements Changelog
 
+## 1.2.0 (2020-03-23)
+
+##### Enhancements
+
+* Update internal gem dependencies to latest versions 
+ [Olivier Halligon](https://github.com/AliSoftware)
+ [#56](https://github.com/CocoaPods/cocoapods-acknowledgements/pull/56)
+
+* Add `targets` options to specify targets to add metadata  
+ [Richard Lee](https://github.com/dlackty)
+ [#46](https://github.com/CocoaPods/cocoapods-acknowledgements/issues/46)
+
+* Improve the performance of metadata generation  
+ [Eric Amorde](https://github.com/amorde)
+ [#54](https://github.com/CocoaPods/cocoapods-acknowledgements/pull/54)
+
+* Add tests  
+ [Eric Amorde](https://github.com/amorde)
+ [#1](https://github.com/CocoaPods/cocoapods-acknowledgements/issues/1)
+
+##### Bug Fixes
+
+* None.  
+
+
 ## 1.1.3 (2018-04-04)
 
 ##### Enhancements

data/Gemfile.lock

@@ -0,0 +1,115 @@
+PATH
+  remote: .
+  specs:
+    cocoapods-acknowledgements (1.2.0)
+      activesupport (>= 4.0.2, < 5)
+      redcarpet (~> 3.3)
+      xcodeproj
+
+GEM
+  remote: https://rubygems.org/
+  specs:
+    CFPropertyList (3.0.2)
+    activesupport (4.2.11.1)
+      i18n (~> 0.7)
+      minitest (~> 5.1)
+      thread_safe (~> 0.3, >= 0.3.4)
+      tzinfo (~> 1.1)
+    algoliasearch (1.27.1)
+      httpclient (~> 2.8, >= 2.8.3)
+      json (>= 1.5.1)
+    atomos (0.1.3)
+    bacon (1.2.0)
+    claide (1.0.3)
+    cocoapods (1.9.1)
+      activesupport (>= 4.0.2, < 5)
+      claide (>= 1.0.2, < 2.0)
+      cocoapods-core (= 1.9.1)
+      cocoapods-deintegrate (>= 1.0.3, < 2.0)
+      cocoapods-downloader (>= 1.2.2, < 2.0)
+      cocoapods-plugins (>= 1.0.0, < 2.0)
+      cocoapods-search (>= 1.0.0, < 2.0)
+      cocoapods-stats (>= 1.0.0, < 2.0)
+      cocoapods-trunk (>= 1.4.0, < 2.0)
+      cocoapods-try (>= 1.1.0, < 2.0)
+      colored2 (~> 3.1)
+      escape (~> 0.0.4)
+      fourflusher (>= 2.3.0, < 3.0)
+      gh_inspector (~> 1.0)
+      molinillo (~> 0.6.6)
+      nap (~> 1.0)
+      ruby-macho (~> 1.4)
+      xcodeproj (>= 1.14.0, < 2.0)
+    cocoapods-core (1.9.1)
+      activesupport (>= 4.0.2, < 6)
+      algoliasearch (~> 1.0)
+      concurrent-ruby (~> 1.1)
+      fuzzy_match (~> 2.0.4)
+      nap (~> 1.0)
+      netrc (~> 0.11)
+      typhoeus (~> 1.0)
+    cocoapods-deintegrate (1.0.4)
+    cocoapods-downloader (1.3.0)
+    cocoapods-plugins (1.0.0)
+      nap
+    cocoapods-search (1.0.0)
+    cocoapods-stats (1.1.0)
+    cocoapods-trunk (1.4.1)
+      nap (>= 0.8, < 2.0)
+      netrc (~> 0.11)
+    cocoapods-try (1.1.0)
+    colored2 (3.1.2)
+    concurrent-ruby (1.1.6)
+    escape (0.0.4)
+    ethon (0.12.0)
+      ffi (>= 1.3.0)
+    ffi (1.12.2)
+    fourflusher (2.3.1)
+    fuzzy_match (2.0.4)
+    gh_inspector (1.1.3)
+    httpclient (2.8.3)
+    i18n (0.9.5)
+      concurrent-ruby (~> 1.0)
+    json (2.3.0)
+    metaclass (0.0.4)
+    minitest (5.14.0)
+    mocha (0.11.4)
+      metaclass (~> 0.0.1)
+    mocha-on-bacon (0.2.1)
+      mocha (>= 0.9.8)
+    molinillo (0.6.6)
+    nanaimo (0.2.6)
+    nap (1.1.0)
+    netrc (0.11.0)
+    prettybacon (0.0.2)
+      bacon (~> 1.2)
+    rake (13.0.1)
+    redcarpet (3.5.0)
+    ruby-macho (1.4.0)
+    thread_safe (0.3.6)
+    typhoeus (1.3.1)
+      ethon (>= 0.9.0)
+    tzinfo (1.2.6)
+      thread_safe (~> 0.1)
+    xcodeproj (1.15.0)
+      CFPropertyList (>= 2.3.3, < 4.0)
+      atomos (~> 0.1.3)
+      claide (>= 1.0.2, < 2.0)
+      colored2 (~> 3.1)
+      nanaimo (~> 0.2.6)
+
+PLATFORMS
+  ruby
+
+DEPENDENCIES
+  bacon
+  bundler (~> 2.0)
+  cocoapods
+  cocoapods-acknowledgements!
+  mocha (~> 0.11.4)
+  mocha-on-bacon
+  prettybacon
+  rake
+
+BUNDLED WITH
+   2.0.2

data/README.md

@@ -35,7 +35,7 @@ plugin 'cocoapods-acknowledgements', :settings_bundle => true , :settings_post_p
 
 The plugin will search through your project files to find a `Settings.bundle` file, and add the file to the bundle. If this is not enough for you, we'd love a PR.
 
-You can also exclude some dependencies so they won't be added to the generated plists. This is useful when you don't want to add private dependencies.
+You can exclude some dependencies so they won't be added to the generated plists. This is useful when you don't want to add private dependencies.
 
 ```ruby
 plugin 'cocoapods-acknowledgements', :settings_bundle => true, :exclude => 'PrivateKit'
@@ -43,6 +43,12 @@ plugin 'cocoapods-acknowledgements', :settings_bundle => true, :exclude => 'Priv
 plugin 'cocoapods-acknowledgements', :settings_bundle => true, :exclude => ['PrivateKit', 'SecretLib']
 ```
 
+You can also specify a list of targets for which to generate acknowledgements. This can be useful to exclude test or extension targets.
+
+``` ruby
+plugin 'cocoapods-acknowledgements', :targets => ['MyApp']
+```
+
 ### Location
 
 The plist generated by this plugin is located under the root of your ```Pods``` directory.

data/cocoapods_acknowledgements.gemspec

@@ -20,6 +20,7 @@ Gem::Specification.new do |spec|
   spec.add_runtime_dependency 'activesupport', '>= 4.0.2', '< 5'
 
   spec.add_dependency "redcarpet", "~> 3.3"
-  spec.add_development_dependency "bundler", "~> 1.3"
+  spec.add_dependency "xcodeproj"
+  spec.add_development_dependency "bundler", "~> 2.0"
   spec.add_development_dependency "rake"
 end

data/lib/cocoapods_acknowledgements.rb

@@ -29,7 +29,6 @@ module CocoaPodsAcknowledgements
     end
 
     project.save
-
   end
 
   def self.settings_bundle_in_project(project)
@@ -51,8 +50,9 @@ module CocoaPodsAcknowledgements
 
     Pod::UI.section 'Adding Acknowledgements' do
 
-      should_include_settings = user_options["settings_bundle"] != nil
+      should_include_settings = user_options["settings_bundle"]
       excluded_pods = Set.new(user_options["exclude"])
+      targets = Set.new(user_options["targets"])
 
       sandbox = context.sandbox if defined? context.sandbox
       sandbox ||= Pod::Sandbox.new(context.sandbox_root)
@@ -60,44 +60,46 @@ module CocoaPodsAcknowledgements
       context.umbrella_targets.each do |umbrella_target|
         project = Xcodeproj::Project.open(umbrella_target.user_project_path)
 
-        umbrella_target.user_target_uuids.each do |user_target_uuid|
-
-          # Generate a plist representing all of the podspecs
-          metadata = PlistGenerator.generate(umbrella_target, sandbox, excluded_pods)
-
-          next unless metadata
-
-          plist_path = sandbox.root + "#{umbrella_target.cocoapods_target_label}-metadata.plist"
-          save_metadata(metadata, plist_path, project, sandbox, user_target_uuid)
-
-          if should_include_settings
+        # Generate a plist representing all of the podspecs
+        metadata = PlistGenerator.generate(umbrella_target, sandbox, excluded_pods)
+        next unless metadata
+
+        if should_include_settings
+          # We need to look for a Settings.bundle
+          # and add this to the root of the bundle
+          settings_bundle = settings_bundle_in_project(project)
+          if settings_bundle == nil
+            Pod::UI.warn "Could not find a Settings.bundle to add the Pod Settings Plist to."
+          else
             # Generate a plist in Settings format
             settings_metadata = SettingsPlistGenerator.generate(umbrella_target, sandbox, excluded_pods)
+            settings_plist_path = settings_bundle + "/#{umbrella_target.cocoapods_target_label}-settings-metadata.plist"
+          end
+        end
 
-            # We need to look for a Settings.bundle
-            # and add this to the root of the bundle
+        plist_path = sandbox.root + "#{umbrella_target.cocoapods_target_label}-metadata.plist"
 
-            settings_bundle = settings_bundle_in_project(project)
-            if settings_bundle == nil
-              Pod::UI.warn "Could not find a Settings.bundle to add the Pod Settings Plist to."
-            else
-              settings_plist_path = settings_bundle + "/#{umbrella_target.cocoapods_target_label}-settings-metadata.plist"
-              save_metadata(settings_metadata, settings_plist_path, project, sandbox, user_target_uuid)
-              Pod::UI.info "Added Pod info to Settings.bundle for target #{umbrella_target.cocoapods_target_label}"
+        user_target_uuids = if targets.empty?
+          umbrella_target.user_target_uuids
+        else
+          umbrella_target.user_targets.select do |target|
+            targets.include?(target.name)
+          end.map(&:uuid)
+        end
 
-              # Support a callback for the key :settings_post_process
-              if user_options["settings_post_process"]
-                user_options["settings_post_process"].call(settings_plist_path, umbrella_target, excluded_pods)
-              end
+        user_target_uuids.each do |user_target_uuid|
+          save_metadata(metadata, plist_path, project, sandbox, user_target_uuid)
 
+          if settings_metadata && settings_plist_path
+            save_metadata(settings_metadata, settings_plist_path, project, sandbox, user_target_uuid)
+            Pod::UI.info "Added Pod info to Settings.bundle for target #{umbrella_target.cocoapods_target_label}"
+            # Support a callback for the key :settings_post_process
+            if user_options["settings_post_process"]
+              user_options["settings_post_process"].call(settings_plist_path, umbrella_target, excluded_pods)
             end
           end
-
         end
-
       end
-
     end
-
   end
 end

data/lib/cocoapods_acknowledgements/plist_generator.rb

@@ -1,3 +1,4 @@
+# frozen_string_literal: true
 require 'redcarpet'
 
 module CocoaPodsAcknowledgements
@@ -13,14 +14,12 @@ module CocoaPodsAcknowledgements
 
         return nil if root_specs.empty?
 
-        specs_metadata = []
-        root_specs.each do |spec|
-          pod_root = sandbox.pod_dir(spec.name)
+        specs_metadata = root_specs.map do |spec|
           platform = Pod::Platform.new(target_description.platform_name)
           file_accessor = file_accessor(spec, platform, sandbox)
           license_text = license_text(spec, file_accessor)
 
-          spec_metadata = {
+          {
             "name" => spec.name,
             "version" => spec.version,
             "authors" => spec.authors,
@@ -31,12 +30,11 @@ module CocoaPodsAcknowledgements
             "licenseText" => license_text,
             "homepage" => spec.homepage,
           }
-          specs_metadata << spec_metadata
         end
 
-        metadata = {}
-        metadata["specs"] = specs_metadata
-        metadata
+        {
+          "specs" => specs_metadata
+        }
       end
 
       #-----------------------------------------------------------------------#

data/lib/cocoapods_acknowledgements/settings_plist_generator.rb

@@ -1,3 +1,4 @@
+# frozen_string_literal: true
 require 'cocoapods_acknowledgements/plist_generator'
 
 module CocoaPodsAcknowledgements
@@ -12,7 +13,6 @@ module CocoaPodsAcknowledgements
         specs_metadata = [header]
 
         root_specs.each do |spec|
-          pod_root = sandbox.pod_dir(spec.name)
           platform = Pod::Platform.new(target_description.platform_name)
           file_accessor = file_accessor(spec, platform, sandbox)
           license_text = license_text(spec, file_accessor)
@@ -26,7 +26,7 @@ module CocoaPodsAcknowledgements
         end
 
         specs_metadata << footer
-        metadata = {
+        {
           "PreferenceSpecifiers" => specs_metadata,
           "Title" => "Acknowledgements",
           "StringsTable" => "Acknowledgements"
@@ -34,7 +34,7 @@ module CocoaPodsAcknowledgements
       end
 
       def header
-        header = {
+        {
           "FooterText" => "This application makes use of the following third party libraries:",
           "Title" => "Acknowledgements",
           "Type" => "PSGroupSpecifier"
@@ -42,8 +42,8 @@ module CocoaPodsAcknowledgements
       end
 
       def footer
-        footer = {
-          "FooterText" => "Generated by CocoaPods - http://cocoapods.org",
+        {
+          "FooterText" => "Generated by CocoaPods - https://cocoapods.org",
           "Title" => nil,
           "Type" => "PSGroupSpecifier"
         }

data/lib/cocoapods_acknowledgements/version.rb

@@ -1,3 +1,3 @@
 module CocoaPodsAcknowledgements
-  VERSION = "1.1.3"
+  VERSION = "1.2.0"
 end

data/spec/acknowledgement_spec.rb

@@ -1,5 +1,155 @@
 require File.expand_path('../spec_helper.rb', __FILE__)
+require 'xcodeproj'
 
 describe CocoaPodsAcknowledgements do
 
+  UmbrellaTargetDescription = Pod::Installer::PostInstallHooksContext::UmbrellaTargetDescription
+
+  before do
+    @project_path = SpecHelper.temporary_directory + 'project.xcodeproj'
+    @project = Xcodeproj::Project.new(@project_path)
+    @project.initialize_from_scratch
+    @sandbox = temporary_sandbox
+    @spec1 = SpecHelper.spec1
+    @spec2 = SpecHelper.spec2
+
+    @settings_plist_content = {
+      'Title' => 'Acknowledgements',
+      'StringsTable' => 'Acknowledgements',
+      'PreferenceSpecifiers' => [
+        {
+          'Title' => 'Acknowledgements',
+          'Type' => 'PSGroupSpecifier',
+          'FooterText' => 'This application makes use of the following third party libraries:'
+        },
+        {
+          'Title' => 'monkeylib',
+          'Type' => 'PSGroupSpecifier',
+          'FooterText' => 'Permission is hereby granted ...'
+        },
+        {
+          'Title' => 'BananaLib',
+          'Type' => 'PSGroupSpecifier',
+          'FooterText' => 'Permission is hereby granted ...'
+        },
+        {
+          'Title' => nil,
+          'Type' => 'PSGroupSpecifier',
+          'FooterText' => 'Generated by CocoaPods - https://cocoapods.org'
+        },
+      ]
+    }
+    @plist_content = {
+      "specs" => [
+        {
+          "name" => "monkeylib",
+          "version"=> Pod::Version.new(1.0),
+          "authors"=> {
+            "CocoaPods" => "email@cocoapods.org"
+          },
+          "socialMediaURL" => "https://twitter.com/CocoaPods",
+          "summary" => "A lib to do monkey things",
+          "description" => "<h2>What is it</h2>\n\n<p>A lib to do monkey things</p>\n\n<h2>Why?</h2>\n\n<p>Why not?</p>\n",
+          "licenseType" => "MIT",
+          "licenseText" => "Permission is hereby granted ...",
+          "homepage" => "https://github.com/CocoaPods/monkeylib"
+        },
+        {
+          "name" => "BananaLib",
+          "version" => Pod::Version.new(1.0),
+          "authors" => {
+            "Banana Corp" => nil,
+            "Monkey Boy" => "monkey@banana-corp.local"
+          },
+          "socialMediaURL" => nil,
+          "summary" => "Chunky bananas!",
+          "description" => "<p>Full of chunky bananas.</p>\n",
+          "licenseType" => "MIT",
+          "licenseText" => "Permission is hereby granted ...",
+          "homepage" => "http://banana-corp.local/banana-lib.html"
+        }
+      ]
+    }
+
+    @target = @project.new_target(:application, 'MyApp', :ios)
+    @plist_path = @sandbox.root + 'Pods-MyApp-metadata.plist'
+    @project.save
+  end
+
+  after do
+    FileUtils.rm_rf(SpecHelper.temporary_directory)
+  end
+
+  describe 'In general' do
+    it 'finds existing settings bundles' do
+      settings_bundle = SpecHelper.temporary_directory + 'Settings.bundle'
+      FileUtils.mkdir(settings_bundle)
+      resource_group = @project.main_group.new_group('Resources')
+      resource_group.new_file(settings_bundle)
+
+      result = CocoaPodsAcknowledgements.settings_bundle_in_project(@project)
+      result.to_s.should == settings_bundle.to_s
+      FileUtils.rm_rf(settings_bundle)
+    end
+  end
+
+  describe '#save_metadata' do
+    it 'saves the metadata to disk' do
+      Xcodeproj::Plist.expects(:write_to_path).with(@plist_content, @plist_path).once
+      CocoaPodsAcknowledgements.save_metadata(@plist_content, @plist_path, @project, @sandbox, @target.uuid)
+    end
+
+    it 'adds the Pods group if not already existing' do
+      @project.main_group["Pods"].should.be.nil?
+      CocoaPodsAcknowledgements.save_metadata(@plist_content, @plist_path, @project, @sandbox, @target.uuid)
+      @project.main_group["Pods"].should.not.be.nil?
+    end
+
+    it 'adds the plist to the Pods group' do
+      CocoaPodsAcknowledgements.save_metadata(@plist_content, @plist_path, @project, @sandbox, @target.uuid)
+      @project.main_group["Pods"].files.find { |f| f.path == 'Pods-MyApp-metadata.plist' }.should.not.be.nil?
+    end
+
+    it 'adds the plist to user target Copy Resources build phase' do
+      CocoaPodsAcknowledgements.save_metadata(@plist_content, @plist_path, @project, @sandbox, @target.uuid)
+      file_ref = @project.main_group["Pods"].files.find { |f| f.path == 'Pods-MyApp-metadata.plist' }
+      file_ref.should.not.be.nil?
+
+      @target.resources_build_phase.files.find { |f| f.file_ref == file_ref }.should.not.be.nil?
+    end
+  end
+
+  describe 'plugin-hook' do
+    before do
+      @target_description = UmbrellaTargetDescription.new(@project, [@target], [@spec1, @spec2], :ios, '8.0', 'Pods-MyApp')
+      @hook_context = Pod::Installer::PostInstallHooksContext.new(@sandbox, @sandbox.root, nil, [@target_description])
+      Xcodeproj::Project.stubs(:open).returns(@project)
+    end
+
+    it 'generates acknowledgement plists' do
+      CocoaPodsAcknowledgements.expects(:save_metadata).with(@plist_content, @plist_path, @project, @sandbox, @target.uuid)
+      Pod::HooksManager.run(:post_install, @hook_context, { 'cocoapods-acknowledgements' => {}})
+    end
+
+    it 'generates a settings plist when specified' do
+      settings_bundle = SpecHelper.temporary_directory + 'Settings.bundle'
+      settings_plist_path = settings_bundle + 'Pods-MyApp-settings-metadata.plist'
+      FileUtils.mkdir(settings_bundle)
+      resource_group = @project.main_group.new_group('Resources')
+      resource_group.new_file(settings_bundle)
+
+      CocoaPodsAcknowledgements.expects(:save_metadata).with(@plist_content, @plist_path, @project, @sandbox, @target.uuid).once
+      CocoaPodsAcknowledgements.expects(:save_metadata).with(@settings_plist_content, settings_plist_path.to_s, @project, @sandbox, @target.uuid).once
+      Pod::HooksManager.run(:post_install, @hook_context, { 'cocoapods-acknowledgements' => { :settings_bundle => true }})
+      FileUtils.rm_rf(settings_bundle)
+    end
+
+    it "generates acknowledgement plists to only specified targets" do
+      CocoaPodsAcknowledgements.expects(:save_metadata).with(@plist_content, @plist_path, @project, @sandbox, @target.uuid).once
+      Pod::HooksManager.run(:post_install, @hook_context, { 'cocoapods-acknowledgements' => { targets: ['MyApp'] }})
+
+      CocoaPodsAcknowledgements.expects(:save_metadata).never
+      Pod::HooksManager.run(:post_install, @hook_context, { 'cocoapods-acknowledgements' => { targets: ['TheOtherTarget'] }})
+    end
+  end
 end

data/spec/plist_generator_spec.rb

@@ -1,5 +1,142 @@
 require File.expand_path('../spec_helper.rb', __FILE__)
 
-describe CocoaPodsAcknowledgements::PlistGenerator do
+describe PlistGenerator = CocoaPodsAcknowledgements::PlistGenerator do
 
+  before do
+    @spec1 = SpecHelper.spec1
+    @spec2 = SpecHelper.spec2
+    PlistGenerator.stubs(:file_accessor).returns(nil)
+    @sandbox = temporary_sandbox
+    @target_description = stub('target_description',
+                              :specs => [@spec1, @spec2],
+                              :platform_name => 'ios')
+  end
+
+  describe 'In general' do
+    it 'generates metadata' do
+      result = PlistGenerator.generate(@target_description, @sandbox, [])
+      result.should == {
+        "specs" => [
+          {
+            "name" => "monkeylib",
+            "version"=> Pod::Version.new(1.0),
+            "authors"=> {
+              "CocoaPods" => "email@cocoapods.org"
+            },
+            "socialMediaURL" => "https://twitter.com/CocoaPods",
+            "summary" => "A lib to do monkey things",
+            "description" => "<h2>What is it</h2>\n\n<p>A lib to do monkey things</p>\n\n<h2>Why?</h2>\n\n<p>Why not?</p>\n",
+            "licenseType" => "MIT",
+            "licenseText" => "Permission is hereby granted ...",
+            "homepage" => "https://github.com/CocoaPods/monkeylib"
+          },
+          {
+            "name" => "BananaLib",
+            "version" => Pod::Version.new(1.0),
+            "authors" => {
+              "Banana Corp" => nil,
+              "Monkey Boy" => "monkey@banana-corp.local"
+            },
+            "socialMediaURL" => nil,
+            "summary" => "Chunky bananas!",
+            "description" => "<p>Full of chunky bananas.</p>\n",
+            "licenseType" => "MIT",
+            "licenseText" => "Permission is hereby granted ...",
+            "homepage" => "http://banana-corp.local/banana-lib.html"
+          }
+        ]
+      }
+    end
+
+    it 'generates nil if specs is empty' do
+      target_description = stub('target_description',
+                                :specs => [],
+                                :platform_name => 'ios')
+      result = PlistGenerator.generate(target_description, @sandbox, [])
+      result.should.be.nil?
+    end
+
+    it 'does not include metadata for excluded specs' do
+      target_description = stub('target_description',
+                                :specs => [@spec1, @spec2],
+                                :platform_name => 'ios')
+      result = PlistGenerator.generate(target_description, @sandbox, [@spec1.name])
+      result.should == {
+        "specs" => [
+          {
+            "name" => "BananaLib",
+            "version" => Pod::Version.new(1.0),
+            "authors" => {
+              "Banana Corp" => nil,
+              "Monkey Boy" => "monkey@banana-corp.local"
+            },
+            "socialMediaURL" => nil,
+            "summary" => "Chunky bananas!",
+            "description" => "<p>Full of chunky bananas.</p>\n",
+            "licenseType" => "MIT",
+            "licenseText" => "Permission is hereby granted ...",
+            "homepage" => "http://banana-corp.local/banana-lib.html"
+          }
+        ]
+      }
+    end
+
+    it 'generates nil when all specs are excluded' do
+      target_description = stub('target_description',
+                                :specs => [@spec1, @spec2],
+                                :platform_name => 'ios')
+      result = PlistGenerator.generate(target_description, @sandbox, [@spec1.name, @spec2.name])
+      result.should.be.nil?
+    end
+
+    describe '#license_text' do
+      it 'returns nil if license is missing' do
+        spec = stub('spec', :license => nil)
+        result = PlistGenerator.license_text(spec, nil)
+        result.should.be.nil?
+      end
+
+      it 'returns text if specified' do
+        spec = stub('spec', :license => { :text => 'Permission is hereby granted ...'})
+        result = PlistGenerator.license_text(spec, nil)
+        result.should == 'Permission is hereby granted ...'
+      end
+
+      it 'reads license files when specified' do
+        license_file = SpecHelper.temporary_directory + 'LICENSE'
+        license_file.open('w') { |f| f.write("Permission is hereby granted ...") }
+        spec = stub('spec', :license => { :file => license_file })
+        file_accessor = stub('file_accessor', :license => license_file)
+        result = PlistGenerator.license_text(spec, file_accessor)
+        result.should == 'Permission is hereby granted ...'
+        FileUtils.rm_f(license_file)
+      end
+
+      it 'warns when a license file is specified but does not exist' do
+        license_file = SpecHelper.temporary_directory + 'non-existent-file.txt'
+        spec = stub('spec', :license => { :file => license_file })
+        file_accessor = stub('file_accessor', :license => license_file)
+        PlistGenerator.license_text(spec, file_accessor)
+        Pod::UI.warnings.should.match /Unable to read the license file/
+      end
+    end
+
+    it 'renders markdown' do
+      contents = <<EOT
+# Title
+Title description
+
+## H2 Title
+* List item 1
+* List item 2
+
+### Sub Sub Head
+> Some interesting quote
+**
+EOT
+      expected = "<h1>Title</h1>\n\n<p>Title description</p>\n\n<h2>H2 Title</h2>\n\n<ul>\n<li>List item 1</li>\n<li>List item 2</li>\n</ul>\n\n<h3>Sub Sub Head</h3>\n\n<blockquote>\n<p>Some interesting quote\n**</p>\n</blockquote>\n"
+      result = PlistGenerator.parse_markdown(contents)
+      result.should == "<h1>Title</h1>\n\n<p>Title description</p>\n\n<h2>H2 Title</h2>\n\n<ul>\n<li>List item 1</li>\n<li>List item 2</li>\n</ul>\n\n<h3>Sub Sub Head</h3>\n\n<blockquote>\n<p>Some interesting quote\n**</p>\n</blockquote>\n"
+    end
+  end
 end

data/spec/settings_plist_generator_spec.rb

@@ -1,5 +1,80 @@
 require File.expand_path('../spec_helper.rb', __FILE__)
 
-describe CocoaPodsAcknowledgements::SettingsPlistGenerator do
+describe SettingsPlistGenerator = CocoaPodsAcknowledgements::SettingsPlistGenerator do
 
+  before do
+    @spec1 = SpecHelper.spec1
+    @spec2 = SpecHelper.spec2
+    SettingsPlistGenerator.stubs(:file_accessor).returns(nil)
+    @sandbox = temporary_sandbox
+    @target_description = stub('target_description',
+                               :specs => [@spec1, @spec2],
+                               :platform_name => 'ios')
+  end
+
+  it 'generates metadata' do
+    result = SettingsPlistGenerator.generate(@target_description, @sandbox, [])
+    result.should == {
+      'Title' => 'Acknowledgements',
+      'StringsTable' => 'Acknowledgements',
+      'PreferenceSpecifiers' => [
+        {
+          'Title' => 'Acknowledgements',
+          'Type' => 'PSGroupSpecifier',
+          'FooterText' => 'This application makes use of the following third party libraries:'
+        },
+        {
+          'Title' => 'monkeylib',
+          'Type' => 'PSGroupSpecifier',
+          'FooterText' => 'Permission is hereby granted ...'
+        },
+        {
+          'Title' => 'BananaLib',
+          'Type' => 'PSGroupSpecifier',
+          'FooterText' => 'Permission is hereby granted ...'
+        },
+        {
+          'Title' => nil,
+          'Type' => 'PSGroupSpecifier',
+          'FooterText' => 'Generated by CocoaPods - https://cocoapods.org'
+        },
+      ]
+    }
+  end
+
+  it 'generates nil if specs is empty' do
+    target_description = stub('target_description',
+                              :specs => [],
+                              :platform_name => 'ios')
+    result = SettingsPlistGenerator.generate(target_description, @sandbox, [])
+    result.should.be.nil?
+  end
+
+  it 'does not include metadata for excluded specs' do
+    target_description = stub('target_description',
+                              :specs => [@spec1, @spec2],
+                              :platform_name => 'ios')
+    result = SettingsPlistGenerator.generate(target_description, @sandbox, [@spec1.name])
+    result.should == {
+      'Title' => 'Acknowledgements',
+      'StringsTable' => 'Acknowledgements',
+      'PreferenceSpecifiers' => [
+        {
+          'Title' => 'Acknowledgements',
+          'Type' => 'PSGroupSpecifier',
+          'FooterText' => 'This application makes use of the following third party libraries:'
+        },
+        {
+          'Title' => 'BananaLib',
+          'Type' => 'PSGroupSpecifier',
+          'FooterText' => 'Permission is hereby granted ...'
+        },
+        {
+          'Title' => nil,
+          'Type' => 'PSGroupSpecifier',
+          'FooterText' => 'Generated by CocoaPods - https://cocoapods.org'
+        },
+      ]
+    }
+  end
 end

data/spec/spec_helper.rb

@@ -44,4 +44,66 @@ module Pod
   end
 end
 
+module SpecHelper
+  def self.temporary_directory
+    ROOT + 'tmp'
+  end
+
+  def self.spec1
+    Pod::Specification.new do |s|
+      s.name = 'monkeylib'
+      s.version = '1.0'
+      s.authors = {
+        'CocoaPods' => 'email@cocoapods.org'
+      }
+      s.social_media_url = 'https://twitter.com/CocoaPods'
+      s.homepage = 'https://github.com/CocoaPods/monkeylib'
+      s.license = {
+        :type => 'MIT',
+        :file => 'LICENSE',
+        :text => 'Permission is hereby granted ...'
+      }
+      s.summary = 'A lib to do monkey things'
+      s.description = <<EOF
+## What is it
+A lib to do monkey things
+## Why?
+Why not?
+EOF
+    end
+  end
+
+  def self.spec2
+    Pod::Specification.new do |s|
+      s.name         = 'BananaLib'
+      s.version      = '1.0'
+      s.authors      = 'Banana Corp', { 'Monkey Boy' => 'monkey@banana-corp.local' }
+      s.homepage     = 'http://banana-corp.local/banana-lib.html'
+      s.summary      = 'Chunky bananas!'
+      s.description  = 'Full of chunky bananas.'
+      s.source       = { :git => 'http://banana-corp.local/banana-lib.git', :tag => 'v1.0' }
+      s.license      = {
+        :type => 'MIT',
+        :file => 'LICENSE',
+        :text => 'Permission is hereby granted ...'
+      }
+      s.source_files        = 'Classes/*.{h,m,d}', 'Vendor', 'framework/Source/*.h'
+      s.resources           = "Resources/*", "Resources/Images.xcassets"
+      s.vendored_framework  = 'BananaFramework.framework'
+      s.vendored_library    = 'libBananaStaticLib.a'
+      s.preserve_paths      = 'preserve_me.txt'
+      s.public_header_files = 'Classes/Banana.h', 'framework/Source/MoreBanana.h'
+      s.module_map          = 'Banana.modulemap'
+
+      s.prefix_header_file = 'Classes/BananaLib.pch'
+      s.pod_target_xcconfig = { 'OTHER_LDFLAGS' => '-framework SystemConfiguration' }
+      s.dependency   'monkey', '~> 1.0.1', '< 1.0.9'
+    end
+  end
+end
+
+def temporary_sandbox
+  Pod::Sandbox.new(SpecHelper.temporary_directory + 'Pods')
+end
+
 #-----------------------------------------------------------------------------#

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: cocoapods-acknowledgements
 version: !ruby/object:Gem::Version
-  version: 1.1.3
+  version: 1.2.0
 platform: ruby
 authors:
 - Fabio Pelosin
@@ -10,7 +10,7 @@ authors:
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2018-04-04 00:00:00.000000000 Z
+date: 2020-03-23 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: activesupport
@@ -46,20 +46,34 @@ dependencies:
     - - "~>"
       - !ruby/object:Gem::Version
         version: '3.3'
+- !ruby/object:Gem::Dependency
+  name: xcodeproj
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: '0'
+  type: :runtime
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: '0'
 - !ruby/object:Gem::Dependency
   name: bundler
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '1.3'
+        version: '2.0'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '1.3'
+        version: '2.0'
 - !ruby/object:Gem::Dependency
   name: rake
   requirement: !ruby/object:Gem::Requirement
@@ -84,6 +98,7 @@ files:
 - ".travis.yml"
 - CHANGELOG.md
 - Gemfile
+- Gemfile.lock
 - LICENSE
 - README.md
 - Rakefile
@@ -116,8 +131,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
-rubyforge_project: 
-rubygems_version: 2.7.6
+rubygems_version: 3.0.6
 signing_key: 
 specification_version: 4
 summary: CocoaPods plugin that generates an acknowledgements plist to make it easy