cocina-models 0.84.4 → 0.84.5

This diff represents the content of publicly available package versions that have been released to one of the supported registries. The information contained in this diff is provided for informational purposes only and reflects changes between package versions as they appear in their respective public registries.
Files changed (8) hide show
  1. checksums.yaml +4 -4
  2. data/.rubocop.yml +7 -0
  3. data/Gemfile.lock +7 -7
  4. data/README.md +2 -1
  5. data/lib/cocina/models/mapping/from_mods/part_builder.rb +4 -4
  6. data/lib/cocina/models/validators/date_time_validator.rb +1 -2
  7. data/lib/cocina/models/version.rb +1 -1
  8. metadata +3 -3
checksums.yaml CHANGED
@@ -1,7 +1,7 @@
1
1
  ---
2
2
  SHA256:
3
- metadata.gz: ec3a00a348ca9a851ee3455b7b0208628ca9590556ad76b0f536c4da3e1b6079
4
- data.tar.gz: 156105d8055745c353db2690e2c39b72a043243272fddc72fb80e5e9a42b81c4
3
+ metadata.gz: f88398655e31aa97ffb0ac963a0400dd2864535dd10819d53b57efecfeb6359f
4
+ data.tar.gz: 89e6074e7ba0c38db6db81e00263f84fc579fa039615d1f6be1b52ec32daff4b
5
5
  SHA512:
6
- metadata.gz: ff595ddde9a4729ed1e77239d78b7d1729798708bb44a407a6019d98943b50d8f14a3ad12fa06f17085294d499a32b82ece50f7ca6f23a30ce857bcd12a2de87
7
- data.tar.gz: 3bdb368b93e0ba0fc8f865cbb2888045589c2169af810f3380f18e2c8511fafea30fc088980a4503f6f0405a1b60daf575c1df07ac7463830058e9517827d97a
6
+ metadata.gz: 88d62e72d63ac8f5760f7ada91f7052c15ae0572f49c96ff601f4bc8f76db481015e48b910840cb862fe3bad80e91932172d6b7fe1e45bb62112dcf3613089be
7
+ data.tar.gz: c3164b24d4184f9fe10a3d4b2a0bbf58881fc63bf7237f46a01065a70f4b9d1315d8ea982c1dde2bbec4c8bff327b15c857c666596575da3ce6e8bc58bcb8648
data/.rubocop.yml CHANGED
@@ -336,3 +336,10 @@ RSpec/Capybara/SpecificMatcher: # new in 2.12
336
336
  Enabled: false
337
337
  RSpec/Rails/HaveHttpStatus: # new in 2.12
338
338
  Enabled: false
339
+
340
+ RSpec/ClassCheck: # new in 2.13
341
+ Enabled: true
342
+ RSpec/NoExpectationExample: # new in 2.13
343
+ Enabled: true
344
+ RSpec/Capybara/SpecificFinders: # new in 2.13
345
+ Enabled: true
data/Gemfile.lock CHANGED
@@ -1,7 +1,7 @@
1
1
  PATH
2
2
  remote: .
3
3
  specs:
4
- cocina-models (0.84.4)
4
+ cocina-models (0.84.5)
5
5
  activesupport
6
6
  deprecation
7
7
  dry-struct (~> 1.0)
@@ -20,7 +20,7 @@ PATH
20
20
  GEM
21
21
  remote: https://rubygems.org/
22
22
  specs:
23
- activesupport (7.0.3.1)
23
+ activesupport (7.0.4)
24
24
  concurrent-ruby (~> 1.0, >= 1.0.2)
25
25
  i18n (>= 1.6, < 2)
26
26
  minitest (>= 5.1)
@@ -83,7 +83,7 @@ GEM
83
83
  patience_diff (1.2.0)
84
84
  optimist (~> 3.0)
85
85
  racc (1.6.0)
86
- rack (2.2.4)
86
+ rack (3.0.0)
87
87
  rainbow (3.1.1)
88
88
  rake (13.0.6)
89
89
  regexp_parser (2.5.0)
@@ -94,7 +94,7 @@ GEM
94
94
  rspec-mocks (~> 3.11.0)
95
95
  rspec-core (3.11.0)
96
96
  rspec-support (~> 3.11.0)
97
- rspec-expectations (3.11.0)
97
+ rspec-expectations (3.11.1)
98
98
  diff-lcs (>= 1.2.0, < 2.0)
99
99
  rspec-support (~> 3.11.0)
100
100
  rspec-mocks (3.11.1)
@@ -105,7 +105,7 @@ GEM
105
105
  rspec-core (>= 2, < 4, != 2.12.0)
106
106
  rss (0.2.9)
107
107
  rexml
108
- rubocop (1.35.1)
108
+ rubocop (1.36.0)
109
109
  json (~> 2.3)
110
110
  parallel (~> 1.10)
111
111
  parser (>= 3.1.2.1)
@@ -119,8 +119,8 @@ GEM
119
119
  parser (>= 3.1.1.0)
120
120
  rubocop-rake (0.6.0)
121
121
  rubocop (~> 1.0)
122
- rubocop-rspec (2.12.1)
123
- rubocop (~> 1.31)
122
+ rubocop-rspec (2.13.1)
123
+ rubocop (~> 1.33)
124
124
  ruby-progressbar (1.11.0)
125
125
  simplecov (0.21.2)
126
126
  docile (~> 1.1)
data/README.md CHANGED
@@ -55,7 +55,8 @@ If there is a possibility that a model or validation change will conflict with s
55
55
 
56
56
  1. Create a cocina-models branch containing the proposed change and push to GitHub.
57
57
  2. On sdr-infra, check out `main`, update the `Gemfile` so that cocina-models references the branch, and `bundle install`.
58
- 3. Select the appropriate database.
58
+ 3. Select the appropriate environment vars below - they are set to values in puppet. (first 2 lines are the same; last two lines use different variables)
59
+
59
60
  For QA:
60
61
  ```
61
62
  export DATABASE_NAME="dor_services"
data/lib/cocina/models/mapping/from_mods/part_builder.rb CHANGED
@@ -34,7 +34,7 @@ module Cocina
34
34
  values.concat(extent_values.flatten)
35
35
  values.concat(part_note_value_for(part_element, 'text'))
36
36
  values.concat(part_note_value_for(part_element, 'date'))
37
- values.reject!(&:blank?)
37
+ values.compact_blank!
38
38
 
39
39
  return if values.empty?
40
40
 
@@ -50,7 +50,7 @@ module Cocina
50
50
  values.concat(extent_values)
51
51
  values.concat(part_note_value_for(part_element, 'text'))
52
52
  values.concat(part_note_value_for(part_element, 'date'))
53
- values.reject!(&:blank?)
53
+ values.compact_blank!
54
54
 
55
55
  return if values.empty?
56
56
 
@@ -83,7 +83,7 @@ module Cocina
83
83
  detail_values.concat(part_note_value_for(detail_node, 'number'))
84
84
  detail_values.concat(part_note_value_for(detail_node, 'caption'))
85
85
  detail_values.concat(part_note_value_for(detail_node, 'title'))
86
- detail_values.reject!(&:blank?)
86
+ detail_values.compact_blank!
87
87
  if detail_values.present?
88
88
  detail_values.concat(part_note_value_for(detail_node, 'detail type',
89
89
  xpath: '@type'))
@@ -101,7 +101,7 @@ module Cocina
101
101
  extent_values = []
102
102
  extent_values.concat(part_note_value_for(extent_node, 'list'))
103
103
  extent_values << pages_for(extent_node)
104
- extent_values.reject!(&:blank?)
104
+ extent_values.compact_blank!
105
105
  if extent_values.present?
106
106
  extent_values.concat(part_note_value_for(extent_node, 'extent unit',
107
107
  xpath: '@unit'))
data/lib/cocina/models/validators/date_time_validator.rb CHANGED
@@ -76,8 +76,7 @@ module Cocina
76
76
  #
77
77
  # So we catch the false positives from the upstream gem and allow
78
78
  # this pattern to validate
79
- /\AY-?\d{5,}\Z/.match?(value) ||
80
- /\A-?\d{1,3}\Z/.match?(value) # temporarily allow format violations
79
+ /\AY-?\d{5,}\Z/.match?(value)
81
80
  end
82
81
 
83
82
  def valid_iso8601?(value)
data/lib/cocina/models/version.rb CHANGED
@@ -2,6 +2,6 @@
2
2
 
3
3
  module Cocina
4
4
  module Models
5
- VERSION = '0.84.4'
5
+ VERSION = '0.84.5'
6
6
  end
7
7
  end
metadata CHANGED
@@ -1,14 +1,14 @@
1
1
  --- !ruby/object:Gem::Specification
2
2
  name: cocina-models
3
3
  version: !ruby/object:Gem::Version
4
- version: 0.84.4
4
+ version: 0.84.5
5
5
  platform: ruby
6
6
  authors:
7
7
  - Justin Coyne
8
8
  autorequire:
9
9
  bindir: exe
10
10
  cert_chain: []
11
- date: 2022-09-01 00:00:00.000000000 Z
11
+ date: 2022-09-14 00:00:00.000000000 Z
12
12
  dependencies:
13
13
  - !ruby/object:Gem::Dependency
14
14
  name: activesupport
@@ -538,7 +538,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
538
538
  - !ruby/object:Gem::Version
539
539
  version: '0'
540
540
  requirements: []
541
- rubygems_version: 3.3.7
541
+ rubygems_version: 3.2.32
542
542
  signing_key:
543
543
  specification_version: 4
544
544
  summary: Data models for the SDR