cocina-models 0.84.3 → 0.84.5

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: aab0f71139e7186ac04a7f2132ae54dc4c90986fa8a5d96d1b827469502df1a1
-  data.tar.gz: dc0014735d2b42cf8031540677aa64a8a8fb975a20b5e7e3c895a699a2ec6c49
+  metadata.gz: f88398655e31aa97ffb0ac963a0400dd2864535dd10819d53b57efecfeb6359f
+  data.tar.gz: 89e6074e7ba0c38db6db81e00263f84fc579fa039615d1f6be1b52ec32daff4b
 SHA512:
-  metadata.gz: b6aec7701fad871d5d10403ef0af0fa6b786f4ec97f01f3bd5021943e34071c4c253a5569f129cdc804556180cbbf19f862bc8edad5842abf1bad4b9f9c9b2c3
-  data.tar.gz: d8584408d94f5698c1c55e2477583c95079c20447e59f5a6361a481a71c8ae9d2cee475002a5ca3ee2eb4532e75afcb01a94a87500b85618a34072e273151b57
+  metadata.gz: 88d62e72d63ac8f5760f7ada91f7052c15ae0572f49c96ff601f4bc8f76db481015e48b910840cb862fe3bad80e91932172d6b7fe1e45bb62112dcf3613089be
+  data.tar.gz: c3164b24d4184f9fe10a3d4b2a0bbf58881fc63bf7237f46a01065a70f4b9d1315d8ea982c1dde2bbec4c8bff327b15c857c666596575da3ce6e8bc58bcb8648

data/.rubocop.yml

@@ -336,3 +336,10 @@ RSpec/Capybara/SpecificMatcher: # new in 2.12
   Enabled: false
 RSpec/Rails/HaveHttpStatus: # new in 2.12
   Enabled: false
+
+RSpec/ClassCheck: # new in 2.13
+  Enabled: true
+RSpec/NoExpectationExample: # new in 2.13
+  Enabled: true
+RSpec/Capybara/SpecificFinders: # new in 2.13
+  Enabled: true

data/Gemfile.lock

@@ -1,7 +1,7 @@
 PATH
   remote: .
   specs:
-    cocina-models (0.84.3)
+    cocina-models (0.84.5)
       activesupport
       deprecation
       dry-struct (~> 1.0)
@@ -20,7 +20,7 @@ PATH
 GEM
   remote: https://rubygems.org/
   specs:
-    activesupport (7.0.3.1)
+    activesupport (7.0.4)
       concurrent-ruby (~> 1.0, >= 1.0.2)
       i18n (>= 1.6, < 2)
       minitest (>= 5.1)
@@ -83,7 +83,7 @@ GEM
     patience_diff (1.2.0)
       optimist (~> 3.0)
     racc (1.6.0)
-    rack (2.2.4)
+    rack (3.0.0)
     rainbow (3.1.1)
     rake (13.0.6)
     regexp_parser (2.5.0)
@@ -94,7 +94,7 @@ GEM
       rspec-mocks (~> 3.11.0)
     rspec-core (3.11.0)
       rspec-support (~> 3.11.0)
-    rspec-expectations (3.11.0)
+    rspec-expectations (3.11.1)
       diff-lcs (>= 1.2.0, < 2.0)
       rspec-support (~> 3.11.0)
     rspec-mocks (3.11.1)
@@ -105,7 +105,7 @@ GEM
       rspec-core (>= 2, < 4, != 2.12.0)
     rss (0.2.9)
       rexml
-    rubocop (1.35.1)
+    rubocop (1.36.0)
       json (~> 2.3)
       parallel (~> 1.10)
       parser (>= 3.1.2.1)
@@ -119,8 +119,8 @@ GEM
       parser (>= 3.1.1.0)
     rubocop-rake (0.6.0)
       rubocop (~> 1.0)
-    rubocop-rspec (2.12.1)
-      rubocop (~> 1.31)
+    rubocop-rspec (2.13.1)
+      rubocop (~> 1.33)
     ruby-progressbar (1.11.0)
     simplecov (0.21.2)
       docile (~> 1.1)

data/README.md

@@ -55,7 +55,8 @@ If there is a possibility that a model or validation change will conflict with s
 
 1. Create a cocina-models branch containing the proposed change and push to GitHub.
 2. On sdr-infra, check out `main`, update the `Gemfile` so that cocina-models references the branch, and `bundle install`.
-3. Select the appropriate database.
+3. Select the appropriate environment vars below - they are set to values in puppet.  (first 2 lines are the same;  last two lines use different variables)
+
 For QA:
 ```
 export DATABASE_NAME="dor_services"
@@ -87,6 +88,38 @@ RAILS_ENV=production bin/validate-cocina -p 8
 ```
 5. Check `validate-cocina.csv` for validation errors.
 
+## Running Reports in DSA
+
+Custom reports stored in dor-services-app can be run similarly to validation testing described above.
+
+1. Go the sdr-infra box:
+
+```
+ssh deploy@sdr-infra
+```
+
+2. Go to the dor-services-app directory and reset to main if needed (verify nobody else is using this first though):
+
+```
+cd dor-services-app
+git status # see if there are any unsaved changes, if so, you may need to git stash them
+git pull # OR git reset --hard main   to just ditch any local unsaved changes
+```
+
+3. Connect to the desired database by setting the environment variables as described in the section above.  This must be done each time you SSH back into the box to run a new report.
+
+4. Run the report (good idea to do it in a screen or via background process in case you get disconnected):
+
+```
+bundle exec bin/rails r -e production "BadIso8601Dates.report" > BadIso8601Dates.csv
+```
+
+5. When done, you can pull the report to your laptop as needed:
+
+```
+scp deploy@sdr-infra:/opt/app/deploy/dor-services-app/BadIso8601Dates.csv BadIso8601Dates.csv
+```
+
 ## Releasing
 
 ### Step 0: Share intent to change the models

data/lib/cocina/models/mapping/from_mods/part_builder.rb

@@ -34,7 +34,7 @@ module Cocina
             values.concat(extent_values.flatten)
             values.concat(part_note_value_for(part_element, 'text'))
             values.concat(part_note_value_for(part_element, 'date'))
-            values.reject!(&:blank?)
+            values.compact_blank!
 
             return if values.empty?
 
@@ -50,7 +50,7 @@ module Cocina
             values.concat(extent_values)
             values.concat(part_note_value_for(part_element, 'text'))
             values.concat(part_note_value_for(part_element, 'date'))
-            values.reject!(&:blank?)
+            values.compact_blank!
 
             return if values.empty?
 
@@ -83,7 +83,7 @@ module Cocina
             detail_values.concat(part_note_value_for(detail_node, 'number'))
             detail_values.concat(part_note_value_for(detail_node, 'caption'))
             detail_values.concat(part_note_value_for(detail_node, 'title'))
-            detail_values.reject!(&:blank?)
+            detail_values.compact_blank!
             if detail_values.present?
               detail_values.concat(part_note_value_for(detail_node, 'detail type',
                                                        xpath: '@type'))
@@ -101,7 +101,7 @@ module Cocina
             extent_values = []
             extent_values.concat(part_note_value_for(extent_node, 'list'))
             extent_values << pages_for(extent_node)
-            extent_values.reject!(&:blank?)
+            extent_values.compact_blank!
             if extent_values.present?
               extent_values.concat(part_note_value_for(extent_node, 'extent unit',
                                                        xpath: '@unit'))

data/lib/cocina/models/version.rb

@@ -2,6 +2,6 @@
 
 module Cocina
   module Models
-    VERSION = '0.84.3'
+    VERSION = '0.84.5'
   end
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: cocina-models
 version: !ruby/object:Gem::Version
-  version: 0.84.3
+  version: 0.84.5
 platform: ruby
 authors:
 - Justin Coyne
 autorequire:
 bindir: exe
 cert_chain: []
-date: 2022-09-01 00:00:00.000000000 Z
+date: 2022-09-14 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: activesupport
@@ -538,7 +538,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
-rubygems_version: 3.3.7
+rubygems_version: 3.2.32
 signing_key:
 specification_version: 4
 summary: Data models for the SDR