cocina-models 0.78.0 → 0.79.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: '09a3e28b24593aeb0e75c0318067e72fc8e10bb98e189d00b3f166357b198cab'
-  data.tar.gz: 688dbfe3ef449fe8caccd5c3518a6cd059cff2920ad9af3d9fb11553516b520e
+  metadata.gz: 193f5886756d2fd6432e90ab5323f6ed5a11c699cb97f49d61394bc5fafd5f53
+  data.tar.gz: ecb1493a56b7b20f9733084c8a9a115e3a3c6639a8072bc371f53a51d69d0a2c
 SHA512:
-  metadata.gz: 3bc1bce3e8624fa829ce0f41b69362d723e77549d102d561b41245c462c178cbcac5733fcd0816fd7750fa7bf736611e46de503e1e6b93dfce009ae6bd33eea4
-  data.tar.gz: 5cb526603a08485e0c04abccfa962b92b890fbf9d966d5dc00cb5ddd9aec64b24ebb4aa555397d769d5814edb914960d7d83a1b7f5c23be6752252f34b64a033
+  metadata.gz: 8cc210b897872f3b90fd59e12f381f049b1389b0cf3d798a0375eea57282cf456c6591a8d474c5c612253123bca01ed9a9b931129c89153b8a8dae3ad713254b
+  data.tar.gz: f1a23590223b7760780e3b547b053355a1ba600fdc468ce563aef20a4c38cd3571345bde621f3f9f23248d27c29f0f3b5a829dd0c7d5c08d95d27efec472453d

data/description_types.yml

@@ -391,6 +391,8 @@ identifier:
   - value: record id
   - value: Senate Number
   - value: Series
+  - value: SICI
+    code: sici
   - value: SIRSI
   - value: Source ID
   - value: sourceID

data/lib/cocina/models/mapping/to_mods/name_writer.rb

@@ -199,8 +199,6 @@ module Cocina
                 xml.affiliation note.value
               when 'description'
                 xml.description note.value
-              when 'citation status'
-                xml.description UNCITED_DESCRIPTION if note.value == 'false'
               end
             end
           end

data/lib/cocina/models/validators/associated_name_validator.rb

@@ -11,7 +11,7 @@ module Cocina
 
         def initialize(clazz, attributes)
           @clazz = clazz
-          @attributes = attributes.deep_symbolize_keys
+          @attributes = attributes
           @error_paths = []
         end
 
@@ -29,9 +29,7 @@ module Cocina
         attr_reader :clazz, :attributes, :error_paths
 
         def meets_preconditions?
-          resources.any? do |resource|
-            titles_with_associated_name_note_for(resource).present?
-          end
+          [Cocina::Models::Description, Cocina::Models::RequestDescription].include?(clazz)
         end
 
         def valid?(resource)

data/lib/cocina/models/validators/description_types_validator.rb

@@ -11,7 +11,7 @@ module Cocina
 
         def initialize(clazz, attributes)
           @clazz = clazz
-          @attributes = attributes.deep_symbolize_keys
+          @attributes = attributes
           @error_paths = []
         end
 
@@ -30,8 +30,7 @@ module Cocina
         attr_reader :clazz, :attributes, :error_paths
 
         def meets_preconditions?
-          attributes.key?(:description) || [Cocina::Models::Description,
-                                            Cocina::Models::RequestDescription].include?(clazz)
+          [Cocina::Models::Description, Cocina::Models::RequestDescription].include?(clazz)
         end
 
         def validate_hash(hash, path)

data/lib/cocina/models/validators/description_values_validator.rb

@@ -11,7 +11,7 @@ module Cocina
 
         def initialize(clazz, attributes)
           @clazz = clazz
-          @attributes = attributes.deep_symbolize_keys
+          @attributes = attributes
           @error_paths = []
         end
 
@@ -30,8 +30,7 @@ module Cocina
         attr_reader :clazz, :attributes, :error_paths
 
         def meets_preconditions?
-          attributes.key?(:description) || [Cocina::Models::Description,
-                                            Cocina::Models::RequestDescription].include?(clazz)
+          [Cocina::Models::Description, Cocina::Models::RequestDescription].include?(clazz)
         end
 
         def validate_hash(hash, path)

data/lib/cocina/models/validators/validator.rb

@@ -26,8 +26,7 @@ module Cocina
           # In the meantime, copying code.
           attributes_hash = deep_transform_values(attributes.to_h) do |value|
             value.class.name.starts_with?('Cocina::Models') ? value.to_h : value
-          end.with_indifferent_access
-
+          end.deep_symbolize_keys.with_indifferent_access
           VALIDATORS.each { |validator| validator.validate(clazz, attributes_hash) }
         end
 

data/lib/cocina/models/version.rb

@@ -2,6 +2,6 @@
 
 module Cocina
   module Models
-    VERSION = '0.78.0'
+    VERSION = '0.79.0'
   end
 end

data/lib/cocina/models.rb

@@ -119,7 +119,7 @@ module Cocina
     # @param [DROWithMetadata,CollectionWithMetadata,AdminPolicyWithMetadata] cocina_object
     # @return [DRO,Collection,AdminPolicy]
     def self.without_metadata(cocina_object)
-      build(cocina_object.to_h.except(:created, :modified, :lock))
+      build(cocina_object.to_h.except(:created, :modified, :lock), validate: false)
     end
 
     # Adds metadata to a DRO, Collection, AdminPolicy
@@ -144,7 +144,7 @@ module Cocina
               else
                 AdminPolicyWithMetadata
               end
-      clazz.new(props)
+      clazz.new(props, false, false)
     end
 
     def self.type_for(dyn)

data/lib/cocina/rspec/factories.rb

@@ -45,24 +45,31 @@ module Cocina
         type: Cocina::Models::ObjectType.object,
         id: 'druid:bc234fg5678',
         version: 1,
-        label: 'test object',
-        title: 'test object',
+        label: 'factory DRO label',
+        title: 'factory DRO title',
         source_id: 'sul:1234',
         admin_policy_id: 'druid:hv992ry2431'
       }.freeze
 
       REQUEST_DRO_DEFAULTS = DRO_DEFAULTS.except(:id)
 
-      COLLECTION_DEFAULTS = DRO_DEFAULTS.except(:source_id).merge(type: Cocina::Models::ObjectType.collection)
+      COLLECTION_DEFAULTS = {
+        type: Cocina::Models::ObjectType.collection,
+        id: 'druid:bb222ff5555',
+        version: 1,
+        label: 'factory collection label',
+        title: 'factory collection title',
+        admin_policy_id: 'druid:hv992ry2431'
+      }.freeze
 
       REQUEST_COLLECTION_DEFAULTS = COLLECTION_DEFAULTS.except(:id)
 
       ADMIN_POLICY_DEFAULTS = {
         type: Cocina::Models::ObjectType.admin_policy,
-        id: 'druid:bc234fg5678',
+        id: 'druid:cb432gf8765',
         version: 1,
-        label: 'test admin policy',
-        title: 'test admin policy',
+        label: 'factory APO label',
+        title: 'factory APO title',
         admin_policy_id: 'druid:hv992ry2431',
         agreement_id: 'druid:hp308wm0436'
       }.freeze

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: cocina-models
 version: !ruby/object:Gem::Version
-  version: 0.78.0
+  version: 0.79.0
 platform: ruby
 authors:
 - Justin Coyne
 autorequire:
 bindir: exe
 cert_chain: []
-date: 2022-05-04 00:00:00.000000000 Z
+date: 2022-05-09 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: activesupport