cocina-models 0.74.0 → 0.76.0

data/lib/cocina/models/mapping/to_mods/title.rb

@@ -0,0 +1,260 @@
+# frozen_string_literal: true
+
+module Cocina
+  module Models
+    module Mapping
+      module ToMods
+        # Maps titles from cocina to MODS XML
+        #   NOTE: contributors from nameTitleGroups are output here as well;
+        #   this allows for consistency of the nameTitleGroup number for the matching title(s) and the contributor(s)
+        class Title # rubocop:disable Metrics/ClassLength
+          TAG_NAME = Cocina::Models::Mapping::FromMods::Title::TYPES.invert.merge('activity dates' => 'date').freeze
+          NAME_TYPES = ['name', 'forename', 'surname', 'life dates', 'term of address'].freeze
+
+          # @params [Nokogiri::XML::Builder] xml
+          # @params [Array<Cocina::Models::Title>] titles
+          # @params [Array<Cocina::Models::Contributor>] contributors
+          # @params [Hash] additional_attrs for title
+          # @params [IdGenerator] id_generator
+          def self.write(xml:, titles:, id_generator:, contributors: [], additional_attrs: {})
+            new(xml: xml, titles: titles, contributors: contributors, additional_attrs: additional_attrs,
+                id_generator: id_generator).write
+          end
+
+          def initialize(xml:, titles:, additional_attrs:, contributors: [], id_generator: {})
+            @xml = xml
+            @titles = titles
+            @contributors = contributors
+            @name_title_vals_index = {}
+            @additional_attrs = additional_attrs
+            @id_generator = id_generator
+          end
+
+          # rubocop:disable Metrics/AbcSize
+          # rubocop:disable Metrics/BlockLength
+          # rubocop:disable Metrics/CyclomaticComplexity
+          def write
+            titles.each do |title|
+              name_title_vals_index = name_title_vals_index_for(title)
+
+              if title.valueAt
+                write_xlink(title: title)
+              elsif title.parallelValue.present?
+                write_parallel(title: title, title_info_attrs: additional_attrs)
+              elsif title.groupedValue.present?
+                write_grouped(title: title, title_info_attrs: additional_attrs)
+              elsif title.structuredValue.present?
+                if name_title_vals_index.present?
+                  title_value_slice = Cocina::Models::Builders::NameTitleGroupBuilder.slice_of_value_or_structured_value(title.to_h)
+                  # don't leak nameTitleGroup into later titles
+                  my_additional_attrs = additional_attrs.dup
+                  my_additional_attrs[:nameTitleGroup] = name_title_group_number(title_value_slice)
+                  write_structured(title: title, title_info_attrs: my_additional_attrs.compact)
+                else
+                  write_structured(title: title, title_info_attrs: additional_attrs.compact)
+                end
+              elsif title.value
+                if name_title_vals_index.present?
+                  title_value_slice = Cocina::Models::Builders::NameTitleGroupBuilder.slice_of_value_or_structured_value(title.to_h)
+                  # don't leak nameTitleGroup into later titles
+                  my_additional_attrs = additional_attrs.dup
+                  my_additional_attrs[:nameTitleGroup] = name_title_group_number(title_value_slice)
+                  write_basic(title: title, title_info_attrs: my_additional_attrs.compact)
+                else
+                  write_basic(title: title, title_info_attrs: additional_attrs.compact)
+                end
+              end
+
+              associated_name = Cocina::Models::Builders::NameTitleGroupBuilder.title_value_note_slices(title).each do |value_note_slice|
+                value_note_slice[:note]&.detect { |note| note[:type] == 'associated name' }
+              end
+              next if associated_name.blank?
+
+              contributors.each do |contributor|
+                if NameTitleGroup.in_name_title_group?(contributor: contributor, titles: [title])
+                  NameWriter.write(xml: xml, contributor: contributor,
+                                   name_title_vals_index: name_title_vals_index, id_generator: id_generator)
+                end
+              end
+            end
+          end
+          # rubocop:enable Metrics/AbcSize
+          # rubocop:enable Metrics/BlockLength
+          # rubocop:enable Metrics/CyclomaticComplexity
+
+          private
+
+          attr_reader :xml, :titles, :contributors, :name_title_vals_index, :id_generator, :additional_attrs
+
+          def write_xlink(title:)
+            attrs = { 'xlink:href' => title.valueAt }
+            xml.titleInfo attrs
+          end
+
+          def write_basic(title:, title_info_attrs: {})
+            title_info_attrs = title_info_attrs_for(title).merge(title_info_attrs)
+
+            xml.titleInfo(title_info_attrs) do
+              xml.title(title.value)
+            end
+          end
+
+          # rubocop:disable Metrics/AbcSize
+          # rubocop:disable Metrics/CyclomaticComplexity
+          def write_parallel(title:, title_info_attrs: {})
+            title_alt_rep_group = id_generator.next_altrepgroup
+
+            title.parallelValue.each do |parallel_title|
+              parallel_attrs = title_info_attrs.dup
+              parallel_attrs[:altRepGroup] = title_alt_rep_group
+              parallel_attrs[:lang] = parallel_title.valueLanguage.code if parallel_title.valueLanguage&.code
+              if title.type == 'uniform'
+                parallel_attrs[:type] = 'uniform'
+                if name_title_vals_index.present?
+                  title_value_slice = Cocina::Models::Builders::NameTitleGroupBuilder.slice_of_value_or_structured_value(parallel_title.to_h)
+                  parallel_attrs[:nameTitleGroup] = name_title_group_number(title_value_slice)
+                end
+              elsif parallel_title.type == 'transliterated'
+                parallel_attrs[:type] = 'translated'
+                parallel_attrs[:transliteration] = parallel_title.standard.value
+              elsif title.parallelValue.any? { |parallel_value| parallel_value.status == 'primary' }
+                if parallel_title.status == 'primary'
+                  parallel_attrs[:usage] = 'primary'
+                elsif parallel_title.type == 'translated'
+                  parallel_attrs[:type] = 'translated'
+                end
+              end
+
+              if parallel_title.structuredValue.present?
+                write_structured(title: parallel_title, title_info_attrs: parallel_attrs.compact)
+              elsif parallel_title.value
+                write_basic(title: parallel_title, title_info_attrs: parallel_attrs.compact)
+              end
+            end
+          end
+
+          # rubocop:enable Metrics/AbcSize
+          # rubocop:enable Metrics/CyclomaticComplexity
+          def write_grouped(title:, title_info_attrs: {})
+            title.groupedValue.each do |grouped_title|
+              write_basic(title: grouped_title, title_info_attrs: title_info_attrs)
+            end
+          end
+
+          # @params [Cocina::Models::Title] titles
+          # @return [Hash<Hash, Hash<Hash, Integer>>]
+          #   the key is a hash representing a single contributor name, with a key of :value or :structuredValue
+          #   the value is a hash, where
+          #      the key is a hash representing a single title value, with a key of :value or :structuredValue
+          #      the value is the nameTitleGroup number as an Integer
+          #   e.g. {{:value=>"James Joyce"}=>{:value=>"Portrait of the artist as a young man"}=>1,
+          #   e.g.  {:value=>"Vinsky Cat"}=>{:structuredValue=>[{:value=>"Demanding Food", :type=>"main"},{:value=>"A Cat's Life", :type=>"subtitle"}]}=>2}
+          #
+          # This complexity is needed for multilingual titles mapping to multilingual names. :-P
+          def name_title_vals_index_for(title)
+            return nil unless contributors
+
+            title_vals_to_contrib_name_vals = Cocina::Models::Builders::NameTitleGroupBuilder.build_title_values_to_contributor_name_values(title)
+            return nil if title_vals_to_contrib_name_vals.blank?
+
+            title_value_slices = Cocina::Models::Builders::NameTitleGroupBuilder.value_slices(title)
+            title_value_slices.each do |title_value_slice|
+              contrib_name_val_slice = title_vals_to_contrib_name_vals[title_value_slice]
+              next if contrib_name_val_slice.blank?
+
+              name_title_group = id_generator.next_nametitlegroup
+              name_title_vals_index[contrib_name_val_slice] = { title_value_slice => name_title_group }
+            end
+
+            name_title_vals_index
+          end
+
+          def write_structured(title:, title_info_attrs: {})
+            title_info_attrs = title_info_attrs_for(title).merge(title_info_attrs)
+            xml.titleInfo(with_uri_info(title, title_info_attrs)) do
+              title_parts = flatten_structured_value(title)
+              title_parts_without_names = title_parts_without_names(title_parts)
+
+              title_parts_without_names.each do |title_part|
+                title_type = tag_name_for(title_part)
+                title_value = title_value_for(title_part, title_type, title)
+                xml.public_send(title_type, title_value) if title_part.note.blank?
+              end
+            end
+          end
+
+          def title_value_for(title_part, title_type, title)
+            return title_part.value unless title_type == 'nonSort'
+
+            non_sorting_size = [non_sorting_char_count_for(title) - (title_part.value&.size || 0), 0].max
+            "#{title_part.value}#{' ' * non_sorting_size}"
+          end
+
+          def non_sorting_char_count_for(title)
+            non_sort_note = title.note&.find { |note| note.type&.downcase == 'nonsorting character count' }
+            return 0 unless non_sort_note
+
+            non_sort_note.value.to_i
+          end
+
+          # Flatten the structuredValues into a simple list.
+          def flatten_structured_value(title)
+            leafs = title.structuredValue.select(&:value)
+            nodes = title.structuredValue.select(&:structuredValue).reject { |value| value.type == 'name' }
+            leafs + nodes.flat_map { |node| flatten_structured_value(node) }
+          end
+
+          # Filter out name types
+          def title_parts_without_names(parts)
+            parts.reject { |structured_title| NAME_TYPES.include?(structured_title.type) }
+          end
+
+          def with_uri_info(cocina, xml_attrs)
+            xml_attrs[:valueURI] = cocina.uri
+            xml_attrs[:authorityURI] = cocina.source&.uri
+            xml_attrs[:authority] = cocina.source&.code
+            xml_attrs.compact
+          end
+
+          def tag_name_for(title_part)
+            return 'title' if title_part.type == 'title'
+
+            TAG_NAME.fetch(title_part.type, nil)
+          end
+
+          def title_info_attrs_for(title)
+            {
+              usage: title.status,
+              script: title.valueLanguage&.valueScript&.code,
+              lang: title.valueLanguage&.code,
+              displayLabel: title.displayLabel,
+              valueURI: title.uri,
+              authorityURI: title.source&.uri,
+              authority: title.source&.code,
+              transliteration: title.standard&.value
+            }.tap do |attrs|
+              if title.type == 'supplied'
+                attrs[:supplied] = 'yes'
+              elsif title.type != 'transliterated'
+                attrs[:type] = title.type
+              end
+            end.compact
+          end
+
+          # @return [Integer] the integer to be used for a nameTitleGroup attribute
+          def name_title_group_number(title_value_slice)
+            # name_title_vals_index is [Hash<Hash, Hash<Hash, Integer>>]
+            #   the key is a hash representing a single contributor name, with a key of :value or :structuredValue
+            #   the value is a hash, where
+            #      the key is a hash representing a single title value, with a key of :value or :structuredValue
+            #      the value is the nameTitleGroup number as an Integer
+            #   e.g. {{:value=>"James Joyce"}=>{:value=>"Portrait of the artist as a young man"}=>1}
+            #
+            # This complexity is needed for multilingual titles mapping to multilingual names. :-P
+            name_title_vals_index.values.detect { |hash| hash.key?(title_value_slice) }&.values&.first
+          end
+        end
+      end
+    end
+  end
+end

data/lib/cocina/models/object_metadata.rb

@@ -4,9 +4,9 @@ module Cocina
   module Models
     class ObjectMetadata < Struct
       # When the object was created.
-      attribute :created, Types::Params::DateTime.meta(omittable: true)
+      attribute? :created, Types::Params::DateTime
       # When the object was modified.
-      attribute :modified, Types::Params::DateTime.meta(omittable: true)
+      attribute? :modified, Types::Params::DateTime
       # Key for optimistic locking. The contents of the key is not specified.
       attribute :lock, Types::Strict::String
     end

data/lib/cocina/models/presentation.rb

@@ -4,9 +4,9 @@ module Cocina
   module Models
     class Presentation < Struct
       # Height in pixels
-      attribute :height, Types::Strict::Integer.meta(omittable: true)
+      attribute? :height, Types::Strict::Integer
       # Width in pixels
-      attribute :width, Types::Strict::Integer.meta(omittable: true)
+      attribute? :width, Types::Strict::Integer
     end
   end
 end

data/lib/cocina/models/related_resource.rb

@@ -4,11 +4,11 @@ module Cocina
   module Models
     class RelatedResource < Struct
       # The relationship of the related resource to the described resource.
-      attribute :type, Types::Strict::String.meta(omittable: true)
+      attribute? :type, Types::Strict::String
       # Status of the related resource relative to other related resources.
-      attribute :status, Types::Strict::String.meta(omittable: true)
+      attribute? :status, Types::Strict::String
       # The preferred display label to use for the related resource in access systems.
-      attribute :displayLabel, Types::Strict::String.meta(omittable: true)
+      attribute? :displayLabel, Types::Strict::String
       attribute :title, Types::Strict::Array.of(DescriptiveValue).default([].freeze)
       attribute :contributor, Types::Strict::Array.of(Contributor).default([].freeze)
       attribute :event, Types::Strict::Array.of(Event).default([].freeze)
@@ -16,17 +16,17 @@ module Cocina
       attribute :language, Types::Strict::Array.of(Language).default([].freeze)
       attribute :note, Types::Strict::Array.of(DescriptiveValue).default([].freeze)
       attribute :identifier, Types::Strict::Array.of(DescriptiveValue).default([].freeze)
-      attribute :standard, Standard.optional.meta(omittable: true)
+      attribute? :standard, Standard.optional
       attribute :subject, Types::Strict::Array.of(DescriptiveValue).default([].freeze)
       # Stanford persistent URL associated with the related resource. Note this is http, not https.
-      attribute :purl, Types::Strict::String.meta(omittable: true)
-      attribute :access, DescriptiveAccessMetadata.optional.meta(omittable: true)
+      attribute? :purl, Types::Strict::String
+      attribute? :access, DescriptiveAccessMetadata.optional
       attribute :relatedResource, Types::Strict::Array.of(RelatedResource).default([].freeze)
-      attribute :adminMetadata, DescriptiveAdminMetadata.optional.meta(omittable: true)
+      attribute? :adminMetadata, DescriptiveAdminMetadata.optional
       # The version of the related resource.
-      attribute :version, Types::Strict::String.meta(omittable: true)
+      attribute? :version, Types::Strict::String
       # URL or other pointer to the location of the related resource information.
-      attribute :valueAt, Types::Strict::String.meta(omittable: true)
+      attribute? :valueAt, Types::Strict::String
     end
   end
 end

data/lib/cocina/models/release_tag.rb

@@ -5,15 +5,15 @@ module Cocina
     class ReleaseTag < Struct
       # Who did this release
       # example: petucket
-      attribute :who, Types::Strict::String.meta(omittable: true)
+      attribute? :who, Types::Strict::String
       # What is being released. This item or the whole collection.
       # example: self
-      attribute :what, Types::Strict::String.enum('self', 'collection').meta(omittable: true)
+      attribute? :what, Types::Strict::String.enum('self', 'collection')
       # When did this action happen
-      attribute :date, Types::Params::DateTime.meta(omittable: true)
+      attribute? :date, Types::Params::DateTime
       # What platform is it released to
       # example: Searchworks
-      attribute :to, Types::Strict::String.meta(omittable: true)
+      attribute? :to, Types::Strict::String
       attribute :release, Types::Strict::Bool.default(false)
     end
   end

data/lib/cocina/models/request_admin_policy.rb

@@ -16,7 +16,7 @@ module Cocina
       attribute :label, Types::Strict::String
       attribute :version, Types::Strict::Integer.default(1).enum(1)
       attribute(:administrative, AdminPolicyAdministrative.default { AdminPolicyAdministrative.new })
-      attribute :description, RequestDescription.optional.meta(omittable: true)
+      attribute? :description, RequestDescription.optional
     end
   end
 end

data/lib/cocina/models/request_administrative.rb

@@ -8,7 +8,7 @@ module Cocina
       attribute :releaseTags, Types::Strict::Array.of(ReleaseTag).default([].freeze)
       # Internal project this resource is a part of. This governs routing of messages about this object.
       # example: Google Books
-      attribute :partOfProject, Types::Strict::String.meta(omittable: true)
+      attribute? :partOfProject, Types::Strict::String
     end
   end
 end

data/lib/cocina/models/request_collection.rb

@@ -21,8 +21,8 @@ module Cocina
       attribute :version, Types::Strict::Integer.default(1).enum(1)
       attribute(:access, CollectionAccess.default { CollectionAccess.new })
       attribute(:administrative, RequestAdministrative.default { RequestAdministrative.new })
-      attribute :description, RequestDescription.optional.meta(omittable: true)
-      attribute :identification, CollectionIdentification.optional.meta(omittable: true)
+      attribute? :description, RequestDescription.optional
+      attribute? :identification, CollectionIdentification.optional
     end
   end
 end

data/lib/cocina/models/request_description.rb

@@ -14,12 +14,12 @@ module Cocina
       attribute :note, Types::Strict::Array.of(DescriptiveValue).default([].freeze)
       attribute :identifier, Types::Strict::Array.of(DescriptiveValue).default([].freeze)
       attribute :subject, Types::Strict::Array.of(DescriptiveValue).default([].freeze)
-      attribute :access, DescriptiveAccessMetadata.optional.meta(omittable: true)
+      attribute? :access, DescriptiveAccessMetadata.optional
       attribute :relatedResource, Types::Strict::Array.of(RelatedResource).default([].freeze)
       attribute :marcEncodedData, Types::Strict::Array.of(DescriptiveValue).default([].freeze)
-      attribute :adminMetadata, DescriptiveAdminMetadata.optional.meta(omittable: true)
+      attribute? :adminMetadata, DescriptiveAdminMetadata.optional
       # URL or other pointer to the location of the resource description.
-      attribute :valueAt, Types::Strict::String.meta(omittable: true)
+      attribute? :valueAt, Types::Strict::String
     end
   end
 end

data/lib/cocina/models/request_dro.rb

@@ -29,12 +29,12 @@ module Cocina
       attribute :type, Types::Strict::String.enum(*RequestDRO::TYPES)
       attribute :label, Types::Strict::String
       attribute :version, Types::Strict::Integer.default(1).enum(1)
-      attribute :access, DROAccess.optional.meta(omittable: true)
+      attribute? :access, DROAccess.optional
       attribute(:administrative, RequestAdministrative.default { RequestAdministrative.new })
-      attribute :description, RequestDescription.optional.meta(omittable: true)
+      attribute? :description, RequestDescription.optional
       attribute(:identification, RequestIdentification.default { RequestIdentification.new })
-      attribute :structural, RequestDROStructural.optional.meta(omittable: true)
-      attribute :geographic, Geographic.optional.meta(omittable: true)
+      attribute? :structural, RequestDROStructural.optional
+      attribute? :geographic, Geographic.optional
     end
   end
 end

data/lib/cocina/models/request_file.rb

@@ -10,15 +10,15 @@ module Cocina
       attribute :type, Types::Strict::String.enum(*RequestFile::TYPES)
       attribute :label, Types::Strict::String
       attribute :filename, Types::Strict::String
-      attribute :size, Types::Strict::Integer.meta(omittable: true)
+      attribute? :size, Types::Strict::Integer
       attribute :version, Types::Strict::Integer
-      attribute :hasMimeType, Types::Strict::String.meta(omittable: true)
-      attribute :externalIdentifier, Types::Strict::String.meta(omittable: true)
-      attribute :use, Types::Strict::String.meta(omittable: true)
+      attribute? :hasMimeType, Types::Strict::String
+      attribute? :externalIdentifier, Types::Strict::String
+      attribute? :use, Types::Strict::String
       attribute :hasMessageDigests, Types::Strict::Array.of(MessageDigest).default([].freeze)
       attribute(:access, FileAccess.default { FileAccess.new })
       attribute(:administrative, FileAdministrative.default { FileAdministrative.new })
-      attribute :presentation, Presentation.optional.meta(omittable: true)
+      attribute? :presentation, Presentation.optional
     end
   end
 end

data/lib/cocina/models/request_identification.rb

@@ -4,7 +4,7 @@ module Cocina
   module Models
     class RequestIdentification < Struct
       # A barcode
-      attribute :barcode, Types::Nominal::Any.meta(omittable: true)
+      attribute? :barcode, Types::Nominal::Any
       attribute :catalogLinks, Types::Strict::Array.of(CatalogLink).default([].freeze)
       # Unique identifier in some other system. This is because a large proportion of what is deposited in SDR, historically and currently, are representations of objects that are also represented in other systems. For example, digitized paper and A/V collections have physical manifestations, and those physical objects are managed in systems that have their own identifiers. Similarly, books have barcodes, archival materials have collection numbers and physical locations, etc. The sourceId allows determining if an item has been deposited before and where to look for the original item if you're looking at its SDR representation. The format is: "namespace:identifier"
 

data/lib/cocina/models/sequence.rb

@@ -5,7 +5,7 @@ module Cocina
     class Sequence < Struct
       attribute :members, Types::Strict::Array.of(Types::Strict::String).default([].freeze)
       # The direction that a sequence of canvases should be displayed to the user
-      attribute :viewingDirection, Types::Strict::String.enum('right-to-left', 'left-to-right').meta(omittable: true)
+      attribute? :viewingDirection, Types::Strict::String.enum('right-to-left', 'left-to-right')
     end
   end
 end

data/lib/cocina/models/source.rb

@@ -4,14 +4,14 @@ module Cocina
   module Models
     class Source < Struct
       # Code representing the value source.
-      attribute :code, Types::Strict::String.meta(omittable: true)
+      attribute? :code, Types::Strict::String
       # URI for the value source.
-      attribute :uri, Types::Strict::String.meta(omittable: true)
+      attribute? :uri, Types::Strict::String
       # String describing the value source.
-      attribute :value, Types::Strict::String.meta(omittable: true)
+      attribute? :value, Types::Strict::String
       attribute :note, Types::Strict::Array.of(DescriptiveValue).default([].freeze)
       # The version of the value source.
-      attribute :version, Types::Strict::String.meta(omittable: true)
+      attribute? :version, Types::Strict::String
     end
   end
 end

data/lib/cocina/models/standard.rb

@@ -4,15 +4,15 @@ module Cocina
   module Models
     class Standard < Struct
       # Code representing the standard or encoding.
-      attribute :code, Types::Strict::String.meta(omittable: true)
+      attribute? :code, Types::Strict::String
       # URI for the standard or encoding.
-      attribute :uri, Types::Strict::String.meta(omittable: true)
+      attribute? :uri, Types::Strict::String
       # String describing the standard or encoding.
-      attribute :value, Types::Strict::String.meta(omittable: true)
+      attribute? :value, Types::Strict::String
       attribute :note, Types::Strict::Array.of(DescriptiveValue).default([].freeze)
       # The version of the standard or encoding.
-      attribute :version, Types::Strict::String.meta(omittable: true)
-      attribute :source, Source.optional.meta(omittable: true)
+      attribute? :version, Types::Strict::String
+      attribute? :source, Source.optional
     end
   end
 end

data/lib/cocina/models/stanford_access.rb

@@ -8,8 +8,8 @@ module Cocina
       # Download access level.
       attribute :download, Types::Strict::String.enum('stanford')
       # Not used for this access type, must be null.
-      attribute :location, Types::Strict::String.optional.enum('').meta(omittable: true)
-      attribute :controlledDigitalLending, Types::Strict::Bool.enum(false).meta(omittable: true)
+      attribute? :location, Types::Strict::String.optional.enum('')
+      attribute? :controlledDigitalLending, Types::Strict::Bool.default(false).enum(false)
     end
   end
 end

data/lib/cocina/models/title.rb

@@ -7,27 +7,27 @@ module Cocina
       attribute :parallelValue, Types::Strict::Array.of(DescriptiveValue).default([].freeze)
       attribute :groupedValue, Types::Strict::Array.of(DescriptiveValue).default([].freeze)
       # String or integer value of the descriptive element.
-      attribute :value, Types::Nominal::Any.meta(omittable: true)
-      # Type of value provided by the descriptive element.
-      attribute :type, Types::Strict::String.meta(omittable: true)
+      attribute? :value, Types::Nominal::Any
+      # Type of value provided by the descriptive element. See https://github.com/sul-dlss/cocina-models/blob/main/docs/description_types.md for valid types.
+      attribute? :type, Types::Strict::String
       # Status of the descriptive element value relative to other instances of the element.
-      attribute :status, Types::Strict::String.meta(omittable: true)
+      attribute? :status, Types::Strict::String
       # Code value of the descriptive element.
-      attribute :code, Types::Strict::String.meta(omittable: true)
+      attribute? :code, Types::Strict::String
       # URI value of the descriptive element.
-      attribute :uri, Types::Strict::String.meta(omittable: true)
-      attribute :standard, Standard.optional.meta(omittable: true)
-      attribute :encoding, Standard.optional.meta(omittable: true)
+      attribute? :uri, Types::Strict::String
+      attribute? :standard, Standard.optional
+      attribute? :encoding, Standard.optional
       attribute :identifier, Types::Strict::Array.of(DescriptiveValue).default([].freeze)
-      attribute :source, Source.optional.meta(omittable: true)
+      attribute? :source, Source.optional
       # The preferred display label to use for the descriptive element in access systems.
-      attribute :displayLabel, Types::Strict::String.meta(omittable: true)
+      attribute? :displayLabel, Types::Strict::String
       # A term providing information about the circumstances of the statement (e.g., approximate dates).
-      attribute :qualifier, Types::Strict::String.meta(omittable: true)
+      attribute? :qualifier, Types::Strict::String
       attribute :note, Types::Strict::Array.of(DescriptiveValue).default([].freeze)
-      attribute :valueLanguage, DescriptiveValueLanguage.optional.meta(omittable: true)
+      attribute? :valueLanguage, DescriptiveValueLanguage.optional
       # URL or other pointer to the location of the value of the descriptive element.
-      attribute :valueAt, Types::Strict::String.meta(omittable: true)
+      attribute? :valueAt, Types::Strict::String
       attribute :appliesTo, Types::Strict::Array.of(DescriptiveBasicValue).default([].freeze)
     end
   end

data/lib/cocina/models/validators/associated_name_validator.rb

@@ -0,0 +1,77 @@
+# frozen_string_literal: true
+
+module Cocina
+  module Models
+    module Validators
+      # Validates that when title.note with type "associated name" has a value, it must match a contributor name.
+      class AssociatedNameValidator
+        def self.validate(clazz, attributes)
+          new(clazz, attributes).validate
+        end
+
+        def initialize(clazz, attributes)
+          @clazz = clazz
+          @attributes = attributes.deep_symbolize_keys
+          @error_paths = []
+        end
+
+        def validate
+          return unless meets_preconditions?
+
+          return if resources.all? { |resource| valid?(resource) }
+
+          raise ValidationError,
+                'Missing data: Name associated with uniform title does not match any contributor.'
+        end
+
+        private
+
+        attr_reader :clazz, :attributes, :error_paths
+
+        def meets_preconditions?
+          resources.any? do |resource|
+            titles_with_associated_name_note_for(resource).present?
+          end
+        end
+
+        def valid?(resource)
+          titles_with_associated_name_note_for(resource).all? do |title|
+            contributor_name_value_slices = Builders::NameTitleGroupBuilder
+                                            .build_title_values_to_contributor_name_values(
+                                              Cocina::Models::Title.new(title)
+                                            ).values
+            contributor_name_value_slices.all? do |contributor_name_value_slice|
+              contributors = Array(resource[:contributor]).map do |contributor|
+                Cocina::Models::Contributor.new(contributor)
+              end
+              Builders::NameTitleGroupBuilder.contributor_for_contributor_name_value_slice(
+                contributor_name_value_slice: contributor_name_value_slice, contributors: contributors
+              ).present?
+            end
+          end
+        end
+
+        def resources
+          @resources ||= [description_attributes] + Array(description_attributes[:relatedResource])
+        end
+
+        def description_attributes
+          @description_attributes ||= if [Cocina::Models::Description,
+                                          Cocina::Models::RequestDescription].include?(clazz)
+                                        attributes
+                                      else
+                                        attributes[:description] || {}
+                                      end
+        end
+
+        def associated_name_note_for(title)
+          Array(title[:note]).detect { |note| note[:type] == 'associated name' }
+        end
+
+        def titles_with_associated_name_note_for(resource)
+          Array(resource[:title]).select { |title| associated_name_note_for(title).present? }
+        end
+      end
+    end
+  end
+end

data/lib/cocina/models/validators/dark_validator.rb

@@ -28,7 +28,8 @@ module Cocina
         attr_reader :clazz, :attributes
 
         def meets_preconditions?
-          dro? && attributes.dig(:access, :view) == 'dark'
+          # Checking for nil to account for default being dark.
+          dro? && ['dark', nil].include?(attributes.dig(:access, :view))
         end
 
         def dro?
@@ -55,7 +56,8 @@ module Cocina
           return false if file[:hasMimeType] == 'application/warc'
 
           return true if file.dig(:administrative, :shelve)
-          return true if file.dig(:access, :view) != 'dark'
+          # Checking for nil to account for default being dark.
+          return true if ['dark', nil].exclude?(file.dig(:access, :view))
 
           false
         end