cocaine 0.3.1 → 0.3.2

data/lib/cocaine/command_line/runners/posix_runner.rb

@@ -6,9 +6,10 @@ module Cocaine
         def call(command, env = {})
           input, output = IO.pipe
           pid = spawn(env, command, :out => output)
-          waitpid(pid)
           output.close
-          input.read
+          result = input.read
+          waitpid(pid)
+          result
         end
 
         private

data/lib/cocaine/command_line/runners/process_runner.rb

@@ -6,9 +6,10 @@ module Cocaine
         def call(command, env = {})
           input, output = IO.pipe
           pid = spawn(env, command, :out => output)
-          waitpid(pid)
           output.close
-          input.read
+          result = input.read
+          waitpid(pid)
+          result
         end
 
         private

data/lib/cocaine/version.rb

@@ -1,3 +1,3 @@
 module Cocaine
-  VERSION = "0.3.1".freeze
+  VERSION = "0.3.2".freeze
 end

data/spec/cocaine/command_line/runners/backticks_runner_spec.rb

@@ -1,6 +1,8 @@
 require 'spec_helper'
 
 describe Cocaine::CommandLine::BackticksRunner do
+  it_behaves_like 'a command that does not block'
+
   it 'runs the command given' do
     subject.call("echo hello").should == "hello\n"
   end

data/spec/cocaine/command_line/runners/posix_runner_spec.rb

@@ -2,6 +2,8 @@ require 'spec_helper'
 
 describe Cocaine::CommandLine::PosixRunner do
   if Cocaine::CommandLine::posix_spawn_available?
+    it_behaves_like 'a command that does not block'
+
     it 'runs the command given' do
       subject.call("echo hello").should == "hello\n"
     end

data/spec/cocaine/command_line/runners/process_runner_spec.rb

@@ -2,6 +2,8 @@ require 'spec_helper'
 
 describe Cocaine::CommandLine::ProcessRunner do
   if Process.respond_to?(:spawn)
+    it_behaves_like "a command that does not block"
+
     it 'runs the command given' do
       subject.call("echo hello").should == "hello\n"
     end

data/spec/spec_helper.rb

@@ -1,9 +1,11 @@
 require 'rspec'
-require './spec/support/with_exitstatus'
-require './spec/support/stub_os'
 require 'mocha'
 require 'bourne'
 require 'cocaine'
+require 'timeout'
+require 'tempfile'
+
+Dir[File.dirname(__FILE__) + "/support/**.rb"].each{|support_file| require support_file }
 
 RSpec.configure do |config|
   config.mock_with :mocha

data/spec/support/nonblocking_examples.rb

@@ -0,0 +1,12 @@
+shared_examples_for "a command that does not block" do
+  it 'does not block if the command outputs a lot of data' do
+    garbage_file = Tempfile.new("garbage")
+    10.times{ garbage_file.write("A" * 1024 * 1024) }
+
+    Timeout::timeout(5) do
+      output = subject.call("cat '#{garbage_file.path}'")
+      $?.exitstatus.should == 0
+      output.length.should == 10 * 1024 * 1024
+    end
+  end
+end

metadata

@@ -1,102 +1,101 @@
---- !ruby/object:Gem::Specification
+--- !ruby/object:Gem::Specification 
 name: cocaine
-version: !ruby/object:Gem::Version
-  version: 0.3.1
+version: !ruby/object:Gem::Version 
+  hash: 23
   prerelease: 
+  segments: 
+  - 0
+  - 3
+  - 2
+  version: 0.3.2
 platform: ruby
-authors:
+authors: 
 - Jon Yurek
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2012-09-21 00:00:00.000000000 Z
-dependencies:
-- !ruby/object:Gem::Dependency
+
+date: 2012-09-28 00:00:00 Z
+dependencies: 
+- !ruby/object:Gem::Dependency 
   name: rspec
-  requirement: !ruby/object:Gem::Requirement
-    none: false
-    requirements:
-    - - ! '>='
-      - !ruby/object:Gem::Version
-        version: '0'
-  type: :development
   prerelease: false
-  version_requirements: !ruby/object:Gem::Requirement
-    none: false
-    requirements:
-    - - ! '>='
-      - !ruby/object:Gem::Version
-        version: '0'
-- !ruby/object:Gem::Dependency
-  name: bourne
-  requirement: !ruby/object:Gem::Requirement
+  requirement: &id001 !ruby/object:Gem::Requirement 
     none: false
-    requirements:
-    - - ! '>='
-      - !ruby/object:Gem::Version
-        version: '0'
+    requirements: 
+    - - ">="
+      - !ruby/object:Gem::Version 
+        hash: 3
+        segments: 
+        - 0
+        version: "0"
   type: :development
+  version_requirements: *id001
+- !ruby/object:Gem::Dependency 
+  name: bourne
   prerelease: false
-  version_requirements: !ruby/object:Gem::Requirement
-    none: false
-    requirements:
-    - - ! '>='
-      - !ruby/object:Gem::Version
-        version: '0'
-- !ruby/object:Gem::Dependency
-  name: mocha
-  requirement: !ruby/object:Gem::Requirement
+  requirement: &id002 !ruby/object:Gem::Requirement 
     none: false
-    requirements:
-    - - ! '>='
-      - !ruby/object:Gem::Version
-        version: '0'
+    requirements: 
+    - - ">="
+      - !ruby/object:Gem::Version 
+        hash: 3
+        segments: 
+        - 0
+        version: "0"
   type: :development
+  version_requirements: *id002
+- !ruby/object:Gem::Dependency 
+  name: mocha
   prerelease: false
-  version_requirements: !ruby/object:Gem::Requirement
+  requirement: &id003 !ruby/object:Gem::Requirement 
     none: false
-    requirements:
-    - - ! '>='
-      - !ruby/object:Gem::Version
-        version: '0'
-- !ruby/object:Gem::Dependency
-  name: rake
-  requirement: !ruby/object:Gem::Requirement
-    none: false
-    requirements:
-    - - ! '>='
-      - !ruby/object:Gem::Version
-        version: '0'
+    requirements: 
+    - - ">="
+      - !ruby/object:Gem::Version 
+        hash: 3
+        segments: 
+        - 0
+        version: "0"
   type: :development
+  version_requirements: *id003
+- !ruby/object:Gem::Dependency 
+  name: rake
   prerelease: false
-  version_requirements: !ruby/object:Gem::Requirement
+  requirement: &id004 !ruby/object:Gem::Requirement 
     none: false
-    requirements:
-    - - ! '>='
-      - !ruby/object:Gem::Version
-        version: '0'
-- !ruby/object:Gem::Dependency
-  name: posix-spawn
-  requirement: !ruby/object:Gem::Requirement
-    none: false
-    requirements:
-    - - ! '>='
-      - !ruby/object:Gem::Version
-        version: '0'
+    requirements: 
+    - - ">="
+      - !ruby/object:Gem::Version 
+        hash: 3
+        segments: 
+        - 0
+        version: "0"
   type: :development
+  version_requirements: *id004
+- !ruby/object:Gem::Dependency 
+  name: posix-spawn
   prerelease: false
-  version_requirements: !ruby/object:Gem::Requirement
+  requirement: &id005 !ruby/object:Gem::Requirement 
     none: false
-    requirements:
-    - - ! '>='
-      - !ruby/object:Gem::Version
-        version: '0'
+    requirements: 
+    - - ">="
+      - !ruby/object:Gem::Version 
+        hash: 3
+        segments: 
+        - 0
+        version: "0"
+  type: :development
+  version_requirements: *id005
 description: A small library for doing (command) lines
 email: jyurek@thoughtbot.com
 executables: []
+
 extensions: []
+
 extra_rdoc_files: []
-files:
+
+files: 
 - .gitignore
 - .travis.yml
 - GOALS
@@ -119,38 +118,48 @@ files:
 - spec/cocaine/command_line/runners/process_runner_spec.rb
 - spec/cocaine/command_line_spec.rb
 - spec/spec_helper.rb
+- spec/support/nonblocking_examples.rb
 - spec/support/stub_os.rb
 - spec/support/with_exitstatus.rb
 homepage: http://github.com/thoughtbot/cocaine
 licenses: []
+
 post_install_message: 
 rdoc_options: []
-require_paths:
+
+require_paths: 
 - lib
-required_ruby_version: !ruby/object:Gem::Requirement
+required_ruby_version: !ruby/object:Gem::Requirement 
   none: false
-  requirements:
-  - - ! '>='
-    - !ruby/object:Gem::Version
-      version: '0'
-required_rubygems_version: !ruby/object:Gem::Requirement
+  requirements: 
+  - - ">="
+    - !ruby/object:Gem::Version 
+      hash: 3
+      segments: 
+      - 0
+      version: "0"
+required_rubygems_version: !ruby/object:Gem::Requirement 
   none: false
-  requirements:
-  - - ! '>='
-    - !ruby/object:Gem::Version
-      version: '0'
+  requirements: 
+  - - ">="
+    - !ruby/object:Gem::Version 
+      hash: 3
+      segments: 
+      - 0
+      version: "0"
 requirements: []
+
 rubyforge_project: 
 rubygems_version: 1.8.24
 signing_key: 
 specification_version: 3
 summary: A small library for doing (command) lines
-test_files:
+test_files: 
 - spec/cocaine/command_line/runners/backticks_runner_spec.rb
 - spec/cocaine/command_line/runners/posix_runner_spec.rb
 - spec/cocaine/command_line/runners/process_runner_spec.rb
 - spec/cocaine/command_line_spec.rb
 - spec/spec_helper.rb
+- spec/support/nonblocking_examples.rb
 - spec/support/stub_os.rb
 - spec/support/with_exitstatus.rb
-has_rdoc: