cobra_commander 0.8.0 → 0.8.1

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 6f1de2b5ceb4fbde7dcd12fd71606c55cdd733e6928e4c6a866dfc1f3ec65af3
-  data.tar.gz: 5a9537dabd13b974df919be911755debf92761b6bdf99b370c59cec2c8fc09af
+  metadata.gz: a07c92126bfb5a1179d1fb056a0c33452d5b9cab9087c9062d3c0e8203b3d165
+  data.tar.gz: a338e59737c442e533d7c9cf951dde539666617d2c571999c8d104b1dddb68aa
 SHA512:
-  metadata.gz: 58f066894063d46d3b1c25baf2b085f3212db9ac716eee5c8ef6c2465c82233f06fae79e30c04205d95b75551799cd3f1c67901a60a516bf079e2cb154baa2b2
-  data.tar.gz: 99babd4c1ae0b5e218ed913bf175cbd38d4efe4bc19d11ea108d8f914c9f3381a7f43bb6c8a4d64171bec648e5c5e8441c39c30f5c3a83f11e0c9f1aa4e0948b
+  metadata.gz: b47bca554823ceaca8ce8449c0a0a955103d84dd979ebc232b577042ee3e2f6a5a99e976277cbe926a6f4e3929f072f69e086dfad6f9805f6c1bce6b5167ff01
+  data.tar.gz: 27ee91733374ae24fbb24fe26fa3692bd0a2afa22ebbd5a213431b51f55a84631b5e0d9fcaa8f30c1ccc15095afe090b94bbe7ff6a955e4f19120e3b2e9f942a

data/.github/workflows/ci.yml

@@ -0,0 +1,38 @@
+name: CI
+
+on: [push, pull_request]
+
+jobs:
+  test:
+    name: Tests
+    runs-on: ubuntu-latest
+    strategy:
+      matrix:
+        ruby:
+          - "2.5"
+          - "2.6"
+    steps:
+    - uses: actions/checkout@v2
+    - name: Set up Ruby
+      uses: ruby/setup-ruby@v1
+      with:
+        ruby-version: ${{ matrix.ruby }}
+        bundler: 1
+        bundler-cache: true
+    - name: Install Graphviz
+      run: sudo apt -qq install graphviz
+    - name: Run tests
+      run: bundle exec rake spec
+  lint:
+    name: Lint Ruby
+    runs-on: ubuntu-latest
+    steps:
+    - uses: actions/checkout@v2
+    - name: rubocop
+      uses: reviewdog/action-rubocop@v1
+      with:
+        rubocop_version: 0.48.1
+        filter_mode: nofilter
+        fail_on_error: true
+        rubocop_extensions: ""
+        github_token: ${{ secrets.github_token }}

data/CHANGELOG.md

@@ -2,6 +2,10 @@
 
 ## Unreleased
 
+## Version 0.8.1 - 2020-07-29
+
+* Fix CobraCommander::Executor when running [`bundler`](https://bundler.io/) based commands (i.e.: `bundle exec rspec`)
+
 ## Version 0.8 - 2020-07-21
 
 * Standardize Cobra CLI options

data/README.md

@@ -136,6 +136,14 @@ After checking out the repo, run `bin/setup` to install dependencies. You will a
 
 To install this gem onto your local machine, run `bundle exec rake install`. To release a new version, update the version number in `version.rb`, and then run `bundle exec rake release`, which will create a git tag for the version, push git commits and tags, and push the `.gem` file to [rubygems.org](https://rubygems.org).
 
+### Bundled App
+
+In order to maintain the features around umbrella apps and specially `changes`, a bundled [`umbrella app repo`](spec/fixtures/app.tgz) is included in this repository. This repo is compacted by `tar`/`gzip` in order to keep isolation, the format was chosen to avoid issues described in https://github.com/swcarpentry/git-novice/issues/272. To avoid the same issues, the workflow for this fixture app is the following:
+
+1. unpack it somewhere outside your repo
+1. do your changes and commit (locally only, it doesn't have a remote)
+1. from within the app run `tar cfz path/to/cobra/spec/fixtures/app.tgz .`
+
 ## Contributing
 
 Bug reports and pull requests are welcome on GitHub at https://github.com/powerhome/cobra_commander. This project is intended to be a safe, welcoming space for collaboration, and contributors are expected to adhere to the [Contributor Covenant](http://contributor-covenant.org) code of conduct.

data/lib/cobra_commander/affected.rb

@@ -49,8 +49,16 @@ module CobraCommander
       @directly = @directly.sort_by(&:name)
     end
 
+    def component_changed?(component)
+      component.root_paths.any? do |component_path|
+        @changes.any? do |file_path|
+          file_path.start_with?(component_path)
+        end
+      end
+    end
+
     def add_if_changed(component)
-      return if component.root_paths.uniq.none? { |path| @changes.any?(Regexp.new(path)) }
+      return unless component_changed?(component)
 
       @directly << component
       @transitively.merge(component.deep_dependents)

data/lib/cobra_commander/cli.rb

@@ -32,8 +32,8 @@ module CobraCommander
       puts options.total ? components.size : CobraCommander::Output::FlatList.new(components).to_s
     end
 
-    desc "exec [component] <command>", "Executes the command in the context of a given component or set of components. " \
-                                       "If no component is given executes the command in all components."
+    desc "exec [component] <command>", "Executes the command in the context of a given component or set thereof. " \
+                                       "Defaults to all components."
     method_option :dependencies, type: :boolean, desc: "Run the command on each dependency of a given component"
     method_option :dependents, type: :boolean, desc: "Run the command on each dependency of a given component"
     def exec(command_or_component, command = nil)

data/lib/cobra_commander/executor.rb

@@ -4,11 +4,13 @@ module CobraCommander
   # Execute commands on all components of a ComponentTree
   module Executor
     def self.exec(components, command, printer = $stdout)
-      components.each do |component|
-        component.root_paths.each do |path|
-          printer.puts "===> #{component.name} (#{path})"
-          output, = Open3.capture2e(command, chdir: path, unsetenv_others: true)
-          printer.puts output
+      Bundler.with_original_env do
+        components.each do |component|
+          component.root_paths.each do |path|
+            printer.puts "===> #{component.name} (#{path})"
+            output, = Open3.capture2e(command, chdir: path)
+            printer.puts output
+          end
         end
       end
     end

data/lib/cobra_commander/version.rb

@@ -1,5 +1,5 @@
 # frozen_string_literal: true
 
 module CobraCommander
-  VERSION = "0.8.0"
+  VERSION = "0.8.1"
 end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: cobra_commander
 version: !ruby/object:Gem::Version
-  version: 0.8.0
+  version: 0.8.1
 platform: ruby
 authors:
 - Ben Langfeld
@@ -10,7 +10,7 @@ authors:
 autorequire: 
 bindir: exe
 cert_chain: []
-date: 2020-07-27 00:00:00.000000000 Z
+date: 2020-07-29 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: bundler
@@ -172,6 +172,7 @@ extensions: []
 extra_rdoc_files: []
 files:
 - ".editorconfig"
+- ".github/workflows/ci.yml"
 - ".gitignore"
 - ".rspec"
 - ".rubocop.yml"