cobench 0.0.13 → 0.0.16

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 1b298ef3dbb65893787af11d1b4cf86e9b02169dc2c83a3e34d902c2c26a2d43
-  data.tar.gz: b13f5d42eb289a3e6a5fdd9bdb8a5c31a2357ec1c8a3f35cc35b3c5ec1b6c9e6
+  metadata.gz: 48f017fb5f4994354ad835b809870f6c804bf3350cd22b443e29f2dfda0f1276
+  data.tar.gz: a57ba22b48e7760415921e4c80fb52c407e95ad84c1c3d5da4e1b2de76538f5e
 SHA512:
-  metadata.gz: 83080a2db71ccd8d2e93a00bcbb0bd33a1aa3ddd3ae4a31accdc442403f65b22db215b6e2887dae69c43f0a3655293c7d398f8d5be2819e272995162884923bc
-  data.tar.gz: 86b2a9d10ac6e59b41b43ba16c1e55aa0cec3b83729556f53a7530b847a6c2b5738bc8b142ebca0583ac231dc3750156c870776dfad93f2201c1467ab85c67eb
+  metadata.gz: 845946fc2dfb68de3ef780a35b2063311e38104f337a235067f88d2ab00bf3b309e30025e1bb3dd2091ca2d43af80e18a8332258f6085dedf96f9f3de39889ef
+  data.tar.gz: 9133dcf17b4d1ca286e70c46b122dfd458c6bce44f1f247bae74a4b5b7604db34c90a74493eb5ac49a05fa74626c5ab5ee14f09751d23ec5143052122173b5e6

data/assets/index.xsl

@@ -97,9 +97,11 @@ SOFTWARE.
                 <xsl:text>pull requests</xsl:text>
               </a>
               <xsl:text> created by the user and merged. </xsl:text>
+              <xsl:text>"Reviews" is the total number of merged pull requests reviewed by the user. </xsl:text>
               <xsl:text>"Score" is an arithmetic summary of all other numbers with multipliers: </xsl:text>
               <xsl:text>one Pull costs 100 points, </xsl:text>
               <xsl:text>one Issue 50 points, </xsl:text>
+              <xsl:text>one Review 40 points, </xsl:text>
               <xsl:text>one Commit 5 points, </xsl:text>
               <xsl:text>one HoC 1 point.</xsl:text>
             </p>

data/bin/cobench

@@ -56,7 +56,7 @@ opts = Slop.parse(args, strict: true, help: true) do |o|
   o.array '--exclude', 'Mask of GitHub repo to exclude'
 end
 
-if opts.help?
+if opts.help? || opts[:coder].empty?
   puts opts
   exit
 end
@@ -95,18 +95,19 @@ begin
   loog.info("Reading GitHub data for the last #{opts[:days]} days")
   titles = {}
   opts[:coder].each do |u|
-    loog.info("Scanning #{u}...")
-    data[u] = {}
+    user = u.downcase
+    loog.info("Scanning #{user}...")
+    data[user] = {}
     Dir[File.join(__dir__, '../lib/cobench/metrics/*.rb')].each do |f|
       name = File::basename(f).split('.')[0]
       if !opts[:metrics].empty? && !opts[:metrics].include?(name)
-        loog.info("Ignoring #{u}/#{name} due to --metrics")
+        loog.info("Ignoring #{user}/#{name} due to --metrics")
         next
       end
       type = "Cobench::#{name.capitalize}"
-      loog.info("Reading #{u}/#{name}...")
+      loog.info("Reading #{user}/#{name}...")
       require_relative f
-      m = type.split('::').reduce(Module, :const_get).new(api, u, opts)
+      m = type.split('::').reduce(Module, :const_get).new(api, user, opts)
       if opts.dry?
         measures = [
           { title: 'Issues', total: Random.new.rand(100), href: 'https://github.com/' },
@@ -119,10 +120,10 @@ begin
       end
       measures.each do |d|
         before = 0
-        before += data[u][d[:title]][:total] if data[u][d[:title]] != nil
-        data[u][d[:title]] = { total: d[:total] + before, href: d[:href] }
+        before += data[user][d[:title]][:total] if data[user][d[:title]] != nil
+        data[user][d[:title]] = { total: d[:total] + before, href: d[:href] }
         titles[d[:title]] = d[:title]
-        loog.info("The value of #{u}/#{d[:title]} is #{d[:total]}")
+        loog.info("The value of #{user}/#{d[:title]} is #{d[:total]}")
       end
     end
   end
@@ -136,6 +137,8 @@ begin
         50
       elsif t == 'Commits'
         5
+      elsif t == 'Reviews'
+        40
       else
         raise "Unknown title '#{t}'"
       end

data/features/cli.feature

@@ -11,7 +11,7 @@ Feature: Simple Reporting
     Then Exit code is zero
 
   Scenario: Simple report
-    When I run bin/cobench with "--coder yegor256 --verbose --dry --to foo"
+    When I run bin/cobench with "--coder yegor256 --coder John --verbose --dry --to foo"
     Then Stdout contains "XML saved to"
     And Exit code is zero
 

data/lib/cobench/mask.rb

@@ -24,11 +24,11 @@
 # License:: MIT
 class Cobench::Mask
   def initialize(txt)
-    @org, @repo = txt.split('/')
+    @org, @repo = txt.downcase.split('/')
   end
 
   def matches?(repo)
-    org, repo = repo.split('/')
+    org, repo = repo.downcase.split('/')
     return false if ['', nil].include?(org)
     return false if ['', nil].include?(repo)
     return false if org != @org && @org != '*'

data/lib/cobench/metrics/pulls.rb

@@ -34,7 +34,7 @@ class Cobench::Pulls
 
   def take(loog)
     from = (Time.now - (60 * 60 * 24 * @opts[:days])).strftime('%Y-%m-%d')
-    q = "in:comments type:pr author:#{@user} is:merged closed:>#{from}"
+    q = "in:comments type:pr author:#{@user} is:merged merged:>#{from}"
     json = @api.search_issues(q)
     loog.debug("Found #{json.total_count} pull requests")
     hoc = 0

data/lib/cobench/metrics/reviews.rb

@@ -0,0 +1,54 @@
+# Copyright (c) 2022 Yegor Bugayenko
+#
+# Permission is hereby granted, free of charge, to any person obtaining a copy
+# of this software and associated documentation files (the 'Software'), to deal
+# in the Software without restriction, including without limitation the rights
+# to use, copy, modify, merge, publish, distribute, sublicense, and/or sell
+# copies of the Software, and to permit persons to whom the Software is
+# furnished to do so, subject to the following conditions:
+#
+# The above copyright notice and this permission notice shall be included in all
+# copies or substantial portions of the Software.
+#
+# THE SOFTWARE IS PROVIDED 'AS IS', WITHOUT WARRANTY OF ANY KIND, EXPRESS OR
+# IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
+# FITNESS FOR A PARTICULAR PURPOSE AND NONINFINGEMENT. IN NO EVENT SHALL THE
+# AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER
+# LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM,
+# OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE
+# SOFTWARE.
+
+require 'iri'
+require_relative '../match'
+
+# Reviews in GitHub API.
+# Author:: Yegor Bugayenko (yegor256@gmail.com)
+# Copyright:: Copyright (c) 2022 Yegor Bugayenko
+# License:: MIT
+class Cobench::Reviews
+  def initialize(api, user, opts)
+    @api = api
+    @user = user
+    @opts = opts
+  end
+
+  def take(loog)
+    from = (Time.now - (60 * 60 * 24 * @opts[:days])).strftime('%Y-%m-%d')
+    q = "reviewed-by:#{@user} merged:>#{from}"
+    json = @api.search_issues(q)
+    loog.debug("Found #{json.total_count} reviews")
+    total = json.items.count do |p|
+      pr = p.pull_request.url.split('/')[-1]
+      repo = p.repository_url.split('/')[-2..-1].join('/')
+      next unless Cobench::Match.new(@opts, loog).matches?(repo)
+      loog.debug("Including #{repo}##{pr} reviewed by #{@user}")
+    end
+    [
+      {
+        title: 'Reviews',
+        total: total,
+        href: Iri.new('https://github.com/search').add(q: q)
+      }
+    ]
+  end
+end

data/lib/cobench/version.rb

@@ -23,5 +23,5 @@
 # Copyright:: Copyright (c) 2022 Yegor Bugayenko
 # License:: MIT
 module Cobench
-  VERSION = '0.0.13'.freeze
+  VERSION = '0.0.16'.freeze
 end

data/test/test_mask.rb

@@ -28,8 +28,8 @@ require_relative '../lib/cobench/mask'
 class TestMask < Minitest::Test
   def test_positive
     assert Cobench::Mask.new('*/*').matches?('foo/bar')
-    assert Cobench::Mask.new('test/*').matches?('test/one')
-    assert Cobench::Mask.new('test/hello').matches?('test/hello')
+    assert Cobench::Mask.new('test/*').matches?('Test/one')
+    assert Cobench::Mask.new('test/hello').matches?('test/Hello')
   end
 
   def test_negative

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: cobench
 version: !ruby/object:Gem::Version
-  version: 0.0.13
+  version: 0.0.16
 platform: ruby
 authors:
 - Yegor Bugayenko
@@ -255,6 +255,7 @@ files:
 - lib/cobench/metrics/commits.rb
 - lib/cobench/metrics/issues.rb
 - lib/cobench/metrics/pulls.rb
+- lib/cobench/metrics/reviews.rb
 - lib/cobench/version.rb
 - logo.svg
 - test/test__helper.rb